On Thu, 14 Nov 2024 11:21:54 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up SecurityManager-related code following
> JEP-486 integraion.
>
> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
> * `ZipFileSystemProvider` is updated to not perform
>
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
On Thu, 14 Nov 2024 20:45:49 GMT, Roger Riggs wrote:
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
I did a pass over this. Most of it i
On Thu, 14 Nov 2024 17:26:31 GMT, Aleksey Shipilev wrote:
> > That is probably correct. I was however thinking that it would only be
> > pooled asymmetrically as some type of hystereses. So you pool when you
> > remove a node (switch the head) and keep it far an arbitrary amount of
> > removal
On Fri, 15 Nov 2024 07:01:39 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which removes code depending on SecurityManager from
>> the `java.lang.module` and `jdk.internal.module` packages:
>>
>> * `ModuleFinder::ofSystem` is updated to not check the
>> `"accessSystemModules"` RuntimePer
On Thu, 14 Nov 2024 09:00:31 GMT, Alan Bateman wrote:
> Remove the code for the now defunct SecurityManager execution mode from
> ClassLoader and the built-in class loader implementations. The override of
> getPermissions is removed from the application class loader, and from the
> class loade
On Fri, 15 Nov 2024 05:48:27 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Fri, 15 Nov 2024 06:37:26 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the class
On Fri, 15 Nov 2024 06:33:30 GMT, Alan Bateman wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove empty line in addProvides
>> - Add full stop after class description for SystemImage
>
> src/java.base/shar
> Please review this PR which removes code depending on SecurityManager from
> the `java.lang.module` and `jdk.internal.module` packages:
>
> * `ModuleFinder::ofSystem` is updated to not check the
> `"accessSystemModules"` RuntimePermission
> * The `ModuleReferences.ExplodedModuleReader` constru
On Thu, 14 Nov 2024 17:32:40 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes code depending on SecurityManager from
> the `java.lang.module` and `jdk.internal.module` packages:
>
> * `ModuleFinder::ofSystem` is updated to not check the
> `"accessSystemModules"` RuntimePermissi
On Thu, 14 Nov 2024 21:03:35 GMT, Brent Christian wrote:
>> Nevermind, I added a directed regression test for it now.
>
>> I see that existing `Cleaner` tests are quite rich already.
>> ...
>> The new asserts around that code should IMO test enough with existing tests.
>
> Should any of the exi
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Thu, 14 Nov 2024 23:51:24 GMT, Phil Race wrote:
> remove uses of SM APIs from the java.datatransfer module. Also cleans up the
> now un-needed export from java.base
This pull request has now been integrated.
Changeset: 99070658
Author:Phil Race
URL:
https://git.openjdk.org/jdk/c
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Thu, 7 Nov 2024 17:52:53 GMT, Sean Mullan wrote:
>> Prasadrao Koppula has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge master
>> - initialized storeName with empty string
>> - Replaced Paths.get with
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote:
> Make jpackage test lib more practical. List of changes:
>
> Support multiple args and var args in `@Parameter` annotation:
>
> @Test
> @Parameter({"12", "foo"})
> @Parameter({"-89", "bar", "more"})
> @Parameter({"-89", "bar", "more", "mo
On Thu, 14 Nov 2024 19:16:34 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brough
On Fri, 15 Nov 2024 01:20:43 GMT, Chen Liang wrote:
> Looks good
Thanks, @liach , for the second review.
> src/java.base/share/classes/java/io/BufferedReader.java line 329:
>
>> 327: if (term != null) term[0] = false;
>> 328:
>> 329: bufferLoop:
>
> How do we usually
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote:
> Make jpackage test lib more practical. List of changes:
>
> Support multiple args and var args in `@Parameter` annotation:
>
> @Test
> @Parameter({"12", "foo"})
> @Parameter({"-89", "bar", "more"})
> @Parameter({"-89", "bar", "more", "mo
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 23:20:23 GMT, Dean Long wrote:
>> The type of the Unsafe base offset constant is int, which may cause overflow
>> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
>> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
>> stil
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still unfixed.
>
> @liach proposed the idea of changing th
On Fri, 15 Nov 2024 00:25:20 GMT, Paul Sandoz wrote:
> Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export
> the package `jdk.internal` in module `java.base` to module`
> jdk.incubator.vector`.
>
> Doing so enables the compiler and runtime to report warnings about improp
On Fri, 15 Nov 2024 00:25:20 GMT, Paul Sandoz wrote:
> Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export
> the package `jdk.internal` in module `java.base` to module`
> jdk.incubator.vector`.
>
> Doing so enables the compiler and runtime to report warnings about improp
On Thu, 14 Nov 2024 23:51:24 GMT, Phil Race wrote:
> remove uses of SM APIs from the java.datatransfer module. Also cleans up the
> now un-needed export from java.base
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22127#pullrequestreview-2437
Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export the
package `jdk.internal` in module `java.base` to module` jdk.incubator.vector`.
Doing so enables the compiler and runtime to report warnings about improper
attempts to synchronize on instances of `Float16`, as describe
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote:
> Remove use of doPrivileged and SecurityManager in java.util.
Marked as reviewed by smarks (Reviewer).
I mainly wanted to look at Arrays, and I looked briefly at the other stuff too.
All looks good.
-
PR Review: https://git.op
On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons wrote:
> The policy has long been to use Classpath Exception in the src and make
> directories, but not in the test directories. If you're changing the policy,
> you might want to check and update any documentation where the policy might
> be
remove uses of SM APIs from the java.datatransfer module. Also cleans up the
now un-needed export from java.base
-
Commit messages:
- 8344065
Changes: https://git.openjdk.org/jdk/pull/22127/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22127&range=00
Issue: https://bug
On Thu, 14 Nov 2024 05:32:34 GMT, Shaojin Wen wrote:
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote:
> Remove use of doPrivileged and SecurityManager in java.util.
src/java.base/share/classes/java/util/Properties.java line 952:
> 950:
> 951: private static void writeDateComment(BufferedWriter bw) throws
> IOException {
> 952: /
Oh ok. So it truly is a toss-up depending on each implementation when and
where this occurs.
Ok, then as my final request, I think even informing the user that this CAN
occur is worth doing. If nothing else, the user scouring the documentation
for documentation of this behaviour will know that it
Remove use of doPrivileged and SecurityManager in java.util.
-
Commit messages:
- 8344252: SM cleanup in java.util classes
Changes: https://git.openjdk.org/jdk/pull/22122/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22122&range=00
Issue: https://bugs.openjdk.org/browse
On Thu, 14 Nov 2024 12:28:21 GMT, Jaikiran Pai wrote:
>> I agree with marking these close methods as final as long as the previous
>> corpus search did not find any user-defined close method in subclasses.
>
> Hello Chen, corpus analysis shows that there are no subclasses of
> Inflater/Deflater
On Thu, 14 Nov 2024 20:28:31 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Thu, 14 Nov 2024 20:28:31 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 13:20:06 GMT, Aleksey Shipilev wrote:
>> I see that existing `Cleaner` tests are quite rich already. Array-based
>> implementation does rise question about testing the resizes, that's obvious.
>> But I have discovered that copying arrays is not really that good in this
>> s
Please review this PR which removes code depending on SecurityManager from the
`java.lang.module` and `jdk.internal.module` packages:
* `ModuleFinder::ofSystem` is updated to not check the `"accessSystemModules"`
RuntimePermission
* The `ModuleReferences.ExplodedModuleReader` constructor is upda
On Thu, 14 Nov 2024 20:02:50 GMT, Lance Andersen wrote:
>> I think both are in the 90-100 range. Line length is a bit subjective, but I
>> know that at least in the Security Group, we try to keep code to around 80
>> chars so it is easy to review in a side-by-side diff. It also is visually
>>
Refactored to remove use of doPrivileged() and use of SecurityManager.
The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a common
thread pool.
A careful review is requested.
-
Commit messages:
- Drop mention of permissions
- 8344197: SM cleanup in java.util.co
On Thu, 14 Nov 2024 17:19:02 GMT, Roger Riggs wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
>> Serialization implementation dependencies on SecurityManager, doPrivildged,
>> and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expe
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
> * `ZipFile` is updated to not call SM::checkRead, SM::
On Thu, 14 Nov 2024 20:25:35 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 19:59:55 GMT, Sean Mullan wrote:
>> Yes, they are 96 and 98 chars long, which means I sympathise with both views
>> :)
>>
>> Unless hearing back from @seanjmullan I'll go with Roger's suggestion of one
>> line here.
>
> I think both are in the 90-100 range. Line length is a
On Thu, 14 Nov 2024 19:58:21 GMT, Eirik Bjørsnøs wrote:
>> As long as the line in your ide is around 80 characters or less you are
>> good to go. If it is say 100 bytes so you have to scroll, that is when I
>> would fold the line.
>>
>> I think you are OK here
>
> Yes, they are 96 and 98 cha
On Thu, 14 Nov 2024 19:51:33 GMT, Lance Andersen wrote:
>> See review comments from @RogerRiggs:
>>
>> https://github.com/openjdk/jdk/pull/22099#pullrequestreview-2435969401
>> https://github.com/openjdk/jdk/pull/22099#discussion_r1842150753
>>
>> where the folding of these lines into one was s
On Thu, 14 Nov 2024 19:45:27 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 182:
>>
>>> 180: }
>>> 181: RUNTIME_VERSION =
>>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>>> 182: String enableMultiRelease =
>>> Sys
On Thu, 14 Nov 2024 19:16:34 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brough
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Thu, 14 Nov 2024 19:30:58 GMT, Sean Mullan wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fold lines for System::getProperty when reading enableMultiRelease and
>> inhibitZip64
>
> src/java.base/share/classe
On Thu, 14 Nov 2024 18:24:59 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
The field `com.sun.jndi.ldap.EventSupport#notifiers` is always accessed under
`lock`. It means extra synchronization from `Hashtable` is not needed.
Subtle difference in Hashtable vs Hashmap behavior is that Hashtable doesn't
allow `null` keys and `null` values. I've checked all usages of it - on
On Thu, 14 Nov 2024 19:21:32 GMT, Sean Mullan wrote:
> Ok, but your change did not check `UnsupportedOperationException.getCause()
> instanceof NoSuchFileException`, it just checked if the exception was
> `NoSuchFileException`.
For the record, there was a typo in my comment, I meant to say
`P
On Thu, 14 Nov 2024 18:24:59 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Thu, 14 Nov 2024 16:56:00 GMT, Eirik Bjørsnøs wrote:
>> test/jdk/jdk/nio/zipfs/TestPosix.java line 236:
>>
>>> 234: }
>>> 235: return zfpv.readAttributes().group().getName();
>>> 236: } catch (UnsupportedOperationException | NoSuchFileException
>>> e) {
>>
>>
On Thu, 14 Nov 2024 17:01:48 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code following
>> JEP-486 integraion.
>>
>> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
>> * `ZipFileSystemProvider` is updated to not perfor
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains nine additional
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
> instruction for following IR pallets.
>
>
>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>MulVL (URShiftVL SRC1 , 32) (URShiftVL SRC2, 32)
>MulVL (URShiftVL SRC1 , 32) ( A
On Thu, 14 Nov 2024 02:52:26 GMT, Vladimir Ivanov wrote:
>> Jatin Bhateja has refreshed the contents of this pull request, and previous
>> commits have been removed. Incremental views are not available. The pull
>> request now contains seven commits:
>>
>> - Removing target specific hooks
>>
On Tue, 12 Nov 2024 21:49:22 GMT, Vladimir Ivanov wrote:
>>> In the latest version you added new Ideal nodes (`MulIVL` and `MulUIVL`). I
>>> don't see a compelling reason to do so. IMO matcher functionality is more
>>> than enough to cover `VPMULDQ` case. `MulIVL` is equivalent to `MulVL` +
>>
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Thu, 14 Nov 2024 17:19:02 GMT, Roger Riggs wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
>> Serialization implementation dependencies on SecurityManager, doPrivildged,
>> and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expe
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Thu, 14 Nov 2024 05:32:34 GMT, Shaojin Wen wrote:
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still
On Tue, 5 Nov 2024 18:29:52 GMT, Chen Liang wrote:
> After the ClassFile API migration, when serializable lambdas are requested
> for hidden class callers, illegal class name is generated for the
> serialization methods, which previously had legal yet unusable class names,
> as hidden classes
On Thu, 14 Nov 2024 11:25:08 GMT, Alan Bateman wrote:
>> Remove the code for the now defunct SecurityManager execution mode from
>> ClassLoader and the built-in class loader implementations. The override of
>> getPermissions is removed from the application class loader, and from the
>> class l
On Thu, 14 Nov 2024 04:14:03 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 14 Nov 2024 14:50:21 GMT, Axel Boldt-Christmas
wrote:
> That is probably correct. I was however thinking that it would only be pooled
> asymmetrically as some type of hystereses. So you pool when you remove a node
> (switch the head) and keep it far an arbitrary amount of removals. So
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request incremental
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request incremental
> Class-File API usually expose names in a form of
> `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately
> `java.lang.classfile.Attribute::attributeName` method was omitted during the
> API review and it returns inflated `String` value of the name.
>
> This patch changes return type of
On Thu, 14 Nov 2024 17:04:55 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more fixes
>
> test/langtools/tools/javap/T6716452.java line 73:
>
>> 71: error(mm + ": unexpected at
On Thu, 14 Nov 2024 14:50:21 GMT, Axel Boldt-Christmas
wrote:
> I was however thinking that it would only be pooled asymmetrically as some
> type of hystereses. So you pool when you remove a node (switch the head) and
> keep it far an arbitrary amount of removals. So it would only really waste
> Please review this PR which cleans up SecurityManager-related code following
> JEP-486 integraion.
>
> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
> * `ZipFileSystemProvider` is updated to not perform
> `AccessController::doPrivileged`
> * The test `TestPosix`
On Thu, 14 Nov 2024 17:02:49 GMT, Adam Sotona wrote:
>> Class-File API usually expose names in a form of
>> `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately
>> `java.lang.classfile.Attribute::attributeName` method was omitted during the
>> API review and it returns inflated `String`
> Class-File API usually expose names in a form of
> `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately
> `java.lang.classfile.Attribute::attributeName` method was omitted during the
> API review and it returns inflated `String` value of the name.
>
> This patch changes return type of
On Thu, 14 Nov 2024 15:48:30 GMT, Sean Mullan wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update debug logging to not reference privileged operations
>
> test/jdk/jdk/nio/zipfs/TestPosix.java line 236:
>
>>
On Thu, 14 Nov 2024 15:52:32 GMT, Sean Mullan wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert catching of NoSuchFileException in expectedDefaultOwner and
>> expectedDefaultGroup
>> - Remove @SuppressWa
On Thu, 24 Oct 2024 18:29:18 GMT, Jorn Vernee wrote:
> We were made aware of the fact the `TestLargeStub::testUpcall` was not
> actually calling `Linker::upcallStub`. This PR addresses that issue.
This pull request has now been integrated.
Changeset: 002b985a
Author:Jorn Vernee
URL:
On Thu, 14 Nov 2024 16:41:12 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Change "resizble" comment in BOS
On Thu, 14 Nov 2024 13:18:03 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/io/BufferedOutputStream.java line 89:
>>
>>> 87:
>>> 88: if (getClass() == BufferedOutputStream.class) {
>>> 89: // resizable if initialSize < maxSize
>>
>> I think the comment is confusin
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Change "resizble" comment in BOS
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22
On Wed, 13 Nov 2024 12:05:38 GMT, Alan Bateman wrote:
>> Change default value of the command line option
>> --sun-misc-unsafe-memory-access from "allow" to "warn".
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes
On Tue, 12 Nov 2024 14:29:08 GMT, Alan Bateman wrote:
>>> Instead, I think we should look at adding a property such as jdk.patched
>>
>> You mean a new standard property - observable with
>> `System.getProperty("jdk.patched")` as well - which would also show up with
>> `java -XshowSettings:pro
On Thu, 14 Nov 2024 14:43:50 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code following
>> JEP-486 integraion.
>>
>> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
>> * `ZipFileSystemProvider` is updated to not perfor
On Thu, 14 Nov 2024 15:35:17 GMT, Chen Liang wrote:
>> Class-File API usually expose names in a form of
>> `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately
>> `java.lang.classfile.Attribute::attributeName` method was omitted during the
>> API review and it returns inflated `String`
Class-File API usually expose names in a form of
`java.lang.classfile.constantpool.Utf8Entry`. Unfortunately
`java.lang.classfile.Attribute::attributeName` method was omitted during the
API review and it returns inflated `String` value of the name.
This patch changes return type of
`java.lang.
On Thu, 14 Nov 2024 14:19:58 GMT, Adam Sotona wrote:
> Class-File API usually expose names in a form of
> `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately
> `java.lang.classfile.Attribute::attributeName` method was omitted during the
> API review and it returns inflated `String` val
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request with a new
On Thu, 14 Nov 2024 05:32:34 GMT, Shaojin Wen wrote:
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still
On Thu, 14 Nov 2024 13:24:26 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list segmented list of arrays. Arrays are easy targets for GC. There
>> are possible improvements here, most glaring is parallelism that is
>> curr
1 - 100 of 170 matches
Mail list logo
