On Tue, 12 Nov 2024 22:08:42 GMT, Roger Riggs wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 227 commits:
>>
>> - Merge branch 'master' into JDK-8343981
>> - Merge commit 'db85090553ab14a84c3ed0a2604dd56c
On Tue, 12 Nov 2024 23:34:48 GMT, Shaojin Wen wrote:
>> In the JDK code, there are some places that may cause Unsafe offset
>> overflow. The probability of occurrence is low, but if it occurs, it will
>> cause JVM crash.
>
> Shaojin Wen has updated the pull request incrementally with one additi
On 13/11/2024 03:44, David Holmes wrote:
The VM already sets properties like
jdk.module.patch.N=<...>
when processing --patch-mods. Doesn't that suffice if all you need is
a boolean flag to indicate any patching has occurred?
I would have thought you'd like to know which module has been pa
On Wed, 13 Nov 2024 03:11:41 GMT, Chen Liang wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> src/java.base/share/classes/java/io/BufferedOutputStream.java line 88:
>
>> 86: }
>> 87:
>> 88: this.buf = new byte[initialSize]; // resizable if initi
On Tue, 12 Nov 2024 21:59:43 GMT, Roger Riggs wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
>> Serialization implementation dependencies on SecurityManager, doPrivildged,
>> and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expe
On Mon, 11 Nov 2024 02:09:41 GMT, Jatin Bhateja wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 91:
>
>
On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.i
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Implement code review feedback.
- Misc cleanups.
-
Changes:
- all: https://git.open
On Tue, 12 Nov 2024 21:01:36 GMT, Joe Darcy wrote:
> > Looks good. Approving the current status. Are there plans for other small
> > additions?
>
> Subsequent to this comment, I did a light clean-up pass over the tests. I'll
> do a pass over the Float16 implementation too to make sure previous
Hi Severin,
On 13/11/2024 1:33 am, Severin Gehwolf wrote:
Hi,
For JDK-8343839 it would be useful to have some form of API in order to
be able to detect that a currently running Java process has been
launched with '--patch-module'.
Alan Bateman suggested to expose a boolean JDK property to indi
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
https://github.com/openjdk/jdk/tree/5212535a276a92d96ca20bdcfccfbce956febdb1 is
a baseline for before virtual threads were integrated. Note that in this
period, the
On Wed, 13 Nov 2024 02:41:05 GMT, ExE Boss wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> src/java.base/share/classes/java/io/BufferedInputStream.java line 241:
>
>> 239: }
>> 240: initialSize = size;
>> 241: buf = new byte[size];
>
>
On Tue, 12 Nov 2024 21:49:22 GMT, Vladimir Ivanov wrote:
>>> In the latest version you added new Ideal nodes (`MulIVL` and `MulUIVL`). I
>>> don't see a compelling reason to do so. IMO matcher functionality is more
>>> than enough to cover `VPMULDQ` case. `MulIVL` is equivalent to `MulVL` +
>>
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
src/java.base/share/classes/java/io/BufferedInputStream.java line 241:
> 239: }
> 240: initialSize = size;
> 241: buf = new byte[size];
This
> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
> instruction for following IR pallets.
>
>
>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>MulVL (URShiftVL SRC1 , 32) (URShiftVL SRC2, 32)
>MulVL (URShiftVL SRC1 , 32) ( A
> Refactor removing the dependencies on SecurityManager, doPrivileged, and
> AccessController.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Revert unnecessary copyright change in ProcessEnvironment.java.
Fix code style in Process
On Wed, 13 Nov 2024 02:02:27 GMT, Alexey Semenyuk wrote:
>> The PR affects jpackage test library only. Changes:
>>
>> - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is
>> still used as there is no better alternative.
>> - Use `TKit.concatMessages()` instead of `String.fo
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
> The PR affects jpackage test library only. Changes:
>
> - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is
> still used as there is no better alternative.
> - Use `TKit.concatMessages()` instead of `String.format()` in
> TKit.assert...() methods.
> - Added unit tests for
On Mon, 4 Nov 2024 21:30:10 GMT, Magnus Ihse Bursie wrote:
>>> I can confirm that with your patch, and clang, and a complete wipe +
>>> rebuild, the .java file loading works. I'm currently testing with gcc as
>>> well.
>>
>> Good.
>>
>> I tested using gcc.
>
> @jianglizhou Thank you for your
On Tue, 12 Nov 2024 15:41:01 GMT, Roger Riggs wrote:
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on doPriviledged and
> AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
src/java.base/
On Tue, 12 Nov 2024 16:00:39 GMT, Aleksey Shipilev wrote:
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with the `ArrayList` wrapper that manages synchronization, search
> and replacements efficiently. Arrays are easy targets for GC. There are
> po
On Tue, 12 Nov 2024 18:00:01 GMT, Chen Liang wrote:
>> After the ClassFile API migration, when serializable lambdas are requested
>> for hidden class callers, illegal class name is generated for the
>> serialization methods, which previously had legal yet unusable class names,
>> as hidden cla
On Tue, 12 Nov 2024 23:13:16 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sin
Apologies, I did not mean to add reduce(). Please ignore that part.
On Tue, Nov 12, 2024, 6:37 PM David Alayachew
wrote:
> Oh sure, I expect something like distinct() to pull everything. In order
> to know if something is distinct, you have to do some variant of "check
> against everyone else".
On Tue, 12 Nov 2024 18:05:46 GMT, Roger Riggs wrote:
>> Refactor removing the dependencies on SecurityManager, doPrivileged, and
>> AccessController.
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 228 commits:
>
>
Oh sure, I expect something like distinct() to pull everything. In order to
know if something is distinct, you have to do some variant of "check
against everyone else". Whether that is holding all instances in memory or
their hashes, it's clear from a glance that you will need to look at
everything
> In the JDK code, there are some places that may cause Unsafe offset overflow.
> The probability of occurrence is low, but if it occurs, it will cause JVM
> crash.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base
On Tue, 12 Nov 2024 19:41:50 GMT, Severin Gehwolf wrote:
>> Sergey Chernyshev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Fri, 8 Nov 2024 23:57:58 GMT, Alexey Semenyuk wrote:
> The PR affects jpackage test library only. Changes:
>
> - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is
> still used as there is no better alternative.
> - Use `TKit.concatMessages()` instead of `String.format()
The PR affects jpackage test library only. Changes:
- Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is still
used as there is no better alternative.
- Use `TKit.concatMessages()` instead of `String.format()` in TKit.assert...()
methods.
- Added unit tests for all TKit.asse
On Fri, 8 Nov 2024 23:57:58 GMT, Alexey Semenyuk wrote:
> The PR affects jpackage test library only. Changes:
>
> - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is
> still used as there is no better alternative.
> - Use `TKit.concatMessages()` instead of `String.format()
On Tue, 12 Nov 2024 18:47:46 GMT, Alan Bateman wrote:
>> Removes the SecurityManager usage from Thread + friends.
>>
>> In Thread, the getContextClassLoader method is no longer caller-sensitive
>> method.
>>
>> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
>> longer
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request with a new
On Sun, 10 Nov 2024 07:40:30 GMT, Jatin Bhateja wrote:
>> In the latest version you added new Ideal nodes (`MulIVL` and `MulUIVL`). I
>> don't see a compelling reason to do so. IMO matcher functionality is more
>> than enough to cover `VPMULDQ` case. `MulIVL` is equivalent to `MulVL` +
>> `has
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `sycnhronized` is reinstated.
Dynamic buffer resizing in `BufferedOutputStream` and `BufferedWriter` is
retained.
The `jdk.internal.access` classes `JavaIOPrintStreamAccess` and
`JavaIOPrintWrit
Uses of `InternalLock` are removed and `sycnhronized` is reinstated.
-
Commit messages:
- 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
Changes: https://git.openjdk.org/jdk/pull/22048/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22048&range=00
On Tue, 12 Nov 2024 14:14:18 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1870:
>
>> 1868:
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Tue, 12 Nov 2024 19:15:45 GMT, Raffaello Giulietti
wrote:
> Looks good. Approving the current status. Are there plans for other small
> additions?
Subsequent to this comment, I did a light clean-up pass over the tests. I'll do
a pass over the Float16 implementation too to make sure previou
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Tue, 12 Nov 2024 19:31:21 GMT, kabutz wrote:
>>> @kabutz Let me know how you want to proceed. 👍
>>
>> 've made the changes and sent another PR to the branch holding the changes.
>> Hope that's the right way of doing it...
>
>> @kabutz The update for CSLM is based on @DougLea's proposal on th
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Cleanup pass on tests.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/files
On Tue, 12 Nov 2024 18:05:46 GMT, Roger Riggs wrote:
>> Refactor removing the dependencies on SecurityManager, doPrivileged, and
>> AccessController.
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 228 commits:
>
>
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Tue, 12 Nov 2024 14:59:41 GMT, Sergey Chernyshev
wrote:
> > The JBS issue doesn't mention `NullPointerException`. It would be good to
> > list the observed NPE issue.
>
> Example for NPE:
>
> ```
> public class Test {
> public static void main(String[] args) {
> java.lang.manag
On Tue, 12 Nov 2024 13:17:13 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Tue, 12 Nov 2024 19:09:54 GMT, Sergey Chernyshev
wrote:
> > Edit: Yet, cg v2 will get into trouble since there, for example on rootless
> > podman on cg v2 you'd end up with this instead:
> > ```
> > [0.008s][trace][os,container] OSContainer::init: Initializing Container
> > Support
> > [0.
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote:
>>> @kabutz I think @DougLea identified some potential edge-cases with the
>>> proposed solution, so I added his suggested diff to the JBS Issue for
>>> reference.
>>
>> Indeed, I didn't check what happens when we create a spliterator on an empty
On Tue, 12 Nov 2024 18:28:33 GMT, Kevin Bourrillion wrote:
> About the version string: I think I first proposed including it. If we don't,
> then I think that `-version` ought to be in the shortlist of options we show
> here (not just in full help), so it doesn't become a _three_ step goose cha
After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization
implementation dependencies on doPriviledged and AccessController are removed.
Some refactoring to cleanup the remaining code is expected.
-
Commit messages:
- Merge branch 'master' into 8344039-sm-clean
On Tue, 12 Nov 2024 16:30:12 GMT, Shaojin Wen wrote:
>> In the JDK code, there are some places that may cause Unsafe offset
>> overflow. The probability of occurrence is low, but if it occurs, it will
>> cause JVM crash.
>
> Shaojin Wen has updated the pull request incrementally with one additi
On Tue, 12 Nov 2024 19:06:31 GMT, Daniel Fuchs wrote:
> The proposed changes look reasonable to me. Good simplification of the code.
> I had some uncertainty about the JNDI changes but I couldn't find any place
> in JNDI where a Subject would be extracted from the ACC associated with the
> cre
On Tue, 12 Nov 2024 18:40:34 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix bug parsing short inputs.
Looks g
> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to
> the head, which has item == null, rather than to the first element. The
> trySplit() method no longer worked, and always returned null. Therefore,
> parallel streams have not worked for ConcurrentSkipListMap and
> Co
On Tue, 12 Nov 2024 18:05:46 GMT, Roger Riggs wrote:
>> Refactor removing the dependencies on SecurityManager, doPrivileged, and
>> AccessController.
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 228 commits:
>
>
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
On Tue, 12 Nov 2024 18:47:46 GMT, Alan Bateman wrote:
>> Removes the SecurityManager usage from Thread + friends.
>>
>> In Thread, the getContextClassLoader method is no longer caller-sensitive
>> method.
>>
>> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
>> longer
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix bug parsing short inputs.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574
> Removes the SecurityManager usage from Thread + friends.
>
> In Thread, the getContextClassLoader method is no longer caller-sensitive
> method.
>
> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
> longer exported to java.naming. The usage of newThreadWithAcc is remo
On Tue, 12 Nov 2024 12:49:01 GMT, Raffaello Giulietti
wrote:
>> Thanks for catching that; fix and tests added in subsequent push.
>
> Single digit inputs, e.g., `Float16.valueOf"2")` throw as well.
Addressed in most recent push; thanks.
-
PR Review Comment: https://git.openjdk.org
> Removes the SecurityManager usage from Thread + friends.
>
> In Thread, the getContextClassLoader method is no longer caller-sensitive
> method.
>
> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
> longer exported to java.naming. The usage of newThreadWithAcc is remo
On Tue, 12 Nov 2024 13:17:13 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Tue, 5 Nov 2024 19:21:58 GMT, Chen Liang wrote:
>> After the ClassFile API migration, when serializable lambdas are requested
>> for hidden class callers, illegal class name is generated for the
>> serialization methods, which previously had legal yet unusable class names,
>> as hidden clas
> Refactor removing the dependencies on SecurityManager, doPrivileged, and
> AccessController.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 228 commits:
- Merge branch 'master' into 8343958-process-sm-cleanup
- corre
> After the ClassFile API migration, when serializable lambdas are requested
> for hidden class callers, illegal class name is generated for the
> serialization methods, which previously had legal yet unusable class names,
> as hidden classes cannot be described by a `CONSTANT_Class_info`.
>
>
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote:
>>> @kabutz I think @DougLea identified some potential edge-cases with the
>>> proposed solution, so I added his suggested diff to the JBS Issue for
>>> reference.
>>
>> Indeed, I didn't check what happens when we create a spliterator on an empty
On Tue, 12 Nov 2024 15:54:00 GMT, Shaojin Wen wrote:
>> In the JDK code, there are some places that may cause Unsafe offset
>> overflow. The probability of occurrence is low, but if it occurs, it will
>> cause JVM crash.
>
> Shaojin Wen has updated the pull request incrementally with one additi
> Removes the SecurityManager usage from Thread + friends.
>
> In Thread, the getContextClassLoader method is no longer caller-sensitive
> method.
>
> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
> longer exported to java.naming. The usage of newThreadWithAcc is remo
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request with a new
> Refactor removing the dependencies on SecurityManager, doPrivileged, and
> AccessController.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 226 commits:
- Simplify the generation of the exception message.
The file
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Sun, 10 Nov 2024 07:36:55 GMT, Jatin Bhateja wrote:
>> Yes, this should ensure 0x.
>
> We land here only after checking if inputs are uints, didn't want redundant
> match, its just a convince routine for forwarding inputs. I will create a
> lambda for this.
uint check only ensures v
> 8342566: Improve javadoc of java.lang.annotation.ElementType
Kevin Bourrillion has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains nine additional
commit
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote:
> Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is
> fully initialized in `` block.
> It means we can replace legacy synchronized `Hashtable` with immutable set.
Thanks for running the tests @AlekseiEfimov
---
On Tue, 12 Nov 2024 15:09:23 GMT, Roger Riggs wrote:
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typos founds in code review.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21
On Tue, 12 Nov 2024 16:30:12 GMT, Shaojin Wen wrote:
>> In the JDK code, there are some places that may cause Unsafe offset
>> overflow. The probability of occurrence is low, but if it occurs, it will
>> cause JVM crash.
>
> Shaojin Wen has updated the pull request incrementally with one additi
On Tue, 12 Nov 2024 16:37:28 GMT, Shaojin Wen wrote:
> @liach provided a new idea, which is to change the type of
> jdk.internal.misc.Unsafe.ARRAY_XXX_OFFSET from int to long. I think @liach's
> idea is better, that is the way to completely solve this problem.
I discussed this briefly with him
Removes the SecurityManager usage from Thread + friends.
In Thread, the getContextClassLoader method is no longer caller-sensitive
method.
JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no longer
exported to java.naming. The usage of newThreadWithAcc is removed from
com.
On Tue, 12 Nov 2024 16:30:12 GMT, Shaojin Wen wrote:
>> In the JDK code, there are some places that may cause Unsafe offset
>> overflow. The probability of occurrence is low, but if it occurs, it will
>> cause JVM crash.
>
> Shaojin Wen has updated the pull request incrementally with one additi
> In the JDK code, there are some places that may cause Unsafe offset overflow.
> The probability of occurrence is low, but if it occurs, it will cause JVM
> crash.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright
-
After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), Serialization
implementation dependencies on SecurityManager, doPrivildged, and
AccessController are removed.
Some refactoring to cleanup the remaining code is expected.
-
Depends on: https://git.openjdk.org/jdk/pull/
On Tue, 12 Nov 2024 12:10:07 GMT, Alan Bateman wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename address to offset, from @AlanBateman
>
> Marked as reviewed by alanb (Reviewer).
> @AlanBateman @minborg Sorry,
> Javac is not issuing a mandated unchecked cast warning for code like:
>
>
> import java.lang.invoke.VarHandle;
>
> class VarHandleCast {
> VarHandle vh;
> V method(Object obj) {
> return (V)vh.getAndSet(this, obj);
> }
> }
>
>
> according to the spec the return type i
On Tue, 12 Nov 2024 16:00:39 GMT, Aleksey Shipilev wrote:
> See the bug for more discussion and reproducer. This PR replaces the linked
> list with an `ArrayList` wrapper that manages synchronization, search and
> replacements effectively. There are possible improvements here, most glaring
> i
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
See the bug for more discussion and reproducer. This PR replaces the linked
list with an `ArrayList` wrapper that manages synchronization, search and
replacements effectively. There are possible improvements here, most glaring is
parallelism that is currently knee-capped by global synchronizatio
> Javac is not issuing a mandated unchecked cast warning for code like:
>
>
> import java.lang.invoke.VarHandle;
>
> class VarHandleCast {
> VarHandle vh;
> V method(Object obj) {
> return (V)vh.getAndSet(this, obj);
> }
> }
>
>
> according to the spec the return type i
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote:
> Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is
> fully initialized in `` block.
> It means we can replace legacy synchronized `Hashtable` with immutable set.
The changes look good to me. Also, I've launched exi
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 12 Nov 2024 12:10:07 GMT, Alan Bateman wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename address to offset, from @AlanBateman
>
> Marked as reviewed by alanb (Reviewer).
@AlanBateman @minborg
Sorry, a
> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to
> the head, which has item == null, rather than to the first element. The
> trySplit() method no longer worked, and always returned null. Therefore,
> parallel streams have not worked for ConcurrentSkipListMap and
> Co
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote:
>>> @kabutz I think @DougLea identified some potential edge-cases with the
>>> proposed solution, so I added his suggested diff to the JBS Issue for
>>> reference.
>>
>> Indeed, I didn't check what happens when we create a spliterator on an empty
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote:
>>> @kabutz I think @DougLea identified some potential edge-cases with the
>>> proposed solution, so I added his suggested diff to the JBS Issue for
>>> reference.
>>
>> Indeed, I didn't check what happens when we create a spliterator on an empty
> In the JDK code, there are some places that may cause Unsafe offset overflow.
> The probability of occurrence is low, but if it occurs, it will cause JVM
> crash.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
more fix unsafe addr
On Mon, 4 Nov 2024 16:14:35 GMT, kabutz wrote:
>> Sure, where should I add that test?
>
>> @kabutz I think @DougLea identified some potential edge-cases with the
>> proposed solution, so I added his suggested diff to the JBS Issue for
>> reference.
>
> Indeed, I didn't check what happens when
On Tue, 12 Nov 2024 14:34:45 GMT, Severin Gehwolf wrote:
>> Yes, I'm wondering if a JDK-specific (rather than standard) property could
>> be more widely useful as it would allow observability tools to know that the
>> JDK has been patched. It would be good to get wider input on this.
>
> OK, th
1 - 100 of 169 matches
Mail list logo
