On Thu, 24 Oct 2024 03:31:31 GMT, Julian Waters wrote:
>> I'm not sure what you mean by "that one". It's the static one that should be
>> removed. The local variables always hide the static, and there seems to be
>> no reason for the value of memHandle to survive outside of the local scope
>>
> Discovered this small cleanup while looking at wrapper class code.
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four additional commits
On Thu, 24 Oct 2024 06:28:31 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Factor out IR tests and Transforms to follow-up PRs.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/
On Mon, 21 Oct 2024 12:25:37 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>
On Mon, 21 Oct 2024 12:25:37 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>
On Thu, 24 Oct 2024 03:31:02 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/objectMonitor.hpp line 302:
>>
>>> 300: void set_owner_from(int64_t old_value, JavaThread* current);
>>> 301: // Set _owner field to tid of current thread; current value must be
>>> ANONYMOUS_
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Wed, 23 Oct 2024 15:36:08 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Boolean.java line 259:
>>
>>> 257: public boolean equals(Object obj) {
>>> 258: if (obj instanceof Boolean b) {
>>> 259: return value == b.booleanValue();
>>
>> I would go even a
On Wed, 23 Oct 2024 20:22:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 03:38:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Wed, 21 Aug 2024 20:25:07 GMT, Chen Liang wrote:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces t
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Wed, 23 Oct 2024 05:43:53 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address David's comments to ObjectMonitor.hpp
>
> src/hotspot/share/runtime/objectMonitor.hpp line 302:
>
>>
On Thu, 24 Oct 2024 03:14:47 GMT, Chen Liang wrote:
>> Discovered this small cleanup while looking at wrapper class code.
>
> Chen Liang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the me
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Wed, 23 Oct 2024 09:58:44 GMT, Alan Bateman wrote:
>> src/hotspot/share/runtime/javaThread.hpp line 166:
>>
>>> 164: // current _vthread object, except during creation of the primordial
>>> and JNI
>>> 165: // attached thread cases where this field can have a temporary value.
>>> 166:
On Wed, 23 Oct 2024 09:53:44 GMT, Alan Bateman wrote:
>> The problem is that within that window we don't have access to the virtual
>> thread's tid. The current thread has already been changed and we haven't yet
>> set the lock id back. Since this will be a rare corner case maybe we can
>> jus
On Wed, 23 Oct 2024 16:51:23 GMT, Chris Plummer wrote:
>> I wasn't sure whether the global memHandle not being used was a bug, so I
>> commented out the local one. I missed the line 88 one because it wasn't
>> flagged. If it really isn't needed I'll remove that one instead
>
> I'm not sure what
On Wed, 23 Oct 2024 23:56:33 GMT, Joe Darcy wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits sinc
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Wed, 23 Oct 2024 02:06:20 GMT, Joe Darcy wrote:
> Noticed this refactoring opportunity while doing some other work in the area.
This pull request has now been integrated.
Changeset: a21c5586
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/a21c558699646d44d071945c82203e2d
On Mon, 23 Sep 2024 17:32:10 GMT, Henry Jen wrote:
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
This pull request has now been integrated.
Changeset: 158b93d1
Author:Henry Jen
URL:
https://git.openjdk.org/jdk/commit/158b93d19a5
On Fri, 18 Oct 2024 19:39:52 GMT, Justin Lu wrote:
>> Please review this PR which improves the readObject logic for
>> _j.text.MessageFormat_.
>>
>> No offset should be larger than the pattern length. We already ensure the
>> offsets when consumed backwards are equal/descending. The existing
On Wed, 23 Oct 2024 00:53:57 GMT, Chen Liang wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add equals/hashCode implementation; tests to follow.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16
On Wed, 23 Oct 2024 03:06:39 GMT, Chen Liang wrote:
> Discovered this small cleanup while looking at wrapper class code.
src/java.base/share/classes/java/lang/Class.java line 3284:
> 3282: * primitive type.
> 3283: */
> 3284: static native Class getPrimitiveClass(String name);
I
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Wed, 23 Oct 2024 16:10:01 GMT, Chen Liang wrote:
>> In other place in the code, I've written out "ell" to avoid any confusion
>> between lowercase "l" and a number "1", etc.
>
> What does "ell" stand for? Looks like "eel" to me.
> That aside, if there's no good name, we usually use `that` or
Modify `FileInputStream` (FIS) to fall back to the superclass implementations
of `readAllBytes()`, `readNBytes(int)`, `skip()`, and `transferTo` when the
input source would otherwise fail with "Illegal Seek" in the FIS
implementation, such as for the standard input or a named pipe.
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Tue, 22 Oct 2024 21:36:06 GMT, Mandy Chung wrote:
> Reviewed test/jdk/java/lang/** and test/jdk/sun/reflect/* tests.
Thanks for the comprehensive review. I have incorporated all of your comments
except for removing the enum from
`java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java`
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
Please review the fix that uses String type for the mapped value in
ModuleLoaderMap.Mapper map (Map). Please see details in
https://bugs.openjdk.org/browse/JDK-8342642, thanks.
-
Commit messages:
- Use String instances as the loader indexes in ModuleLoaderMap.Mapper map.
Changes:
On Wed, 23 Oct 2024 12:14:24 GMT, Alan Bateman wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Tue, 22 Oct 2024 22:17:11 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the
>> default locale with `user.region` creation is inadvertently broken. Fix is
>> to restore the user.region override within
On Wed, 23 Oct 2024 20:34:48 GMT, Patricio Chilano Mateo
wrote:
>> If the virtual thread is un-mounting from the carrier, why do we need to set
>> the "lock id" back to the virtual thread's id? Sorry I'm finding this quite
>> confusing.
>>
>> Also `JavaThread::_lock_id` in the VM means "the j
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Improve specification per code review feedback.
-
Changes:
- all: https://git.openjdk.
On Wed, 23 Oct 2024 05:56:48 GMT, Axel Boldt-Christmas
wrote:
>> Also, is it better to have this without assignment. Which is a nit.
>> Address dst(rthread, JavaThread::held_monitor_count_offset());
>
> The `=` in a variable definition is always construction, never assignment.
>
> That said,
On Wed, 23 Oct 2024 05:18:10 GMT, David Holmes wrote:
>> Thread identity switches to the carrier so Thread.currentThread() is the
>> carrier thread and JavaThread._lock_id is the thread identifier of the
>> carrier. setCurrentLockId changes JavaThread._lock_id back to the virtual
>> thread's
On Wed, 23 Oct 2024 05:42:34 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address David's comments to ObjectMonitor.hpp
>
> src/hotspot/share/runtime/objectMonitor.hpp line 299:
>
>>
On Tue, 22 Oct 2024 15:50:15 GMT, Andrew Haley wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent files
>>
On Wed, 23 Oct 2024 00:19:23 GMT, Coleen Phillimore wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/hotspot/cpu/aarch64/macroAssemble
On Tue, 22 Oct 2024 15:56:21 GMT, Andrew Haley wrote:
>> Note also that `inc_held_monitor_count` clobbers `rscratch2`. That might be
>> worth a comment at the call site.
>> I guess `inc_held_monitor_count` is so hot that we can't push and pop
>> scratch registers, in which case it'd clobber no
On Wed, 23 Oct 2024 19:38:10 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/CachePremissionsTest/CachePermissionsTest.java line
>> 76:
>>
>>> 74: System.out.println("java.io.tmpdir is " +
>>> System.getProperty("java.io.tmpdir"));
>>> 75:
>>> 76: if (args.length > 1) {
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 12 addi
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Wed, 23 Oct 2024 05:33:55 GMT, Axel Boldt-Christmas
wrote:
>> Ok, I'll change copy_lockstack to both load and clear the oops in the same
>> method. Now, when we call do_barriers on recurse_thaw we don't clear the
>> oops, we just load and store the loaded value again. Is it the case that we
On Tue, 22 Oct 2024 01:46:45 GMT, Alexander Matveev
wrote:
> - Removed hard check for "Xcode with command line developer tools" when
> `--mac-sign` is specified and instead we will show information message if
> `codesign` fails for any reason that possible root cause of failure is
> missing X
On Mon, 21 Oct 2024 21:12:29 GMT, Phil Race wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to depr
On Wed, 23 Oct 2024 06:15:27 GMT, David Holmes wrote:
> Why do we need to cache it? Is it the implicit barriers related to accessing
> the threadObj oop each time?
We cache threadObj.thread_id in JavaThread::_lock_id so that the fast path
c2_MacroAssembler code has one less load and code to fi
On Wed, 23 Oct 2024 12:53:12 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvm.cpp line 1272:
>>
>>> 1270:
>>> 1271:
>>> 1272: // Returns the inherited_access_control_context field of the running
>>> thread.
>>
>> There's some code in this file in
>> static void trace_class_resolution
On Mon, 14 Oct 2024 23:30:06 GMT, Brian Burkhalter wrote:
> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
> to native code and use these in `ChannelInputStream` to work around cases
> where a wrapped `FileChannelImpl` is not really seekable.
This pull request ha
Having opted in to allow setting an SM is a clearer signal.
-
Commit messages:
- Better fix for Thread.setContextClassloader from thread in FJP commonPool
task no longer works after JDK-8327501
Changes: https://git.openjdk.org/jdk/pull/21668/files
Webrev: https://webrevs.openjdk.
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 00:09:25 GMT, Brian Burkhalter wrote:
>> Add `isOther` and `available` methods to `FileChannelImpl` and the
>> interfaces to native code and use these in `ChannelInputStream` to work
>> around cases where a wrapped `FileChannelImpl` is not really seekable.
>
> Brian Burkhalt
On Wed, 23 Oct 2024 16:02:07 GMT, Roger Riggs wrote:
> lgtm
Thanks @RogerRiggs. I'm going to push this PR as-is; any further refinements
can be done next time someone is updating these classes.
-
PR Comment: https://git.openjdk.org/jdk/pull/21652#issuecomment-2433088864
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Wed, 23 Oct 2024 11:32:54 GMT, Alan Bateman wrote:
>> Suggestion: `timedWaitCounter` ?
>
> We could rename it to timedWaitSeqNo if needed.
Ok, renamed to timedWaitSeqNo.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1813240667
On Tue, 22 Oct 2024 18:09:57 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
> locale with `user.region` creation is inadvertently broken. Fix is to restore
> the user.region override within Stat
On Thu, 17 Oct 2024 20:01:33 GMT, Naoto Sato wrote:
> Changing the charset initialization of `java.io.Console` class, which is the
> basis of `java.io.IO`, so that it would behave the same way as `System.out`
> wrt encoding. This change will also have the capability to override the
> default c
On Tue, 22 Oct 2024 18:55:29 GMT, Naoto Sato wrote:
>> Changing the charset initialization of `java.io.Console` class, which is the
>> basis of `java.io.IO`, so that it would behave the same way as `System.out`
>> wrt encoding. This change will also have the capability to override the
>> defau
On Tue, 22 Oct 2024 22:17:11 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the
>> default locale with `user.region` creation is inadvertently broken. Fix is
>> to restore the user.region override within
On Tue, 22 Oct 2024 07:03:48 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent files
>>
On Tue, 22 Oct 2024 18:55:29 GMT, Naoto Sato wrote:
>> Changing the charset initialization of `java.io.Console` class, which is the
>> basis of `java.io.IO`, so that it would behave the same way as `System.out`
>> wrt encoding. This change will also have the capability to override the
>> defau
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 21 Oct 2024 12:32:00 GMT, Axel Boldt-Christmas
wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Rename timedWaitNonce to timedWaitSeqNo
>> - Fix comment in Thread.java
>> - Clear oops when t
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Wed, 23 Oct 2024 15:46:31 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 865:
>>
>>> 863: public static Float16 min(Float16 a, Float16 b) {
>>> 864: return
>>> shortBitsToFloat16(floatToFloat16(Math.min(a.floatValue(),
>
On Wed, 23 Oct 2024 05:22:45 GMT, Julian Waters wrote:
>> src/jdk.jdi/windows/native/libdt_shmem/shmem_md.c line 47:
>>
>>> 45: {
>>> 46: void *mappedMemory;
>>> 47: // HANDLE memHandle;
>>
>> Why comment out this one but not the one at line 88? It seems they are both
>> equally problemat
On Wed, 23 Oct 2024 05:23:39 GMT, Julian Waters wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 53:
>>
>>> 51: #ifndef _WIN32
>>> 52: static MUTEX_T my_mutex = MUTEX_INIT;
>>> 53: #endif
>>
>> The reason for no reference on windows is because of the following on
>> window
On Sat, 24 Aug 2024 10:49:56 GMT, Eirik Bjørsnøs wrote:
> Please review this refactoring PR which moves the `ZipEntry.flag` field back
> to `ZipOutputStream.XEntry`.
>
> Moving this field will save four bytes from the `ZipEntry` object size and
> also saves an unneccessary read in `ZipFile.get
On Wed, 23 Oct 2024 15:37:00 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Long.java line 1249:
>>
>>> 1247: public boolean equals(Object obj) {
>>> 1248: if (obj instanceof Long ell) {
>>> 1249: return value == ell.longValue();
>>
>> Suggestion:
>>
>>
On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 23 Oct 2024 02:06:20 GMT, Joe Darcy wrote:
> Noticed this refactoring opportunity while doing some other work in the area.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21652#pullrequestreview-2389308583
On Wed, 23 Oct 2024 12:53:20 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add equals/hashCode implementation; tests to follow.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vect
On Wed, 23 Oct 2024 02:14:49 GMT, Chen Liang wrote:
>> Noticed this refactoring opportunity while doing some other work in the area.
>
> src/java.base/share/classes/java/lang/Long.java line 1249:
>
>> 1247: public boolean equals(Object obj) {
>> 1248: if (obj instanceof Long ell) {
>
On Wed, 23 Oct 2024 05:45:33 GMT, Rémi Forax wrote:
>> Noticed this refactoring opportunity while doing some other work in the area.
>
> src/java.base/share/classes/java/lang/Boolean.java line 259:
>
>> 257: public boolean equals(Object obj) {
>> 258: if (obj instanceof Boolean b) {
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Mon, 21 Oct 2024 11:03:44 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanu
On Wed, 23 Oct 2024 11:54:39 GMT, Alan Bateman wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Mon, 21 Oct 2024 22:43:42 GMT, Chen Liang wrote:
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
Great job done!
It would be good to have another pair of eyes to read the new doc, however it
look
On Wed, 23 Oct 2024 12:44:53 GMT, Coleen Phillimore wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote
On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add equals/hashCode implementation; te
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add equals/hashCode implementation; te
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Mon, 21 Oct 2024 17:20:15 GMT, Sean Mullan wrote:
> > There are a couple of micro benchmarks in test/micro that fork with
> > `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be
> > examined.
>
> Fixed, will be in next drop. There are a couple of other micro tests that
On Tue, 22 Oct 2024 21:20:59 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Wed, 23 Oct 2024 06:11:26 GMT, David Holmes wrote:
>> Sequence number, nouce, anything will work here as it's just to deal with
>> the scenario where the timeout task for a previous wait may run concurrently
>> with a subsequent wait.
>
> Suggestion: `timedWaitCounter` ?
We could rename it
On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Fri, 18 Oct 2024 16:02:26 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1796:
>>
>>> 1794: if (metaVersions == null)
>>> 1795: metaVersions = new HashMap<>();
>>> 1796:
1 - 100 of 115 matches
Mail list logo
