Re: RFR: 8340553: ZipEntry field validation does not take into account the size of a CEN header

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 17:40:36 GMT, Lance Andersen wrote: > Please review the changes for > [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a > follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which > addresses that > > - ZipEntry(String) > - ZipEntry

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Jaikiran Pai
On Thu, 17 Oct 2024 06:29:05 GMT, Jan Lahoda wrote: >> src/java.base/share/native/libjli/java.c line 1935: >> >>> 1933: NULL_CHECK(printConciseUsageMessage = >>> (*env)->GetStaticMethodID(env, cls, >>> 1934: "printConciseUsageMessage", >>> "(Z)V"));

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Jan Lahoda
On Thu, 17 Oct 2024 06:14:21 GMT, Jaikiran Pai wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjusting the concise help as suggested: 'using main class of a JAR >> archive' and '.jar'/'.java' > > src/java.base/sha

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 14:55:34 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points [v2]

2024-10-16 Thread Alan Bateman
On Thu, 17 Oct 2024 01:37:01 GMT, Brian Burkhalter wrote: >> Improve support for Windows directory junctions. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8069345: Add os.family == windows to tests This is going to

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 14:55:34 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 20:14:07 GMT, Sean Mullan wrote: >> We've had logging library maintainers on the core-libs-dev several times in >> the last 7+ years so I hope there is good awareness of StackWalker. >> SM.getClassContext is legacy, shouldn't be any reason to use it in 2024. > > Ok, I'll als

Re: Would it make sense to add a new constructor to java.io.SequenceInputStream?

2024-10-16 Thread Jaikiran Pai
It was suggested in that PR that the discussion be brought to this mailing list to gather any inputs and interest in the change. Except for your current mail, there hasn't been any other discussion here in the mailing list about it. In the PR itself I haven't seen any objections to this change

Re: Would it make sense to add a new constructor to java.io.SequenceInputStream?

2024-10-16 Thread David Alayachew
Hello Jaikiran, Thanks for the response. This is exactly what I was looking for. Does this mean that this is up for grabs? There was a comment near the bottom about more evaluations, but that was also in 2023. If all I need to do is continue the work that the other person was doing, I am more th

Re: Would it make sense to add a new constructor to java.io.SequenceInputStream?

2024-10-16 Thread Jaikiran Pai
Hello David, There's an enhancement request for this here https://bugs.openjdk.org/browse/JDK-8305947 -Jaikiran On 17/10/24 9:17 am, David Alayachew wrote: Hello Core Libs Dev Team, Currently, java.io.SequenceInputStream only has 2 constructors -- one that takes in 2 instances of InputStre

Re: RFR: 8173970: jar tool should have a way to extract to a directory [v16]

2024-10-16 Thread Jaikiran Pai
> Can I please get a review for this patch which proposes to implement the > enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970? > > Edit: This PR description has now been updated to match the changes that were > done over the course of review inputs that were received

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v6]

2024-10-16 Thread Ioi Lam
On Wed, 16 Oct 2024 05:13:13 GMT, Chen Liang wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 31 commits: >> >> - @DanHeidinga comments -- added comments and asserts related to >> ClassLoaderData used by archive

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v5]

2024-10-16 Thread Ioi Lam
On Tue, 15 Oct 2024 19:42:51 GMT, Chen Liang wrote: > I recommend adding javadoc or block comments indicating that `runtimeSetup`, > `resetArchivedStates`, etc. are called by VM CDS code so people don't > accidentally rename this and have unintended impact. Done. > src/java.base/share/classes

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v8]

2024-10-16 Thread Ioi Lam
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > This PR implements the AOT-linking of invokedynamic callsites: > - We only link lambda expressions (`LambdaMetafactory::metafactory`) and > string concat (`Stri

Would it make sense to add a new constructor to java.io.SequenceInputStream?

2024-10-16 Thread David Alayachew
Hello Core Libs Dev Team, Currently, java.io.SequenceInputStream only has 2 constructors -- one that takes in 2 instances of InputStream, and another that takes in an Enumeration of type InputStream. Would it make sense to add a third constructor that takes in multiple instances of InputStream? I

Re: RFR: 8233451: (fs) Files.newInputStream() cannot be used with character special files [v2]

2024-10-16 Thread xxDark
On Tue, 15 Oct 2024 22:37:26 GMT, Brian Burkhalter wrote: >> Add `isOther` and `available` methods to `FileChannelImpl` and the >> interfaces to native code and use these in `ChannelInputStream` to work >> around cases where a wrapped `FileChannelImpl` is not really seekable. > > Brian Burkhalt

Re: RFR: 8325089: jpackage utility creates an "infinite", undeleteable directory tree [v2]

2024-10-16 Thread Alexander Matveev
On Wed, 16 Oct 2024 23:09:47 GMT, Alexey Semenyuk wrote: >> Make jpackage correctly handle the output directory (`--dest`) that is: >> - a subdirectory of the input directory; >> - the same as the input directory. >> >> Make jpackage correctly handle temp directory (`--temp`) that is: >> - a

Withdrawn: 8336267: Method and Constructor signature parsing can be shared on the root object

2024-10-16 Thread duke
On Mon, 15 Jul 2024 04:05:55 GMT, Chen Liang wrote: > A straightforward optimization, to share the signature parsing of method, > constructor, and field between the root and the copied objects, like how > method handle accessors are shared. This pull request has been closed without being integ

Re: RFR: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points [v2]

2024-10-16 Thread Brian Burkhalter
> Improve support for Windows directory junctions. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8069345: Add os.family == windows to tests - Changes: - all: https://git.openjdk.org/jdk/pull/21555/files - new:

Re: RFR: 8319343: Improve CDS module graph support for --add-modules option [v2]

2024-10-16 Thread Calvin Cheung
On Wed, 16 Oct 2024 23:18:42 GMT, John R Rose wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @rose00 comment > > src/hotspot/share/classfile/modules.cpp line 697: > >> 695: st.print("%s%s", prefix, m); >>

Re: RFR: 8319343: Improve CDS module graph support for --add-modules option [v2]

2024-10-16 Thread Calvin Cheung
> Summary of changes: > > Before dumping info the archive, all the module names from `--add-modules` > will be sorted and then concatenated into one string with comma as the > separator between module names. > > During runtime, same function will be used to obtain the string in the same > form

Re: RFR: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points

2024-10-16 Thread Brian Burkhalter
On Thu, 17 Oct 2024 00:05:26 GMT, Brian Burkhalter wrote: > Improve support for Windows directory junctions. A Windows directory junction is an empty (void) directory which has a reparse point with tag `IO_REPARSE_TAG_MOUNT_POINT` and a data buffer containing the name of the target of the junc

RFR: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points

2024-10-16 Thread Brian Burkhalter
Improve support for Windows directory junctions. - Commit messages: - 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points Changes: https://git.openjdk.org/jdk/pull/21555/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21555&range=00 Issue: h

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread David Holmes
On Wed, 16 Oct 2024 14:55:34 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8319343: Improve CDS module graph support for --add-modules option

2024-10-16 Thread John R Rose
On Wed, 16 Oct 2024 22:46:40 GMT, Calvin Cheung wrote: > Summary of changes: > > Before dumping info the archive, all the module names from `--add-modules` > will be sorted and then concatenated into one string with comma as the > separator between module names. > > During runtime, same funct

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v3]

2024-10-16 Thread Naoto Sato
On Wed, 16 Oct 2024 23:01:31 GMT, Justin Lu wrote: > BTW, can we go even further and remove "EST", "HST" and "MST" from > `SHORT_IDS`? IIUC the basis for keeping those 3 specifically as part of > `SHORT_IDS` was the conflicting 1.1 behavior. Now that the old mapping is > removed, those 3 will

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v7]

2024-10-16 Thread Ashutosh Mehra
On Wed, 16 Oct 2024 02:42:52 GMT, Ioi Lam wrote: >> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> This PR implements the AOT-linking of invokedynamic callsites: >> - We only link lambda expressions (`Lamb

Re: RFR: 8325089: jpackage utility creates an "infinite", undeleteable directory tree [v2]

2024-10-16 Thread Alexey Semenyuk
> Make jpackage correctly handle the output directory (`--dest`) that is: > - a subdirectory of the input directory; > - the same as the input directory. > > Make jpackage correctly handle temp directory (`--temp`) that is: > - a subdirectory of the input directory. > > jpackage will produce a

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v3]

2024-10-16 Thread Justin Lu
On Wed, 16 Oct 2024 19:59:44 GMT, Naoto Sato wrote: >> Removing the old compatibility behavior switch for JDK1.1. With the >> integration of tzdata2024b, definitions of those three (deprecated) IDs >> changed again, so maintaining the JDK11 compatibility got less useful. >> Removing the compat

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v7]

2024-10-16 Thread Ashutosh Mehra
On Wed, 16 Oct 2024 02:42:52 GMT, Ioi Lam wrote: >> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> This PR implements the AOT-linking of invokedynamic callsites: >> - We only link lambda expressions (`Lamb

RFR: 8335271: Specify the MessageFormat ArgumentIndex Implementation Limit

2024-10-16 Thread Justin Lu
Please review this PR which specifies the _j.text.MessageFormat_ ArgumentIndex limit. A corresponding CSR is drafted. Both the existence of the limit (and behavior if violated), as well as this implementation's limit are added to the class description. See the JBS issue comments for further his

Re: RFR: 8325089: jpackage utility creates an "infinite", undeleteable directory tree

2024-10-16 Thread Alexey Semenyuk
On Wed, 16 Oct 2024 18:45:38 GMT, Alexey Semenyuk wrote: > Make jpackage correctly handle the output directory (`--dest`) that is: > - a subdirectory of the input directory; > - the same as the input directory. > > Make jpackage correctly handle temp directory (`--temp`) that is: > - a subdir

RFR: 8325089: jpackage utility creates an "infinite", undeleteable directory tree

2024-10-16 Thread Alexey Semenyuk
Make jpackage correctly handle the output directory (`--dest`) that is: - a subdirectory of the input directory; - the same as the input directory. Make jpackage correctly handle temp directory (`--temp`) that is: - a subdirectory of the input directory. jpackage will produce an app image or a

RFR: 8319343: Improve CDS module graph support for --add-modules option

2024-10-16 Thread Calvin Cheung
Summary of changes: Before dumping info the archive, all the module names from `--add-modules` will be sorted and then concatenated into one string with comma as the separator between module names. During runtime, same function will be used to obtain the string in the same format with sorted m

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Serguei Spitsyn
On Tue, 15 Oct 2024 21:59:41 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnvBase.cpp line 692: >> >>> 690: if (jt->is_in_VTMS_transition()) { >>> 691: jvf = check_and_skip_hidden_frames(jt->is_in_VTMS_transition(), >>> jvf); >>> 692: } else if (is_virtual) { // filter ou

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v3]

2024-10-16 Thread Justin Lu
On Wed, 16 Oct 2024 19:59:44 GMT, Naoto Sato wrote: >> Removing the old compatibility behavior switch for JDK1.1. With the >> integration of tzdata2024b, definitions of those three (deprecated) IDs >> changed again, so maintaining the JDK11 compatibility got less useful. >> Removing the compat

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Serguei Spitsyn
On Wed, 16 Oct 2024 14:38:13 GMT, Alan Bateman wrote: >> Thank you for the comment. I can move the try-finally to the method >> `java/lang/VirtualThread$VThreadContinuation$1.run()` if you prefer. But it >> will play the same role functionally. > > Changing the run method to > > vthread.notify

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Serguei Spitsyn
On Wed, 16 Oct 2024 08:00:12 GMT, Alan Bateman wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Disallow NotifyFramePop for >> enter/enter0/VirtualThread.run/VThreadContinuation.run > > src/java.base/share/class

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 13:28:47 GMT, Weijun Wang wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 06:58:40 GMT, Alan Bateman wrote: >> Ok, I will revert it. > > The description for the SecurityException thrown by these methods were > adjusted to "if access to the screen is denied by desktop environment". If > you bring back the paragraphs that were removed then you might

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v3]

2024-10-16 Thread Iris Clark
On Wed, 16 Oct 2024 19:59:44 GMT, Naoto Sato wrote: >> Removing the old compatibility behavior switch for JDK1.1. With the >> integration of tzdata2024b, definitions of those three (deprecated) IDs >> changed again, so maintaining the JDK11 compatibility got less useful. >> Removing the compat

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 15:53:33 GMT, Alan Bateman wrote: >> **SLF4J** currently depends on this method when logger name mismatch  >> detection is enabled. >> >> >> >> See also: >> - https://github.com/qos-ch/slf4j/pul

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v3]

2024-10-16 Thread Naoto Sato
> Removing the old compatibility behavior switch for JDK1.1. With the > integration of tzdata2024b, definitions of those three (deprecated) IDs > changed again, so maintaining the JDK11 compatibility got less useful. > Removing the compatibility behavior makes the code and test simpler. A CSR >

Re: RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v25]

2024-10-16 Thread Paul Sandoz
On Wed, 16 Oct 2024 17:29:04 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> for following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v2]

2024-10-16 Thread Naoto Sato
On Wed, 16 Oct 2024 18:33:25 GMT, Justin Lu wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java line 239: > >> 237:

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones [v2]

2024-10-16 Thread Naoto Sato
> Removing the old compatibility behavior switch for JDK1.1. With the > integration of tzdata2024b, definitions of those three (deprecated) IDs > changed again, so maintaining the JDK11 compatibility got less useful. > Removing the compatibility behavior makes the code and test simpler. A CSR >

Re: RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones

2024-10-16 Thread Justin Lu
On Wed, 16 Oct 2024 17:46:20 GMT, Naoto Sato wrote: > Removing the old compatibility behavior switch for JDK1.1. With the > integration of tzdata2024b, definitions of those three (deprecated) IDs > changed again, so maintaining the JDK11 compatibility got less useful. > Removing the compatibil

Re: RFR: 8342336: Optimize ClassFile imports [v2]

2024-10-16 Thread Chen Liang
On Wed, 16 Oct 2024 16:24:55 GMT, Shaojin Wen wrote: >> This is a code style improvement for imports in the java/lang/classfile and >> jdk/internal/classfile/impl directories, includes: >> 1. Import in alphabetical order >> 2. Add a blank line between java and jdk imports >> 3. Use import * for

Re: RFR: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)

2024-10-16 Thread Brian Burkhalter
On Wed, 16 Oct 2024 16:56:38 GMT, Brian Burkhalter wrote: > Modify the `handleAvailable` native code path to ignore an > `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an > existing test to verify this change. I verified that `PeekNamedPipe` also fails with `ERROR_INVALID_F

Withdrawn: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Chen Liang
On Wed, 16 Oct 2024 17:49:51 GMT, Chen Liang wrote: > This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was > based against the master from a few months ago and caused build failures on > all platforms upon integration. The reverted commit can build again on my > persona

Re: RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Jatin Bhateja
On Wed, 16 Oct 2024 17:49:51 GMT, Chen Liang wrote: > This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was > based against the master from a few months ago and caused build failures on > all platforms upon integration. The reverted commit can build again on my > persona

Re: RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Jatin Bhateja
On Wed, 16 Oct 2024 18:08:36 GMT, Chen Liang wrote: > Sure. Please reuse https://bugs.openjdk.org/browse/JDK-8342439 (feel free to > edit the title and description to indicate this is a hotfix) for your hotfix. Ok, fix is ready, I will update the title and fix as a build issue. Thanks!! -

Re: RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Chen Liang
On Wed, 16 Oct 2024 17:49:51 GMT, Chen Liang wrote: > This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was > based against the master from a few months ago and caused build failures on > all platforms upon integration. The reverted commit can build again on my > persona

Re: RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Jatin Bhateja
On Wed, 16 Oct 2024 17:49:51 GMT, Chen Liang wrote: > This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was > based against the master from a few months ago and caused build failures on > all platforms upon integration. The reverted commit can build again on my > persona

Re: RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Chen Liang
On Wed, 16 Oct 2024 17:49:51 GMT, Chen Liang wrote: > This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was > based against the master from a few months ago and caused build failures on > all platforms upon integration. The reverted commit can build again on my > persona

Re: RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Vladimir Kozlov
On Wed, 16 Oct 2024 17:49:51 GMT, Chen Liang wrote: > This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was > based against the master from a few months ago and caused build failures on > all platforms upon integration. The reverted commit can build again on my > persona

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Roger Riggs
On Wed, 16 Oct 2024 14:55:34 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Joe Wang
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

RFR: 8342440: [BACKOUT] Support two vector selectFrom API

2024-10-16 Thread Chen Liang
This reverts commit 709914fc92dd180c8f081ff70ef476554a04f4ce, #20508. It was based against the master from a few months ago and caused build failures on all platforms upon integration. The reverted commit can build again on my personal machine. - Commit messages: - Revert "8338023

RFR: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones

2024-10-16 Thread Naoto Sato
Removing the old compatibility behavior switch for JDK1.1. With the integration of tzdata2024b, definitions of those three (deprecated) IDs changed again, so maintaining the JDK11 compatibility got less useful. Removing the compatibility behavior makes the code and test simpler. A CSR for the be

Re: RFR: 8338023: Support two vector selectFrom API [v17]

2024-10-16 Thread Chen Liang
On Sun, 13 Oct 2024 11:18:01 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> for following new two vector permutation APIs. >> >> >> Declaration:- >> Vector.selectFrom(Vector v1, Vector v2) >> >> >> Semantics:- >>

RFR: 8340553: ZipEntry field validation does not take into account the size of a CEN header

2024-10-16 Thread Lance Andersen
Please review the changes for [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which addresses that - ZipEntry(String) - ZipEntry::setComment - ZipEntry::setExtra currently validate that the max possi

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Eirik Bjørsnøs
On Wed, 16 Oct 2024 14:55:34 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Eirik Bjørsnøs
On Wed, 16 Oct 2024 14:55:34 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Serguei Spitsyn
On Tue, 15 Oct 2024 21:21:07 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Disallow NotifyFramePop for >> enter/enter0/VirtualThread.run/VThreadContinuation.run > > src/hotspot/share/prims/jv

Re: RFR: 8342083: Make a few fields in FileSystemPreferences final

2024-10-16 Thread Brian Burkhalter
On Mon, 23 Sep 2024 09:13:58 GMT, Andrey Turbanov wrote: > 8342083: Make a few fields in FileSystemPreferences final Looks all right. - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21131#pullrequestreview-2373154059

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Serguei Spitsyn
On Wed, 16 Oct 2024 14:50:43 GMT, Alan Bateman wrote: >> The method `java/lang/VirtualThread$VThreadContinuation$1.run()` is starting >> and finishing in a VTMS transition. The issue is with the JVMTI >> `NotifyFramePop`. We need a way to disallow adding `FramePop` event requests >> to its fra

RFR: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)

2024-10-16 Thread Brian Burkhalter
Modify the `handleAvailable` native code path to ignore an `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an existing test to verify this change. - Commit messages: - 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win) Cha

Re: RFR: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)

2024-10-16 Thread Brian Burkhalter
On Wed, 16 Oct 2024 16:56:38 GMT, Brian Burkhalter wrote: > Modify the `handleAvailable` native code path to ignore an > `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an > existing test to verify this change. If `PeekNamedPipe` fails with `ERROR_INVALID_FUNCTION`, then the

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-16 Thread Viktor Klang
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote: > This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overh

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-16 Thread Viktor Klang
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote: > This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overh

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-16 Thread Viktor Klang
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote: > This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overh

RFR: 8341399: Add since checker tests to the langtools modules

2024-10-16 Thread Nizar Benalla
Can I get a review for this patch that adds `@since` checker tests to the following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. The initial test for `java.base` has been integrated in [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). The jtreg comments are almost

Re: RFR: 8342336: Optimize ClassFile imports [v2]

2024-10-16 Thread Shaojin Wen
> This is a code style improvement for imports in the java/lang/classfile and > jdk/internal/classfile/impl directories, includes: > 1. Import in alphabetical order > 2. Add a blank line between java and jdk imports > 3. Use import * for a large number of imports Shaojin Wen has updated the pull

Re: RFR: 8342206: Convenience method to check if a ClassEntry matches a ClassDesc [v2]

2024-10-16 Thread Chen Liang
On Wed, 16 Oct 2024 05:58:08 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java >> line 609: >> >>> 607: var mySym = this.sym; >>> 608: if (mySym != null) >>> 609: return mySym.equals(symbol); >> >> N

Re: RFR: 8342206: Convenience method to check if a ClassEntry matches a ClassDesc [v2]

2024-10-16 Thread Chen Liang
> Currently, to efficiently check if a `ClassEntry`, such as one from an > `InvokeInstruction`, is of a particular class, we use such a pattern (as seen > in JEP 486 [Appendix](https://openjdk.org/jeps/486#Appendix)): > > inst.owner().name().equalsString("java/lang/System") > > This pattern has

Re: RFR: 8338023: Support two vector selectFrom API [v17]

2024-10-16 Thread Sandhya Viswanathan
On Sun, 13 Oct 2024 11:18:01 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> for following new two vector permutation APIs. >> >> >> Declaration:- >> Vector.selectFrom(Vector v1, Vector v2) >> >> >> Semantics:- >>

Integrated: 8338023: Support two vector selectFrom API

2024-10-16 Thread Jatin Bhateja
On Thu, 8 Aug 2024 06:57:28 GMT, Jatin Bhateja wrote: > Hi All, > > As per the discussion on panama-dev mailing list[1], patch adds the support > for following new two vector permutation APIs. > > > Declaration:- > Vector.selectFrom(Vector v1, Vector v2) > > > Semantics:- > Using in

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v5]

2024-10-16 Thread Ioi Lam
On Wed, 16 Oct 2024 03:29:56 GMT, Ioi Lam wrote: >> src/hotspot/share/memory/iterator.inline.hpp line 53: >> >>> 51: // class has not yet been loaded by CDS. >>> 52: cld->oops_do(this, _claim); >>> 53: } >> >> Could you show the stack trace for this? I want to understand better why we

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 15:31:49 GMT, ExE Boss wrote: >> SecurityManager::getClassContext hasn't been needed since JDK 9 but we >> decided to keep the implementation in case there are older versions of >> logging libraries that extend SecurityManager so they can call this method. >> What we have c

Re: RFR: 8335989: Implement Module Import Declarations (Second Preview) [v3]

2024-10-16 Thread Vicente Romero
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote: >> This is a current patch for module imports declarations, second preview. At >> least the JEP number and preview revision will need to be updated in >> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is >> ready to

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread ExE Boss
On Wed, 16 Oct 2024 06:28:03 GMT, Alan Bateman wrote: >> Thanks, will fix. > > SecurityManager::getClassContext hasn't been needed since JDK 9 but we > decided to keep the implementation in case there are older versions of > logging libraries that extend SecurityManager so they can call this me

Re: RFR: 8338694: x86_64 intrinsic for tanh using libm [v13]

2024-10-16 Thread Yudi Zheng
On Mon, 23 Sep 2024 19:24:51 GMT, Srinivas Vamsi Parasa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.tanh() using libm >> >> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup >> -- | -- | -- | -- >> MathBench.tanhDouble | 70900 | 95618 | 1.35x

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v2]

2024-10-16 Thread Jan Lahoda
On Thu, 10 Oct 2024 17:54:51 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v3]

2024-10-16 Thread Jan Lahoda
> Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not the `java` launcher, but it is difficult find out abo

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 10:07:31 GMT, Serguei Spitsyn wrote: >> src/java.base/share/classes/java/lang/VirtualThread.java line 219: >> >>> 217: public void run() { >>> 218: // notify JVMTI >>> 219: vthread.notifyJvmtiStart(); >> >> The notifyJv

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 10:10:16 GMT, Serguei Spitsyn wrote: >> src/java.base/share/classes/java/lang/VirtualThread.java line 423: >> >>> 421: } >>> 422: >>> 423: } finally { >> >> This means an empty finally block, I assume you'll remove the try-finally >> here. > > T

Re: RFR: 8329597: C2: Intrinsify Reference.clear [v10]

2024-10-16 Thread Aleksey Shipilev
On Tue, 15 Oct 2024 11:07:32 GMT, Aleksey Shipilev wrote: >> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native >> method for `Reference.clear`. The original patch skipped intrinsification of >> this method, because we thought `Reference.clear` is not on a performance

Integrated: 8329597: C2: Intrinsify Reference.clear

2024-10-16 Thread Aleksey Shipilev
On Thu, 11 Jul 2024 15:28:37 GMT, Aleksey Shipilev wrote: > [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native > method for `Reference.clear`. The original patch skipped intrinsification of > this method, because we thought `Reference.clear` is not on a performance > s

Re: RFR: 8342083: Make a few fields in FileSystemPreferences final

2024-10-16 Thread Jaikiran Pai
On Mon, 23 Sep 2024 09:13:58 GMT, Andrey Turbanov wrote: > 8342083: Make a few fields in FileSystemPreferences final This looks OK to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21131#pullrequestreview-2372568195

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Weijun Wang
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

Re: RFR: 8342336: Optimize ClassFile imports

2024-10-16 Thread Chen Liang
On Sun, 13 Oct 2024 01:42:38 GMT, Shaojin Wen wrote: > This is a code style improvement for imports in the java/lang/classfile and > jdk/internal/classfile/impl directories, includes: > 1. Import in alphabetical order > 2. Add a blank line between java and jdk imports > 3. Use import * for a lar

Re: RFR: 8310996: Add JFR event for connect operations

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote: > Adds a JFR event for socket connect operations. > > Existing tests TestSocketEvents and TestSocketChannelEvents modified to also > check for connect events. I think this change should have a release note. - PR Comment: https

Re: [External] : Re: Fw: New candidate JEP: 485: Stream Gatherers

2024-10-16 Thread Viktor Klang
Hi Cay, >Maybe just a mental block on my side. If other programmers worked with the API >and found it consistent, don't mind me. I just thought to bring it up in case >this has not received a lot of scrutiny. It is a pretty specialized aspect, >after all. Perhaps the best thing here is to just

Integrated: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote: > This brings in CPU24_10 changes into master branch. This pull request has now been integrated. Changeset: cf5bb127 Author:Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/cf5bb12731b0eefe53b99281453e40493ddafbe4 Stats:

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote: > This brings in CPU24_10 changes into master branch. Thank you Alan and Daniel for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/21533#issuecomment-2416550126

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d [v2]

2024-10-16 Thread Daniel Fuchs
On Wed, 16 Oct 2024 11:36:18 GMT, Jaikiran Pai wrote: >> This brings in CPU24_10 changes into master branch. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase.

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d [v2]

2024-10-16 Thread Jaikiran Pai
> This brings in CPU24_10 changes into master branch. Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote: > This brings in CPU24_10 changes into master branch. Discussed with Jai to confirm testing. All good. - Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21533#pullrequestreview-2372116298

RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Jaikiran Pai
This brings in CPU24_10 changes into master branch. - Commit messages: - 8335713: Enhance vectorization analysis - 8332644: Improve graph optimizations - 8331446: Improve deserialization support - 8307383: Enhance DTLS connections - 8311208: Improve CDS Support - 8328544: Improv

  1   2   >