> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
On Wed, 9 Oct 2024 14:50:30 GMT, Ramkumar Sunderbabu
wrote:
> The System property "docker.support" defined in VMProps gives a wrong
> impression that it is tied to docker alone. The property is common for any
> container runtime. Hence, it needs to be renamed as "container.support".
>
> Posit
> Timezone data 2024b changes
Johny Jose has updated the pull request incrementally with one additional
commit since the last revision:
Review changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21265/files
- new: https://git.openjdk.org/jdk/pull/21265/files/c3238444..
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Added comments explaining the algorithm in more details
-
Changes:
- a
On Fri, 11 Oct 2024 06:43:33 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Fri, 11 Oct 2024 22:23:42 GMT, Justin Lu wrote:
>> Please review this PR which improves the safety of equality checking for
>> DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for
>> NPE in the equality method. This PR now updates the setters to throw NPE.
>>
>> In a
On Fri, 11 Oct 2024 21:02:30 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/Reader.java line 212:
>>
>>> 210: default -> {
>>> 211: for (int i = next, j = next + n; i < j;)
>>> 212: cbuf[off++] = cs.charAt(i+
On Fri, 11 Oct 2024 20:56:44 GMT, Roger Riggs wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> inc should be faster than add on most CPUs
>
> src/java.base/share/classes/java/io/Reader.java line 212:
>
>> 210:
On Thu, 10 Oct 2024 21:10:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Wed, 9 Oct 2024 18:05:55 GMT, Chen Liang wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.org/j
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-authored-by: Raffaello Giulietti
Co-auth
> Please review this PR which improves the safety of equality checking for
> DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for
> NPE in the equality method. This PR now updates the setters to throw NPE.
>
> In addition to the NPEs, there is also a behavioral change tha
On Fri, 11 Oct 2024 16:21:30 GMT, Chen Liang wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null
>> checks across the ClassFile API. This is an updated version of #20556 that
>> minimizes impact on our implementation code.
>>
>> Notes:
>> 1. There's one change
On Wed, 9 Oct 2024 18:05:55 GMT, Chen Liang wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.org/j
On Fri, 11 Oct 2024 20:10:54 GMT, Roger Riggs wrote:
> That's fine, but talking about performance improvements because of what you
> think the compiler will do isn't productive. Make the source clear and
> maintainable and low maintenance. tnx
Uhm... actually I thought my change *made* it clea
On Thu, 10 Oct 2024 21:10:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Fri, 11 Oct 2024 19:45:23 GMT, fabioromano1 wrote:
> This doesn't say much about `maxPowsOf5`, though. You are not using `intVal`
> but 2^`bitLength` > `intVal` in the computation of `maxPowsOf5`. So maybe the
> property you are looking for is `maxPowsOf5` - 1 <= log5(intVal) <
> `maxPowsOf
On Fri, 11 Oct 2024 19:38:03 GMT, Raffaello Giulietti
wrote:
> This doesn't say much about `maxPowsOf5`, though. You are not using `intVal`
> but 2^`bitLength` > `intVal` in the computation of `maxPowsOf5`. So maybe the
> property you are looking for is `maxPowsOf5` - 1 <= log5(intVal) <
> `m
On Fri, 11 Oct 2024 19:25:51 GMT, fabioromano1 wrote:
>> Sorry, this is not a good question, disregard.
>
>> As I asked above, what's the property that should hold? 5^`maxPowsOf5` <=
>> `intVal` < 5^(`maxPowsOf5` + 1)?
>
> Yes, as `floor(log5(intVal)) == max{integer n : 5^n <= intVal}`.
This d
On Fri, 11 Oct 2024 19:09:50 GMT, Raffaello Giulietti
wrote:
>> As I asked above, what's the property that should hold?
>> 5^`maxPowsOf5` <= `intVal` < 5^(`maxPowsOf5` + 1)?
>
> Sorry, this is not a good question, disregard.
> As I asked above, what's the property that should hold? 5^`maxPowsOf
On Fri, 11 Oct 2024 19:01:19 GMT, Raffaello Giulietti
wrote:
>> And considering that `Math.round()` rounds to the closest integer, it also
>> should assure `maxPowsOf5 >= floor(log5(intVal))`, giving a better upper
>> bound.
>
> As I asked above, what's the property that should hold?
> 5^`maxP
On Fri, 11 Oct 2024 18:55:28 GMT, fabioromano1 wrote:
>>> If the mathematical value v of the product and its floating-point value fp
>>> are separated by an integer i in such a way that fp < i < v, we are in
>>> trouble: the ceilings will be different, even if the values are very close
>>> to
On Fri, 11 Oct 2024 18:51:21 GMT, fabioromano1 wrote:
>> One might prove that this cannot happen for a specific approximation of
>> log5(2), like `LOG_5_OF_2` and for all bit length, but I don't think it is
>> worthwhile to put too much effort on this, given the performance figures.
>
>> If the
On Fri, 11 Oct 2024 18:41:50 GMT, Raffaello Giulietti
wrote:
>> If the mathematical value v of the product and its floating-point value fp
>> are separated by an integer i in such a way that fp < i < v, we are in
>> trouble: the ceilings will be different, even if the values are very close
>>
On Fri, 11 Oct 2024 18:32:01 GMT, Raffaello Giulietti
wrote:
>> Actually, if we reason in terms of "ulp vs precision", the computation
>> should be safe: `Math.log()`'s results are within 1 ulp of the exact result,
>> and the floating point operations are a multiplication and a division. The
On Fri, 11 Oct 2024 18:20:50 GMT, fabioromano1 wrote:
>> IIUC, the code assumes that the floating-point computation
>> `Math.ceil(intVal.bitLength() * LOG_5_OF_2)` has the same value as the
>> mathematical ⌈ `intVal.bitLength()` × log5(2) ⌉.
>> I don't think this is safe, as it might happen tha
On Fri, 11 Oct 2024 17:40:21 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refining mathematical definition of remainingZeros
>
> src/java.base/share/classes/java/math/BigDecimal.java li
On Fri, 11 Oct 2024 17:29:59 GMT, Raffaello Giulietti
wrote:
>> I'll have to check...
>> ... tomorrow ;-)
>
> IIUC, the code assumes that the floating-point computation
> `Math.ceil(intVal.bitLength() * LOG_5_OF_2)` has the same value as the
> mathematical ⌈ `intVal.bitLength()` × log5(2) ⌉.
>
On Fri, 11 Oct 2024 15:21:34 GMT, Roger Riggs wrote:
> > I have slightly adapted the copy loop to allow CPUs to use solely
> > single-operand INC within the loop instead of dual-operand ADD.
>
> Did you measure a performance improvement? Compiler optimizations are more
> productive than spot s
On Fri, 11 Oct 2024 18:02:40 GMT, Chen Liang wrote:
>> Please review this change that adds a new dynamic proxies implementation as
>> hidden classes.
>>
>> Summary:
>> 1. Adds new implementation which can be `-Djdk.reflect.useHiddenProxy=true`
>> for early adoption.
>> 2. ClassLoader.defineCla
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
> Please review this change that adds a new dynamic proxies implementation as
> hidden classes.
>
> Summary:
> 1. Adds new implementation which can be `-Djdk.reflect.useHiddenProxy=true`
> for early adoption.
> 2. ClassLoader.defineClass0 takes a ClassLoader instance but discards it in
> native
On Thu, 10 Oct 2024 20:36:26 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refining mathematic
On Thu, 10 Oct 2024 20:36:26 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refining mathematic
On Thu, 10 Oct 2024 21:54:27 GMT, Raffaello Giulietti
wrote:
>> Could make sense using Math.round() instead of Math.ceil() to get better
>> upper bound?
>
> I'll have to check...
> ... tomorrow ;-)
IIUC, the code assumes that the floating-point computation
`Math.ceil(intVal.bitLength() * LOG_
On Fri, 11 Oct 2024 16:54:23 GMT, Quan Anh Mai wrote:
> I am having a similar idea that is to group those transformations together
> into a `Phase` called `PhaseLowering`
I think such a phase could be quite useful in general. Recently I was trying to
implement the BMI1 instruction `bextr` for
On Wed, 9 Oct 2024 09:59:11 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMULUDQ
>> instruction for following IR pallets.
>>
>>
>>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>>MulL (URShift SRC1 , 32) (URShift S
On Thu, 10 Oct 2024 19:42:14 GMT, Roger Riggs wrote:
>> I am keeping the timeout as 60 seconds. is this ok?
>>
>> @Test(timeOut=6)
>> public void now() {
>> Instant expected, test;
>> long diff;
>> do {
>> expected = Instant.now(Clock.systemUTC());
On Fri, 11 Oct 2024 16:21:30 GMT, Chen Liang wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null
>> checks across the ClassFile API. This is an updated version of #20556 that
>> minimizes impact on our implementation code.
>>
>> Notes:
>> 1. There's one change
On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang wrote:
> Please review this patch that adds a test by @nizarbenalla to perform null
> checks across the ClassFile API. This is an updated version of #20556 that
> minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `Me
> Please review this patch that adds a test by @nizarbenalla to perform null
> checks across the ClassFile API. This is an updated version of #20556 that
> minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `MethodHandleProxies` to explicitly use platform
> class
On Fri, 11 Oct 2024 15:57:50 GMT, Adam Sotona wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null
>> checks across the ClassFile API. This is an updated version of #20556 that
>> minimizes impact on our implementation code.
>>
>> Notes:
>> 1. There's one change
On Fri, 11 Oct 2024 16:02:29 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/ClassRemapperImpl.java
>> line 276:
>>
>>> 274: @Override
>>> 275: public ClassDesc map(ClassDesc desc) {
>>> 276: if (desc == null) return null;
>>
>> I'm not sure th
On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang wrote:
> Please review this patch that adds a test by @nizarbenalla to perform null
> checks across the ClassFile API. This is an updated version of #20556 that
> minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `Me
On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang wrote:
> Please review this patch that adds a test by @nizarbenalla to perform null
> checks across the ClassFile API. This is an updated version of #20556 that
> minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `Me
On Wed, 25 Sep 2024 20:46:27 GMT, Stuart Marks wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Add test to ensure reproducible iteration order
>> - Merge branch 'master' of https://github
> Please review this patch that:
> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
> 2. Implemented `spliterator` to optimize for a single element.
>
> The default implementations for multiple-element immutable collections are
> fine as-is, specializing implementation doesn't
Please review this PR which adds test coverage for the case where
`URLClassLoader.defineClass` fails with a `ClassFormatError` _and_ the CRC32
checksum of the class file byte array did not match the CRC32 value stated in
the JAR file's CEN header.
In such cases, an `IOException` with the messag
On Wed, 9 Oct 2024 09:59:11 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMULUDQ
>> instruction for following IR pallets.
>>
>>
>>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>>MulL (URShift SRC1 , 32) (URShift S
On Fri, 11 Oct 2024 06:16:02 GMT, Markus KARG wrote:
> I have slightly adapted the copy loop to allow CPUs to use solely
> single-operand INC within the loop instead of dual-operand ADD.
Did you measure a performance improvement? Compiler optimizations are more
productive than spot source chan
On Fri, 11 Oct 2024 08:11:37 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes overrides of
> `InflaterInputStream.fill` in `ZipFileInflaterInputStream` and
> `ZipFileSystem::getInputStream`. Associated boolean fields used to track
> `eof` are also removed.
>
> These ov
> Please review this cleanup PR which removes overrides of
> `InflaterInputStream.fill` in `ZipFileInflaterInputStream` and
> `ZipFileSystem::getInputStream`. Associated boolean fields used to track
> `eof` are also removed.
>
> These overrides exist to provide zlib with an extra dummy byte at
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Tue, 8 Oct 2024 21:13:47 GMT, Mandy Chung wrote:
>> So like `if (rank <= 0) throw ConstantUtils.rankNotPositive(rank);` at
>> individual use sites?
>
> I meant no need to have a utility method. Just do this:
>
> Suggestion:
>
> public static void validateArrayDepth(int rank) {
>
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Fri, 11 Oct 2024 14:05:40 GMT, Lance Andersen wrote:
> I think we need to be a bit cautious with the proposed change while I
> understand the desire to remove potentially unneeded code.
I understand the need to be cautious in this area. But I would also like to
avoid cargo-culting this for
On Thu, 10 Oct 2024 08:23:42 GMT, Julian Waters wrote:
> I do wonder why the header both here and inside HotSpot is named ub.h instead
> of ubsan.h. Latter sounds better to me, but it doesn't really matter much
I agree it would have probably been better from the start, but at this point
consis
On Thu, 10 Oct 2024 17:54:51 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Fri, 11 Oct 2024 08:11:37 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes overrides of
> `InflaterInputStream.fill` in `ZipFileInflaterInputStream` and
> `ZipFileSystem::getInputStream`. Associated boolean fields used to track
> `eof` are also removed.
>
> These ov
On Fri, 11 Oct 2024 09:35:35 GMT, ExE Boss wrote:
>> test/jdk/jdk/classfile/NullHostileTest.java line 1:
>>
>>> 1: /*
>>
>> I'm a bit worried about maintainability of such complex parametrized test
>> with hard-listed method signatures in a text form. I would recommend to find
>> better locat
On Thu, 10 Oct 2024 12:25:53 GMT, Kevin Rushforth wrote:
>> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it
>> with JavaFX instead.
>>
>> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR
>> openjdk/jfx#1529 for the JavaFX PR that will include the mo
On Mon, 7 Oct 2024 12:42:00 GMT, Prasadrao Koppula wrote:
>> Using SharedSecrets, I attempted to expose FileInputStream::path
>> information. After implementing the fix, I validated the startup performance
>> tests. Observed no consistent pattern of performance drops or gains, can
>> disregard
On Fri, 11 Oct 2024 07:55:44 GMT, Adam Sotona wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null
>> checks across the ClassFile API. This is an updated version of #20556 that
>> minimizes impact on our implementation code.
>>
>> Notes:
>> 1. There's one change
On Fri, 11 Oct 2024 08:11:37 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes overrides of
> `InflaterInputStream.fill` in `ZipFileInflaterInputStream` and
> `ZipFileSystem::getInputStream`. Associated boolean fields used to track
> `eof` are also removed.
>
> These ov
Please review this cleanup PR which removes overrides of
`InflaterInputStream.fill` in `ZipFileInflaterInputStream` and
`ZipFileSystem::getInputStream`. Associated boolean fields used to track `eof`
are also removed.
These overrides exist to provide zlib with an extra dummy byte at the end of
On Fri, 11 Oct 2024 05:39:20 GMT, Chen Liang wrote:
> Patch a tableswitch instruction's low value to be greater than a high value,
> previously, javap will not print any previous instruction and report
> problematic address/bci to be 0. This is because the iteration of bound
> models require f
On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang wrote:
> Please review this patch that adds a test by @nizarbenalla to perform null
> checks across the ClassFile API. This is an updated version of #20556 that
> minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `Me
67 matches
Mail list logo
