On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote:
>> There are a few warnings as errors occurring when building on Linux with
>> clang (clang15). Mostly these are some kind of 'unused' warnings.
>> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 .
>
> Matthias Baesken has
On Tue, 8 Oct 2024 17:10:43 GMT, Ramkumar Sunderbabu
wrote:
> The time difference check might fail for scenarios such as batch compilation.
> It is safer to give a bigger allowance of 10 seconds instead of 0.1 sec.
>
> Testing: The test was run for 100 times with -Xcomp option.
Background of
On Wed, 9 Oct 2024 19:14:06 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/StringReader.java line 38:
>>
>>> 36: * {@code Reader.of(String)} should generally be used in preference to
>>> this one,
>>> 37: * as it supports all of the same operations but it is faster, as it
>>>
On Wed, 9 Oct 2024 21:12:10 GMT, Roger Riggs wrote:
>> The test name follows the conventions currently applied in this folder. Feel
>> free to propose a better name, I would be happy to change it.
>
> The test name should provide enough context so the *human* reader does not
> have to hunt arou
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote:
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to rece
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote:
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to rece
On Wed, 9 Oct 2024 07:00:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to deprecate for
>> removal the `jrunscript` tool?
>>
>> The `jrunscript` tool as documented in its specification
>> https://docs.oracle.com/en/java/javase/23/docs/specs/man/jrunsc
On Thu, 10 Oct 2024 04:36:58 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.or
On Wed, 9 Oct 2024 19:12:33 GMT, Roger Riggs wrote:
> I see Alan and I have different views on the inclusion of the details. With
> only a single CharSequence argument, I can't see any ambiguity about the
> starting position.
It could be a second sentence, "Reading starts at the first characte
On Wed, 9 Oct 2024 11:49:47 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
> ReferenceClassDescImpl caches internalName to avoid creating a new String
> object for each call, which can also simplify the implementation of classfile.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated c
On Fri, 31 May 2024 18:33:39 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Wed, 9 Oct 2024 17:17:36 GMT, Shaojin Wen wrote:
> Cache method names to reduce the overhead of using StringBuilder to construct
> method names, which will make the performance test results more stable.
This pull request has now been integrated.
Changeset: 475f8f94
Author:Shaojin Wen
U
On Tue, 8 Oct 2024 00:47:27 GMT, Shaojin Wen wrote:
> A simple optimization that eliminates the allocation of the
> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates
> the allocation of argNames when parameterCount is equal to 1
This pull request has now been integrate
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
On Tue, 8 Oct 2024 23:11:25 GMT, Justin Lu wrote:
> A trivial correction to the _j.util.Currency_ external specification ISO
> currency codes link. Browsers will auto resolve and correct the link, but it
> should still be fixed regardless.
This pull request has now been integrated.
Changeset
On Tue, 1 Oct 2024 21:46:44 GMT, Justin Lu wrote:
> Please review this PR which modifies a suspicious check in the fallback of
> `Locale.getDisplayName(Locale inLocale)`.
>
> As a fallback, a hard coded pattern is used. The previous code outputted the
> qualifiers if the `displayNames` array h
On Wed, 2 Oct 2024 01:06:20 GMT, Ioi Lam wrote:
>> This is the 6th PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> The implementation of java.lang.invoke uses SoftReferences so that unused
>> MethodHandles, LambdaForms, etc, can be
On Wed, 9 Oct 2024 20:08:25 GMT, Markus KARG wrote:
>> test/jdk/java/io/Reader/Of.java line 40:
>>
>>> 38: * @bug 8341566
>>> 39: * @summary Check for expected behavior of Reader.of().
>>> 40: * @run testng Of
>>
>> The test name should be more descriptive. Without the package name it is
>
On Wed, 9 Oct 2024 20:47:25 GMT, fabioromano1 wrote:
>> What's wrong with the semantics? In my understanding, it should count the
>> ones for non-negative values and the zeros for negative values, where
>> non-negative values have an infinite prefix of zero bits and negative values
>> have an
On Wed, 9 Oct 2024 17:28:07 GMT, Justin Lu wrote:
> Please review this PR which fixes incorrect usage of `jthrowable
> ExceptionOccurred(JNIEnv *env)` within _java.prefs_.
>
> This corrects instances where the return value is being treated as a boolean.
> Such occurrences are replaced with `jb
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote:
> Please review this PR which fixes incorrect usage of `jthrowable
> ExceptionOccurred(JNIEnv *env)` within _java.base_.
>
> This corrects instances where the return value is being treated as a boolean.
> Such occurrences are replaced with `jbo
On Wed, 9 Oct 2024 20:19:39 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti I think I just found a problem much more serious than a simple
>> optimization, I'm afraid the semantics of `BigInteger.bitCount()` is
>> ill-defined, although it seems absurd to me that no one has noticed it so
>> far
On Wed, 9 Oct 2024 20:19:39 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti I think I just found a problem much more serious than a simple
>> optimization, I'm afraid the semantics of `BigInteger.bitCount()` is
>> ill-defined, although it seems absurd to me that no one has noticed it so
>> far
On Wed, 9 Oct 2024 15:18:15 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Store log5(2) in Big
On Wed, 9 Oct 2024 17:25:12 GMT, fabioromano1 wrote:
>> If you are interested, you can create new PRs without reference to JBS
>> issues, and I'll file them.
>> As usual, it's easier for review purposes when each PR touches only small
>> groups of strongly related changes rather than big modifi
This is a current patch for module imports declarations, second preview. At
least the JEP number and preview revision will need to be updated in
`jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
ready to receive feedback.
The main changes are:
- `requires transitive j
On Wed, 9 Oct 2024 18:59:58 GMT, Roger Riggs wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.org/
On Wed, 9 Oct 2024 14:50:30 GMT, Ramkumar Sunderbabu
wrote:
> The System property "docker.support" defined in VMProps gives a wrong
> impression that it is tied to docker alone. The property is common for any
> container runtime. Hence, it needs to be renamed as "container.support".
>
> Posit
On Wed, 9 Oct 2024 18:40:34 GMT, Roger Riggs wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.org/
On Wed, 9 Oct 2024 18:56:19 GMT, Roger Riggs wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.org/
On Wed, 9 Oct 2024 18:37:53 GMT, Roger Riggs wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in
>> https://openjdk.org/
On Wed, 9 Oct 2024 11:49:47 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Wed, 9 Oct 2024 07:00:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to deprecate for
>> removal the `jrunscript` tool?
>>
>> The `jrunscript` tool as documented in its specification
>> https://docs.oracle.com/en/java/javase/23/docs/specs/man/jrunsc
On Wed, 9 Oct 2024 15:47:22 GMT, David M. Lloyd wrote:
>> David M. Lloyd has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> Could anyone provide a second review? I'm hoping to get this finished before
> rampdown
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Wed, 9 Oct 2024 11:49:47 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Wed, 9 Oct 2024 11:49:47 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Wed, 9 Oct 2024 00:08:30 GMT, Justin Lu wrote:
>> A trivial correction to the _j.util.Currency_ external specification ISO
>> currency codes link. Browsers will auto resolve and correct the link, but it
>> should still be fixed regardless.
>
> Justin Lu has updated the pull request incremen
On Wed, 9 Oct 2024 00:08:30 GMT, Justin Lu wrote:
>> A trivial correction to the _j.util.Currency_ external specification ISO
>> currency codes link. Browsers will auto resolve and correct the link, but it
>> should still be fixed regardless.
>
> Justin Lu has updated the pull request incremen
On Wed, 9 Oct 2024 17:17:36 GMT, Shaojin Wen wrote:
> Cache method names to reduce the overhead of using StringBuilder to construct
> method names, which will make the performance test results more stable.
Marked as reviewed by liach (Reviewer).
-
PR Review: https://git.openjdk.or
Cache method names to reduce the overhead of using StringBuilder to construct
method names, which will make the performance test results more stable.
-
Commit messages:
- cache methodName
Changes: https://git.openjdk.org/jdk/pull/21425/files
Webrev: https://webrevs.openjdk.org/?r
> Reduce code size by combining calls and defining local variables
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 18 commits:
- Merge remote-tracking branch 'upstream/master' into
optim_stack_map_gen_202408
- use 4 spa
> Reduce code size by combining calls and defining local variables
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
use 4 spaces.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20756/files
- new: https://git.openjd
Please review this PR which fixes incorrect usage of `jthrowable
ExceptionOccurred(JNIEnv *env)` within _java.prefs_.
This corrects instances where the return value is being treated as a boolean.
Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`.
-
Commit me
Please review this PR which fixes incorrect usage of `jthrowable
ExceptionOccurred(JNIEnv *env)` within _java.base_.
This corrects instances where the return value is being treated as a boolean.
Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`.
-
Commit mes
On Wed, 9 Oct 2024 16:17:59 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti BTW of opening new issues, I've found that there are some
>> optimizations and code simplifications that can be done in `BigInteger`'s
>> bit operations that uses lowest non-zero word search, like `shiftRight()`,
>> `g
> Reduce code size by combining calls and defining local variables
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
Co-authored-by: Chen Liang
On Mon, 7 Oct 2024 09:00:28 GMT, Aleksei Efimov wrote:
>> This PR proposes the following changes to address wrong timeout computations
>> in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
>> clock. The existing `Timeout` test ha
On Thu, 29 Aug 2024 11:44:50 GMT, Shaojin Wen wrote:
> A very small optimization, split the large method inflate, split the
> infrequently used paths into a method inflateCHAR
This pull request has now been integrated.
Changeset: a24525b6
Author:Shaojin Wen
URL:
https://git.openjdk
On Sat, 5 Oct 2024 15:42:08 GMT, Shaojin Wen wrote:
>> Reduce code size by combining calls and defining local variables
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> - Merge branch 'master' into o
On Fri, 4 Oct 2024 16:53:50 GMT, Shaojin Wen wrote:
>> A very small optimization, split the large method inflate, split the
>> infrequently used paths into a method inflateCHAR
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 9 Oct 2024 11:49:47 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote:
>> This change stores InstanceKlass for interface and abstract classes in the
>> non-class metaspace, since class metaspace will have limits on number of
>> classes that can be represented when Lilliput changes go in. Classes that
>> h
On Wed, 9 Oct 2024 16:03:05 GMT, fabioromano1 wrote:
>> Oh right, `expandBigIntegerTenPowers()` indeed computes and stores a lot of
>> values.
>>
>> I'm thinking of opening an issue to rewrite it to just keep the values that
>> are actually computed as intermediate results of a repeated squari
On Tue, 3 Sep 2024 15:50:13 GMT, Thomas Stuefe wrote:
>>> > I don't think the costs for two address comparisons matter, not with the
>>> > comparatively few deallocations that happen (few hundreds or few
>>> > thousand). If deallocate is hot, we are using metaspace wrong.
>>>
>>> MethodData do
On Wed, 9 Oct 2024 16:07:19 GMT, Andrew Haley wrote:
> simply(?) by allocating everything contiguously
Suddenly I seem to hear Boromir and Yoda, in unison, saying, "One does not
simply."
-
PR Comment: https://git.openjdk.org/jdk/pull/19157#issuecomment-2402756530
On Wed, 9 Oct 2024 06:07:13 GMT, John R Rose wrote:
> If the interfaces had a compact numbering, and there were a side table
> mapping the compact numbers to interface Klass* pointers, then I think
> Andrew's code would still work (with natural adjustments).
Probably, yes. I can pack klass ID+
On Wed, 9 Oct 2024 15:46:37 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti
>> - About powers of two, there is a difference here: all powers of two are
>> removed, not only the common, to use numbers as small as possible, and the
>> powers are removed all in once, while if not they were remove
On Mon, 7 Oct 2024 09:13:57 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds validation of the 'total entries' value when
> fetched from the 'ZIP64 End of Central Directory' header.
>
> We should reject this value under the following conditions:
>
> 1. It is too large to fit withi
On Wed, 25 Sep 2024 12:58:20 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Wed, 9 Oct 2024 14:28:53 GMT, fabioromano1 wrote:
>> Seems like `BigInteger`s division either takes care of removing common
>> powers of 2 in the dividend and divisor (Knuth division), or removing them
>> has no practical benefit (Burnikel-Ziegler).
>>
>> Thus, I'm wondering if using powers
On Wed, 9 Oct 2024 09:00:06 GMT, Andrew Haley wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Replace Metaspace::is_compressed_klass_ptr with
>> CompressedKlassPointers::is_in_encoding_range.
>
> On 10/9/24 0
On Wed, 9 Oct 2024 10:36:28 GMT, Matthias Baesken wrote:
>> Might be a good idea to have rslt commented out rather than removed outright
>> if we don't want to forget about it. guarantee on a variable that doesn't
>> exist will be rather confusing to anyone reading through the code
>
>> Might b
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote:
>> There are a few warnings as errors occurring when building on Linux with
>> clang (clang15). Mostly these are some kind of 'unused' warnings.
>> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 .
>
> Matthias Baesken has
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Store log5(2) in BigDecimal
-
Changes:
- all: https://git.openjdk.org/
The System property "docker.support" defined in VMProps gives a wrong
impression that it is tied to docker alone. The property is common for any
container runtime. Hence, it needs to be renamed as "container.support".
Positive Testing:
tier1,tier2,tier3 - to check stability
tier5 - to run contai
On Mon, 7 Oct 2024 20:00:03 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove trailing whitespace
>> - Use a ZIP64 test vector which may be reproduced using InfoZIP
>
> Marked as revie
On Tue, 8 Oct 2024 07:45:13 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which adds validation of the 'total entries' value
>> when fetched from the 'ZIP64 End of Central Directory' header.
>>
>> We should reject this value under the following conditions:
>>
>> 1. It is too large to fit
On Mon, 7 Oct 2024 19:35:10 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use log cache of Big
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Wed, 9 Oct 2024 14:10:17 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti FYI, I have found that `BigInteger` has already a cache for the
>> repeated squares that uses in radix string conversion, and it is provided by
>> the method `BigInteger.getRadixConversionCache(int radix, int exponent)`
On Mon, 7 Oct 2024 19:48:20 GMT, fabioromano1 wrote:
>> `BigDecimal` was not designed to do astronomical computations. One would
>> probably use other libraries for that, e.g., [GMP](https://gmplib.org/) and
>> would not be interested too much in "stripping trailing zeros".
>> The focus of this
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
> This is the implementation task for `JEP 490: ZGC: Remove the
> Non-Generational Mode`. See the JEP for details.
> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
Axel Boldt-Christmas has updated the pull request incrementally with six
additional commits since the last revision:
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Mon, 7 Oct 2024 19:35:10 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use log cache of Big
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Wed, 9 Oct 2024 07:44:49 GMT, Jan Lahoda wrote:
> I was thinking of a different way to say , that would not
> loose the descriptiveness, but none so far. Any more descriptive/specific
> suggestions than ?
I understand why you ended up with that choice of words, since it is not
trivial to
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Wed, 9 Oct 2024 10:40:53 GMT, Alan Bateman wrote:
>>> @AlanBateman Can you please review [the CSR
>>> request](https://bugs.openjdk.org/browse/JDK-8341596) so I can finish it?
>>> Thanks!
>>
>> Latest API docs looks good, will you update the CSR?
>
>> @AlanBateman WDYT?
>
> A title like "A
This is the implementation task for `JEP 490: ZGC: Remove the Non-Generational
Mode`. See the JEP for details.
[JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
-
Commit messages:
- Remove XCollectedHeap from HSDB
- Fix typo in TestZUncommitEvent.java
- Add missing probl
On Wed, 9 Oct 2024 07:21:48 GMT, Jaikiran Pai wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved wording: 'If the sequence changes while the reader is open, e.g.
>> the length changes, the behavior is undefin
On Wed, 9 Oct 2024 10:40:53 GMT, Alan Bateman wrote:
> > @AlanBateman WDYT?
>
> A title like "Add Reader.of(CharSequence)" would make it clear to everyone
> what this issue, and the CSR, is about.
Changed in PR, RFE and CSR.
-
PR Comment: https://git.openjdk.org/jdk/pull/21371#is
> This Pull Requests proposes an implementation for
> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
> method `public static Reader Reader.of(CharSequence)` will return an
> anonymous, non-synchronized implementation of a `Reader` for each kind of
> `CharSequence` im
On Tue, 8 Oct 2024 13:38:54 GMT, Matthias Baesken wrote:
> There are a few warnings as errors occurring when building on Linux with
> clang (clang15). Mostly these are some kind of 'unused' warnings.
> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 .
I brought back `rslt` but
> There are a few warnings as errors occurring when building on Linux with
> clang (clang15). Mostly these are some kind of 'unused' warnings.
> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 .
Matthias Baesken has updated the pull request incrementally with one additional
commi
> This PR moves the section on restricted methods from the the javadoc of
> `java.lang.foreign` package into a standalone static [javadoc
> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base/java/lang/foreign/doc-files/RestrictedMethods.html).
>
> This is
On Mon, 30 Sep 2024 10:35:35 GMT, Tobias Hartmann wrote:
> You've probably seen this but the new test is failing IR verification:
>
> ```
> Failed IR Rules (4) of Methods (4)
> --
> 1) Method "private static double
> compiler.intrinsics.math.TestMinMaxInlining.te
On Wed, 9 Oct 2024 06:57:38 GMT, Alan Bateman wrote:
>> Reader.of(CharSequence) looks much better than introducing
>> CharSequenceReader. It won't have an equivalent on Writer but I think that
>> is okay. Also it means that the user will need to deal with close throwing
>> IOException but anyt
On Wed, 9 Oct 2024 07:26:41 GMT, Julian Waters wrote:
> Might be a good idea to have rslt commented out
Why not; Chris what do you say ?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21407#discussion_r1793282296
On Wed, 9 Oct 2024 09:59:11 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMULUDQ
>> instruction for following IR pallets.
>>
>>
>>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>>MulL (URShift SRC1 , 32) (URShift S
On Sun, 29 Sep 2024 00:02:38 GMT, Shaojin Wen wrote:
> Some DirectCodeBuilder related optimizations to improve startup and running
> performance:
> 1. Merge calls, merge writeU1 and writeU2 into writeU3
> 2. Merge calls, merge writeU1 and writeIndex operations
> 3. Directly use writeU1 instead o
> This patch optimizes LongVector multiplication by inferring VPMULUDQ
> instruction for following IR pallets.
>
>
>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>MulL (URShift SRC1 , 32) (URShift SRC2, 32)
>MulL (URShift SRC1 , 32) ( And SRC2, 0x
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote:
>> This change stores InstanceKlass for interface and abstract classes in the
>> non-class metaspace, since class metaspace will have limits on number of
>> classes that can be represented when Lilliput changes go in. Classes that
>> h
On Mon, 7 Oct 2024 08:15:21 GMT, Erik Österlund wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More precise bit-unmasks
>
> src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp line 342:
>
>> 340: }
>> 341: if (
1 - 100 of 118 matches
Mail list logo
