> Reduce code size by combining calls and defining local variables
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 14 commits:
- Merge branch 'master' into optim_stack_map_gen_202408
- reduce codeSize
- reduce codeSize
On Fri, 4 Oct 2024 02:47:12 GMT, Shaojin Wen wrote:
> A small optimization to reduce CodeSize, codeSize reduced from 164 to 140.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. Use decStack instead of popStack to reduce array access in popStack
> 3. Call Util.fieldTypeSymbol to pa
> A small optimization for StackMapGenerator::processInvokeInstructions.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. remove Util.methodTypeSymbol(NameAndTypeEntry)
> 3. Use decStack instead of popStack to reduce array access in popStack
> 4. codeSize reduced from 277 to 262
Sha
On Fri, 4 Oct 2024 18:02:21 GMT, fabioromano1 wrote:
>> It takes around 100 ms and less than 1 MB to build a table up to 20 rather
>> than 29.
>> It can be fully constructed in `static { ... }`, avoiding races.
>>
>> IMO, this would cover the vast majority of the cases encountered in practice.
> java.base should provide best practices for Class File API
>
> 1. Use fluent coding style
> 2. Use aconst_null instead of oadConstant(null)
> 3. use astore intead of 'storeLocal(REFERENCE'
> 4. use aload instead of 'loadLocal(REFERENCE'
> 5. 'lload/lstore' instead of 'loadLocal(LONG)/storeLocal(
On Fri, 6 Sep 2024 09:58:58 GMT, Shaojin Wen wrote:
> PR #20772 introduced an optimization for writeUTF, which can also be used in
> DataOutputStream::writeUTF.
This pull request has now been integrated.
Changeset: b42fbf43
Author:Shaojin Wen
URL:
https://git.openjdk.org/jdk/commit
On Mon, 23 Sep 2024 16:32:23 GMT, Kevin Rushforth wrote:
>> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it
>> with JavaFX instead.
>>
>> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR
>> openjdk/jfx#1529 for the JavaFX PR that will include the mo
On Fri, 4 Oct 2024 02:47:12 GMT, Shaojin Wen wrote:
> A small optimization to reduce CodeSize, codeSize reduced from 164 to 140.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. Use decStack instead of popStack to reduce array access in popStack
> 3. Call Util.fieldTypeSymbol to pa
On Wed, 2 Oct 2024 20:32:57 GMT, Alexander Matveev wrote:
> - `AppContentTest` and `SigningOptionsTest` failed on macOS 15 due to
> `codesign` no longer fails if additional content is added to app image.
> - `SigningOptionsTest` fixed by failing `codesign` due to missing identity,
> since we on
On Mon, 23 Sep 2024 16:35:18 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reword doce
Following a discussion offline, w
On Mon, 30 Sep 2024 14:59:12 GMT, David M. Lloyd wrote:
>> Please review this small documentation change to ConstantPoolBuilder to fix
>> a typo and clarify the usage of the `constantValueEntry` method.
>
> David M. Lloyd has updated the pull request incrementally with one additional
> commit s
On Fri, 4 Oct 2024 18:24:37 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/constant/ArrayClassDescImpl.java
>> line 116:
>>
>>> 114: sb.append(componentDesc);
>>> 115: return sb.toString();
>>> 116: }
>>
>> Is there really that much benefit in lazily com
On Fri, 27 Sep 2024 14:21:57 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Fri, 4 Oct 2024 17:17:53 GMT, Joe Darcy wrote:
> Fix broken links.
This pull request has now been integrated.
Changeset: e70cbcfd
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/e70cbcfd0c07c0334bf3d5fe20da806129d7565e
Stats: 3 lines in 2 files changed: 0 ins; 0 del;
On Fri, 4 Oct 2024 14:25:09 GMT, Shaojin Wen wrote:
>> A small optimization for StackMapGenerator::processInvokeInstructions.
>>
>> 1. Use local currentFrame to avoid multiple getfields
>> 2. remove Util.methodTypeSymbol(NameAndTypeEntry)
>> 3. Use decStack instead of popStack to reduce array ac
On Fri, 4 Oct 2024 17:17:53 GMT, Joe Darcy wrote:
> Fix broken links.
Thanks, hannes' pr popped up first in the PR list so I omitted this one.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21360#pullrequestreview-2348973542
On Fri, 4 Oct 2024 17:37:09 GMT, Hannes Wallnöfer wrote:
> Please review a doc change to fix the target anchor for the "wrapper class"
> links added in #21215.
>
> In addition to changing the anchor to "wrapperClass" (singular) I also moved
> the id attribute to the `` tag so that browser vie
On Fri, 4 Oct 2024 19:07:54 GMT, Joe Darcy wrote:
>> Please review a doc change to fix the target anchor for the "wrapper class"
>> links added in #21215.
>>
>> In addition to changing the anchor to "wrapperClass" (singular) I also moved
>> the id attribute to the `` tag so that browser view
On Fri, 4 Oct 2024 17:17:53 GMT, Joe Darcy wrote:
> Fix broken links.
I hadn't caught the use of the plural form anchor in `Types.java`. Looks good.
-
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21360#pullrequestreview-2348949061
On Fri, 20 Sep 2024 05:09:19 GMT, Shaojin Wen wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> bug fix for
On Fri, 4 Oct 2024 17:37:09 GMT, Hannes Wallnöfer wrote:
> Please review a doc change to fix the target anchor for the "wrapper class"
> links added in #21215.
>
> In addition to changing the anchor to "wrapperClass" (singular) I also moved
> the id attribute to the `` tag so that browser vie
On Thu, 3 Oct 2024 19:31:06 GMT, Attila Szegedi wrote:
>> Fixes a regression with #17818 where `ArrayList.subList(…).sort()` started
>> incrementing `ArrayList.modCount` resulting in some cases throwing a
>> `ConcurrentModificationException` where none was thrown before.
>>
>> This change keep
On Fri, 4 Oct 2024 17:37:09 GMT, Hannes Wallnöfer wrote:
> Please review a doc change to fix the target anchor for the "wrapper class"
> links added in #21215.
>
> In addition to changing the anchor to "wrapperClass" (singular) I also moved
> the id attribute to the `` tag so that browser vie
On Fri, 4 Oct 2024 17:38:51 GMT, Jorn Vernee wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 21 Aug 2024 20:25:07 GMT, Chen Liang wrote:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces t
On Wed, 2 Oct 2024 00:20:32 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing from last commit
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
> line 1
On Fri, 4 Oct 2024 17:48:13 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti Which means, however, wanting to work with a precision of
>> billions of decimal digits, and therefore taking on the consequences...
>
> It takes around 100 ms and less than 1 MB to build a table up to 20 rather
> than
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
On Wed, 2 Oct 2024 05:15:04 GMT, David Holmes wrote:
> 3. I will just note that the description for this issue is "Clarify handling
> of restricted and caller-sensitive methods" but there is nothing in the
> proposed changes that relate to CS methods, and I think we have agreed that
> any doc
On Fri, 4 Oct 2024 17:48:13 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti Which means, however, wanting to work with a precision of
>> billions of decimal digits, and therefore taking on the consequences...
>
> It takes around 100 ms and less than 1 MB to build a table up to 20 rather
> than
On Fri, 4 Oct 2024 17:22:32 GMT, fabioromano1 wrote:
>> The real problem here is the maximal size this table can reach and the time
>> it takes to be filled in the worst case: around 300 MB and several minutes.
>
> @rgiulietti Which means, however, wanting to work with a precision of
> billions
Please review a doc change to fix the target anchor for the "wrapper class"
links added in #21215.
In addition to changing the anchor to "wrapperClass" (singular) I also moved
the id attribute to the `` tag so that browser view is positioned over the
whole paragraph instead of just the term "w
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Minor formatting change
-
Changes:
- all: https://git.openjdk.org/jdk/
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Solving thread-safe issues
-
Changes:
- all: https://git.openjdk.org/j
On Thu, 19 Sep 2024 22:25:25 GMT, Justin Lu wrote:
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment o
On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>> c
On Fri, 4 Oct 2024 17:15:54 GMT, Raffaello Giulietti
wrote:
>> @fabioromano1, this is a static method manipulating static fields that are
>> shared by all instances; whether individual instances are thread safe is a
>> separate and unrelated issue.
>
> The real problem here is the maximal size
Fix broken links.
-
Commit messages:
- JDK-8341541: Wrong anchor in wrapper classes links
Changes: https://git.openjdk.org/jdk/pull/21360/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21360&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8341541
Stats: 3 lines in
On Fri, 4 Oct 2024 17:11:51 GMT, Archie Cobbs wrote:
>> @archiecobbs AFAIK, the documentation of `BigDecimal` does not specify that
>> the class is thread-safe, but I could be wrong...
>
> @fabioromano1, this is a static method manipulating static fields that are
> shared by all instances; whet
On Tue, 24 Sep 2024 14:56:19 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
On Fri, 4 Oct 2024 16:32:50 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/doclet/testRestricted/TestRestricted.java line 45:
>>
>>> 43: public static void main(String... args) throws Exception {
>>> 44: var tester = new TestRestricted();
>>> 45: tester.setAutomaticChe
On Fri, 4 Oct 2024 17:03:38 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 5238:
>>
>>> 5236: BigInteger pow = FIVE_TO_2_TO[FIVE_TO_2_TO_LEN - 1];
>>> 5237: for (int i = FIVE_TO_2_TO_LEN; i <= n; i++)
>>> 5238: FIVE_
On Fri, 4 Oct 2024 16:09:28 GMT, Shaojin Wen wrote:
>> fabioromano1 has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'patchStripTrailingZeros' of
>> https://github.com/fabioromano1/jdk into patchStripTrailingZeros
>> - Ad
On Fri, 4 Oct 2024 12:05:02 GMT, Shaojin Wen wrote:
> java.base should provide best practices for Class File API
>
> 1. Use fluent coding style
> 2. Use aconst_null instead of oadConstant(null)
> 3. use astore intead of 'storeLocal(REFERENCE'
> 4. use aload instead of 'loadLocal(REFERENCE'
> 5.
On Fri, 4 Oct 2024 12:05:02 GMT, Shaojin Wen wrote:
> java.base should provide best practices for Class File API
>
> 1. Use fluent coding style
> 2. Use aconst_null instead of oadConstant(null)
> 3. use astore intead of 'storeLocal(REFERENCE'
> 4. use aload instead of 'loadLocal(REFERENCE'
> 5.
java.base should provide best practices for Class File API
1. Use fluent coding style
2. Use aconst_null instead of oadConstant(null)
3. use astore intead of 'storeLocal(REFERENCE'
4. use aload instead of 'loadLocal(REFERENCE'
5. 'lload/lstore' instead of 'loadLocal(LONG)/storeLocal(LONG)'
--
On Thu, 3 Oct 2024 17:15:34 GMT, Archie Cobbs wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code simplification
>
> src/java.base/share/classes/java/math/BigDecimal.java line 5238:
>
>> 5236: BigInte
> A very small optimization, split the large method inflate, split the
> infrequently used paths into a method inflateCHAR
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/jdk/internal/classfile/impl
On Fri, 4 Oct 2024 16:32:50 GMT, Pavel Rappo wrote:
> It will only be `@docRoot` in the JDK, but not in any other code base, and
> certainly not in that test.
Note: only JDK is allowed to have restricted methods. `@Restricted` is a
non-exported JDK annotation. So 3rd party libraries cannot def
On Fri, 4 Oct 2024 16:09:28 GMT, Shaojin Wen wrote:
>> fabioromano1 has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'patchStripTrailingZeros' of
>> https://github.com/fabioromano1/jdk into patchStripTrailingZeros
>> - Ad
On Mon, 23 Sep 2024 21:03:08 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix javadoc test failure
>
> test/langtools/jdk/javadoc/doclet/testRestricted/TestRestricted.java line 4
On Fri, 4 Oct 2024 14:12:16 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Merge branch 'patc
On Wed, 25 Sep 2024 01:10:04 GMT, Shaojin Wen wrote:
>> A very small optimization, split the large method inflate, split the
>> infrequently used paths into a method inflateCHAR
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request no
On Wed, 25 Sep 2024 01:10:04 GMT, Shaojin Wen wrote:
>> A very small optimization, split the large method inflate, split the
>> infrequently used paths into a method inflateCHAR
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request no
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Wed, 2 Oct 2024 13:38:17 GMT, Aleksei Efimov wrote:
>> This PR proposes the following changes to address wrong timeout computations
>> in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
>> clock. The existing `Timeout` test ha
> This PR proposes the following changes to address wrong timeout computations
> in the `com.sun.jndi.dns.DnsClient`:
> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
> clock. The existing `Timeout` test has also been updated to use the nano
> clock to measure obser
On Thu, 3 Oct 2024 17:11:09 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Code simplification
> A small optimization for StackMapGenerator::processInvokeInstructions.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. remove Util.methodTypeSymbol(NameAndTypeEntry)
> 3. Use decStack instead of popStack to reduce array access in popStack
> 4. codeSize reduced from 277 to 262
Sha
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'patchStripTrailingZeros' of
https://github.com/fabioromano1/jdk into
On Fri, 4 Oct 2024 02:15:51 GMT, Shaojin Wen wrote:
> A small optimization for StackMapGenerator::processInvokeInstructions.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. remove Util.methodTypeSymbol(NameAndTypeEntry)
> 3. Use decStack instead of popStack to reduce array access
On Fri, 4 Oct 2024 14:03:20 GMT, Shaojin Wen wrote:
>> Reduce code size by combining calls and defining local variables
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 13 commits:
>
> - reduce codeSize
> - reduce
On Wed, 28 Aug 2024 22:20:25 GMT, Shaojin Wen wrote:
> Reduce code size by combining calls and defining local variables
Can you fix the merge conflicts?
-
PR Comment: https://git.openjdk.org/jdk/pull/20756#issuecomment-2372834014
> Reduce code size by combining calls and defining local variables
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- reduce codeSize
- reduce codeSize
- decStack & stackUnderflow
- fix merge error
- Merge
On Fri, 4 Oct 2024 12:28:37 GMT, Raffaello Giulietti
wrote:
> @fabioromano1 I'll have a look once the commits settle down to something you
> consider stable for review.
@rgiulietti I think the code is already stable enough now.
-
PR Comment: https://git.openjdk.org/jdk/pull/21323
On Fri, 4 Oct 2024 09:34:54 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Avoid overflow of sc
On Fri, 4 Oct 2024 09:34:54 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Avoid overflow of sc
On Fri, 4 Oct 2024 09:52:20 GMT, Maurizio Cimadamore
wrote:
> This is a clean backport of https://git.openjdk.org/jdk/pull/21283
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21351
On Wed, 2 Oct 2024 20:29:10 GMT, David Holmes wrote:
> I think you could probably place ub.h along-side jni_util.h in that directory.
I moved the header to the better location.
-
PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2393323469
8341127: Extra call to MethodHandle::asType from memory segment var handles
fails to inline
-
Commit messages:
- Backport 7fa2f229fbee68112cbdd18b811d95721adfe2ec
Changes: https://git.openjdk.org/jdk/pull/21351/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21351&range=00
On Tue, 1 Oct 2024 10:08:54 GMT, Maurizio Cimadamore
wrote:
> The fix for JDK-8331865 introduced an accidental performance regression.
> The main issue is that now *all* memory segment var handles go through some
> round of adaptation.
> Adapting a var handle results in a so called *indirect* v
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Avoid overflow of scale - preferredScale
-
Changes:
- all: https://git
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at least for now.
>
> The change adds a macro ATTRIBUTE_NO_UBS
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Code simplification
-
Changes:
- all: https://git.openjdk.org/jdk/pull
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Code simplification
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Fri, 4 Oct 2024 04:59:04 GMT, Chen Liang wrote:
>> A small optimization to reduce CodeSize, codeSize reduced from 164 to 140.
>>
>> 1. Use local currentFrame to avoid multiple getfields
>> 2. Use decStack instead of popStack to reduce array access in popStack
>> 3. Call Util.fieldTypeSymbol t
78 matches
Mail list logo
