On Fri, 4 Oct 2024 02:47:12 GMT, Shaojin Wen wrote:
> A small optimization to reduce CodeSize, codeSize reduced from 164 to 140.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. Use decStack instead of popStack to reduce array access in popStack
> 3. Call Util.fieldTypeSymbol to pa
A small optimization for StackMapGenerator::processInvokeInstructions.
1. Use local currentFrame to avoid multiple getfields
2. remove Util.methodTypeSymbol(NameAndTypeEntry)
3. Use decStack instead of popStack to reduce array access in popStack
4. codeSize reduced from 277 to 262
-
On Fri, 4 Oct 2024 02:15:51 GMT, Shaojin Wen wrote:
> A small optimization for StackMapGenerator::processInvokeInstructions.
>
> 1. Use local currentFrame to avoid multiple getfields
> 2. remove Util.methodTypeSymbol(NameAndTypeEntry)
> 3. Use decStack instead of popStack to reduce array access
A small optimization to reduce CodeSize, codeSize reduced from 164 to 140.
1. Use local currentFrame to avoid multiple getfields
2. Use decStack instead of popStack to reduce array access in popStack
3. Call Util.fieldTypeSymbol to pass in type instead of nameAndType
-
Commit message
> This change fixes a bug preventing javac from emitting
> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
> non-default value. The diagnostics are currently emitted for values of
> `--release`, and for the default value of `--system`.
>
> The is a redo of [JDK-8331081](ht
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB
> This change fixes a bug preventing javac from emitting
> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
> non-default value. The diagnostics are currently emitted for values of
> `--release`, and for the default value of `--system`.
>
> The is a redo of [JDK-8331081](ht
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Removed superfluous condition
-
Changes:
- all: https://git.openjdk.or
Hi Louis,
You’re welome!
It definitely handles the “/dev/stdin” case. Other possible fixes are also
being considered.
The Windows case is yet to be investigated, but if needed, does not have to be
part of this issue.
Brian
On Oct 3, 2024, at 11:35 AM, Louis Bergelson wrote:
Thanks for look
On Thu, 3 Oct 2024 19:05:14 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
> Please review this PR which improves the safety of equality checking for
> DecimalFormatSymbols.
>
> DecimalFormatSymbols via its setters, allows certain instance variables to be
> set as null. (Note that some variables are allowed to be null, and others are
> not.) However, non null safe com
On Thu, 3 Oct 2024 00:48:55 GMT, Chen Liang wrote:
>> Please review this PR which improves the safety of equality checking for
>> DecimalFormatSymbols.
>>
>> DecimalFormatSymbols via its setters, allows certain instance variables to
>> be set as null. (Note that some variables are allowed to b
On Thu, 3 Oct 2024 13:15:10 GMT, Shaojin Wen wrote:
>> 1. Construct Frames directly without BitSet
>> 2. Use Frame[] instead of ArrayList
>> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects
>> when there is no frame.
>
> Shaojin Wen has updated the pull request incrementa
On Thu, 3 Oct 2024 19:18:38 GMT, Paul Sandoz wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Typographic error
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMath.java
> line 46:
>
>> 44:
On Thu, 3 Oct 2024 19:51:31 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB
Please review this PR which fixes an unexpected exception for
`TimeZone.toZoneId("HST")` when the old mapping system property is used.
The culprit is in `TimeZone.toZoneId0()`.
This method provides workarounds for "EST", "MST", and "HST" when the old
mapping system property is true. However, it
On Tue, 1 Oct 2024 03:26:26 GMT, Stuart Marks wrote:
>> @dholmes-ora and @dfuch both your observations are quite valid and I agree
>> with them. If you look at the [JBS
>> issue](https://bugs.openjdk.org/browse/JDK-8340572), we discussed this topic
>> there.
>>
>> Clarifying the collections'
> Fixes a regression with #17818 where `ArrayList.subList(…).sort()` started
> incrementing `ArrayList.modCount` resulting in some cases throwing a
> `ConcurrentModificationException` where none was thrown before.
>
> This change keeps the optimization from #17818 but restores the behavior
> wh
On Thu, 3 Oct 2024 19:13:22 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB
On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>> c
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new two vector permutation APIs.
>
>
> Declaration:-
> Vector.selectFrom(Vector v1, Vector v2)
>
>
> Semantics:-
> Using index values stored in the lanes of "this" vector, assembl
> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
> method for `Reference.clear`. The original patch skipped intrinsification of
> this method, because we thought `Reference.clear` is not on a performance
> sensitive path. However, it shows up prominently on simple be
On Thu, 3 Oct 2024 05:04:35 GMT, Jatin Bhateja wrote:
>> I see the problem with float/double vectors. Let us do the rearrange form
>> only for Integral (byte, short, int, long) vectors then. For float/double
>> vector we could keep the code that you have currently.
>
> You will also need additi
Hi Brian,
Thanks for looking into this! That sounds like it would work for my use
case. Anything that returns a result instead of a crash would be a huge
improvement. My main concern is definitely unix/bsd/osx systems, I don't
have a good sense of how pipes work on windows or if there is an an
On Thu, 3 Oct 2024 05:09:22 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Update documentation
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Fri, 27 Sep 2024 18:08:54 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Thu, 3 Oct 2024 05:04:35 GMT, Jatin Bhateja wrote:
>> I see the problem with float/double vectors. Let us do the rearrange form
>> only for Integral (byte, short, int, long) vectors then. For float/double
>> vector we could keep the code that you have currently.
>
> You will also need additi
On Tue, 1 Oct 2024 05:09:25 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
Hello,
With the OpenJDK 11.0.21 release the constructor visibility changed.
That breaks code that relied on
"sun.security.util.ObjectIdentifier(String oid)" such as Apache Kerby
directory's GssTokenV1 class.
The error I receive is:
class org.apache.kerby.kerberos.kerb.gss.impl.GssTokenV1 tried t
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Code simplification
-
Changes:
- all: https://git.openjdk.org/jdk/pull
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Small change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21323/
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Cache the powers of 5 to allow the reuse
-
Changes:
- all: https://git
On Wed, 2 Oct 2024 10:47:09 GMT, Tobias Hartmann wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also dispatch to slow-path on other arches
>
> test/micro/org/openjdk/bench/java/lang/ref/ReferenceClear.java lin
On Thu, 3 Oct 2024 12:14:08 GMT, Erik Österlund wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also dispatch to slow-path on other arches
>
> src/hotspot/share/opto/library_call.cpp line 7002:
>
>> 7000: //
> Some DirectCodeBuilder related optimizations to improve startup and running
> performance:
> 1. Merge calls, merge writeU1 and writeU2 into writeU3
> 2. Merge calls, merge writeU1 and writeIndex operations
> 3. Directly use writeU1 instead of writeBytecode
> 4. Rewrite the implementation of load
On Fri, 27 Sep 2024 16:06:51 GMT, Brian Burkhalter wrote:
> Improve the first sentences of the three `FileInputStream` constructors, in
> particular removing the term "connection."
This pull request has now been integrated.
Changeset: f1ea57f0
Author:Brian Burkhalter
URL:
https://g
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Correct abs(intVal) >= 10 to abs(intVal) >= 5
-
Changes:
- all: https:
On Wed, 2 Oct 2024 23:08:52 GMT, Vladimir Ivanov wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 13 additional commits
>> sinc
On Wed, 25 Sep 2024 12:05:02 GMT, Shaojin Wen wrote:
> 1. Construct Frames directly without BitSet
> 2. Use Frame[] instead of ArrayList
> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects when
> there is no frame.
This pull request has now been integrated.
Changeset: 12
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Use powers of 5 instead of 10 by removing binary trailing zeros
-
Change
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with two additional
commits since the last revision:
- Removed old exp declaration
- Moved exp declaration
-
Changes:
- al
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
An optimization in counting remaining zeros
-
Changes:
- all: https://
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Small correction to avoid an unlikely overflow
-
Changes:
- all: https
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Removed trailing whitespaces
-
Changes:
- all: https://git.openjdk.org
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Removed superfluous conditions
-
Changes:
- all: https://git.openjdk.o
On Thu, 3 Oct 2024 13:15:10 GMT, Shaojin Wen wrote:
>> 1. Construct Frames directly without BitSet
>> 2. Use Frame[] instead of ArrayList
>> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects
>> when there is no frame.
>
> Shaojin Wen has updated the pull request incrementa
> 1. Construct Frames directly without BitSet
> 2. Use Frame[] instead of ArrayList
> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects when
> there is no frame.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
r
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Correction
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21323/fi
On Wed, 2 Oct 2024 04:32:10 GMT, Shaojin Wen wrote:
>> Some DirectCodeBuilder related optimizations to improve startup and running
>> performance:
>> 1. Merge calls, merge writeU1 and writeU2 into writeU3
>> 2. Merge calls, merge writeU1 and writeIndex operations
>> 3. Directly use writeU1 inste
On Fri, 27 Sep 2024 01:34:18 GMT, Shaojin Wen wrote:
>> 1. Construct Frames directly without BitSet
>> 2. Use Frame[] instead of ArrayList
>> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects
>> when there is no frame.
>
> Shaojin Wen has updated the pull request increment
An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses repeated
squares trick.
-
Commit messages:
- Removed trailing whitespaces
- Changed stripTrailingZeros() implementation
Changes: https://git.openjdk.org/jdk/pull/21323/files
Webrev: https://webrevs.openjdk.or
On Thu, 3 Oct 2024 12:30:20 GMT, fabioromano1 wrote:
>> I'll open a JBS issue to refer to as soon as you open the new PR.
>>
>> Please keep the first PR comment as short as possible, then add further
>> details in another comment. As only the first comment is auto-copied in
>> every email in t
On Thu, 3 Oct 2024 09:18:56 GMT, Raffaello Giulietti
wrote:
>> @fabioromano1 I agree with starting a new PR for speed up
>> `stripZerosToMatchScale()`.
>
> I'll open a JBS issue to refer to as soon as you open the new PR.
>
> Please keep the first PR comment as short as possible, then add furt
On Mon, 30 Sep 2024 16:59:16 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
On Wed, 2 Oct 2024 07:53:44 GMT, Shaojin Wen wrote:
> A small optimization to the RawBytecodeHelper::next method
> * Remove `len <= 0` once
> * merge store opcode and isWide
This pull request has now been integrated.
Changeset: d7f32d89
Author:Shaojin Wen
URL:
https://git.openjdk.or
On Mon, 30 Sep 2024 16:32:48 GMT, Aleksey Shipilev wrote:
> > I think we need a new
> > ZBarrierSetRuntime::no_keepalive_store_barrier_on_oop_field_without_healing(oop*
> > p) and to make that the selected slow path function when
> > ZBarrierNoKeepalive is set on a StorePNode. Its implementati
On Tue, 6 Aug 2024 17:26:55 GMT, Jorn Vernee wrote:
> As discussed in the JBS issue:
>
> FFM upcall stubs embed a `Method*` of the target method in the stub. This
> `Method*` is read from the `LambdaForm::vmentry` field associated with the
> target method handle at the time when the upcall stu
On 03/10/2024 10:17, Denis Bredelet wrote:
Hello,
With the OpenJDK 11.0.21 release the constructor visibility changed.
That breaks code that relied on
"sun.security.util.ObjectIdentifier(String oid)" such as Apache Kerby
directory's GssTokenV1 class.
The error I receive is:
class org.apache.ke
On Thu, 3 Oct 2024 09:10:07 GMT, fabioromano1 wrote:
>> @rgiulietti I tried to implement and test stripping zeros algorithm with
>> repeated squares trick, and on my laptop it takes around two seconds for
>> strip one million of zeros. So, I decided to remove the method
>> `stripZerosToEvenS
Hello,
With the OpenJDK 11.0.21 release the constructor visibility changed.
That breaks code that relied on
"sun.security.util.ObjectIdentifier(String oid)" such as Apache Kerby
directory's GssTokenV1 class.
The error I receive is:
class org.apache.kerby.kerberos.kerb.gss.impl.GssTokenV1 tried t
On Thu, 3 Oct 2024 07:55:26 GMT, fabioromano1 wrote:
>> Without experimenting a bit, it's hard to tell.
>> Anyway, I believe the current implementation of `stripZerosToMatchScale()`
>> is O(n^2) rather than exponential, because each single division by 10 is
>> linear.
>>
>> But let's focus on
On Thu, 3 Oct 2024 07:55:26 GMT, fabioromano1 wrote:
>> Without experimenting a bit, it's hard to tell.
>> Anyway, I believe the current implementation of `stripZerosToMatchScale()`
>> is O(n^2) rather than exponential, because each single division by 10 is
>> linear.
>>
>> But let's focus on
On Wed, 2 Oct 2024 18:16:06 GMT, Raffaello Giulietti
wrote:
>> A possible faster implementation of `stripZerosToMatchScale()` could be
>> based on dividing by increasing powers of 10 whose exponent doubles at each
>> step (a kind of repeated squares trick), although the asymptotic running
>>
67 matches
Mail list logo
