Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v17]

2024-09-21 Thread Chen Liang
On Sat, 24 Aug 2024 06:27:26 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two meth

Integrated: 8340544: Optimize setLocalsFromArg

2024-09-21 Thread Shaojin Wen
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote: > CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method > size, codeSize is reduced from 367 to 263. This pull request has now been integrated. Changeset: ab06a878 Author:Shaojin Wen URL: https://git.openjdk

ClassLoader API to look up class files

2024-09-21 Thread Rafael Winterhalter
Hello, It is a quite common need for Java agents to resolve class files for Java classes by their name. Normally, this is done by requesting a resource from the class loader. So if a class: pkg.SampleClass is requested, the agent calls ClassLoader.getResourceAsStream("pkg/SampleClass.class"). Thi

Re: RFR: 8336895: BufferedReader doesn't read full \r\n line ending when it doesn't fit in buffer [v4]

2024-09-21 Thread Alan Bateman
On Wed, 28 Aug 2024 18:04:33 GMT, Brian Burkhalter wrote: >> Add some verbiage stating that two buffered readers or input streams should >> not be used to read from the same reader or input stream, respectively. > > Brian Burkhalter has updated the pull request incrementally with one > addition

Re: RFR: 8336895: BufferedReader doesn't read full \r\n line ending when it doesn't fit in buffer [v4]

2024-09-21 Thread Alan Bateman
On Wed, 28 Aug 2024 18:04:33 GMT, Brian Burkhalter wrote: >> Add some verbiage stating that two buffered readers or input streams should >> not be used to read from the same reader or input stream, respectively. > > Brian Burkhalter has updated the pull request incrementally with one > addition

Re: RFR: 8336025: Improve ZipOutputSream validation of MAX CEN Header field limits [v4]

2024-09-21 Thread Lance Andersen
> Please review the following PR which addresses that ZipOutputStream should > validate the CEN header fields similar to what was done via > [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141) > > As part of this change, the javadoc for ZipEntry has been updated to indicate > that the CE