Hi Viktor, Archie, and Daniel,
I hope everything is going well on your end. I really appreciate the thoughtful
feedback you've provided so far, and I wanted to follow up on our previous
discussion about the potential fairness issue in ArrayBlockingQueue when using
ReentrantLock with Condition.a
On Thu, 19 Sep 2024 19:00:45 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggestion from @liach
>
> src/java.base/share/classes/java/io/ObjectOutputStream.java line 2047:
>
>> 2045:
> PR #20772 introduced an optimization for writeUTF, which can also be used in
> DataOutputStream::writeUTF.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
bug fix for write long utf
-
Changes:
- all: https://git.open
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> Add the following command-line options as specified in JEP 483:
>
>
> - `-XX:AOTMode=off/record/create/auto/on`
> - `-XX:AOTConfiguration=.aotconfig`
> - `-XX:AOTCache=.
On Thu, 19 Sep 2024 12:20:13 GMT, Jorn Vernee wrote:
>> As discussed in the JBS issue:
>>
>> FFM upcall stubs embed a `Method*` of the target method in the stub. This
>> `Method*` is read from the `LambdaForm::vmentry` field associated with the
>> target method handle at the time when the upca
> Move `resource.wxl-file-name` property from `WinResources.properties` files
> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
> be excluded from automatic translations.
Alexey Semenyuk has updated the pull request incrementally with two additional
commits since the
On Fri, 20 Sep 2024 01:06:12 GMT, Alexander Matveev
wrote:
>> Move `resource.wxl-file-name` property from `WinResources.properties` files
>> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
>> be excluded from automatic translations.
>
> src/jdk.jpackage/windows/clas
On Thu, 19 Sep 2024 12:29:34 GMT, Maurizio Cimadamore
wrote:
> And I claim that this is outside the scope of this PR.
And I strongly disagree because the only reason I conceded that this
documentation issue need not be addressed by the CSR request for JEP 472 was
because JDK-8338596 was filed
On Thu, 19 Sep 2024 22:06:14 GMT, Mat Carter wrote:
>> src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp line 40:
>>
>>> 38: strcmp(value, "create") != 0 &&
>>> 39: strcmp(value, "auto") != 0 &&
>>> 40: strcmp(value, "on")) {
>>
>> This should be strcmp(value, "on"
On Thu, 19 Sep 2024 23:37:38 GMT, Alexey Semenyuk wrote:
> Move `resource.wxl-file-name` property from `WinResources.properties` files
> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
> be excluded from automatic translations.
src/jdk.jpackage/windows/classes/jdk/j
`Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
sounds redundant, just say "expected not equals but was 12345".
`Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
Modify it to follow the `assertEquals` style ""expected... but was...".
---
On Thu, 19 Sep 2024 21:15:11 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.tanh() using libm
>>
>> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
>> -- | -- | -- | --
>> MathBench.tanhDouble | 70900 | 95618 | 1.35x
On Tue, 17 Sep 2024 16:13:55 GMT, Quan Anh Mai wrote:
> Hi,
>
> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just
> the revert of the backout.
>
> Regarding the related issues:
>
> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
> [JDK-8309531](ht
Move `resource.wxl-file-name` property from `WinResources.properties` files to
the new `WinResourcesNoL10N.properties` files. The later are supposed to be
excluded from automatic translations.
-
Commit messages:
- 8338918: Remove non translated file name from WinResources resource
On Thu, 19 Sep 2024 16:38:54 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
On Thu, 19 Sep 2024 16:38:54 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
Please review this PR which removes usages of Applet within the corelibs tests.
This includes both code usage as well as occurrences of the word.
There were more files found than the ones included in this PR, please see the
comment on the JBS issue for the reason why they were not included. In g
On Thu, 19 Sep 2024 16:38:54 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
On Thu, 19 Sep 2024 16:38:54 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
On Thu, 19 Sep 2024 21:09:43 GMT, Mat Carter wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comments: do not check for -XX:AOTMode=create in JLI java.c
>
> src/hotspot/share/runtime/flags/jvmFlagConstraint
On Wed, 18 Sep 2024 12:23:48 GMT, Emanuel Peter wrote:
>> Sandhya Viswanathan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> I'm a bit confused by the name `shuffleWrapIndexes` and
> `inline_vector_shuffle_w
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
On Thu, 19 Sep 2024 07:29:11 GMT, Jatin Bhateja wrote:
>> Sandhya Viswanathan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change method name
>
> Hi @sviswa7 , some comments, overall patch looks good to me.
>
> Best Regards,
> Jatin
> Currently the rearrange and selectFrom APIs check shuffle indices and throw
> IndexOutOfBoundsException if there is any exceptional source index in the
> shuffle. This causes the generated code to be less optimal. This PR modifies
> the rearrange/selectFrom Vector API methods to perform wrapIn
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
> This PR moves the section on restricted methods from the the javadoc of
> `java.lang.foreign` package into a standalone static [javadoc
> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base/java/lang/foreign/doc-files/RestrictedMethods.html).
>
> This is
On Thu, 19 Sep 2024 17:21:30 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move restricted method page to `java.lang`
>> Update restricted method page
>
> src/java.base/share/classes/jav
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.tanh() using libm
>
> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
> -- | -- | -- | --
> MathBench.tanhDouble | 70900 | 95618 | 1.35x
Srinivas Vamsi Parasa has updated the pull request incrementally with
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
On Sun, 8 Sep 2024 07:52:26 GMT, Shaojin Wen wrote:
> Similar to ObjectInputStream, use JLA.countPositives and
> JLA.inflateBytesToChars to speed up readUTF
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20903#pullrequestreview-2316686796
On Mon, 16 Sep 2024 14:23:52 GMT, Shaojin Wen wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggestion
Hi Viktor
> Alas, there's no place where this could be enforced, users could have their
> own implementations of Stream (so cannot be enforced in Stream::gather).
The idea is to collect feedback, to see how many people report their Gatherers
being broken (i.e. their Gatherers being non-complian
On Thu, 19 Sep 2024 18:02:07 GMT, Chen Liang wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
>> `ClassDesc` comparison and reusing descriptor hash to calculate internal
>> name hash if possible. No suitable device to run benchmarks so need to find
>> something
On Thu, 19 Sep 2024 14:08:04 GMT, Claes Redestad wrote:
> This PR changes proxy code gen to avoid generating
> `Class.forName("java.lang.Object")`, instead emitting an ldc for the class
> literal, `ldc(CD_Object)`, java code equivalent `Object.class`.
>
> More types could profitably use `ldc(
On Mon, 16 Sep 2024 19:11:23 GMT, Claes Redestad wrote:
>> I measured in bytestacks and the clinit instructions reduced by about 2/3
>
> Yes, you have to pick and evaluate between two trade-offs here: a compact
> routine to compute the array, or a larger initializer which does less
> compute. N
On Thu, 22 Aug 2024 14:34:58 GMT, Claes Redestad wrote:
>> Uh, I mean it's a class entry... and class file format prohibits primitives
>> in class entries. I would deduce that information from the benchmark name.
>
> Yes, obvious in hind-sight, but comments are good to remind readers of
> conte
On Tue, 17 Sep 2024 02:04:51 GMT, Chen Liang wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
>> `ClassDesc` comparison and reusing descriptor hash to calculate internal
>> name hash if possible. No suitable device to run benchmarks so need to find
>> something
> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
> `ClassDesc` comparison and reusing descriptor hash to calculate internal name
> hash if possible. No suitable device to run benchmarks so need to find
> something to run the new benchmark to ensure things work as intended
> This PR proposes the following changes to address wrong timeout computations
> in the `com.sun.jndi.dns.DnsClient`:
> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
> clock. The existing `Timeout` test has also been updated to use the nano
> clock to measure obser
On Wed, 11 Sep 2024 16:27:29 GMT, Daniel Fuchs wrote:
>> 2 time is not too high,
>> I have presented, in the comment, a failures with the elapsed time is almost
>> twice the expected time
>> where the elapsed time is 14229 !! which is approx 1.84 * expected timeout
>
> @msheppar with the latest
On Thu, 19 Sep 2024 13:59:30 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
The `tag` field in `AbstractPoolEntry` is redundant, as it's always of the same
value for each subtype. This is now replaced with an override. This can reduce
the footprint of the entries..
The removal of `hash` was considered but withdrawn; in part because hash
computations are heavy; in c2 th
On Thu, 19 Sep 2024 16:38:54 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in which
> the given API element was introduced. That is:
On Tue, 17 Sep 2024 02:04:51 GMT, Chen Liang wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
>> `ClassDesc` comparison and reusing descriptor hash to calculate internal
>> name hash if possible. No suitable device to run benchmarks so need to find
>> something
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote:
> Please review this PR which removes occurrences of 'applet' within the
> corelibs specification. Applet has been deprecated since JDK9, and may be a
> confusing term for new Java developers, so it should be removed from the
> documentation.
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so it should be removed from the
>> documentati
On Thu, 19 Sep 2024 14:08:04 GMT, Claes Redestad wrote:
> This PR changes proxy code gen to avoid generating
> `Class.forName("java.lang.Object")`, instead emitting an ldc for the class
> literal, `ldc(CD_Object)`, java code equivalent `Object.class`.
>
> More types could profitably use `ldc(
On Thu, 19 Sep 2024 14:14:59 GMT, Chen Liang wrote:
>> This PR changes proxy code gen to avoid generating
>> `Class.forName("java.lang.Object")`, instead emitting an ldc for the class
>> literal, `ldc(CD_Object)`, java code equivalent `Object.class`.
>>
>> More types could profitably use `ldc
On Thu, 19 Sep 2024 13:59:30 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
This PR changes proxy code gen to avoid generating
`Class.forName("java.lang.Object")`, instead emitting an ldc for the class
literal, `ldc(CD_Object)`, java code equivalent `Object.class`.
More types could profitably use `ldc(ClassDesc/-Entry)`, taking cues from
`InvokerBytecodeGenerator.isSt
> This PR moves the section on restricted methods from the the javadoc of
> `java.lang.foreign` package into a standalone static [javadoc
> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base/java/lang/foreign/doc-files/RestrictedMethods.html).
>
> This is
On Thu, 19 Sep 2024 13:59:30 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
On Thu, 19 Sep 2024 02:59:39 GMT, David Holmes wrote:
> As I wrote in the CSR request for the JEP:
>
> > I think each method that is restricted and/or caller-sensitive should
> > specify what happens when called when there is no caller context. We should
> > use `AccessibleObject::canAccess` a
On Thu, 19 Sep 2024 05:03:50 GMT, Amit Kumar wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove PC save/restore on s390
>
> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3063:
>
>> 3061: address start =
> As discussed in the JBS issue:
>
> FFM upcall stubs embed a `Method*` of the target method in the stub. This
> `Method*` is read from the `LambdaForm::vmentry` field associated with the
> target method handle at the time when the upcall stub is generated. The MH
> instance itself is stashed i
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so it should be removed from the
>> documentati
Hi Anthony,
Bear with me for a moment,
in the same vein as there's nothing which enforces equals(…) or hashCode() to
be conformant to their specs, or any interface-implementation for that matter,
I don't see how we could make any stronger enforcement of Gatherers.
>My belief is that the subjec
Windows Server 2025 will be releases in a few months.
The OS detection code of the JVM/JDK should recognize the new Windows server
2025 version.
(currently Windows server 2022 is printed , that is wrong)
The build numbers of some recent previews documented here
https://learn.microsoft.com/en-us/w
On Wed, 18 Sep 2024 17:00:30 GMT, Sandhya Viswanathan
wrote:
>> Currently the rearrange and selectFrom APIs check shuffle indices and throw
>> IndexOutOfBoundsException if there is any exceptional source index in the
>> shuffle. This causes the generated code to be less optimal. This PR modifi
On Wed, 18 Sep 2024 17:00:30 GMT, Sandhya Viswanathan
wrote:
>> Currently the rearrange and selectFrom APIs check shuffle indices and throw
>> IndexOutOfBoundsException if there is any exceptional source index in the
>> shuffle. This causes the generated code to be less optimal. This PR modifi
On Tue, 17 Sep 2024 06:28:54 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to deprecate several
> outdated and undocumented java launcher options? This addresses
> https://bugs.openjdk.org/browse/JDK-8286851.
>
> Specifically, the non-standard launcher opti
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
64 matches
Mail list logo
