Can I please get a review of this change which proposes to deprecate several
outdated and undocumented java launcher options? This addresses
https://bugs.openjdk.org/browse/JDK-8286851.
Specifically, the non-standard launcher options `-verbosegc`, `-noclassgc`,
`-verify`, `-verifyremote`, `-ss`
On Mon, 16 Sep 2024 19:09:03 GMT, Brian Burkhalter wrote:
>> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
>> `isHidden` behave when the `File` represents a symbolic link.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit si
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.tanh() using libm
>
> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
> -- | -- | -- | --
> MathBench.tanhDouble | 70900 | 95618 | 1.35x
Srinivas Vamsi Parasa has updated the pull request incrementally with
On Tue, 16 Jul 2024 18:02:57 GMT, Chen Liang wrote:
> In annotated types, local and inner class types should be annotated as
> "top-level" types. For example, in the test here
>
> public static Class getLocalsMember() {
> class Local {
> class Member {
>
On Sun, 8 Sep 2024 10:05:35 GMT, ExE Boss wrote:
>> Similar to ObjectInputStream, use JLA.countPositives and
>> JLA.inflateBytesToChars to speed up readUTF
>
> src/java.base/share/classes/java/io/DataInputStream.java line 602:
>
>> 600: int ascii = JLA.countPositives(bytearr, 0, utflen)
On Sun, 8 Sep 2024 07:52:26 GMT, Shaojin Wen wrote:
> Similar to ObjectInputStream, use JLA.countPositives and
> JLA.inflateBytesToChars to speed up readUTF
src/java.base/share/classes/java/io/DataInputStream.java line 602:
> 600: int ascii = JLA.countPositives(bytearr, 0, utflen);
> 6
On Mon, 16 Sep 2024 16:41:04 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/io/DataInputStream.java line 590:
>>
>>> 588: if (bytearr == null) {
>>> 589: bytearr = new byte[utflen];
>>> 590: allocate = true;
>>
>> Can we rename this boolean to `trust
On Mon, 16 Sep 2024 13:15:02 GMT, Chen Liang wrote:
>> Similar to ObjectInputStream, use JLA.countPositives and
>> JLA.inflateBytesToChars to speed up readUTF
>
> src/java.base/share/classes/java/io/DataInputStream.java line 590:
>
>> 588: if (bytearr == null) {
>> 589: byte
On Sun, 8 Sep 2024 07:52:26 GMT, Shaojin Wen wrote:
> Similar to ObjectInputStream, use JLA.countPositives and
> JLA.inflateBytesToChars to speed up readUTF
In the readUTFAscii scenario, the performance is significantly improved, but in
the readUTFSmall scenario, the performance is regressed.
On Sun, 8 Sep 2024 07:52:26 GMT, Shaojin Wen wrote:
> Similar to ObjectInputStream, use JLA.countPositives and
> JLA.inflateBytesToChars to speed up readUTF
Thanks for the logical cleanup. I will find another io reviewer too.
Another comment: we currently eagerly allocate a char array, but now
Similar to ObjectInputStream, use JLA.countPositives and
JLA.inflateBytesToChars to speed up readUTF
-
Commit messages:
- suggestion from @liach
- optimize for ascii
- only allocate the char array if we have non-ascii
- optimize DataOutputStream::readUTF
Changes: https://git.ope
Remove an internal exception for invalid utf8 entry format; it should have been
an IllegalArgumentException but was an arbitrary subtype of RuntimeException.
Converted to throw ConstantPoolException, and consolidated into a single method
to reduce code size.
-
Commit messages:
- 8
Thanks for the explanation, Chen.
I was confused by the javadoc on defineClass, as it states that references
would also be redirected during verification. I now see that class loads
during verification are irrelevant here. I was also unaware that the
receiver of field and method references were di
On Tue, 17 Sep 2024 02:04:51 GMT, Chen Liang wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
>> `ClassDesc` comparison and reusing descriptor hash to calculate internal
>> name hash if possible. No suitable device to run benchmarks so need to find
>> something
On Fri, 13 Sep 2024 19:33:51 GMT, Raffaello Giulietti
wrote:
>> `Math.scalb(double)` can be simplified, removing a loop and using
>> larger/smaller factors.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Introduce
On Tue, 17 Sep 2024 02:04:51 GMT, Chen Liang wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
>> `ClassDesc` comparison and reusing descriptor hash to calculate internal
>> name hash if possible. No suitable device to run benchmarks so need to find
>> something
On Sun, 15 Sep 2024 13:22:22 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 372:
>>
>>> 370: * }
>>> 371: * }
>>> 372: * This is converted to explicit initialization to avoid bootstrap
>>> overhead.
>>
>> Have you measured this t
On Sun, 15 Sep 2024 19:08:00 GMT, ExE Boss wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Fix build
>> - Merge branch 'master' of https://github.com/openjdk/jdk into
>> feature/classent
On Thu, 22 Aug 2024 13:45:31 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Improve benchmark as suggested
>> - Merge branch 'master' of https://github.com/openjdk/
> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
> `ClassDesc` comparison and reusing descriptor hash to calculate internal name
> hash if possible. No suitable device to run benchmarks so need to find
> something to run the new benchmark to ensure things work as intended
On Tue, 17 Sep 2024 02:01:49 GMT, Chen Liang wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through
>> `ClassDesc` comparison and reusing descriptor hash to calculate internal
>> name hash if possible. No suitable device to run benchmarks so need to find
>> something
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.tanh() using libm
>
> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
> -- | -- | -- | --
> MathBench.tanhDouble | 70900 | 95618 | 1.35x
Srinivas Vamsi Parasa has updated the pull request incrementally with
On Sat, 14 Sep 2024 06:47:40 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8339574: Move symbolic link verbiage from class to constructor doc in
>> FIS/FOS/RAF
>
> src/java.base/share/class
On Sat, 14 Sep 2024 07:03:05 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8339574: Move symbolic link verbiage from class to constructor doc in
>> FIS/FOS/RAF
>
> src/java.base/share/class
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.tanh() using libm
>
> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
> -- | -- | -- | --
> MathBench.tanhDouble | 70900 | 95618 | 1.35x
Srinivas Vamsi Parasa has updated the pull request with a new target b
On Sun, 21 Jul 2024 13:29:36 GMT, Technici4n wrote:
> Hi,
>
> Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the
> `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for
> example.
>
> There has been some discussion on nio-dev about more broadl
On Mon, 16 Sep 2024 02:58:41 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
On Thu, 12 Sep 2024 23:03:33 GMT, Naoto Sato wrote:
> Yet another preparation for upgrading the time zone data to 2024b, which
> introduced a new abbreviation format "%z". The update includes:
> ...
> The main source files' time zone abbreviations now use %z,
> supported by zic since
On Fri, 13 Sep 2024 18:39:42 GMT, Naoto Sato wrote:
>> Yet another preparation for upgrading the time zone data to 2024b, which
>> introduced a new abbreviation format "%z". The update includes:
>> ...
>> The main source files' time zone abbreviations now use %z,
>> supported by zic
On Mon, 16 Sep 2024 19:30:56 GMT, Naoto Sato wrote:
>> make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesProvider.java line 308:
>>
>>> 306: if (off < tokens.length) {
>>> 307: String dayRule = tokens[off++];
>>> 308: if (dayRule.regionMatches(true, 0
On Mon, 16 Sep 2024 18:57:42 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> make/jdk/src/classes/build/tools/tzdb/TzdbZoneRul
> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
> `isHidden` behave when the `File` represents a symbolic link.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8339574: Add symbolic link verbiage to Fi
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Fri, 13 Sep 2024 18:39:42 GMT, Naoto Sato wrote:
>> Yet another preparation for upgrading the time zone data to 2024b, which
>> introduced a new abbreviation format "%z". The update includes:
>> ...
>> The main source files' time zone abbreviations now use %z,
>> supported by zic
On Mon, 16 Sep 2024 18:47:40 GMT, Alan Bateman wrote:
>> Short answer. finish() which calls writeCEN, will throw for the above.
>>
>> As the entry comment, is only part of the CEN, I wanted to keep the
>> encoding in writeCEN as there is no reason to do it earlier.
>
> I looks very out of plac
On Mon, 16 Sep 2024 18:22:18 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/zip/ZipEntry.java line 44:
>>
>>> 42: * entry comment and {@linkplain #CENHDR CEN Header size}, must not
>>> 43: * exceed 65,535 bytes. If it does, {@linkplain ZipOutputStream} will
>>> 44: * thro
On Mon, 16 Sep 2024 02:58:41 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
On Mon, 16 Sep 2024 11:59:22 GMT, Eirik Bjørsnøs wrote:
>> I am not sure it is needed, but could tweak to
>>
>>> The combined length, after encoding, of the ..
>>
>> thoughts?
>
>> > The combined length, after encoding, of the ..
>>
>> thoughts?
>
> I like it. Disambiguating but also
On Mon, 16 Sep 2024 18:19:34 GMT, Alan Bateman wrote:
>> ZipOutputStream::close() calls DeflaterOutputStream::close() will in turn
>> will call ZipOutputStream::finish()
>>
>> I could remove the above and just leave the verbiage in
>> ZipOutputStream::finish(), I only added it to close as I di
On Fri, 13 Sep 2024 18:39:42 GMT, Naoto Sato wrote:
>> Yet another preparation for upgrading the time zone data to 2024b, which
>> introduced a new abbreviation format "%z". The update includes:
>> ...
>> The main source files' time zone abbreviations now use %z,
>> supported by zic
On Mon, 16 Sep 2024 17:59:11 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update @link ->@linkplain
>
> src/java.base/share/classes/java/util/zip/ZipEntry.java line 44:
>
>> 42: * entry com
On Fri, 13 Sep 2024 23:10:19 GMT, Sandhya Viswanathan
wrote:
>> Hi Joe (@jddarcy),
>>
>> As suggested by Sandhya (@sviswa7), I added ~750 fixed point tests for tanh
>> in `TanhTests.java` using the quad precision tanh implementation in
>> libquadmath library from gcc.
>>
>> Please let me kn
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.tanh() using libm
>
> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
> -- | -- | -- | --
> MathBench.tanhDouble | 70900 | 95618 | 1.35x
Srinivas Vamsi Parasa has updated the pull request with a new target b
On Mon, 16 Sep 2024 18:12:32 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 409:
>>
>>> 407: * A ZipException will be thrown if the combined length of the
>>> entry name,
>>> 408: * the extra field data, the entry comment and {@linkpl
On Mon, 16 Sep 2024 18:00:48 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update @link ->@linkplain
>
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 409:
>
>> 407:
On Sun, 15 Sep 2024 13:11:26 GMT, Lance Andersen wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the j
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.tanh() using libm
>
> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
> -- | -- | -- | --
> MathBench.tanhDouble | 70900 | 95618 | 1.35x
Srinivas Vamsi Parasa has updated the pull request incrementally with
…nge while creating a jlink image
-
Commit messages:
- 8321413: IllegalArgumentException: Code length outside the allowed range
while creating a jlink image
Changes: https://git.openjdk.org/jdk/pull/21022/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21022&range=00
Iss
On Mon, 16 Sep 2024 17:16:41 GMT, Brian Burkhalter wrote:
>> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
>> `isHidden` behave when the `File` represents a symbolic link.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit si
On Fri, 13 Sep 2024 16:41:40 GMT, Justin Lu wrote:
>> Please review this PR which restores the correct exception message when the
>> current working directory can not be found during java startup in
>> `initPhase1`.
>>
>> Both MacOS and Linux are expected to fail with `java.lang.Error: Propert
On Fri, 13 Sep 2024 16:41:40 GMT, Justin Lu wrote:
>> Please review this PR which restores the correct exception message when the
>> current working directory can not be found during java startup in
>> `initPhase1`.
>>
>> Both MacOS and Linux are expected to fail with `java.lang.Error: Propert
On Thu, 12 Sep 2024 21:56:10 GMT, Justin Lu wrote:
> Please review this PR which restores the correct exception message when the
> current working directory can not be found during java startup in
> `initPhase1`.
>
> Both MacOS and Linux are expected to fail with `java.lang.Error: Properties
> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
> `isHidden` behave when the `File` represents a symbolic link.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8339574: Address reviewer comments on FOS
On Sat, 14 Sep 2024 09:20:25 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Do not add all links
>
> src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.java
> line 270:
>
>> 268:
On Sat, 14 Sep 2024 08:40:44 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Fri, 13 Sep 2024 19:45:11 GMT, Paul Sandoz wrote:
>>> Given `rearrange` with 1 vector gets wrapping indices semantics. I think we
>>> should stop normalizing indices when converting a `Vector` into a
>>> `VectorShuffle` (currently we wrap all out-of-bound elements to `[-VLEN,
>>> 0)`). Then
On Fri, 13 Sep 2024 22:30:36 GMT, Sandhya Viswanathan
wrote:
>> Currently the rearrange and selectFrom APIs check shuffle indices and throw
>> IndexOutOfBoundsException if there is any exceptional source index in the
>> shuffle. This causes the generated code to be less optimal. This PR modifi
On Fri, 13 Sep 2024 22:36:45 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.tanh() using libm
>>
>> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
>> -- | -- | -- | --
>> MathBench.tanhDouble | 70900 | 95618 | 1.35x
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
On Mon, 16 Sep 2024 14:23:52 GMT, Shaojin Wen wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggestion
> PR #20772 introduced an optimization for writeUTF, which can also be used in
> DataOutputStream::writeUTF.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
suggestion from @liach
-
Changes:
- all: https://git.openjdk.
On Fri, 13 Sep 2024 15:40:46 GMT, Claes Redestad wrote:
> Simple internal refactor to load a few classes less on startup. Arguably
> cleaner and avoids some iterator allocations.
This pull request has now been integrated.
Changeset: e1ebeef0
Author:Claes Redestad
URL:
https://git.o
On Mon, 16 Sep 2024 13:50:39 GMT, Jaikiran Pai wrote:
> For macosx, the CreateExecutionEnvironment unconditionally, through an
> internal MacOSXStartup function, spawns a new thread (pthread_create).
I forgot to note that, the reason for spawning this new thread is explained as
a code comment
On Mon, 16 Sep 2024 07:58:44 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 01:06:27 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment improvements
>
> src/java.base/macosx/native/libjli/java_md_macosx.m line 83:
>
>> 81: *point of creating
> Can I please get a review of this change which proposes to remove the
> (internal) `SelectVersion()` function from the java launcher and also update
> the code comments in the launcher to match the current implementation?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340114, the
> `Sel
On Sat, 14 Sep 2024 02:45:47 GMT, Shaojin Wen wrote:
>> This is a large method. By splitting it into multiple methods with the same
>> name, the caller can automatically select based on the different types of
>> parameters, avoiding this large call that cannot be inlined, which can also
>> imp
On Sat, 14 Sep 2024 02:45:47 GMT, Shaojin Wen wrote:
>> This is a large method. By splitting it into multiple methods with the same
>> name, the caller can automatically select based on the different types of
>> parameters, avoiding this large call that cannot be inlined, which can also
>> imp
On Mon, 16 Sep 2024 12:56:14 GMT, David M. Lloyd wrote:
> Please review this small change to fix a misspelling. The constant is not
> used directly; rather it is used by ordinal, which explains why the error was
> not found sooner.
Thanks for the fix! You can transition the CSR issue state to
On Mon, 16 Sep 2024 07:58:44 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 13 Sep 2024 17:38:56 GMT, Shaojin Wen wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - rename JD
On Mon, 16 Sep 2024 07:58:44 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 12:56:14 GMT, David M. Lloyd wrote:
> Please review this small change to fix a misspelling. The constant is not
> used directly; rather it is used by ordinal, which explains why the error was
> not found sooner.
Thanks for this typo fix. Since this will result in a signatur
Please review this small change to fix a misspelling. The constant is not used
directly; rather it is used by ordinal, which explains why the error was not
found sooner.
-
Commit messages:
- 8340200: Misspelled constant
`AttributesProcessingOption.DROP_UNSTABLE_ATRIBUTES`
Changes
On Mon, 16 Sep 2024 11:19:36 GMT, Lance Andersen wrote:
> I left that intentionally for now. A follow on PR will be updating the
> ZipEntry javadoc to reduce the max size of the validation check once this PR
> is finalized.
Hang on, not sure I follow. Perhaps I just didn't understand your resp
On Mon, 16 Sep 2024 06:16:56 GMT, Jaikiran Pai wrote:
>> src/java.base/share/native/libjli/java.c line 38:
>>
>>> 36: * One job of the launcher is to remove command line options which the
>>> 37: * vm does not understand and will not process. These options include
>>> 38: * options which sele
On Mon, 16 Sep 2024 11:31:11 GMT, Lance Andersen wrote:
> > The combined length, after encoding, of the ..
>
> thoughts?
I like it. Disambiguating but also succinct.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21003#discussion_r1761014094
> This PR suggests introducing an internal class in `java.base` to simplify the
> use of some `MethodHandles.Lookup` operations.
>
> While the utility of the methods might appear to be limited in classes with
> many static `VarHandle`/`MethodHandle` variables, it should be noted that the
> clas
On Mon, 16 Sep 2024 10:05:56 GMT, Eirik Bjørsnøs wrote:
> I'm curious why the combined header length validation is being placed so
> late. In general I would assume failing fast is better?
>
> Also, since the combined header length clause applies to "any directory
> record", it also applies to
On Mon, 16 Sep 2024 09:36:49 GMT, Eirik Bjørsnøs wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update @link ->@linkplain
>
> src/java.base/share/classes/java/util/zip/ZipEntry.java line 41:
>
>> 39: * This cl
On Sun, 15 Sep 2024 13:11:26 GMT, Lance Andersen wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the j
> Can I please get a review of this change which proposes to remove the
> (internal) `SelectVersion()` function from the java launcher and also update
> the code comments in the launcher to match the current implementation?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340114, the
> `Sel
On Mon, 16 Sep 2024 10:11:58 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
On Fri, 13 Sep 2024 07:50:49 GMT, Per Minborg wrote:
>> This PR suggests introducing an internal class in `java.base` to simplify
>> the use of some `MethodHandles.Lookup` operations.
>>
>> While the utility of the methods might appear to be limited in classes with
>> many static `VarHandle`/`
On Mon, 16 Sep 2024 08:49:52 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove the
>> (internal) `SelectVersion()` function from the java launcher and also update
>> the code comments in the launcher to match the current implementation?
>>
>> As note
On Sun, 15 Sep 2024 13:11:26 GMT, Lance Andersen wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the j
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull re
On Sun, 15 Sep 2024 13:11:26 GMT, Lance Andersen wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the j
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull re
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
Can I please get a review of this test-only change which replaces the usage of
`-noclassgc` with `-Xnoclassgc` option when launching the test?
As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is an
undocumented option of the `java` launcher, which it converts to `-Xnocla
On Sun, 15 Sep 2024 13:11:26 GMT, Lance Andersen wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the j
> Can I please get a review of this change which proposes to remove the
> (internal) `SelectVersion()` function from the java launcher and also update
> the code comments in the launcher to match the current implementation?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340114, the
> `Sel
On Wed, 11 Sep 2024 09:47:24 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupport
On Mon, 16 Sep 2024 04:44:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which cleans up the `java`
>> launcher to remove checks/support for outdated options?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options
>> have been outdated and unsu
1 - 100 of 107 matches
Mail list logo
