On Thu, 12 Sep 2024 06:39:59 GMT, David Holmes wrote:
> Aside: we do an awful lot of Java code execution in the launcher these days
> before we even get to load the real main class. I have to wonder how all this
> affects startup?
In addition to regular regression testing, I also ran existing
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Wed, 11 Sep 2024 09:47:24 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupport
On Thu, 12 Sep 2024 02:10:00 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> This was being done in the C code to support a long outdated "JRE selection"
> feature (mJRE https://bugs.openjdk.org/browse/JDK-8058407) which required it
> to parse the jar's manifest.
I would like to note here that the mJRE feature is
Can I please get a review of this change which cleans up the code in the `java`
launcher? The original motivation for the change was to prevent the `java`
launcher's C code from parsing a jar's manifest when launching an application
through `java -jar foo.jar`. The jar parsing code in C currentl
This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java` on
s390x. This change should be reverted while fixing
[JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216).
-
Commit messages:
- problemlisted
Changes: https://git.openjdk.org/jdk/pull/20960/files
On Wed, 11 Sep 2024 19:22:00 GMT, Brian Burkhalter wrote:
>> src/java.base/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java line
>> 1097:
>>
>>> 1095:
>>> 1096: static {
>>> 1097: jdk.internal.loader.BootLoader.loadLibrary("net");
>>
>> ...do we still need net here?
>
> We
On Wed, 11 Sep 2024 16:51:43 GMT, Daniel Jeliński wrote:
>> Yes, it still needs to be called in a few places, e.g., for classes whose
>> native component needs the `fdval()` and `handleval()` functions.
>
> that's a good point. The comment might need to be updated to reflect that.
Comments adde
On Wed, 11 Sep 2024 19:31:02 GMT, Brian Burkhalter wrote:
>> Just to be absolutely clear: All my other comments about removing unneeded
>> libraries were about libnio, not libjava. I realize I made the comment in
>> the PR next to libjava, but my intention was to ask if the list of libraries
>
On Tue, 10 Sep 2024 13:26:58 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/Lib.gmk line 81:
>>
>>> 79: libjava/nio/ch \
>>> 80: libnio/ch \
>>> 81: libnio/fs \
>>
>> libnio/fs is gone on all platforms other than aix; is this still necessary?
>
> We can't add e
On Tue, 10 Sep 2024 09:54:56 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337143: Remove loading libnet from Inet6AddressImpl; delete commented out
>> #include in Windows IOUtil.c
>
>
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Tue, 10 Sep 2024 09:46:14 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which replaces the usages of
> `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
> outdat
On Wed, 11 Sep 2024 09:47:24 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupport
Some type descriptors are validated against generic utf8 entries, such as field
or method types; we can cache a type descriptor wrapping the content of the
utf8 entry if this entry is ever used as a type descriptor.
This patch is more of a code cleanup; it is performance neutral.
-
On Mon, 2 Sep 2024 12:27:21 GMT, Alan Bateman wrote:
> This PR proposes changes to the ModuleBootstrap code that is used with CDS
> (Ahead-of-Time Class Loading & Linking in the future). At things stand, the
> module graph and boot layer can be archived at dump time (-Xshare:dump) when
> the i
On Mon, 9 Sep 2024 20:40:22 GMT, Viktor Klang wrote:
> This PR applies @AlanBateman's patch from the JBS issue.
This pull request has now been integrated.
Changeset: b0cff6b5
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/b0cff6b528af7a2de453dd05d1c9ecbe7e00dc20
Stats:
On Wed, 11 Sep 2024 19:18:18 GMT, Brian Burkhalter wrote:
>> did you remove mswsock from libjava or from libnio? Libnio libraries are
>> listed
>> [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89).
>> There's no FileDispatche
On Wed, 11 Sep 2024 19:28:39 GMT, Magnus Ihse Bursie wrote:
>> Apparently I did remove it from libjava and not libnio. It will be fixed in
>> the next commit. Thanks for being persistent.
>
> Just to be absolutely clear: All my other comments about removing unneeded
> libraries were about libni
On Tue, 10 Sep 2024 19:45:01 GMT, Naoto Sato wrote:
> This is a follow on fix to
> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
> Same fix, i.e, replacing `startsWith()` with `regionMatch
On Wed, 11 Sep 2024 18:33:59 GMT, Sean Coffey wrote:
> maybe you can verify with a few simple edits to a tzdata file and building
Yes, that is exactly what I did for this testing.
-
PR Comment: https://git.openjdk.org/jdk/pull/20940#issuecomment-2344538481
On Tue, 10 Sep 2024 11:27:05 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337143: Remove loading libnet from Inet6AddressImpl; delete commented out
>> #include in Windows IOUtil.c
>
>
On Tue, 10 Sep 2024 23:24:25 GMT, Chen Liang wrote:
> A micro-optimization by sharing compatible String objects from MethodType
> (which itself is already deduplicated in a cache) to the generated
> MethodTypeDesc. This very slightly improves hashing performance by avoiding
> some string creat
On Wed, 11 Sep 2024 16:48:24 GMT, Daniel Jeliński wrote:
>> From a clean build in the CI with `mswsock.lib` removed:
>>
>>
>> [2024-09-11T16:00:17,816Z] FileDispatcherImpl.obj : error LNK2019:
>> unresolved external symbol
>> TransmitFile referenced in function
>> Java_sun_nio_ch_FileDispatch
On Mon, 2 Sep 2024 12:27:21 GMT, Alan Bateman wrote:
> This PR proposes changes to the ModuleBootstrap code that is used with CDS
> (Ahead-of-Time Class Loading & Linking in the future). At things stand, the
> module graph and boot layer can be archived at dump time (-Xshare:dump) when
> the i
On Mon, 2 Sep 2024 12:27:21 GMT, Alan Bateman wrote:
> This PR proposes changes to the ModuleBootstrap code that is used with CDS
> (Ahead-of-Time Class Loading & Linking in the future). At things stand, the
> module graph and boot layer can be archived at dump time (-Xshare:dump) when
> the i
On Fri, 6 Sep 2024 19:57:41 GMT, Brent Christian wrote:
> From the bug description:
> ForceGC would be improved by moving the Reference.reachabilityFence() calls
> for 'obj' and 'ref'.
>
> Reference.reachabilityFence(obj) is currently placed after 'obj' has been set
> to null, so effectively d
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Wed, 11 Sep 2024 17:21:36 GMT, Sandhya Viswanathan
wrote:
>> So far, this will be the only intrinsic implementation of tanh. Therefore,
>> at the moment it is just checking the consistency of the intrinsic
>> implementation with StrictMath/FDLIBM tanh. If the intrinsic has a ~1 ulp
>> accu
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Wed, 11 Sep 2024 01:59:54 GMT, Joe Darcy wrote:
>>> If the test is going to use randomness, then its jtreg tags should include
>>>
>>> `@key randomness`
>>>
>>> and it is preferable to use jdk.test.lib.RandomFactory to get and Random
>>> object since that handles printing out a key so the r
On Mon, 3 Jun 2024 17:28:09 GMT, Severin Gehwolf wrote:
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroup
On Tue, 10 Sep 2024 19:58:45 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/sun/nio/ch/IOUtil.java line 575:
>>
>>> 573: * Used to trigger loading of native libraries
>>> 574: */
>>> 575: public static void load() { }
>>
>> do we still need this method?
>
> Yes, it st
On Wed, 11 Sep 2024 16:33:28 GMT, Brian Burkhalter wrote:
>> Right. This PR moves FileDispatcherImpl.c to libjava, so
>> FileDispatcherImpl.obj is no longer there. I'm guessing that our makefiles
>> don't detect source files that were removed, and Brian didn't run `make
>> clean`.
>
> From a c
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Wed, 11 Sep 2024 06:00:23 GMT, Daniel Jeliński wrote:
>> And you did not get `mswsock.lib: FileDispatcherImpl.obj : error LNK2019:
>> unresolved external symbol TransmitFile`?
>
> Right. This PR moves FileDispatcherImpl.c to libjava, so
> FileDispatcherImpl.obj is no longer there. I'm guessi
On Tue, 10 Sep 2024 19:01:54 GMT, Mark Sheppard wrote:
>> I agree that we don't want to document too much here. Updated the factor to
>> 1.75 (2 seems a bit high and might hide real issues), and to make the
>> timeout value calculation and check less arcane - I have updated test output
>> to p
On Wed, 11 Sep 2024 15:22:43 GMT, Aleksei Efimov wrote:
>> This PR proposes the following changes to address wrong timeout computations
>> in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
>> clock. The existing `Timeout` test h
On Wed, 11 Sep 2024 15:13:25 GMT, Sean Coffey wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> LGTM
>
> `sun/util/calendar/zi/TestZoneInfo310.java` exe
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Tue, 10 Sep 2024 19:01:54 GMT, Mark Sheppard wrote:
>> I agree that we don't want to document too much here. Updated the factor to
>> 1.75 (2 seems a bit high and might hide real issues), and to make the
>> timeout value calculation and check less arcane - I have updated test output
>> to p
> This implementation of MutableBigInteger.leftShift(int) optimizes the current
> version, avoiding unnecessary copy of the MutableBigInteger's value content
> and performing the primitive shifting only in the original portion of the
> value array rather than in the value yet extended with trail
On Wed, 11 Sep 2024 12:44:54 GMT, fabioromano1 wrote:
>> test/jdk/java/math/BigInteger/MutableBigIntegerShiftTests.java line 153:
>>
>>> 151:
>>> 152: return result;
>>> 153: }
>>
>> I think this is getting too complex for a test, there's a risk that it is
>> incorrect...
>>
>> I
On Wed, 11 Sep 2024 14:23:40 GMT, fabioromano1 wrote:
>> This implementation of MutableBigInteger.leftShift(int) optimizes the
>> current version, avoiding unnecessary copy of the MutableBigInteger's value
>> content and performing the primitive shifting only in the original portion
>> of the
> This PR proposes the following changes to address wrong timeout computations
> in the `com.sun.jndi.dns.DnsClient`:
> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
> clock. The existing `Timeout` test has also been updated to use the nano
> clock to measure obser
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
> This implementation of MutableBigInteger.leftShift(int) optimizes the current
> version, avoiding unnecessary copy of the MutableBigInteger's value content
> and performing the primitive shifting only in the original portion of the
> value array rather than in the value yet extended with trail
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and cgroups v2 (since
> [JDK-8322420](https://bugs.o
On Thu, 5 Sep 2024 17:58:11 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix errors in a benchmark
>
> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java
> line
On Fri, 6 Sep 2024 15:11:19 GMT, Brett Okken wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix errors in a benchmark
>
> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java
> line 244:
>
On Thu, 5 Sep 2024 17:51:35 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix errors in a benchmark
>
> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java
> line
On Wed, 11 Sep 2024 12:45:50 GMT, Raffaello Giulietti
wrote:
> `Math.scalb(double)` can be simplified, removing a loop and using
> larger/smaller factors.
The proposed implementation is even about 1.5x faster, but that's not the point
of this PR.
The point is to have simpler logic.
Similar lo
`Math.scalb(double)` can be simplified, removing a loop and using
larger/smaller factors.
-
Commit messages:
- 8339934: Simplify Math.scalb(double) method
Changes: https://git.openjdk.org/jdk/pull/20948/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20948&range=00
Issue
On Wed, 11 Sep 2024 11:48:36 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'patchLeftShift' of https://github.com/fabioromano1/jdk into
>> patchLeftShift
>> - Removed re
On Wed, 11 Sep 2024 11:42:19 GMT, Viktor Klang wrote:
>> This PR applies @AlanBateman's patch from the JBS issue.
>
> Viktor Klang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous co
On Sat, 7 Sep 2024 20:39:39 GMT, fabioromano1 wrote:
>> This implementation of MutableBigInteger.leftShift(int) optimizes the
>> current version, avoiding unnecessary copy of the MutableBigInteger's value
>> content and performing the primitive shifting only in the original portion
>> of the v
On Wed, 11 Sep 2024 07:00:25 GMT, Alan Bateman wrote:
>> If these are just methods that might be seen in a stackdump then we still
>> need `ThreadSleepEvent.isEnabled` and `ThreadSleepEvent.`.
>
>> If these are just methods that might be seen in a stackdump then we still
>> need `ThreadSleepEve
> This PR applies @AlanBateman's patch from the JBS issue.
Viktor Klang has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since
On Wed, 11 Sep 2024 09:47:24 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupport
On Mon, 9 Sep 2024 12:57:17 GMT, Maurizio Cimadamore
wrote:
> The new test added by https://github.com/openjdk/jdk/pull/20854 fails
> spuriously.
> While JNI lookup is now moved into the static initializer of the
> `MappedMemoryUtils` class, this class might only get initialized while in the
On Wed, 11 Sep 2024 09:47:24 GMT, Jaikiran Pai wrote:
> Would this change require a CSR?
and probably a release note too.
-
PR Comment: https://git.openjdk.org/jdk/pull/20945#issuecomment-2343274428
On Wed, 11 Sep 2024 08:34:09 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 681:
>>
>>> 679:
>>> 680: e.flag = CENFLG(cen, pos);
>>> 681: e.method = CENHOW(cen, pos);
>>
>> Not reading `nlen` when it's not needed is a good change, and
Can I please get a review for this change which cleans up the `java` launcher
to remove checks/support for outdated options?
As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
been outdated and unsupported for several releases now. 2 of them even throw an
error curren
On Tue, 10 Sep 2024 18:41:41 GMT, Aleksei Efimov wrote:
>> This PR proposes the following changes to address wrong timeout computations
>> in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
>> clock. The existing `Timeout` test h
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Wed, 11 Sep 2024 09:03:58 GMT, Alexey Ivanov wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update JImageToolTest too
>
> test/jdk/java/beans/Introspector/Test5102804.java line 28:
>
>> 26: * @bug 5102804
>>
> Can I please get a review of this trivial change which replaces the usages of
> `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
> outdated and support for them will soon be deprecated and remo
On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Thu, 15 Aug 2024 20:28:28 GMT, Dhamoder Nalla wrote:
>> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
>> across the OpenJDK repository to retrieve the temporary directory path, as
>> GetTempPath2 provides enhanced security. While GetTempPath may still
>> function
On Tue, 10 Sep 2024 19:39:34 GMT, Claes Redestad wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 681:
>
>> 679:
On Tue, 10 Sep 2024 19:39:24 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 161:
>
>> 159:
On Tue, 10 Sep 2024 19:57:56 GMT, Claes Redestad wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 549:
>
>> 547:
On Tue, 10 Sep 2024 19:34:11 GMT, Claes Redestad wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 161:
>
>> 159:
On Tue, 10 Sep 2024 19:30:52 GMT, Lance Andersen wrote:
> If this does not make a huge performance difference, I would keep this
> together with the init of elen and clen on line 692.
I verified this does not cause a regression, so moved the `nlen` read up on the
common path.
See also my comm
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
On Tue, 10 Sep 2024 21:47:15 GMT, Magnus Ihse Bursie wrote:
> sort out the mess that is libawt_headless/libawt_xawt
sounds good. can you point me to a JBS?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20666#discussion_r1753307449
On Wed, 11 Sep 2024 06:18:25 GMT, David Holmes wrote:
> If these are just methods that might be seen in a stackdump then we still
> need `ThreadSleepEvent.isEnabled` and `ThreadSleepEvent.`.
I think minimal here is to just drop isTurnedOn from lists in these tests. From
what I can tell, the te
86 matches
Mail list logo
