> Some ad-hoc lambdas and classes for functional calls to ClassFile API in
> early bootstrap can be replaced with a few fixed factories. This allows some
> methods to be used at early bootstrap with less class loading costs.
>
> Depends on #20627, as this adds another fix to one of the fixes the
On Mon, 19 Aug 2024 15:08:05 GMT, Chen Liang wrote:
> In #20611 and other investigations, we noted that
> `MethodTypeDesc.ofDescriptor` is unnecessarily called due to missing caching
> in ClassBuilder. This patch adds that missing caching functionality.
This pull request has now been integrate
On Mon, 19 Aug 2024 15:08:05 GMT, Chen Liang wrote:
> In #20611 and other investigations, we noted that
> `MethodTypeDesc.ofDescriptor` is unnecessarily called due to missing caching
> in ClassBuilder. This patch adds that missing caching functionality.
Thanks for the review. Integrating to fa
StackCounter was adding return type slots before deducting receiver slot, so
code like
int b() { return this.hashCode(); }
will be counted as having a max stack of 2. Avoid this problem by only calling
`addStackSlot` once for each instruction.
-
Commit messages:
- 8338623: StackC
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote:
>> Move fields common to Method and Field to executable, which simplifies
>> implementation. Removed useless transient modifiers as Method and Field were
>> never serializable.
>>
>> Note to core-libs reviewers: Please review the associated C
On Tue, 16 Jul 2024 18:02:57 GMT, Chen Liang wrote:
> In annotated types, local and inner class types should be annotated as
> "top-level" types. For example, in the test here
>
> public static Class getLocalsMember() {
> class Local {
> class Member {
>
On Tue, 16 Jul 2024 18:02:57 GMT, Chen Liang wrote:
> In annotated types, local and inner class types should be annotated as
> "top-level" types. For example, in the test here
>
> public static Class getLocalsMember() {
> class Local {
> class Member {
>
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote:
>> Move fields common to Method and Field to executable, which simplifies
>> implementation. Removed useless transient modifiers as Method and Field were
>> never serializable.
>>
>> Note to core-libs reviewers: Please review the associated C
On Mon, 19 Aug 2024 23:14:06 GMT, Shaojin Wen wrote:
>> The current implementation of ofDescriptor puts return type and parameter
>> types together in an ArrayList, and then splits them into return type and
>> array of parameter types. This ArrayList creation is unnecessary,
>> considering mos
> The current implementation of ofDescriptor puts return type and parameter
> types together in an ArrayList, and then splits them into return type and
> array of parameter types. This ArrayList creation is unnecessary, considering
> most descriptors only have few parameter types.
>
> By splitt
On Mon, 19 Aug 2024 07:36:15 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
Clean up annotation writing in classfile api: remove the redundant
`Util.Writable` interfaces.
-
Commit messages:
- 8336756: Improve ClassFile Annotation writing
Changes: https://git.openjdk.org/jdk/pull/20635/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20635&range=00
On Fri, 16 Aug 2024 08:53:38 GMT, Shaojin Wen wrote:
> The current implementation of ofDescriptor puts return type and parameter
> types together in an ArrayList, and then splits them into return type and
> array of parameter types. This ArrayList creation is unnecessary, considering
> most de
The `java.lang.module` package specification defines the default set of root
modules as “every module that is observable on the upgrade module path or among
the system modules, and that exports at least one package without
qualification.” There’s no need to use the term “observable” here, since
August 15, 2024 at 1:27 PM, "Viktor Klang" wrote:
>
> Hi Anthony,
Hi Viktor
> Thanks for the input—it's much appreciated!
>
> Introducing yet another, user-facing, type parameter to get slightly improved
> type inference is unfortunately for me a too high of a price to pay. Ideally,
> type i
On Mon, 19 Aug 2024 14:43:44 GMT, Chen Liang wrote:
>> I added two startup process descStrings to the benchmark, and now optimized
>> the parameter type of `Ljava/lang/Object` as follows:
>>
>> ## 1. Benchmark script
>>
>> git remote add wenshao g...@github.com:wenshao/jdk.git
>> git fetch wen
Hi,
Can you help to review this simple patch?
Currently, lineSize linesize for MIME case in macro bench test Base64Decode is
only "4", but in Base64.Encoder default linesize for MIME encoder is 76.
It's helpful to add more linesize, e.g. 76 and so on.
Thanks!
-
Commit messages:
-
Some ad-hoc lambdas and classes for functional calls to ClassFile API in early
bootstrap can be replaced with a few fixed factories. This allows some methods
to be used at early bootstrap with less class loading costs.
Depends on #20627, as this adds another fix to one of the fixes there on
`Cl
The `ClassLoadingMXBean` and `MemoryMXBean` APIs have `setVerbose` methods to
control verbose mode and `isVerbose` methods to query it. Some JCK tests expect
`setVerbose(false)` to disable verbose mode and, subsequently, `isVerbose()` to
return false. However, if logging to a file is enabled by
On Mon, 19 Aug 2024 15:08:05 GMT, Chen Liang wrote:
> In #20611 and other investigations, we noted that
> `MethodTypeDesc.ofDescriptor` is unnecessarily called due to missing caching
> in ClassBuilder. This patch adds that missing caching functionality.
I tested by adding a `System.out.println
On Mon, 19 Aug 2024 15:08:05 GMT, Chen Liang wrote:
> In #20611 and other investigations, we noted that
> `MethodTypeDesc.ofDescriptor` is unnecessarily called due to missing caching
> in ClassBuilder. This patch adds that missing caching functionality.
Looks good to me, do you have any benchm
In #20611 and other investigations, we noted that `MethodTypeDesc.ofDescriptor`
is unnecessarily called due to missing caching in ClassBuilder. This patch adds
that missing caching functionality.
-
Commit messages:
- 8338543: ClassBuilder withMethod builders should cache the method
On Sun, 18 Aug 2024 23:40:24 GMT, Shaojin Wen wrote:
>> The current implementation of ofDescriptor puts return type and parameter
>> types together in an ArrayList, and then splits them into return type and
>> array of parameter types. This ArrayList creation is unnecessary,
>> considering mos
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote:
> The Exchanger class uses spin-waits that are hostile to some uses of
> VirtualThreads. Improving this requires a means of estimating whether there
> are many VirtualThreads with few carriers, which can be supported by adding a
> method in cla
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote:
> This is a test-only addition to add a test for virtual threads invoking a
> synchronized native method and invoking a native method that enter/exits a
> monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo
> for so
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote:
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> di
On Mon, 19 Aug 2024 08:54:24 GMT, Adam Sotona wrote:
> Method
> `jdk.internal.classfile.impl.AbstractPoolEntry.AbstractNamedEntry::equals`
> implementation is invalid.
> Fortunately it is overridden with valid implementation in all its sub types
> and it can be removed.
>
> This patch removes
On Mon, 19 Aug 2024 08:54:24 GMT, Adam Sotona wrote:
> Method
> `jdk.internal.classfile.impl.AbstractPoolEntry.AbstractNamedEntry::equals`
> implementation is invalid.
> Fortunately it is overridden with valid implementation in all its sub types
> and it can be removed.
>
> This patch removes
On Thu, 28 Dec 2023 12:55:22 GMT, Jan Kratochvil
wrote:
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/17198
On Mon, 19 Aug 2024 08:12:25 GMT, Jan Kratochvil
wrote:
> As we cannot find an agreement even on the comment in the testcase and this
> pull request will have soon an anniversary, proposing:
>
> * check-in the fix from a separate pull request as it is whole your fix
> anyway
> * I wil
On Mon, 19 Aug 2024 06:39:26 GMT, Shaojin Wen wrote:
>> I think you can add a case where the parameters are all these vulnerable
>> names like `Ljava/lang/Objecq;` and repeat 8 times, and see how big a
>> negative impact these close mismatches have.
>
> The scenario of `Ljava/lang/Objecq` does
Method
`jdk.internal.classfile.impl.AbstractPoolEntry.AbstractNamedEntry::equals`
implementation is invalid.
Fortunately it is overridden with valid implementation in all its sub types and
it can be removed.
This patch removes the obsolete an invalid method implementation.
Please review.
Than
On Fri, 19 Jul 2024 15:52:14 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
On Sat, 17 Aug 2024 05:29:31 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 12
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new two vector permutation APIs.
>
>
> Declaration:-
> Vector.selectFrom(Vector v1, Vector v2)
>
>
> Semantics:-
> Using index values stored in the lanes of "this" vector, assembl
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
36 matches
Mail list logo
