Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v21]

2024-08-16 Thread Jan Kratochvil
> The testcase requires root permissions. > > Fix by Severin Gehwolf. > Testcase by Jan Kratochvil. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - Functionality fixes after the refactorization - Fix u

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v20]

2024-08-16 Thread Jan Kratochvil
On Wed, 14 Aug 2024 15:55:53 GMT, Severin Gehwolf wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Testcase update upon review by Severin Gehwolf > > test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 139

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v19]

2024-08-16 Thread Jan Kratochvil
On Mon, 12 Aug 2024 18:36:51 GMT, Severin Gehwolf wrote: >> Jan Kratochvil has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Inline adjust_controller() twice >> - Revert "Unify 4 copies of adjust_controller()" >> >>This reverts

Re: RFR: 8338023: Support two vector selectFrom API

2024-08-16 Thread John Rose
(Better late than never, although I wish I’d been more explicit about this on panama-dev.) I think we should be moving away from throwing exceptions on all reorder/shuffle/permute vector ops, and moving toward wrapping. These ops all operate on vectors (small arrays) of vector lane indexes (small

Integrated: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation

2024-08-16 Thread Chen Liang
On Fri, 19 Jul 2024 01:55:57 GMT, Chen Liang wrote: > `TypeAnnotation` is not an annotation, as it should not be used in places > like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an > annotation at a given location instead of to be an annotation. > > Depends on #20205. This

Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v11]

2024-08-16 Thread Chen Liang
On Fri, 16 Aug 2024 15:28:03 GMT, Chen Liang wrote: >> `TypeAnnotation` is not an annotation, as it should not be used in places >> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an >> annotation at a given location instead of to be an annotation. >> >> Depends on #20205.

Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v11]

2024-08-16 Thread Adam Sotona
On Fri, 16 Aug 2024 15:28:03 GMT, Chen Liang wrote: >> `TypeAnnotation` is not an annotation, as it should not be used in places >> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an >> annotation at a given location instead of to be an annotation. >> >> Depends on #20205.

Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v10]

2024-08-16 Thread Chen Liang
On Tue, 13 Aug 2024 19:56:22 GMT, Chen Liang wrote: >> `TypeAnnotation` is not an annotation, as it should not be used in places >> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an >> annotation at a given location instead of to be an annotation. >> >> Depends on #20205.

Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v11]

2024-08-16 Thread Chen Liang
> `TypeAnnotation` is not an annotation, as it should not be used in places > like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an > annotation at a given location instead of to be an annotation. > > Depends on #20205. Chen Liang has updated the pull request with a new target

Integrated: 8338398: Trivially fix grammar and typos

2024-08-16 Thread Pavel Rappo
On Wed, 14 Aug 2024 13:38:34 GMT, Pavel Rappo wrote: > This PR fixes a few trivial grammar issues and typos in documentation. > > The main issue is the use of the word "timeout". To my mind, timeout, a > duration, is not the same as deadline, which is a point in time, an instant, > which allow

Re: RFR: 8336856: Efficient hidden class-based string concatenation strategy [v55]

2024-08-16 Thread Shaojin Wen
On Tue, 13 Aug 2024 16:34:18 GMT, Shaojin Wen wrote: >> The current strategy for bootstrapping JEP 280 String concat expressions >> uses either an optimized MH expression tree, or, due to scalability issues >> with that implementation, a per call-site StringBuilder-based class >> generation sc

Integrated: 8336856: Efficient hidden class-based string concatenation strategy

2024-08-16 Thread Shaojin Wen
On Sun, 21 Jul 2024 12:25:36 GMT, Shaojin Wen wrote: > The current strategy for bootstrapping JEP 280 String concat expressions uses > either an optimized MH expression tree, or, due to scalability issues with > that implementation, a per call-site StringBuilder-based class generation > scheme

Re: RFR: 8336856: Efficient hidden class-based string concatenation strategy [v55]

2024-08-16 Thread Claes Redestad
On Fri, 16 Aug 2024 13:17:04 GMT, Chen Liang wrote: > Should we add a release note for this huge feature? I think it would be reasonable to add something, yes. - PR Comment: https://git.openjdk.org/jdk/pull/20273#issuecomment-2293498875

Re: RFR: 8336856: Efficient hidden class-based string concatenation strategy [v55]

2024-08-16 Thread Chen Liang
On Tue, 13 Aug 2024 16:34:18 GMT, Shaojin Wen wrote: >> The current strategy for bootstrapping JEP 280 String concat expressions >> uses either an optimized MH expression tree, or, due to scalability issues >> with that implementation, a per call-site StringBuilder-based class >> generation sc

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Pavel Rappo
On Fri, 16 Aug 2024 12:10:32 GMT, Doug Lea wrote: > It would also be OK to just drop that "s" -> InterruptedException. True, but there are other similar cases in that same file, maybe it's okay to leave it like that. Similar cases: ForkJoinTasks, Futures, CountedCompleters, InterruptibleTasks,

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Doug Lea
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote: >> This PR fixes a few trivial grammar issues and typos in documentation. >> >> The main issue is the use of the word "timeout". To my mind, timeout, a >> duration, is not the same as deadline, which is a point in time, an instant, >> which

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Pavel Rappo
On Fri, 16 Aug 2024 12:15:47 GMT, Doug Lea wrote: > The overall inconsistency addressed here is that sometime "timeout" refers to > a duration, and sometimes an event. Which is pretty common, but reworking > docs to only mean duration seems reasonable. Am I correct reading your comment as an e

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Doug Lea
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote: >> This PR fixes a few trivial grammar issues and typos in documentation. >> >> The main issue is the use of the word "timeout". To my mind, timeout, a >> duration, is not the same as deadline, which is a point in time, an instant, >> which

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Doug Lea
On Thu, 15 Aug 2024 15:41:21 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 858: >> >>> 856: * usages of ForkJoinTasks ignore interrupt status when executing >>> 857: * or awaiting completion. Otherwise, reporting task results or >>>

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v20]

2024-08-16 Thread Jan Kratochvil
On Wed, 14 Aug 2024 14:56:26 GMT, Severin Gehwolf wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Testcase update upon review by Severin Gehwolf > > test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 109

Integrated: 8337839: Make a few fields in MergeCollation static

2024-08-16 Thread Andrey Turbanov
On Thu, 25 Jul 2024 08:59:17 GMT, Andrey Turbanov wrote: > 3 fields in java.text.MergeCollation could be made 'static': > 1. BITARRAYMASK > 2. BYTEPOWER > 3. BYTEMASK This pull request has now been integrated. Changeset: 60c9b5cd Author:Andrey Turbanov URL: https://git.openjdk.org/j