On Mon, 8 Jul 2024 08:18:42 GMT, Axel Boldt-Christmas
wrote:
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
>
On Thu, 15 Aug 2024 06:12:22 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Fri, 16 Aug 2024 03:27:27 GMT, Joe Darcy wrote:
>> Rafael Winterhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337302: Fix copyright years.
>
> test/jdk/java/lang/reflect/Generics/TestMissingTypeVariable.java line 43:
>
>> 4
On Tue, 13 Aug 2024 23:41:06 GMT, Rafael Winterhalter
wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has updated the pull request incrementally with one
> addition
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote:
> j.u.Formatter$FixedString can be refactored to simplify the code using Record
@wenshao
Your change (at version c7ce3c724183ad3b4a09a9fac1d7411fdd8e) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.op
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote:
> j.u.Formatter$FixedString can be refactored to simplify the code using Record
This pull request has now been integrated.
Changeset: 74066bcc
Author:Shaojin Wen
Committer: Claes Redestad
URL:
https://git.openjdk.org/jdk/commit/74
On Wed, 14 Aug 2024 11:46:31 GMT, Myp wrote:
> Fix of problem RoundingMode.HALF_UP gives different results with NumberFormat
It may look counterintuitive, but the existing behavior is the expected one.
Please see the comment I added in the JBS issue.
-
PR Comment: https://git.open
On Thu, 15 Aug 2024 22:06:14 GMT, Dhamoder Nalla wrote:
>> src/hotspot/os/windows/os_windows.cpp line 1522:
>>
>>> 1520: const char* os::get_temp_directory() {
>>> 1521: static char path_buf[MAX_PATH];
>>> 1522: if (_GetTempPath2A != nullptr) {
>>
>> Where does _GetTempPath2A get initialize
On Thu, 15 Aug 2024 18:32:29 GMT, Chris Plummer wrote:
>> Dhamoder Nalla has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix missing code
>
> src/hotspot/os/windows/os_windows.cpp line 1522:
>
>> 1520: const char* os::get_temp_directory
Fix of problem RoundingMode.HALF_UP gives different results with NumberFormat
-
Commit messages:
- 8338242: RoundingMode.HALF_UP gives different results with NumberFormat
Changes: https://git.openjdk.org/jdk/pull/20580/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20580&r
> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
> across the OpenJDK repository to retrieve the temporary directory path, as
> GetTempPath2 provides enhanced security. While GetTempPath may still function
> without errors, using GetTempPath2 reduces the risk of potenti
On Fri, 7 Jun 2024 12:12:44 GMT, Claes Redestad wrote:
> This PR refactors type matching in BootstrapMethodInvoker and adds a few
> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
> in particular the ProxyGenerator condys generated for e.g. annotation proxies
> sin
On Mon, 10 Jun 2024 10:09:38 GMT, Claes Redestad wrote:
>> This PR refactors type matching in BootstrapMethodInvoker and adds a few
>> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
>> in particular the ProxyGenerator condys generated for e.g. annotation
>> proxie
On Thu, 15 Aug 2024 16:23:18 GMT, Dhamoder Nalla wrote:
> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
> across the OpenJDK repository to retrieve the temporary directory path, as
> GetTempPath2 provides enhanced security. While GetTempPath may still function
> with
On Thu, 15 Aug 2024 06:12:22 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Wed, 14 Aug 2024 17:07:21 GMT, Chen Liang wrote:
> `BytecodeHelpers.handleConstantDescToHandleInfo` is incorrectly using
> `DirectMethodHandleDesc.invocationType`, which accidentally works for static
> bootstrap methods so it's discovered only now with more extensive testing
> from bytebudd
Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code across
the OpenJDK repository to retrieve the temporary directory path, as
GetTempPath2 provides enhanced security. While GetTempPath may still function
without errors, using GetTempPath2 reduces the risk of potential explo
On Thu, 15 Aug 2024 15:29:22 GMT, Alexey Ivanov wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix grammatical tense
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 858:
>
>> 856:
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation.
>>
>> The main issue is the use of the word "timeout". To my mind, timeout, a
>> duration, is not the same as deadline, which is a point in time, an instant,
>> which
On Wed, 14 Aug 2024 17:07:21 GMT, Chen Liang wrote:
> `BytecodeHelpers.handleConstantDescToHandleInfo` is incorrectly using
> `DirectMethodHandleDesc.invocationType`, which accidentally works for static
> bootstrap methods so it's discovered only now with more extensive testing
> from bytebudd
On Thu, 15 Aug 2024 13:45:11 GMT, Yudi Zheng wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove newline
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 677:
>
>> 675:
>> 676: // Check for
On Thu, 15 Aug 2024 14:16:11 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/StringPool.java line 86:
>>
>>> 84:
>>> 85: private static void unpinVirtualThread() {
>>> 86: if (Thread.currentThread().isVirtual() &&
>>> ContinuationSupport.isSupported()) {
>>
>
On Thu, 15 Aug 2024 12:26:38 GMT, David Holmes wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update test comment
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/StringPool.java line 86:
>
>> 84:
>> 85: pr
On Thu, 15 Aug 2024 06:12:22 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Tue, 13 Aug 2024 16:34:18 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision
On Thu, 8 Aug 2024 18:15:29 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>
> Thanks,
> Sonia
This pull request has now been integrated.
Change
On Thu, 15 Aug 2024 11:20:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
>> because migrating a carrier thread local event writer object onto another
>> carrier thread is impossible.
>>
>> During event commit, th
On Fri, 12 Jul 2024 10:12:32 GMT, Roman Kennke wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update arguments.cpp
>
> Is there a plan to get rid of the UseObjectMonitorTable flag in a future
> release? I
Hi Anthony,
Thanks for the input—it's much appreciated!
Introducing yet another, user-facing, type parameter to get slightly improved
type inference is unfortunately for me a too high of a price to pay. Ideally,
type inference/unification will be improved over time making this issue go away
wi
> Greetings,
>
> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
> because migrating a carrier thread local event writer object onto another
> carrier thread is impossible.
>
> During event commit, the thread is in a critical section because it has
> loaded a carri
On Thu, 15 Aug 2024 09:54:24 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
>> because migrating a carrier thread local event writer object onto another
>> carrier thread is impossible.
>>
>> During event commit, th
On Thu, 15 Aug 2024 09:46:04 GMT, Alan Bateman wrote:
>> Good point, thanks.
>
> Yes, it should only unpin if pin completed successfully.
Please see updated changeset.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20588#discussion_r1718203932
> Greetings,
>
> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
> because migrating a carrier thread local event writer object onto another
> carrier thread is impossible.
>
> During event commit, the thread is in a critical section because it has
> loaded a carri
On Thu, 15 Aug 2024 04:11:47 GMT, David Holmes wrote:
>> Greetings,
>>
>> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
>> because migrating a carrier thread local event writer object onto another
>> carrier thread is impossible.
>>
>> During event commit, the t
On Thu, 15 Aug 2024 09:45:20 GMT, Markus Grönlund wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/StringPool.java line 93:
>>
>>> 91: private static long storeString(String s) {
>>> 92: try {
>>> 93: pinVirtualThread();
>>
>> The pin should be outside the try so tha
On Thu, 15 Aug 2024 08:58:46 GMT, David Holmes wrote:
>> I assume you both mean I should change "elapses" to "elapsed" throughout the
>> PR, not just in that particular occurrence.
>
> No, elsewhere you don't have an existing tense to match - I only want the
> sentence to be self-consistent. Th
On Thu, 15 Aug 2024 08:24:30 GMT, Pavel Rappo wrote:
>> Use "elapsed" here to match "completed".
>
> I assume you both mean I should change "elapses" to "elapsed" throughout the
> PR, not just in that particular occurrence.
No, elsewhere you don't have an existing tense to match - I only want t
On Thu, 15 Aug 2024 04:07:19 GMT, David Holmes wrote:
>> I admit I had doubts about the sequence of tenses too. That's a pretty
>> complex sentence, and I'm a non-native English speaker. It's hard to
>> re-tense it while retaining its conditional nature.
>
> Use "elapsed" here to match "complet
> This PR fixes a few trivial grammar issues and typos in documentation.
>
> The main issue is the use of the word "timeout". To my mind, timeout, a
> duration, is not the same as deadline, which is a point in time, an instant,
> which allows "before" and "after". While one can think of timeout
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
On Thu, 15 Aug 2024 03:01:00 GMT, Jasmine Karthikeyan
wrote:
>> @jaskarth , its usage in existing patch is limited to [type
>> comparison.](https://github.com/openjdk/jdk/pull/20507/files#diff-3559dcf23b719805be5fd06fd5c1851dbd8f53e47afe6d99cba13a3de0ebc6b2R1542).
>>
>>
>> My plan is to addr
41 matches
Mail list logo
