On Tue, 13 Aug 2024 17:05:38 GMT, Daniel D. Daugherty
wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove the last OMWorld references
>> - Rename omworldtable_work to object_monitor_table_work
>
> sr
On Tue, 13 Aug 2024 16:34:17 GMT, Daniel D. Daugherty
wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove the last OMWorld references
>> - Rename omworldtable_work to object_monitor_table_work
>
> sr
On Mon, 12 Aug 2024 22:40:06 GMT, Daniel D. Daugherty
wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missing DEBUG_ONLY
>
> src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp line 632:
>
>> 630:
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SATURATING_UADD : Saturating unsigned addition.
> . SATURATING_ADD: Saturating signed addition.
> . SATURATING_USUB : Saturating unsigned
On Mon, 12 Aug 2024 18:39:46 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Inline adjust_controller() twice
>> - Revert "Unify 4 copies of adjust_controller()"
>>
>>This reverts
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Testcase update upon review by Severin Gehwolf
-
Changes:
- all: h
HI,
In addition to Liam's point, I'd like to point out:
1. The version check in jspawnhelper is for the full JDK version. This
means any future in-place JDK update could trigger this problem for
long-running applications.
2. Typical Linux package managers (e.g. apt, yum) seem to update the JDK
pa
On Tue, 13 Aug 2024 23:41:06 GMT, Rafael Winterhalter
wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has updated the pull request incrementally with one
> addition
> When a type uses a type variable without a declaration, no exception is
> thrown. This change triggers a `TypeNotFoundException` to be thrown.
Rafael Winterhalter has updated the pull request incrementally with one
additional commit since the last revision:
8337302: Fix copyright years.
--
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Tue, 13 Aug 2024 16:49:42 GMT, Daniel D. Daugherty
wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove the last OMWorld references
>> - Rename omworldtable_work to object_monitor_table_work
>
> sr
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Tue, 13 Aug 2024 14:56:32 GMT, Coleen Phillimore wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove the last OMWorld references
>> - Rename omworldtable_work to object_monitor_table_work
>
> src/h
On Mon, 15 Jul 2024 00:45:10 GMT, Axel Boldt-Christmas
wrote:
>> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 401:
>>
>>> 399:
>>> 400: if (inserted) {
>>> 401: // Hopefully the performance counters are allocated on distinct
>>
>> It doesn't look like the counters are on d
On Tue, 13 Aug 2024 14:52:03 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 12 Aug 2024 15:58:14 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Tue, 13 Aug 2024 08:02:04 GMT, Alan Bateman wrote:
> > It has been a while since I knew this code reasonably well so perhaps I
> > have just forgotten this difference between AQS and built-in monitors, but
> > it seems that a Condition.await can return by throwing an exception without
> > r
On Tue, 13 Aug 2024 14:37:32 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> Sonia Zaldana Calles has updated the pu
On Tue, 13 Aug 2024 14:37:32 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> Sonia Zaldana Calles has updated the pu
On Mon, 12 Aug 2024 18:55:47 GMT, Joe Darcy wrote:
>> Looks fine; increasing review count to also include someone who more
>> directly maintains this API.
>>
>> If you haven't done so already, I recommend also doing a quick check for an
>> analagous issue with `@jls` tags in this API.
>
>> @jd
> `TypeAnnotation` is not an annotation, as it should not be used in places
> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
> annotation at a given location instead of to be an annotation.
>
> Depends on #20205.
Chen Liang has updated the pull request incrementally with
> `TypeAnnotation` is not an annotation, as it should not be used in places
> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
> annotation at a given location instead of to be an annotation.
>
> Depends on #20205.
Chen Liang has updated the pull request with a new target
On Fri, 5 Jul 2024 19:27:27 GMT, Chen Liang wrote:
> Please review this patch that address the reflection member filtering flaws.
>
> 1. Remove a pointless bootstrap check to ensure no filter is accidentally
> bypassed due to class-loading order.
> 2. Clarify the scenarios for filtering, and th
On Mon, 12 Aug 2024 23:08:07 GMT, Rafael Winterhalter
wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has updated the pull request incrementally with one
> addition
On Tue, 13 Aug 2024 16:34:18 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision
On Wed, 19 Jun 2024 12:52:46 GMT, Alan Bateman wrote:
>> @AlanBateman -- could you please take a look? Thanks.
>
>> @AlanBateman -- could you please take a look? Thanks.
>
> There was a lot of heap analysis done a few years ago that shined a light on
> the number of empty collections in a typic
Hi,
I have a data point to share on the compatibility impact of
JDK-8325621 (Improve jspawnhelper version checks), which was
backported to earlier release trains.
As a result of that change, doing an in-place upgrade from 22.0.1 to
22.0.2 breaks long-running Java applications that create subproce
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- static final
- code style
-
Changes:
-
Hi Viktor
Your previous response inspired me to experiment some more with Gatherers
As a result I'd like to make a couple propositions:
* add an additional type parameter.
After doing so, type inference no longer needs any assistance:
`var maxGatherer = Gatherer.ofSequential(State::new, State
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
On Tue, 13 Aug 2024 12:57:23 GMT, Axel Boldt-Christmas
wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 674:
>>
>>> 672:
>>> 673: // Search for obj in cache.
>>> 674: bind(loop);
>>
>> Same loop transformation would be possible here.
>
> I tried the following (see diff
On Tue, 13 Aug 2024 14:37:32 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> Sonia Zaldana Calles has updated the pu
On Fri, 2 Aug 2024 00:39:12 GMT, Chen Liang wrote:
> 1. Add notes and docs about the difference between resolved constants and
> constant pool descriptors for annotation constants (e.g. `char` vs
> `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value fact
On Fri, 2 Aug 2024 16:31:48 GMT, Chen Liang wrote:
>> 1. Add notes and docs about the difference between resolved constants and
>> constant pool descriptors for annotation constants (e.g. `char` vs
>> `IntegerEntry`)
>> 2. Improved value specification to specify their tags.
>> 3. Improved value
On Tue, 13 Aug 2024 09:38:31 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision
On Tue, 13 Aug 2024 14:52:03 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 12 Aug 2024 14:37:50 GMT, Axel Boldt-Christmas
wrote:
>> This is a really good suggestion and might help a lot with the performance
>> problems that we see with the table with heavily contended locking. I think
>> we should change this in a follow-on patch (which I'll work on).
>
> I
On Mon, 12 Aug 2024 18:55:41 GMT, Coleen Phillimore wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missing DEBUG_ONLY
>
> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 341:
>
>> 339: };
>> 34
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
> Hi all,
>
> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with two
additional commits since the last revisi
On Tue, 13 Aug 2024 11:52:05 GMT, Viktor Klang wrote:
>> The Exchanger class uses spin-waits that are hostile to some uses of
>> VirtualThreads. Improving this requires a means of estimating whether there
>> are many VirtualThreads with few carriers, which can be supported by adding
>> a metho
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
On Tue, 23 Jul 2024 14:27:34 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 105:
>>
>>> 103: };
>>> 104:
>>> 105: class LookupMonitor : public StackObj {
>>
>> I'm not understanding why we need this little wrapper class.
>
> It's a two way looku
On Tue, 23 Jul 2024 16:36:18 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 102:
>>
>>> 100: assert(*value != nullptr, "must be");
>>> 101: return (*value)->object_is_cleared();
>>> 102: }
>>
>> The `is_dead` functions seem oddly plac
On Tue, 23 Jul 2024 13:19:02 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 62:
>>
>>> 60: class ObjectMonitorWorld : public CHeapObj {
>>> 61: struct Config {
>>> 62: using Value = ObjectMonitor*;
>>
>> Does this alias really help? We don't st
On Tue, 23 Jul 2024 20:21:05 GMT, Coleen Phillimore wrote:
>> Only legacy locking uses the displaced header, I believe, which isn't clear
>> in this code at all. This seems like a fix. We should probably assert that
>> only legacy locking uses this field as a displaced header.
>
> Update: yes
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
On Fri, 12 Jul 2024 15:32:45 GMT, Roman Kennke wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update arguments.cpp
>
> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 58:
>
>> 56:
>> 57: //
>>
On Tue, 16 Jul 2024 12:36:08 GMT, Roman Kennke wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with 10
>> additional commits since the last revision:
>>
>> - Remove try_read
>> - Add explicit to single parameter constructors
>> - Remove superfluous access specifier
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote:
> The Exchanger class uses spin-waits that are hostile to some uses of
> VirtualThreads. Improving this requires a means of estimating whether there
> are many VirtualThreads with few carriers, which can be supported by adding a
> method in cla
On Mon, 12 Aug 2024 13:41:24 GMT, Viktor Klang wrote:
> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
> failing due to a LinkageError or other errors
This pull request has now been integrated.
Changeset: fbe4cc96
Author:Viktor Klang
URL:
https://git.openjdk
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- remove unused
- Minor refactoring
-
Chang
On Tue, 13 Aug 2024 09:00:10 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Minor refactoring
-
Changes:
- all: https:
On Tue, 13 Aug 2024 09:00:10 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Simplify HiddenClassUnloading
-
Changes:
-
On Tue, 13 Aug 2024 08:04:07 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add jtreg HiddenClassUnloading
>
> test/jdk/java/lang/String/concat/HiddenClassUnloading.java line 67:
>
>> 65:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/lang/invoke/String
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with three additional
commits since the last revision:
- Simplify HiddenClassUnloading
- Remove unnecessary lo
On Tue, 13 Aug 2024 08:36:18 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with four additional
> commits since the last revisio
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with four additional
commits since the last revision:
- Update src/java.base/share/classes/java/lang/invoke/Str
On Tue, 13 Aug 2024 01:39:33 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 12 Aug 2024 23:39:02 GMT, David Holmes wrote:
> It has been a while since I knew this code reasonably well so perhaps I have
> just forgotten this difference between AQS and built-in monitors, but it
> seems that a Condition.await can return by throwing an exception without
> re-acquir
On Mon, 12 Aug 2024 23:28:26 GMT, David Holmes wrote:
> Though I'm unclear how that compiles without the method declaring `throws
> Throwable` ??
It wouldn't need that because of precise rethrow. In any case, having Error and
RuntimeException are okay.
-
PR Review Comment: https:
On Mon, 12 Aug 2024 16:11:46 GMT, Viktor Klang wrote:
>> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
>> failing due to a LinkageError or other errors
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
68 matches
Mail list logo
