Re: RFR: 8337838: Remove unused methods from ChronoLocalDateImpl

2024-08-06 Thread Andrey Turbanov
On Tue, 6 Aug 2024 19:46:02 GMT, Roger Riggs wrote: >> A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could >> be removed: >> 1. plusWeeks(long) >> 2. minusYears(long) >> 3. minusMonths(long) >> 4. minusWeeks(long) >> 5. minusDays(long) >> >> Tested `test/jdk/java/time`

Re: RFR: 8336856: Optimize String Concat [v37]

2024-08-06 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: 1. not generate coderArgs unless needed 2. code style -

Re: RFR: 8336856: Optimize String Concat [v36]

2024-08-06 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: refactor checkOverflow - Changes: - all: h

Re: RFR: 8336856: Optimize String Concat [v35]

2024-08-06 Thread Claes Redestad
On Tue, 6 Aug 2024 23:41:09 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with six additional > commits since the last revision:

Re: RFR: 8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode} [v5]

2024-08-06 Thread Joe Darcy
> First pass at adding some quality of implementation discussions around the > overridable methods of Object. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull

Re: RFR: 8336856: Optimize String Concat [v35]

2024-08-06 Thread Shaojin Wen
On Tue, 6 Aug 2024 23:41:09 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with six additional > commits since the last revision:

Re: RFR: 8336856: Optimize String Concat [v35]

2024-08-06 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with six additional commits since the last revision: - checkOverflow - highArity default 0 - use MethodTypeDe

Re: RFR: 8336856: Optimize String Concat [v34]

2024-08-06 Thread Claes Redestad
On Tue, 6 Aug 2024 18:07:16 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with two additional > commits since the last revision:

Re: RFR: 8336856: Optimize String Concat [v34]

2024-08-06 Thread Claes Redestad
On Tue, 6 Aug 2024 18:07:16 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with two additional > commits since the last revision:

Re: [External] : Gatherers -- windowBy

2024-08-06 Thread David Alayachew
Thanks. I am going to use it a lot more. If I get more examples, should I post a follow up? Or leave it for others to jump in? On Mon, Aug 5, 2024, 7:26 AM Viktor Klang wrote: > Hi David, > > Thank you for the write-up—sharing your experience with us. > > I'm happy you've had much success with `

Integrated: 8337506: Disable "best-fit" mapping on Windows command line

2024-08-06 Thread Naoto Sato
On Thu, 1 Aug 2024 17:21:09 GMT, Naoto Sato wrote: > Fixing the Java launcher's command line argument parsing issue on Windows. > The Java launcher on Windows has been using `GetCommandLineA()` to obtain > arguments, which by default does "best-fit" mapping when the arguments are > converted t

Re: RFR: 8337838: Remove unused methods from ChronoLocalDateImpl

2024-08-06 Thread Roger Riggs
On Fri, 19 Jul 2024 09:52:50 GMT, Andrey Turbanov wrote: > A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could > be removed: > 1. plusWeeks(long) > 2. minusYears(long) > 3. minusMonths(long) > 4. minusWeeks(long) > 5. minusDays(long) > > Tested `test/jdk/java/time` on L

Re: RFR: 8336856: Optimize String Concat [v34]

2024-08-06 Thread Shaojin Wen
On Tue, 6 Aug 2024 18:07:16 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with two additional > commits since the last revision:

Re: RFR: 8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode} [v4]

2024-08-06 Thread Roger Riggs
On Wed, 31 Jul 2024 01:46:09 GMT, Joe Darcy wrote: >> First pass at adding some quality of implementation discussions around the >> overridable methods of Object. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the

Re: RFR: 8336856: Optimize String Concat [v34]

2024-08-06 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision: - copyright - remove unused import - Change

Re: RFR: 8336856: Optimize String Concat [v33]

2024-08-06 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: resolve the WithSecurityManager test failure

Re: RFR: 8336856: Optimize String Concat [v32]

2024-08-06 Thread Claes Redestad
On Tue, 6 Aug 2024 17:01:11 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8336856: Optimize String Concat [v32]

2024-08-06 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: fix comments & code style - Changes: - all

Re: RFR: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true

2024-08-06 Thread Brian Burkhalter
On Tue, 6 Aug 2024 00:50:48 GMT, Naoto Sato wrote: > Fixing a regression caused by the removal of the legacy locale data. Legacy > locale data happened to have resource bundle for "he" language (new ISO code) > with the launguage name for "iw" (old ISO code). CLDR does not have it, thus > the

Re: RFR: 8337205: Typo in Stack vs Deque Method table in Deque specification

2024-08-06 Thread Turkhan
On Tue, 6 Aug 2024 06:48:52 GMT, Per Minborg wrote: >> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an >> equivalent to Stack's `peek()` method since both of them don't throw when a >> collection is empty. This is not the case with the current `getFirst()` >> method

Re: RFR: 8337205: Typo in Stack vs Deque Method table in Deque specification

2024-08-06 Thread Per Minborg
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote: > This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an > equivalent to Stack's `peek()` method since both of them don't throw when a > collection is empty. This is not the case with the current `getFirst()` > method. > >

RFR: 8337205: Typo in Stack vs Deque Method table in Deque specification

2024-08-06 Thread Turkhan
This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an equivalent to Stack's `peek()` method since both of them don't throw when a collection is empty. This is not the case with the current `getFirst()` method. Please let me know if I have to fix something in the PR. Will ap

Integrated: 8332522: SwitchBootstraps::mappedEnumLookup constructs unused array

2024-08-06 Thread Jan Lahoda
On Wed, 26 Jun 2024 12:32:20 GMT, Jan Lahoda wrote: > For general pattern matching switches, the `SwitchBootstraps` class currently > generates a cascade of `if`-like statements, computing the correct target > case index for the given input. > > There is one special case which permits a relati