> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with 14 additional
commits since the last revision:
- Merge pull request #9 from cl4es/pr_20273_inject_cache
> Fixing the Java launcher's command line argument parsing issue on Windows.
> The Java launcher on Windows has been using `GetCommandLineA()` to obtain
> arguments, which by default does "best-fit" mapping when the arguments are
> converted to ANSI code page encoding. By disabling this "best-fi
On Fri, 2 Aug 2024 18:20:40 GMT, Alan Bateman wrote:
>> The first call to `WideCharToMultiByte()` returns the required size for the
>> multibyte buffer. When it returns 0, `exit(1)` is issued inside
>> `JLI_MemAlloc()`. If the second call to `WideCharToMultiByte()` returns 0,
>> it is explicit
On Fri, 2 Aug 2024 18:00:28 GMT, Naoto Sato wrote:
> The first call to `WideCharToMultiByte()` returns the required size for the
> multibyte buffer. When it returns 0, `exit(1)` is issued inside
> `JLI_MemAlloc()`.
That's a bit subtle. I think it needs to be handled here or at least include a
On Fri, 2 Aug 2024 13:12:00 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor to eliminate "lenient" mode (still failng test: GZIPInZip.java).
>> - Add GZIP input test for various gzip(1
On Fri, 2 Aug 2024 17:53:17 GMT, Alan Bateman wrote:
>> IIUC, all errors should be handled with the proposed patch. On error with
>> JLI_MemAlloc and WideCharToMultiByte, the process exits with `exit(1)`. As
>> to `GetCommandLineW()`, there is no description of error in the MS document
>> (htt
On Fri, 2 Aug 2024 16:57:35 GMT, Naoto Sato wrote:
> IIUC, all errors should be handled with the proposed patch. On error with
> JLI_MemAlloc and WideCharToMultiByte, the process exits with `exit(1)`.
I think I'm mostly wondering about WideCharToMultiByte as it returns 0 when it
fails.
-
On Fri, 2 Aug 2024 09:30:56 GMT, Alan Bateman wrote:
>> Fixing the Java launcher's command line argument parsing issue on Windows.
>> The Java launcher on Windows has been using `GetCommandLineA()` to obtain
>> arguments, which by default does "best-fit" mapping when the arguments are
>> conve
> 1. Add notes and docs about the difference between resolved constants and
> constant pool descriptors for annotation constants (e.g. `char` vs
> `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of
> `O
> Add some verbiage indicating that an `IOException` will be thrown if a file
> with a name generated from the supplied prefix and suffix according to the
> described algorithm cannot be generated by the underlying system, whether
> that be due to the presence of one of more characters not suppo
Thanks for the confirmation. I will submit this finalized specification for CSR
review.
From: javadoc-dev on behalf of Alex Buckley
Sent: Friday, August 2, 2024 10:53 AM
To: compiler-...@openjdk.org ;
core-libs-dev@openjdk.org ; javadoc-...@openjdk.org
Subjec
In the annotation `@Foo(a=1)`, the left hand side `a` is an _element_
(as declared in the annotation interface Foo) and the right hand side
`1` is an _element value_ (per the first line of JLS 9.7.1).
Syntactically the `a` is an identifier but that's almost never relevant
what discussing eleme
One specification question for Alex: we call an annotation interface's element
"element". What about the element-value pair that binds a value to an interface
element in an annotation? Can we call this element-value pair an "element", or
is there any other more proper name that is still concise?
> 1. Add notes and docs about the difference between resolved constants and
> constant pool descriptors for annotation constants (e.g. `char` vs
> `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of
> `O
> 1. Add notes and docs about the difference between resolved constants and
> constant pool descriptors for annotation constants (e.g. `char` vs
> `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of
> `O
On Fri, 2 Aug 2024 00:04:48 GMT, Chen Liang wrote:
>> `TypeAnnotation` is not an annotation, as it should not be used in places
>> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
>> annotation at a given location instead of to be an annotation.
>>
>> Depends on #20205.
>
On Fri, 2 Aug 2024 07:57:27 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits si
> 1. Add notes and docs about the difference between resolved constants and
> constant pool descriptors for annotation constants (e.g. `char` vs
> `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of
> `O
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Fri, 2 Aug 2024 07:37:31 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/util/Date.java line 1015:
>>
>>> 1013: * {@code 59}), as two decimal digits.
>>> 1014: * {@code ss} is the second within the minute ({@code 00}
>>> through
>>> 1015: * {@code 61}), as
On Thu, 1 Aug 2024 10:16:59 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Thu, 1 Aug 2024 17:21:09 GMT, Naoto Sato wrote:
> Fixing the Java launcher's command line argument parsing issue on Windows.
> The Java launcher on Windows has been using `GetCommandLineA()` to obtain
> arguments, which by default does "best-fit" mapping when the arguments are
> converted t
On Fri, 2 Aug 2024 08:43:41 GMT, Alan Bateman wrote:
> I assume it would be better to re-examine the timeout + retry used in the
> test to make it more robust when running with a debug build and different
> compilation modes.
Okey, I will re-examine the timeout value in linux x64/linux aarch64
On Fri, 2 Aug 2024 00:21:28 GMT, Brian Burkhalter wrote:
> Add some verbiage indicating that an `IOException` will be thrown if a file
> with a name generated from the supplied prefix and suffix according to the
> described algorithm cannot be generated by the underlying system, whether
> that
On Fri, 2 Aug 2024 08:21:42 GMT, SendaoYan wrote:
> Hi all,
> The test `com/sun/jndi/dns/ConfigTests/Timeout.java` fails with `-Xcomp
> -XX:TieredStopAtLevel=1` jvm options by fastdebug binary. In C1 mode and with
> debug binary, the JIT comple time longger than -Xmixed and release binary is
Hi all,
The test `com/sun/jndi/dns/ConfigTests/Timeout.java` fails with `-Xcomp
-XX:TieredStopAtLevel=1` jvm options by fastdebug binary. In C1 mode and with
debug binary, the JIT comple time longger than -Xmixed and release binary is
accatable. So this should not report fails with `-Xcomp
-XX
On Fri, 2 Aug 2024 00:39:12 GMT, Chen Liang wrote:
> 1. Add notes and docs about the difference between resolved constants and
> constant pool descriptors for annotation constants (e.g. `char` vs
> `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value fact
On Fri, 2 Aug 2024 07:24:20 GMT, Per Minborg wrote:
>> This trivial PR proposes to add a missing parenthesis in
>> `java.util.Date::toString`.
>
> src/java.base/share/classes/java/util/Date.java line 1015:
>
>> 1013: * {@code 59}), as two decimal digits.
>> 1014: * {@code ss} is t
This trivial PR proposes to add a missing parenthesis in
`java.util.Date::toString`.
-
Commit messages:
- Update copyright year
- Add missing parenthesis in Date::toString
Changes: https://git.openjdk.org/jdk/pull/20439/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2043
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote:
> This trivial PR proposes to add a missing parenthesis in
> `java.util.Date::toString`.
src/java.base/share/classes/java/util/Date.java line 1015:
> 1013: * {@code 59}), as two decimal digits.
> 1014: * {@code ss} is the second
30 matches
Mail list logo