On Thu, 18 Jul 2024 05:52:51 GMT, Jaikiran Pai wrote:
> So I think we should have this increase in memory reviewed by @asotona or
> someone familiar in that area, before deciding whether these tests should be
> changed.
Okey.
-
PR Comment: https://git.openjdk.org/jdk/pull/19864#i
On Wed, 17 Jul 2024 21:42:17 GMT, Naoto Sato wrote:
>> It will be addressed by https://bugs.openjdk.org/browse/JDK-8336679
>
> I am planning to add `@implSpec` with a separate issue:
> [JDK-8336679](https://bugs.openjdk.org/browse/JDK-8336679)
Okay, just a bit strange to add waitFor(Duration) h
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
Maybe the footprint m
class LocalDate {
public String toString() {
if (absYear < 1000) {
if (yearValue < 0) {
buf.append(yearValue - 1).deleteCharAt(1);
} else {
buf.append(yearValue + 1).deleteCharAt(0);
}
// ...
}
}
Cur
On Wed, 17 Jul 2024 21:41:16 GMT, Naoto Sato wrote:
>> Proposing a new overload method for `Process#waitFor()` which takes a
>> `Duration` for the timeout value. This will reduce the possibility for
>> making mistakes with the `TimeUnit` in the other overload method. A
>> corresponding CSR has
On Wed, 17 Jul 2024 21:41:16 GMT, Naoto Sato wrote:
>> Proposing a new overload method for `Process#waitFor()` which takes a
>> `Duration` for the timeout value. This will reduce the possibility for
>> making mistakes with the `TimeUnit` in the other overload method. A
>> corresponding CSR has
On Wed, 17 Jul 2024 21:41:16 GMT, Naoto Sato wrote:
>> Proposing a new overload method for `Process#waitFor()` which takes a
>> `Duration` for the timeout value. This will reduce the possibility for
>> making mistakes with the `TimeUnit` in the other overload method. A
>> corresponding CSR has
On Fri, 26 Apr 2024 14:06:02 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this simple patch?
> Some index check in Byte/ShortVector.fromArray/fromArray0Template seems not
> necessary, could be removed.
> Thanks
This pull request has been closed without being integrated.
-
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We
> need a JMH Benchmark to evaluate the performance of various batch operations
> and the effect of MergeStore.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incrementa
On Tue, 16 Jul 2024 03:10:29 GMT, Chen Liang wrote:
>> The `@Stable` on the `index` field is incorrect, as stable only avoids
>> inlining `0`. On a strategic view, this index field should just become final
>> so that `Name` becomes eligible for value class migration once valhalla
>> comes. Thi
On Thu, 4 Jan 2024 14:21:54 GMT, Valeh Hajiyev wrote:
>>>I think this ticket should focus on adding the new constructor as part of
>>>the API.
>>
>> Okay. I would think the code would avoid heapify when the caller does
>> foolish things with this API such as:
>>
>> SortedSet ss = filledSorte
On Thu, 4 Jan 2024 15:34:03 GMT, Jason Mehrens wrote:
>>> > I think this ticket should focus on adding the new constructor as part of
>>> > the API.
>>>
>>> Okay. I would think the code would avoid heapify when the caller does
>>> foolish things with this API such as:
>>>
>>> ```
>>> SortedSe
On Thu, 28 Dec 2023 00:09:09 GMT, Valeh Hajiyev wrote:
>> This commit addresses the current limitation in the `PriorityQueue`
>> implementation, which lacks a constructor to efficiently create a priority
>> queue with a custom comparator and an existing collection. In order to
>> create such a
On Wed, 17 Jul 2024 09:18:31 GMT, Galder Zamarreño wrote:
> Do you want a microbenchmark for the performance of vectorized max/min long?
Yeah, I think a simple benchmark that tests for long min/max vectorization and
reduction would be good. I worry that checking performance manually like in
`R
On Wed, 17 Jul 2024 19:47:44 GMT, Chen Liang wrote:
> `Class` has 2 VM-injected fields that can be made explicit: `Object[]
> signers` and `ProtectionDomain protectionDomain`. We make the signers field
> explicit. (The ProtectionDomain can be revisited when SecurityManager is
> removed, as Sec
On Wed, 17 Jul 2024 20:00:18 GMT, ExE Boss wrote:
>>> waitFor can be overridden by pre-24 subclasses to provide a better
>>> implementation while ...
>>
>> It doesn't really make sense to extend Process, except maybe for mocking or
>> other testing. Process is really for JDK implementations, i
On Wed, 17 Jul 2024 21:39:39 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/Process.java line 481:
>>
>>> 479: * this method returns immediately with the value {@code false}.
>>> 480: *
>>> 481: * The default implementation of this method polls the {@code
>>> exi
On Wed, 17 Jul 2024 18:28:10 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ProcessTools overriding one-arg waitFor()
>
> src/java.base/share/classes/java/lang/Process.java line 481:
>
>> 479:
> Proposing a new overload method for `Process#waitFor()` which takes a
> `Duration` for the timeout value. This will reduce the possibility for making
> mistakes with the `TimeUnit` in the other overload method. A corresponding
> CSR has also been drafted.
Naoto Sato has updated the pull reque
There's another bug in ClassFile transform composition where the downstream
transform receives items from upstream transform's chained builders before the
downstream transform itself starts. This is a simple fix, and a test case
against `ClassTransform` is added.
-
Commit messages:
The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical
because the GZIP encoding is based on ZLIB "deflate" encoding.
However, while `DeflaterOutputStream` provides constructors that take a custom
`Deflator` argument supplied by the caller, `GZIPOutputStream` has no such
On Wed, 17 Jul 2024 20:51:32 GMT, Chen Liang wrote:
> Qualify the reading of entry lists with the anticipated types up-front, so we
> throw the correct `ConstantPoolException` instead of `ClassCastException`
> when we encounter malformed attribute lists. (`ClassModel.getInterfaces`
> already b
Qualify the reading of entry lists with the anticipated types up-front, so we
throw the correct `ConstantPoolException` instead of `ClassCastException` when
we encounter malformed attribute lists. (`ClassModel.getInterfaces` already
behave correctly, in comparison)
-
Commit message
On Wed, 17 Jul 2024 15:19:18 GMT, Jorn Vernee wrote:
>> This PR limits the number of cases in which we deoptimize frames when
>> closing a shared Arena. The initial intent of this was to improve the
>> performance of shared arena closure in cases where a lot of threads are
>> accessing and clo
`Class` has 2 VM-injected fields that can be made explicit: `Object[] signers`
and `ProtectionDomain protectionDomain`. We make the signers field explicit.
(The ProtectionDomain can be revisited when SecurityManager is removed, as
SecurityManager is accessing it via JNI as well.)
Migrate the JN
On Wed, 17 Jul 2024 18:31:32 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/Process.java line 504:
>>
>>> 502: return false;
>>> 503:
>>> 504: return waitForNanos(TimeUnit.NANOSECONDS.convert(duration));
>>
>> `waitFor` can be overridden by pre-24 subclas
On Wed, 17 Jul 2024 15:19:18 GMT, Jorn Vernee wrote:
>> This PR limits the number of cases in which we deoptimize frames when
>> closing a shared Arena. The initial intent of this was to improve the
>> performance of shared arena closure in cases where a lot of threads are
>> accessing and clo
On Wed, 17 Jul 2024 18:46:11 GMT, Vladimir Ivanov wrote:
>> This is because the C++ runtime does secondary super cache lookups even
>> before the bitmap has been calculated and the hash table sorted. In this
>> case the bitmap is zero, so teh search thinks there are no secondary supers.
>> Set
On Thu, 11 Jul 2024 15:28:37 GMT, Aleksey Shipilev wrote:
> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
> method for `Reference.clear`. The original patch skipped intrinsification of
> this method, because we thought `Reference.clear` is not on a performance
> s
On Wed, 17 Jul 2024 17:13:49 GMT, Andrew Haley wrote:
>> Another observation while browsing the code: `_secondary_supers_bitmap`
>> would be a better name. (Same considerations apply to `_hash_slot`.)
>
> This is because the C++ runtime does secondary super cache lookups even
> before the bitma
On Fri, 12 Jul 2024 13:19:31 GMT, Aleksey Shipilev wrote:
>>> > The reason we did not do this before is that this is not a strong
>>> > reference store. Strong reference stores with a SATB collector will keep
>>> > the referent alive, which is typically the exact opposite of what a user
>>> >
On Mon, 15 Jul 2024 16:09:39 GMT, Kim Barrett wrote:
> > Aw, nice usability landmine. I thought C2 barrier set would assert on me if
> > it cannot deliver. Apparently not, [...]
>
> Reference.refersTo has similar issues. See refersToImpl and refersTo0 in both
> Reference and PhantomReference.
On Fri, 12 Jul 2024 13:19:31 GMT, Aleksey Shipilev wrote:
> > The runtime use of the Access API knows how to resolve an unknown oop ref
> > strength using AccessBarrierSupport::resolve_unknown_oop_ref_strength.
> > However, we do not have support for that in the C2 backend. In fact, it
> > doe
> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
> method for `Reference.clear`. The original patch skipped intrinsification of
> this method, because we thought `Reference.clear` is not on a performance
> sensitive path. However, it shows up prominently on simple be
On Wed, 17 Jul 2024 17:47:11 GMT, Chen Liang wrote:
> Please review this change that moves `Class.protectionDomain` and `signers`
> to explicit fields.
>
> Related native methods in `Class` and `AccessController::getProtectionDomain`
> are converted to pure Java. These fields are still set and
On Wed, 17 Jul 2024 17:47:11 GMT, Chen Liang wrote:
> Please review this change that moves `Class.protectionDomain` and `signers`
> to explicit fields.
>
> Related native methods in `Class` and `AccessController::getProtectionDomain`
> are converted to pure Java. These fields are still set and
On Wed, 17 Jul 2024 17:47:11 GMT, Chen Liang wrote:
> Please review this change that moves `Class.protectionDomain` and `signers`
> to explicit fields.
>
> Related native methods in `Class` and `AccessController::getProtectionDomain`
> are converted to pure Java. These fields are still set and
On Wed, 17 Jul 2024 17:51:52 GMT, Chen Liang wrote:
> waitFor can be overridden by pre-24 subclasses to provide a better
> implementation while ...
It doesn't really make sense to extend Process, except maybe for mocking or
other testing. Process is really for JDK implementations, it's just hi
On Wed, 17 Jul 2024 17:36:29 GMT, Naoto Sato wrote:
> Proposing a new overload method for `Process#waitFor()` which takes a
> `Duration` for the timeout value. This will reduce the possibility for making
> mistakes with the `TimeUnit` in the other overload method. A corresponding
> CSR has als
On Wed, 17 Jul 2024 17:36:29 GMT, Naoto Sato wrote:
> Proposing a new overload method for `Process#waitFor()` which takes a
> `Duration` for the timeout value. This will reduce the possibility for making
> mistakes with the `TimeUnit` in the other overload method. A corresponding
> CSR has als
Proposing a new overload method for `Process#waitFor()` which takes a
`Duration` for the timeout value. This will reduce the possibility for making
mistakes with the `TimeUnit` in the other overload method. A corresponding CSR
has also been drafted.
-
Commit messages:
- initial co
Please review this change that moves `Class.protectionDomain` and `signers` to
explicit fields.
Related native methods in `Class` and `AccessController::getProtectionDomain`
are converted to pure Java. These fields are still set and used by hotspot.
Also fixes the incorrect `protectiondomain_si
On Thu, 11 Jul 2024 00:10:02 GMT, Stuart Marks wrote:
>> First pass at adding some quality of implementation discussions around the
>> overridable methods of Object.
>
> src/java.base/share/classes/java/lang/Object.java line 53:
>
>> 51: * {@link VirtualMachineError} is possible during the exe
On Fri, 5 Jul 2024 22:37:34 GMT, Vladimir Ivanov wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
>> time.
>>
>> HotSpo
On Thu, 11 Jul 2024 23:47:51 GMT, Vladimir Ivanov wrote:
>> src/hotspot/share/oops/klass.cpp line 284:
>>
>>> 282: // which doesn't zero out the memory before calling the constructor.
>>> 283: Klass::Klass(KlassKind kind) : _kind(kind),
>>> 284:_bitmap(SECONDARY_S
On Wed, 17 Jul 2024 15:19:18 GMT, Jorn Vernee wrote:
>> This PR limits the number of cases in which we deoptimize frames when
>> closing a shared Arena. The initial intent of this was to improve the
>> performance of shared arena closure in cases where a lot of threads are
>> accessing and clo
On Wed, 17 Jul 2024 16:39:10 GMT, fabioromano1 wrote:
>> Can try with the old release and the incorrect code again?
>> If the results disagree with newer releases then I'd be interested in which
>> release you were using, as to analyze the generated code and possibly file a
>> bug report for th
On Wed, 17 Jul 2024 16:16:12 GMT, Raffaello Giulietti
wrote:
>> Can try with the old release and the incorrect code again?
>> If the results disagree with newer releases then I'd be interested in which
>> release you were using, as to analyze the generated code and possibly file a
>> bug repor
On Tue, 16 Jul 2024 16:54:09 GMT, Naoto Sato wrote:
>> Removing a redundant private method, which has the same implementation with
>> the public sibling and obsolete method description.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revisio
On Wed, 17 Jul 2024 16:16:12 GMT, Raffaello Giulietti
wrote:
>> Can try with the old release and the incorrect code again?
>> If the results disagree with newer releases then I'd be interested in which
>> release you were using, as to analyze the generated code and possibly file a
>> bug repor
On Tue, 16 Jul 2024 16:33:02 GMT, Naoto Sato wrote:
> Removing a redundant private method, which has the same implementation with
> the public sibling and obsolete method description.
This pull request has now been integrated.
Changeset: 10186ff4
Author:Naoto Sato
URL:
https://git.
On Wed, 17 Jul 2024 15:59:30 GMT, fabioromano1 wrote:
>> Sorry, disregard the above as it doesn't work for x = 0.
>
> @rgiulietti Probably I used a too older release to try the incorrect code
Can try with the old release and the incorrect code again?
If the results disagree with newer releases t
On Wed, 17 Jul 2024 16:15:47 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti Probably I used a too older release to try the incorrect code
>
> Can try with the old release and the incorrect code again?
> If the results disagree with newer releases then I'd be interested in which
> release you we
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote:
>> Move fields common to Method and Field to executable, which simplifies
>> implementation. Removed useless transient modifiers as Method and Field were
>> never serializable.
>>
>> Note to core-libs reviewers: Please review the associated C
On Wed, 17 Jul 2024 15:11:36 GMT, Raffaello Giulietti
wrote:
>> Also, this avoids a test
>>
>> if (Long.compareUnsigned(x, s * s - 1) <= 0) { // benign over-
>> and underflows
>> s--;
>> }
>
> Sorry, disregard the above as it doesn't work for x = 0.
@r
On Wed, 17 Jul 2024 15:19:18 GMT, Jorn Vernee wrote:
>> This PR limits the number of cases in which we deoptimize frames when
>> closing a shared Arena. The initial intent of this was to improve the
>> performance of shared arena closure in cases where a lot of threads are
>> accessing and clo
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
On Wed, 17 Jul 2024 15:11:36 GMT, Raffaello Giulietti
wrote:
>> Also, this avoids a test
>>
>> if (Long.compareUnsigned(x, s * s - 1) <= 0) { // benign over-
>> and underflows
>> s--;
>> }
>
> Sorry, disregard the above as it doesn't work for x = 0.
>
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
> This PR limits the number of cases in which we deoptimize frames when closing
> a shared Arena. The initial intent of this was to improve the performance of
> shared arena closure in cases where a lot of threads are accessing and
> closing shared arenas at the same time (see attached benchmark
On Wed, 17 Jul 2024 15:08:22 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti This is so strange... anyway, I tried also `long x = n * n`,
>> `long s = Math.round(Math.sqrt(x >= 0 ? x : x + 0x1p64))` with the test `s <
>> n`, which I think it's more mathematically natural, and also this never
On Wed, 17 Jul 2024 14:30:33 GMT, fabioromano1 wrote:
>> I tried on older release, they all agree.
>
> @rgiulietti This is so strange... anyway, I tried also `long x = n * n`,
> `long s = Math.round(Math.sqrt(x >= 0 ? x : x + 0x1p64))` with the test `s <
> n`, which I think it's more mathemati
On Wed, 17 Jul 2024 14:11:20 GMT, fabioromano1 wrote:
>> There are no counterexamples for perfect squares if you write `long s =
>> (long) Math.rint(Math.sqrt(x >= 0 ? x : x + 0x1p64));`.
>
> @rgiulietti Is it normal that the same code did not find counterexamples
> until recently, and now it f
On Wed, 17 Jul 2024 14:02:01 GMT, Thomas Stuefe wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updating copyright headers
>
> src/hotspot/share/code/codeCache.cpp line 1800:
>
>> 1798: jio_snprintf(fn
On Wed, 17 Jul 2024 14:17:48 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti Is it normal that the same code did not find counterexamples
>> until recently, and now it finds them?
>
> I tried on older release, they all agree.
@rgiulietti This is so strange... anyway, I tried also `long x = n *
On Wed, 17 Jul 2024 14:02:31 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
>> enabling jcmd diagnostic commands that issue an output file to accept the
>> `%p` pattern in the file name and substitute it for the PID.
On Tue, 16 Jul 2024 03:10:29 GMT, Chen Liang wrote:
>> The `@Stable` on the `index` field is incorrect, as stable only avoids
>> inlining `0`. On a strategic view, this index field should just become final
>> so that `Name` becomes eligible for value class migration once valhalla
>> comes. Thi
On Wed, 17 Jul 2024 13:57:20 GMT, Raffaello Giulietti
wrote:
>> I hope these errors are not due to an implementation change in the virtual
>> machine instructions...
>
> There are no counterexamples for perfect squares if you write `long s =
> (long) Math.rint(Math.sqrt(x >= 0 ? x : x + 0x1p64
On Wed, 17 Jul 2024 13:44:58 GMT, Aleksey Shipilev wrote:
> > @shipilev Would you re-review this patch, or are you no longer interested
> > now that `@Stable` is removed?
>
> I am not sure I understand the performance implications for this change. I
> can see the optimization for avoiding `Nam
> Hi all,
>
> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
> enabling jcmd diagnostic commands that issue an output file to accept the
> `%p` pattern in the file name and substitute it for the PID.
>
> This PR addresses the following diagnostic commands:
> - [x] C
On Wed, 17 Jul 2024 13:57:06 GMT, fabioromano1 wrote:
>> In fact, if you run this code:
>> `long limit = 1L << 32;
>> for (long n = 0; n < limit; n++) {
>> long x = n * n;
>> if (n != (long) Math.sqrt(x >= 0 ? x : x + 0x1p64)) {
>> System.out.println(n);
>> }
>> }`
>>
On Wed, 17 Jul 2024 13:48:59 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 1978:
>>
>>> 1976: * is either correct, or rounded up by one if the value
>>> is too high
>>> 1977: * and too close to the next perfect square.
>>
On Wed, 17 Jul 2024 13:15:17 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimized shift-and-add operations
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1978:
Hi all,
This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
enabling jcmd diagnostic commands that issue an output file to accept the `%p`
pattern in the file name and substitute it for the PID.
This PR addresses the following diagnostic commands:
- [x] Compiler.perfmap
On Mon, 15 Jul 2024 13:39:02 GMT, Aleksey Shipilev wrote:
>> Indeed, for some reason I thought the range of short is -256 to 255 instead
>> of -65536 to 65535
>
>> Indeed, for some reason I thought the range of short is -256 to 255 instead
>> of -65536 to 65535
>
> Yeah, I thought something li
On Mon, 15 Jul 2024 12:59:27 GMT, Maurizio Cimadamore
wrote:
> Effectively, once all the issues surrounding reachability fences will be
> addressed, we should be able to achieve numbers similar to above even in the
> case of shared close.
Is there an issue where I can follow this? [ EDIT: o
On Tue, 16 Jul 2024 18:09:20 GMT, Jorn Vernee wrote:
>> This PR limits the number of cases in which we deoptimize frames when
>> closing a shared Arena. The initial intent of this was to improve the
>> performance of shared arena closure in cases where a lot of threads are
>> accessing and clo
On Mon, 15 Jul 2024 19:58:23 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Wed, 17 Jul 2024 08:33:27 GMT, Adam Sotona wrote:
>> `WritableElement` has always been one of the biggest peculiarities of
>> ClassFile API: it exposes element writing yet has no corresponding reading
>> ability exposed. Its existence creates a lot of API noise, increasing
>> maintenance co
On Wed, 10 Jul 2024 14:24:05 GMT, Jasmine Karthikeyan
wrote:
> The C2 changes look nice! I just added one comment here about style. It would
> also be good to add some IR tests checking that the intrinsic is creating
> `MaxL`/`MinL` nodes before macro expansion, and a microbenchmark to compare
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull re
On Tue, 16 Jul 2024 23:50:17 GMT, Chen Liang wrote:
> `WritableElement` has always been one of the biggest peculiarities of
> ClassFile API: it exposes element writing yet has no corresponding reading
> ability exposed. Its existence creates a lot of API noise, increasing
> maintenance cost in
On Tue, 16 Jul 2024 23:50:17 GMT, Chen Liang wrote:
> `WritableElement` has always been one of the biggest peculiarities of
> ClassFile API: it exposes element writing yet has no corresponding reading
> ability exposed. Its existence creates a lot of API noise, increasing
> maintenance cost in
On Tue, 16 Jul 2024 16:54:09 GMT, Naoto Sato wrote:
>> Removing a redundant private method, which has the same implementation with
>> the public sibling and obsolete method description.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revisio
On Mon, 15 Jul 2024 15:16:23 GMT, Chen Liang wrote:
>> Remove unused `Class/Field/Method/CodeBuilder.original()`, and make
>> `Field/Method/CodeModel.parent()` return present only if it's bound (i.e.
>> not buffered transformed). See the CSR for details.
>
> Chen Liang has updated the pull requ
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
91 matches
Mail list logo
