> Similar to how `MethodHandle#invoke(Exact)` methods are already handled, this
> change adds special casing for `VarHandle.{access-mode}` methods.
>
> The exception message is less exact, but I think that's acceptable.
Hannes Greule has updated the pull request incrementally with one additional
On Tue, 25 Jun 2024 19:33:02 GMT, Naoto Sato wrote:
>> I did not mean to introduce a public API for this change (if we do, the fix
>> cannot be backported). I thought we could define a package private one, but
>> based on your observation, it may get messier... So I agree that falling
>> back
On Tue, 2 Jul 2024 14:04:52 GMT, Shaojin Wen wrote:
>> We need a String format solution with good performance. String Template was
>> once expected, but it has been removed. j.u.Formatter is powerful, but its
>> performance is not good enough.
>>
>> This PR implements a subset of j.u.Formatter
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
See https://openjdk.org/guide/#life-of-a-pr point 6 for the 24-hour wait rule.
-
PR Comment: https://git.openjdk.org/jdk
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
As a general rule, please wait for at least 24 hours to integrate, for devs
around the globe to take a look (unless emergency such as
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
@wenshao
Your change (at version a98bd05c857d0a04dfad471dd28f905be1345376) is now ready
to be sponsored by a Committer.
---
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20018#pullrequestreview-2157610512
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
+1
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/20018#pullrequestreview-2157583
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
Marked as reviewed by liach (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/20018#pullrequestreview-215753437
In JDK 21, StringBuilder added a repeat method, which can be used to improve
j.u.Formatter#trailingZeros
-
Commit messages:
- use StringBuilder#repeat
Changes: https://git.openjdk.org/jdk/pull/20018/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20018&range=00
Issue: ht
On Wed, 3 Jul 2024 19:43:05 GMT, Hannes Greule wrote:
> Similar to how `MethodHandle#invoke(Exact)` methods are already handled, this
> change adds special casing for `VarHandle.{access-mode}` methods.
>
> The exception message is less exact, but I think that's acceptable.
src/hotspot/share/pr
On Wed, 3 Jul 2024 19:43:05 GMT, Hannes Greule wrote:
> Similar to how `MethodHandle#invoke(Exact)` methods are already handled, this
> change adds special casing for `VarHandle.{access-mode}` methods.
>
> The exception message is less exact, but I think that's acceptable.
Great work!
src/hot
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
Similar to how `MethodHandle#invoke(Exact)` methods are already handled, this
change adds special casing for `VarHandle.{access-mode}` methods.
The exception message is less exact, but I think that's acceptable.
-
Commit messages:
- add test (and find missing method)
- make reflec
On Wed, 3 Jul 2024 13:41:29 GMT, Jorn Vernee wrote:
>> Simple fix for `MethodTypeDescImpl`'s violation of `resolveConstantDesc`
>> specification.
>
> src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java
> line 228:
>
>> 226: mtype = mt;
>> 227: } catch
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Fri, 28 Jun 2024 11:11:51 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote:
>> Can I please get a review for this small change? The motivation is that
>> javac does not recognize `package.html` files.
>>
>> The conversion was simple, I used a script to rename the files, append "*"
>> on the left and remove some HTM
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote:
>> Can I please get a review for this small change? The motivation is that
>> javac does not recognize `package.html` files.
>>
>> The conversion was simple, I used a script to rename the files, append "*"
>> on the left and remove some HTM
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote:
>> Can I please get a review for this small change? The motivation is that
>> javac does not recognize `package.html` files.
>>
>> The conversion was simple, I used a script to rename the files, append "*"
>> on the left and remove some HTM
On Wed, 3 Jul 2024 13:41:29 GMT, Jorn Vernee wrote:
>> Simple fix for `MethodTypeDescImpl`'s violation of `resolveConstantDesc`
>> specification.
>
> src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java
> line 228:
>
>> 226: mtype = mt;
>> 227: } catch
On Tue, 2 Jul 2024 16:20:54 GMT, Chen Liang wrote:
> Simple fix for `MethodTypeDescImpl`'s violation of `resolveConstantDesc`
> specification.
src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java line
228:
> 226: mtype = mt;
> 227: } catch (TypeNotPres
On Tue, 2 Jul 2024 16:20:54 GMT, Chen Liang wrote:
> Simple fix for `MethodTypeDescImpl`'s violation of `resolveConstantDesc`
> specification.
Marked as reviewed by jvernee (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19991#pullrequestreview-2156417137
On Wed, 3 Jul 2024 12:04:37 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java
>> line 226:
>>
>>> 224: }
>>> 225: });
>>> 226: mtype = mt;
>>
>> Can you drop this intermediate variable, and just assign to
On Wed, 3 Jul 2024 11:57:31 GMT, Jorn Vernee wrote:
>> Simple fix for `MethodTypeDescImpl`'s violation of `resolveConstantDesc`
>> specification.
>
> src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java
> line 226:
>
>> 224: }
>> 225: });
>> 226
On Tue, 2 Jul 2024 16:20:54 GMT, Chen Liang wrote:
> Simple fix for `MethodTypeDescImpl`'s violation of `resolveConstantDesc`
> specification.
src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java line
226:
> 224: }
> 225: });
> 226:
On Thu, 30 May 2024 20:26:38 GMT, Liam Miller-Cushon wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move test to test/jdk/tools/launcher
>
> @bridgekeeper please keep this open
Hello Liam @cushon, please ke
On Fri, 21 Jul 2023 16:42:25 GMT, Doug Lea wrote:
>> This update addresses performance issues across both LinkedTransferQueue and
>> SynchronousQueue by creating a common basis for implementation across them
>> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
>> changes:
On Fri, 10 May 2024 01:24:15 GMT, Chen Liang wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> @stuart-marks Can you take a look at this?
I've had a look here, and it functionally looks good t
30 matches
Mail list logo
