On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
> enabling `javap -system` to handle internal class names.
>
> Thanks,
> Sonia
+1
-
Marked as reviewed by stuefe (Reviewer
On Wed, 26 Jun 2024 09:43:32 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Sat, 15 Jun 2024 01:59:42 GMT, Shaojin Wen wrote:
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is
On Wed, 26 Jun 2024 09:43:32 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Wed, 26 Jun 2024 09:43:32 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Sun, 23 Jun 2024 08:47:25 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Wed, 26 Jun 2024 17:42:13 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 1. revert code change.
>> 2. comment remove space
>
> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java
On Wed, 26 Jun 2024 18:08:21 GMT, Nizar Benalla wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commi
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
> enabling `javap -system` to handle internal class names.
>
> Thanks,
> Sonia
noreg means no regression test. Since we cannot really cr
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
> enabling `javap -system` to handle internal class names.
>
> Thanks,
> Sonia
Hi everyone, thanks for taking a look.
Seeing the chall
On Thu, 20 Jun 2024 14:32:25 GMT, Shaojin Wen wrote:
>> @cl4es @wenshao I think we should probably work on `putChar`, or at least
>> figure out what blocks `MergeStore` for `putChar`. Can someone produce a
>> simple stand-alone `.java` file that uses `putChar`, so that I can
>> investigate wh
On Wed, 26 Jun 2024 13:02:51 GMT, Jan Lahoda wrote:
>> test/micro/org/openjdk/bench/java/lang/runtime/SwitchEnum.java line 57:
>>
>>> 55: for (E e : inputs) {
>>> 56: sum += switch (e) {
>>> 57: case null -> -1;
>>
>> As this `null` case adds a case relative
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
> Can I please get a review for this small change? The motivation is that javac
> does not recognize `package.html` files.
>
> The conversion was simple, I used a script to rename the files, append "*" on
> the left and remove some HTML tags like `` and ``. I did the
> conversion in place, rena
On Wed, 26 Jun 2024 18:09:10 GMT, Nizar Benalla wrote:
>> Can I please get a review for this small change? The motivation is that
>> javac does not recognize `package.html` files.
>>
>> The conversion was simple, I used a script to rename the files, append "*"
>> on the left and remove some HT
On Wed, 26 Jun 2024 17:59:54 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/ChoiceFormat.java line 591:
>>
>>> 589: /**
>>> 590: * @since 23
>>> 591: */
>>
>> IIUC, this addition will add & inherit the javadoc from `NumberFormat`,
>> which is not the case before.
On Wed, 26 Jun 2024 17:53:07 GMT, Naoto Sato wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new line when having multi-line doc comment
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 591:
>
On Wed, 26 Jun 2024 17:07:27 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 06:53:28 GMT, Adam Sotona wrote:
> Conversion of `java.lang.invoke` package to Class-File API is failing to
> execute method handles with specific type conversion requirements. Root cause
> is in the new `TypeConvertingMethodAdapter::primitiveTypeKindFromClass`
> implementa
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 17:07:27 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Wed, 26 Jun 2024 12:36:17 GMT, Chen Liang wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits si
On Tue, 11 Jun 2024 17:25:29 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920)
> which corrects a bug where NumberFormat cannot successfully parse values in
> integer only mode, when the format expects a suffix.
>
> For example,
>
> // a form
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are needed for some overriding methods for the purpose
> of the
On Wed, 26 Jun 2024 14:22:03 GMT, Raffaello Giulietti
wrote:
>> I looked at it again and I think @cl4es 's suggestion is correct. Can I
>> submit the change? @rgiulietti
>
> Of course, nothing has been approved as of now.
>
> Since you are preparing a commit anyway, may I ask you to revert bac
> Hi all,
> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails on
> rpm build mock environment. The `df -h` command return fail `df: cannot read
> table of mounted file systems: No such file or directory` on the rpm build
> mock environment also. I think it's a environmen
On Wed, 26 Jun 2024 12:15:33 GMT, SendaoYan wrote:
> Hi all,
> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails on
> rpm build mock environment. The `df -h` command return fail `df: cannot read
> table of mounted file systems: No such file or directory` on the rpm buil
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad wrote:
> Simple refactoring to extract identical, simple lambda expressions. Improve
> code clarity and reduce classes generated.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/19760#issuecomment-2191894639
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad wrote:
> Simple refactoring to extract identical, simple lambda expressions. Improve
> code clarity and reduce classes generated.
This pull request has now been integrated.
Changeset: 5883a20b
Author:Claes Redestad
URL:
https://git.o
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Wed, 26 Jun 2024 14:38:04 GMT, Claes Redestad wrote:
>> @wenshao @cl4es I think this use-case is quite a valid one, and deserves an
>> extension. I filed:
>>
>> [JDK-8335113](https://bugs.openjdk.org/browse/JDK-8335113): C2 MergeStores:
>> allow merging of putChar and other larger stores on
On Tue, 25 Jun 2024 17:19:28 GMT, Emanuel Peter wrote:
> I filed:
>
> [JDK-8335113](https://bugs.openjdk.org/browse/JDK-8335113): C2 MergeStores:
> allow merging of putChar and other larger stores on smaller array elements
Great! Should we hold off on this optimization and see if we can avoid
On Wed, 26 Jun 2024 14:17:47 GMT, Shaojin Wen wrote:
>> Yeah, I'm just musing about the perils of leaking/replicating those
>> implementation details, but as you say this is internal code only used by
>> `String` and `StringBuilder` to it's loosely part of that complex. Not
>> requesting any c
On Wed, 26 Jun 2024 14:00:36 GMT, Claes Redestad wrote:
>> I have written a version using boolean locally, but because this class is
>> mainly used by String and StringBuilder, it uses the same style as
>> String/StringBuilder.
>
> Yeah, I'm just musing about the perils of leaking/replicating t
On Tue, 25 Jun 2024 17:45:23 GMT, Andrew John Hughes wrote:
> Is there still going to be some monitoring of these tests? Making it harder
> to run these tests potentially means that genuine failures can go unnoticed
> and JDK certificates are not updated when needed.
Tracking won’t be any diff
On Wed, 26 Jun 2024 13:23:14 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 47:
>>
>>> 45: static final int NAN = 5 << 8;
>>> 46:
>>> 47: static final byte LATIN1 = 0;
>>
>> I think this somewhat unnecessarily copies names and inter
On Wed, 26 Jun 2024 13:20:58 GMT, Shaojin Wen wrote:
>> In principle, you should not arbitrarily change code that is correct, and
>> only limit your changes to reach the goal of the PR.
>> My suggestion is the minimal change required, yours is more than strictly
>> needed.
>
> Got it, should I
On Wed, 26 Jun 2024 12:32:20 GMT, Jan Lahoda wrote:
> For general pattern matching switches, the `SwitchBootstraps` class currently
> generates a cascade of `if`-like statements, computing the correct target
> case index for the given input.
>
> There is one special case which permits a relati
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad wrote:
> Simple refactoring to extract identical, simple lambda expressions. Improve
> code clarity and reduce classes generated.
Marked as reviewed by liach (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/19760#pullreque
On Wed, 26 Jun 2024 13:14:13 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> from @liach: use s.getBytes for performance
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 47:
On Wed, 26 Jun 2024 12:50:38 GMT, Raffaello Giulietti
wrote:
>> I like the new implementation, the code is cleaner, is your suggestion to
>> revert to the original version due to smaller changes?
>
> In principle, you should not arbitrarily change code that is correct, and
> only limit your ch
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini
wrote:
> The following test:
> **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is
> currently marked to be run manually because user inputs are required in the
> console, but instead it can be automated by providing a cus
On Tue, 25 Jun 2024 17:29:04 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 12:46:18 GMT, Claes Redestad wrote:
>> For general pattern matching switches, the `SwitchBootstraps` class
>> currently generates a cascade of `if`-like statements, computing the correct
>> target case index for the given input.
>>
>> There is one special case which permits
On Wed, 26 Jun 2024 12:32:20 GMT, Jan Lahoda wrote:
> For general pattern matching switches, the `SwitchBootstraps` class currently
> generates a cascade of `if`-like statements, computing the correct target
> case index for the given input.
>
> There is one special case which permits a relati
On Tue, 25 Jun 2024 17:02:10 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 236:
>>
>>> 234: dk = -1;
>>> 235: }
>>> 236: return toDecimal(str, index, Q_MIN, t, dk, fd) - start;
>>
>> I sugge
On Wed, 26 Jun 2024 12:32:20 GMT, Jan Lahoda wrote:
> For general pattern matching switches, the `SwitchBootstraps` class currently
> generates a cascade of `if`-like statements, computing the correct target
> case index for the given input.
>
> There is one special case which permits a relati
On Wed, 26 Jun 2024 10:08:38 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
For general pattern matching switches, the `SwitchBootstraps` class currently
generates a cascade of `if`-like statements, computing the correct target case
index for the given input.
There is one special case which permits a relatively easy faster handling, and
that is when all the case labels
Hi all,
Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails on
rpm build mock environment. The `df -h` command return fail `df: cannot read
table of mounted file systems: No such file or directory` on the rpm build mock
environment also. I think it's a environmental issue,
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad wrote:
> Simple refactoring to extract identical, simple lambda expressions. Improve
> code clarity and reduce classes generated.
Looks good to me.
-
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/
On Wed, 26 Jun 2024 11:30:25 GMT, Raffaello Giulietti
wrote:
>> All suggestions have been fixed, can this PR be integrated? @cl4es @liach
>
> @wenshao Looks good, thanks for the improvements.
>
> Let me know when you are finished with your changes.
> Once approved, you should refrain from addi
On Tue, 25 Jun 2024 01:58:29 GMT, Shaojin Wen wrote:
>> Just suggesting some improvements
>
> All suggestions have been fixed, can this PR be integrated? @cl4es @liach
@wenshao Looks good, thanks for the improvements.
Let me know when you are finished with your changes.
Once approved, you shou
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad wrote:
> Simple refactoring to extract identical, simple lambda expressions. Improve
> code clarity and reduce classes generated.
Friendly reminder that this trivial improvement needs a reviewer.
-
PR Comment: https://git.openjdk.or
On Tue, 18 Jun 2024 10:00:46 GMT, Claes Redestad wrote:
>> Extracting duplicate method references to static field reduce proxy class
>> spinning and loading. In this case 2 less classes loaded when using
>> `findAny()` on each type of stream.
>
> Claes Redestad has updated the pull request incr
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are needed for some overriding methods for the purpose
> of the
On Tue, 25 Jun 2024 19:33:02 GMT, Naoto Sato wrote:
> > So, considering all the information given, is it enough to start our new
> > review process? @naotoj @liach @justin-curtis-lu
>
> Well, I was suggesting the same buffer proxying for other Format classes than
> NumberFormat subclasses, suc
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
> ### Performance regression of DecimalFormat.format
> From the output of perf, we can see the hottest regions contain atomic
> instructions. But when run with JDK 11, there is no such problem. The reason
> is the removed biased locking.
> The DecimalFormat uses StringBuffer everywhere, and St
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
> enabling `javap -system` to handle internal class names.
>
> Thanks,
> Sonia
For a test, I agree it is quite difficult. For the `--sys
On Tue, 25 Jun 2024 21:22:34 GMT, Chen Liang wrote:
>> This is a collection of fixes and improvements to CodeBuilder, plus 2
>> renames.
>>
>> Fixes include:
>> 1. `CodeBuilder::receiverSlot` typo
>> 2. `CodeAttribute::labelToBci` update spec
>> 3. `CodeBuilder::exceptionCatch` implementation
>
On Tue, 25 Jun 2024 13:47:39 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
On Mon, 24 Jun 2024 16:01:41 GMT, Adam Sotona wrote:
> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>
> This patch converts all lambdas in ClassSpecializer into anonymous inner
> clas
On Tue, 25 Jun 2024 13:47:39 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
On Wed, 26 Jun 2024 07:54:16 GMT, Alan Bateman wrote:
> > Question, what is the noreg-hard label used for?
>
> It's the label to mean that it's too hard or impossible write a regression
> test. It is documented in the [JBS label
> dictionary](https://openjdk.org/guide/#jbs-label-dictionary) bu
On Wed, 26 Jun 2024 06:04:08 GMT, Thomas Stuefe wrote:
> Question, what is the noreg-hard label used for?
It's the label to mean that it's too hard or impossible write a regression
test. It is documented in the [JBS label
dictionary](https://openjdk.org/guide/#jbs-label-dictionary) but may not
69 matches
Mail list logo
