Conversion of `java.lang.invoke` package to Class-File API is failing to
execute method handles with specific type conversion requirements. Root cause
is in the new `TypeConvertingMethodAdapter::primitiveTypeKindFromClass`
implementation. Original code has been matching the types by hash code an
On Tue, 25 Jun 2024 19:49:07 GMT, Chen Liang wrote:
> Technically javap accepts both notations of `a.b.C` and `a/b/C.class` and
> accepts both `.` and `$` as inner class separators. So this is fine. However
> it's hard to verify that the jdk in `--system` is really used, so I put a
> noreg-har
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
> This is a collection of fixes and improvements to CodeBuilder, plus 2 renames.
>
> Fixes include:
> 1. `CodeBuilder::receiverSlot` typo
> 2. `CodeAttribute::labelToBci` update spec
> 3. `CodeBuilder::exceptionCatch` implementation
> 4. `CodeBuilder::if_nonnull`/`if_null` -> `ifnonnull`/`ifnull`
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
> enabling `javap -system` to handle internal class names.
>
> Thanks,
> Sonia
Technically javap accepts both notations of `a.b.C` and `
On Thu, 20 Jun 2024 18:58:27 GMT, Naoto Sato wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> I did not mean to introduce a public API for this change (if we
On Thu, 20 Jun 2024 18:01:39 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
This pull request has now been integrated.
Changeset: 86b0cf25
Author:Justin Lu
URL:
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
This pull request has now been integra
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
Thanks for the reviews!
-
On Mon, 24 Jun 2024 04:25:45 GMT, Yude Lin wrote:
> [JDK-8318107](https://bugs.openjdk.org/browse/JDK-8318107) Un-ProblemListed
> LocaleProvidersRun and CalendarDataRegression, and
> [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899) added them back.
> I'm guessing it's a mistake in re
On Fri, 21 Jun 2024 16:11:34 GMT, Rajan Halade wrote:
>> Updated all the tests that depend on external infrastructure services as
>> manual. These tests may fail with external reasons, for instance - change in
>> CA test portal, certificate status updates, or network issues.
>
> Rajan Halade ha
This is a collection of fixes and improvements to CodeBuilder, plus 2 renames.
Fixes include:
1. `CodeBuilder::receiverSlot` typo
2. `CodeAttribute::labelToBci` update spec
3. `CodeBuilder::exceptionCatch` implementation
4. `CodeBuilder::if_nonnull`/`if_null` -> `ifnonnull`/`ifnull`
5. Docs for wh
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Thu, 20 Jun 2024 14:32:25 GMT, Shaojin Wen wrote:
>> @cl4es @wenshao I think we should probably work on `putChar`, or at least
>> figure out what blocks `MergeStore` for `putChar`. Can someone produce a
>> simple stand-alone `.java` file that uses `putChar`, so that I can
>> investigate wh
On Sun, 23 Jun 2024 08:47:25 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Tue, 25 Jun 2024 14:47:45 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Utf16 case remove `append first utf16 char`
>
> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.ja
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
Hi all,
This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
enabling `javap -system` to handle internal class names.
Thanks,
Sonia
-
Commit messages:
- 808: javap --system handling doesn't work on internal class names
Changes: https://git.openjdk.o
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Mon, 17 Jun 2024 04:58:41 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Tue, 25 Jun 2024 13:47:39 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
On Mon, 24 Jun 2024 14:33:51 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This is similar with previous JDK-8334396.
> Added some tests.
>
> ### Test
>
> | Tests | Scores | Errors | Unit
> -- | -- | -- | -- | --
> Intrinsic, +zbb, +rvv | Characters.reverseBy
On Tue, 25 Jun 2024 12:51:46 GMT, Ludovic Henry wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This is similar with previous JDK-8334396.
>> Added some tests.
>>
>> ### Test
>>
>> | Tests | Scores | Errors | Unit
>> -- | -- | -- | -- | --
>> Intrinsic, +zbb, +rvv | Char
On Tue, 25 Jun 2024 13:49:31 GMT, Adam Sotona wrote:
>> Transforming the classModel back to the bytes array in order to write the
>> transformed classfile
>
> And what is the purpose of parsing a model from bytes and transforming it
> back to bytes without a change?
This transformation is call
On Thu, 20 Jun 2024 17:37:05 GMT, Thomas Stuefe wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove problem listing of PlainRead which is reworked here
>
> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu limits by means of the cgroup filesystem. If neither of thos
On Tue, 25 Jun 2024 13:45:17 GMT, Oussama Louati wrote:
>> test/jdk/java/lang/invoke/indify/Indify.java line 386:
>>
>>> 384:
>>> 385: byte[] transformToBytes(ClassModel classModel) {
>>> 386: return of().transform(classModel, ClassTransform.ACCEPT_ALL);
>>
>> What is the purpose o
On Tue, 25 Jun 2024 13:17:13 GMT, Adam Sotona wrote:
>> Oussama Louati has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove: removed unnecessary logging
>
> test/jdk/java/lang/invoke/indify/Indify.java line 386:
>
>> 384:
>> 385:
On Tue, 25 Jun 2024 09:36:37 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>
> This patch converts all lambdas in ClassSpecializer into anonymous inner
> classes.
>
> Please review and test on a BigEndian platfor
On Tue, 25 Jun 2024 13:39:07 GMT, Jan Kratochvil
wrote:
> Currently this patch conflicts a lot with #19085
> (jerboaa:jdk-8331560-cgroup-controller-delegation).
Yes, I'll resolve it one way or another depending on which one goes in first.
-
PR Comment: https://git.openjdk.org/jdk
On Thu, 20 Jun 2024 12:06:43 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
On Sat, 22 Jun 2024 15:55:28 GMT, Oussama Louati wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> ### Purpose of Indify
>>
>> - **Transf
On Sat, 22 Jun 2024 15:55:28 GMT, Oussama Louati wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> ### Purpose of Indify
>>
>> - **Transf
On Tue, 25 Jun 2024 09:36:37 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
On Tue, 25 Jun 2024 08:12:53 GMT, Hamlin Li wrote:
>> test/micro/org/openjdk/bench/java/lang/Characters.java line 69:
>>
>>> 67:
>>> 68: @Benchmark
>>> 69: public void reverseBytes() {
>>
>> I'm not sure we want to be adding that benchmark to this class. Could you
>> move to a differe
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This is similar with previous JDK-8334396.
> Added some tests.
>
> ### Test
>
> | Tests | Scores | Errors | Unit
> -- | -- | -- | -- | --
> Intrinsic, +zbb, +rvv | Characters.reverseBy
On Mon, 24 Jun 2024 16:01:41 GMT, Adam Sotona wrote:
> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>
> This patch converts all lambdas in ClassSpecializer into anonymous inner
> clas
> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>
> This patch converts all lambdas in ClassSpecializer into anonymous inner
> classes.
>
> Please review and test on a BigEndian platfor
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
On Mon, 24 Jun 2024 16:01:41 GMT, Adam Sotona wrote:
> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>
> This patch converts all lambdas in ClassSpecializer into anonymous inner
> clas
On Mon, 24 Jun 2024 16:01:41 GMT, Adam Sotona wrote:
> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>
> This patch converts all lambdas in ClassSpecializer into anonymous inner
> clas
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in which
> the given API element was introduced. That is:
On Fri, 21 Jun 2024 14:05:51 GMT, Kevin Walls wrote:
> Man page update for JDK-8327793 which marked jstatd as deprecated for removal
> in JDK 24.
Thanks Alan and David, moving to a single line:
JSTATD(1) JDK
Commands
On Tue, 25 Jun 2024 08:25:00 GMT, Kevin Walls wrote:
>> Man page update for JDK-8327793 which marked jstatd as deprecated for
>> removal in JDK 24.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> text update
Marked as revi
> Man page update for JDK-8327793 which marked jstatd as deprecated for removal
> in JDK 24.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
text update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19829/files
On Mon, 24 Jun 2024 21:01:14 GMT, Ludovic Henry wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This is similar with previous JDK-8334396.
>> Added some tests.
>>
>> ### Test
>>
>> | Tests | Scores | Errors | Unit
>> -- | -- | -- | -- | --
>> Intrinsic, +zbb, +rvv | Char
On Mon, 24 Jun 2024 22:11:55 GMT, Richard Reingruber wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous in
53 matches
Mail list logo
