On Wed, 19 Jun 2024 02:21:05 GMT, Joe Darcy wrote:
> Simple doc improvement.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19781#pullrequestreview-2126919618
Simple doc improvement.
-
Commit messages:
- JDK-8309821: Link to hidden classes section in Class specification for
Class::isHidden
Changes: https://git.openjdk.org/jdk/pull/19781/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19781&range=00
Issue: https://bugs.openjdk.
On Wed, 19 Jun 2024 02:12:01 GMT, lingjun-cg wrote:
>> src/java.base/share/classes/java/text/Format.java line 278:
>>
>>> 276: * {@code false} otherwise
>>> 277: */
>>> 278: boolean isInternalSubclass() {
>>
>> Since this is defined in Format, can we apply similar changes
On Tue, 18 Jun 2024 20:39:30 GMT, Justin Lu wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 561
On Tue, 18 Jun 2024 20:36:52 GMT, Justin Lu wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/Format.java line 278:
>
>
On Tue, 18 Jun 2024 10:00:33 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Fri, 7 Jun 2024 12:48:51 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/Double.java line 595:
>
>> 593: * This
> Misc small doc updates and addition of `@Overrides` annotations.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19590/files
- new: https:
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root
On Tue, 18 Jun 2024 10:00:33 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
> Misc small doc updates and addition of `@Overrides` annotations.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits si
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequestrevi
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
+1
-
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequest
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
LGTM
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequest
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root
The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for string
comparison, which should be avoided.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/19775/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19775&range=00
Issue:
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root
On Tue, 18 Jun 2024 13:22:45 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any com
On Tue, 18 Jun 2024 16:19:39 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Thu, 30 May 2024 19:35:44 GMT, Magnus Ihse Bursie wrote:
> Do os::lookup_function need to be implemented on Windows too, for symmetry,
> even if it is only used on Unix platforms?
@AlanBateman suggested to add `lookup_function` to os_windows.cpp as well, but
just let it contain ShouldNotRea
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
Marked as reviewed by naoto (Reviewer)
> This patch contains a set of changes to improve static builds. They will pave
> the way for implementing a full static-only java launcher. The changes here
> will:
>
> 1) Make sure non-exported symbols are made local in the static libraries.
> This means that the risk of symbol conflict is th
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
Marked as reviewed by srl (Committer).
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
Marked as reviewed by iris (Reviewer).
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> Since the problematic patch from before cannot be backed out, this patch
>> aims to emulate the old behavior before. A diff between before the
>>
On Mon, 10 Jun 2024 01:32:09 GMT, Chen Liang wrote:
> Please review this patch that fixes a critical issue that breaks some Proxy
> usages.
>
> Since the problematic patch from before cannot be backed out, this patch aims
> to emulate the old behavior before. A diff between before the problema
On Tue, 18 Jun 2024 13:30:39 GMT, Claes Redestad wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Merge pull request #8 from cl4es/serialization_hostile
>>
>>SerializationHostileMethod
>> - Reduce gratuit
On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> Since the problematic patch from before cannot be backed out, this patch
>> aims to emulate the old behavior before. A diff between before the
>>
On Tue, 18 Jun 2024 13:22:45 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any com
On Tue, 18 Jun 2024 13:22:45 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any com
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
On Tue, 18 Jun 2024 11:33:51 GMT, Daniel Fuchs wrote:
>> Agree with Kevin. To minimize risk, especially since this is to fix a
>> significant regression and we are in RDP1, we are really trying to preserve
>> the existing code as much as possible, even though it could be improved.
>
> It is als
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Mon, 17 Jun 2024 20:51:34 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Mon, 17 Jun 2024 20:27:05 GMT, Sean Mullan wrote:
>> Hi,
>> We almost always check
>> !SharedSecrets.getJavaLangAccess().allowSecurityManager() (except in the
>> RMIConnectionImpl contstructor)
>>
>> This keeps the "modern" case first (except in that constructor, where it is
>> only one li
On Mon, 17 Jun 2024 20:51:34 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
Marked as reviewed by lancea (Reviewer
On Mon, 17 Jun 2024 20:51:34 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Mon, 17 Jun 2024 18:17:06 GMT, Justin Lu wrote:
>>> I second Justin's suggestion here. The change should benefit every
>>> implementation in the JDK, not only NumberFormat. Also, I might suggest
>>> renaming the new class, as it is kind of long/redundant. How about using
>>> something as si
On Mon, 17 Jun 2024 11:21:37 GMT, Adam Sotona wrote:
>> LMF will BMH and `ClassSpecializer`, but does not call into this code
>> normally as the simple bound method handle needed by LMF is statically
>> defined (`BoundMethodHandle.Species_L`). To be perfectly safe - and to keep
>> lambda/indy/
> ### Performance regression of DecimalFormat.format
> From the output of perf, we can see the hottest regions contain atomic
> instructions. But when run with JDK 11, there is no such problem. The reason
> is the removed biased locking.
> The DecimalFormat uses StringBuffer everywhere, and St
> Extracting duplicate method references to static field reduce proxy class
> spinning and loading. In this case 2 less classes loaded when using
> `findAny()` on each type of stream.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
> Extracting duplicate method references to static field reduce proxy class
> spinning and loading. In this case 2 less classes loaded when using
> `findAny()` on each type of stream.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Simple refactoring to extract identical, simple lambda expressions. Improve
code clarity and reduce classes generated.
-
Commit messages:
- Simplify
- Refactor ProxyMethod list creation
Changes: https://git.openjdk.org/jdk/pull/19760/files
Webrev: https://webrevs.openjdk.org/?re
On Tue, 18 Jun 2024 07:31:59 GMT, Justin Lu wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add a whitespace before if
>
> test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java
> line 54:
>
>> 5
> Hi all,
> Testcase
> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
> run fails with root user privileged. I think it's necessary to skip this
> testcase when user is root.
> Why run the jtreg test by root user? It's because during rpmbuild process for
> linux di
On Tue, 18 Jun 2024 06:31:37 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root
On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> Since the problematic patch from before cannot be backed out, this patch
>> aims to emulate the old behavior before. A diff between before the
>>
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredV
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredV
> This PR removes some unnecessary conversions between byte arrays and long
> arrays during SHA3 digest computations.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
Copyright year update.
-
Changes:
- all: https://
52 matches
Mail list logo
