Re: RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v3]

2024-06-15 Thread Jaikiran Pai
> Can I please get a review of this enhancement which proposes to enhance > `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`? > > The actual work for this was done a few years back when we discussed the > proposed approaches and then I raised a RFR. At that time I could

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v13]

2024-06-15 Thread Weijun Wang
On Fri, 14 Jun 2024 15:26:54 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >> -Djava.security.manager

Re: RFR: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal [v8]

2024-06-15 Thread Shaojin Wen
> The current versions of FloatToDecimal and DoubleToDecimal allocate > additional objects. Reducing these allocations can improve the performance of > Float/Double.toString and AbstractStringBuilder's append(float/double). > > This patch is just a code refactoring to reduce object allocation, b

Re: RFR: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal [v7]

2024-06-15 Thread Shaojin Wen
> The current versions of FloatToDecimal and DoubleToDecimal allocate > additional objects. Reducing these allocations can improve the performance of > Float/Double.toString and AbstractStringBuilder's append(float/double). > > This patch is just a code refactoring to reduce object allocation, b

RFR: 8334333: Run test MissingResourceCauseTestRun.java with root user fails

2024-06-15 Thread SendaoYan
Hi all, Testcase `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root. The change has been verified, only change the testcase, no risk. - Commit messages: -

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-15 Thread Albert Mingkun Yang
On Sat, 15 Jun 2024 05:09:49 GMT, David Holmes wrote: >> Albert Mingkun Yang has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains one commit: >> >> obsolete-old-size > > src/hotspot/share/runtime/arguments.cpp line 37: > >> 35: #inc