On Wed, 12 Jun 2024 19:02:30 GMT, Pavel Rappo wrote:
> Preliminary testing on some affected configurations showed that even 20
> seconds might not be enough. Initially, I suggested that it would be hard to
> imagine, yet here we are.
I haven't seen the jtreg launch command or the jtr files for
On Wed, 12 Jun 2024 19:06:23 GMT, Pavel Rappo wrote:
>> Please review this fix for an intermittent test failure.
>>
>> On some configurations, the default `expect` timeout of 10 seconds is
>> insufficient. It is increased to 20; it's hard to imagine a configuration
>> for which that new value
On Wed, 12 Jun 2024 20:58:28 GMT, Viktor Klang wrote:
> Erronous Javadoc reference addressed. This should be backported to 23.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19682#pullrequestreview-2114807878
> This provides a slightly more accurate bounding limit for
> `computeNextExponentialSoftCapped` when calling it from
> `computeNextGaussian`. This could cause the `while
> (computeNextExponentialSoftCapped(rng, limit) < limit)` check in
> `computeNextGaussian` on line 1402 to always be true, m
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
On Wed, 12 Jun 2024 20:58:28 GMT, Viktor Klang wrote:
> Erronous Javadoc reference addressed. This should be backported to 23.
Hello Viktor, the change looks fine to me. The copyright year on the file will
need an update before integrating.
-
Marked as reviewed by jpai (Reviewer).
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
On Thu, 6 Jun 2024 13:24:06 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - reverted static initialization of ConstantPoolBuilder and CP entries
>> - fixed naming conventions
>
> src/java.base/sha
On Wed, 12 Jun 2024 20:12:15 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> specification improvements
>
> src/java.base/share/classes/java/text/DecimalFormat.java line 2446:
>
>> 2444: // To tra
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920)
> which corrects a bug where NumberFormat cannot successfully parse values in
> integer only mode, when the format expects a suffix.
>
> For example,
>
> // a format that expects a currency suffix
> var fmt = NumberF
> Please review this patch that fixes a critical issue that breaks some Proxy
> usages.
>
> Since the problematic patch from before cannot be backed out, this patch aims
> to emulate the old behavior before. A diff between before the problematic
> patch and this patch is available at
> https:/
On Wed, 12 Jun 2024 14:13:10 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Obtain classloader in security manager friendly code path
>
> Agree with Roger that static imports should be used spari
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
On Wed, 12 Jun 2024 20:48:41 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> Since the problematic patch from before cannot be backed out, this patch
>> aims to emulate the old behavior before. A diff between before the
>>
On Wed, 12 Jun 2024 10:45:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote:
>> @jonathan-gibbons I just realized that this change to the German file
>> matches the file with the Japanese and Chinese localized files. By that I
>> mean the "backwards" translations are also present for the Japanese and
>> Chinese
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translation tool adjusted some definitions, which causes some ch
On Wed, 12 Jun 2024 16:11:28 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Wed, 12 Jun 2024 14:06:39 GMT, Kevin Walls wrote:
>> For the same reason you should be able to just call `Subject.current` in the
>> tests. I don't think you need the `SimpleStandard.useGetSubjectACC` property
>> to toggle the testing of either old or replacement APIs as long as the test
>>
Erronous Javadoc reference addressed. This should be backported to 23.
-
Commit messages:
- Updating Gatherer#defaultCombiner Javadoc to refer to Gatherer#combiner
Changes: https://git.openjdk.org/jdk/pull/19682/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19682&range=00
> Please review this patch that fixes a critical issue that breaks some Proxy
> usages.
>
> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible
> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such types can appear
> in method descriptors in the same class. The
On Wed, 12 Jun 2024 17:31:09 GMT, Rob Spoor wrote:
>> Viktor Klang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 32 commits:
>>
>> - Lowering upper boundary of gatherer composition testing to 512
>> - Javadoc clarifications fo
On Thu, 6 Jun 2024 10:16:14 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any comm
On Wed, 12 Jun 2024 20:04:40 GMT, Ferenc Rakoczi wrote:
> tier1,2,3 mach5 tests all passed.
Thank you for testing.
-
PR Comment: https://git.openjdk.org/jdk/pull/19632#issuecomment-2163863932
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 10 Jun 2024 04:08:41 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible
>> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such types
On Wed, 12 Jun 2024 17:06:25 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920)
>> which corrects a bug where NumberFormat cannot successfully parse values in
>> integer only mode, when the format expects a suffix.
>>
>> For example,
>>
>> //
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Tue, 11 Jun 2024 18:21:49 GMT, Daniel Jeliński wrote:
>> okay
>
> Could you try using MethodHandles instead of b2lLittle? Similar to what's
> used in ChaCha20:
> https://github.com/openjdk/jdk/blob/b77bd5fd6a6f7ddbed90300fba790da4fb683275/src/java.base/share/classes/com/sun/crypto/provider/Ch
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Tue, 11 Jun 2024 09:01:49 GMT, Pavel Rappo wrote:
>> Please review this fix for an intermittent test failure.
>>
>> On some configurations, the default `expect` timeout of 10 seconds is
>> insufficient. It is increased to 20; it's hard to imagine a configuration
>> for which that new value
> Please review this fix for an intermittent test failure.
>
> On some configurations, the default `expect` timeout of 10 seconds is
> insufficient. It is increased to 20; it's hard to imagine a configuration for
> which that new value would still be insufficient, but we'll see.
>
> Aside from
On Wed, 12 Jun 2024 12:40:00 GMT, Alan Bateman wrote:
>> Also it would be helpful to compare the performance without biased locking
>> in JDK11.
>
> @naotoj Has there been any discussion about adding overloads that take a
> StringBuilder?
@AlanBateman yes, we've discussed this over time, but i
On Thu, 30 Nov 2023 14:34:32 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 32 commits:
>
> - Lowering upper bounda
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920)
> which corrects a bug where NumberFormat cannot successfully parse values in
> integer only mode, when the format expects a suffix.
>
> For example,
>
> // a format that expects a currency suffix
> var fmt = NumberF
On Thu, 6 Jun 2024 15:35:20 GMT, Severin Gehwolf wrote:
> My aim will be to bring this into JDK 24 with a JEP then. Hopefully we can
> bring this to a successful conclusion that way.
@AlanBateman JEP draft is here:
https://openjdk.org/jeps/8333799
Could you please help review it? Thanks!
On Wed, 12 Jun 2024 16:11:28 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Wed, 12 Jun 2024 14:55:31 GMT, Daniel Fuchs wrote:
>> Hmm I may have fixed that since changing the policy files, as I'm not seeing
>> the problem without that AuthPermission any more. Am just retesting
>> everything before updating this...
>
> (Same with other policy files in which the perm
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Wed, 12 Jun 2024 14:24:56 GMT, Alan Bateman wrote:
> Are you planning to add tests? I don't think we should be changing this code
> with good tests.
Yes, I will write a test that replicates the failure. So far I verified the
bad-signature condition with GDB, but I agree there should be a t
On Wed, 12 Jun 2024 14:58:39 GMT, Emanuel Peter wrote:
>> @wenshao If you look at the tests in
>> https://github.com/openjdk/jdk/pull/16245, you can see examples like this:
>> https://github.com/eme64/jdk/blob/93bf2ddc9b7f584724034aec6a4f8b9fe1b2dfda/test/hotspot/jtreg/compiler/c2/TestMergeStore
Hi Prasad,
1. The lambdas generated from Class::method, () -> {}, and instance::method are
all from LambdaMetafactory (if you look at the BootstrapMethods attribute from
javap -c -v output), so they always have the same behavior.
2. For JDK 11, according to https://github.com/openjdk/jdk/pull/124
From: Chen Liang
Sent: Wednesday, June 12, 2024 10:22 AM
To: Prasad Velagapudi
Subject: Re: Lambda Classes reachability from GC roots in JDK11 and JDK17
Hello Prasad,
I can confirm the first one is accurate for JDK 15 and later (see JEP 371:
Hidden Classes). La
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
On Wed, 12 Jun 2024 14:24:00 GMT, Emanuel Peter wrote:
>> _putCharStringU will perform MergeStore but with bounds checking. Can the C2
>> optimizer perform MergeStore without bounds checking in this case?
>>
>> StringUTF16.putChar does not have a bounds check, so there should be no
>> bounds c
On Wed, 12 Jun 2024 14:44:56 GMT, Kevin Walls wrote:
>> I think Daniel is right, can you remove this permission and paste in the
>> debug output to see where this is happening?
>
> Hmm I may have fixed that since changing the policy files, as I'm not seeing
> the problem without that AuthPermis
On Wed, 12 Jun 2024 14:24:00 GMT, Emanuel Peter wrote:
>> _putCharStringU will perform MergeStore but with bounds checking. Can the C2
>> optimizer perform MergeStore without bounds checking in this case?
>>
>> StringUTF16.putChar does not have a bounds check, so there should be no
>> bounds c
On Wed, 12 Jun 2024 14:31:26 GMT, Alan Bateman wrote:
>> test/jdk/javax/management/remote/mandatory/notif/policy.negative line 7:
>>
>>> 5: permission javax.management.MBeanPermission
>>> "[domain:type=NB,name=2]", "addNotificationListener";
>>> 6: permission javax.management.MBeanPermi
On Wed, 12 Jun 2024 14:23:07 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> udpates
>
> test/jdk/javax/management/remote/mandatory/notif/policy.negative line 7:
>
>> 5: permission javax.manag
A gentle reminder on these questions… Could you please respond?
Regards,
Prasad.
From: Prasad Velagapudi
Date: Thursday, 6 June 2024 at 8:10 PM
To: core-libs-dev@openjdk.org
Subject: Lambda Classes reachability from GC roots in JDK11 and JDK17
Hello Lambda Experts,
I am looking for clarificati
On Wed, 12 Jun 2024 14:01:40 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Wed, 12 Jun 2024 14:16:50 GMT, Shaojin Wen wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert
>
> _putCharStringU will perform MergeStore but with bounds checking. Can the C2
> optimizer perform MergeStore w
On Wed, 12 Jun 2024 14:02:58 GMT, fitzsim wrote:
> 8334048: -Xbootclasspath can not read some ZIP64 zip files
Are you planning to add tests? I don't think we should be changing this code
with good tests.
-
PR Comment: https://git.openjdk.org/jdk/pull/19678#issuecomment-2163152471
On Tue, Jun 11, 2024 at 1:08 PM David Lloyd wrote:
>
>
> On Tue, Jun 11, 2024 at 12:57 PM Alan Bateman
> wrote:
>
>>
>>
>> On 11/06/2024 18:19, David Lloyd wrote:
>>
>> :
>>
>> I thought that might be where Alan was headed with this. I would support
>> this solution; it would solve the problem f
On Mon, 10 Jun 2024 04:08:41 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible
>> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such types
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 20:31:03 GMT, Sean Mullan wrote:
>> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java
>> line 350:
>>
>>> 348: @SuppressWarnings("removal")
>>> 349: private Subject getSubject() {
>>> 350: Subject subject = null;
>>
>> J
8334048: -Xbootclasspath can not read some ZIP64 zip files
-
Commit messages:
- 8334048: -Xbootclasspath can not read some ZIP64 zip files
Changes: https://git.openjdk.org/jdk/pull/19678/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19678&range=00
Issue: https://bugs.op
> This PR removes some unnecessary conversions between byte arrays and long
> arrays during SHA3 digest computations.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
Fix clone(), accept review suggestions.
-
Changes:
On Wed, 12 Jun 2024 13:38:21 GMT, Shaojin Wen wrote:
> In the AbstractStringBuilder#appendNull method, is it possible to not check
> the bounds based on the information from ensureCapacityInternal?
Perhaps you'd need something like a `Preconditions.checkIndex` in or before the
4-char `StringUT
On Tue, 11 Jun 2024 16:55:44 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1633:
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 16:53:09 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1438:
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 20:58:54 GMT, Sean Mullan wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>> line 1436:
>>
>>> 1434: } else {
>>> 1435: // ACC is present, we have a Subject and SM is
>>> permitted:
>>> 1436:
On Wed, 12 Jun 2024 12:38:58 GMT, Shaojin Wen wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert
>
> -XX:+TraceMergeStores -XX:+UnlockDiagnosticVMOptions
> -XX:DisableIntrinsic=_putCharStringU
>
>
>
> [Trace
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 4 Jun 2024 19:44:57 GMT, Naoto Sato wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> Also it would be helpful to compare the performance without bias
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Wed, 12 Jun 2024 12:18:32 GMT, Shaojin Wen wrote:
> I have another question. The StringUTF16.putChar method inside JDK is an
> intrinsic method, which seems to cause the putCharsAt method to be unable to
> merge to long stores.
Can you show me an example, with the `-XX:CompileCommand=printc
On Wed, 12 Jun 2024 11:59:47 GMT, Emanuel Peter wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert
>
> Going back to:
>
> ./java -XX:+TraceMergeStores -Xbatch -XX:CompileCommand=printcompilation,*::*
> -XX:+Pr
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 4 Jun 2024 19:44:57 GMT, Naoto Sato wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> Also it would be helpful to compare the performance without bias
On Tue, 11 Jun 2024 16:59:31 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management/share/classes/javax/management/monitor/Monitor.java line
> 1541:
>
>> 1539:
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
Can I please get a review of this enhancement which proposes to enhance
`java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
The actual work for this was done a few years back when we discussed the
proposed approaches and then I raised a RFR. At that time I couldn't take t
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
On Thu, 22 Feb 2024 05:40:10 GMT, Joe Darcy wrote:
>> Update: confirmed that the new test fails without the fix.
>
>> Update: confirmed that the new test fails without the fix.
>
> Thanks for verifying the test checks the fix; I'll let others who have worked
> more directly on the random code r
On Fri, 7 Jun 2024 12:59:26 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/cp
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Mon, 10 Jun 2024 15:45:07 GMT, Per Minborg wrote:
> This PR proposes to explicitly state that returned segments form the
> `asSlice` and `reinterpret` method share memory regions with `this` memory
> segment.
>
> Note: The term "subset" means a true subset or the same set.
This pull reque
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
97 matches
Mail list logo
