On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
>> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
>> this testcase run failed. So I make change from `throw new SkippedExce
On Tue, 21 May 2024 14:28:38 GMT, Matthias Baesken wrote:
> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
> jtreg tests afterwards I run into this error :
>
> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime error:
> null pointer passed as arg
On Sun, 26 May 2024 02:58:02 GMT, SendaoYan wrote:
> Hi all,
> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
> this testcase run failed. So I make change from `throw new SkippedExceptio
On Mon, 27 May 2024 00:03:41 GMT, ExE Boss wrote:
>> Please review this change that convert dynamic proxies implementations to
>> hidden classes, intended to target JDK 24.
>>
>> Summary:
>> 1. Adds new implementation while preserving the old implementation behind
>> `-Djdk.reflect.useLegacyPr
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote:
> Please review this change that convert dynamic proxies implementations to
> hidden classes, intended to target JDK 24.
>
> Summary:
> 1. Adds new implementation while preserving the old implementation behind
> `-Djdk.reflect.useLegacyProxyI
On Sun, 26 May 2024 07:40:38 GMT, Daniel Jeliński wrote:
> LGTM. I assume you verified it does the right thing.
Thanks for the review and approved. The change has been verified.
-
PR Comment: https://git.openjdk.org/jdk/pull/19403#issuecomment-2132120584
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
>> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
>> this testcase run failed. So I make change from `throw new SkippedExce
On Sun, 26 May 2024 06:16:44 GMT, Alan Bateman wrote:
>> test/jdk/java/io/IO/IO.java line 64:
>>
>>> 62: expect = Paths.get("/usr/bin/expect"); // os-specific path
>>> 63: if (!Files.exists(expect) || !Files.isExecutable(expect)) {
>>> 64: System.out.print
> Hi all,
> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
> this testcase run failed. So I make change from `throw new SkippedException`
> to `System.exit` to avoid this issue. When use
