On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas
wrote:
>> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
>> deprecated warnings. Testing non-generational ZGC requires the use of a
>> deprecated option.
>
> Axel Boldt-Christmas has updated the pull request incremen
On Mon, 20 May 2024 06:41:45 GMT, Axel Boldt-Christmas
wrote:
> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
> deprecated warnings. Testing non-generational ZGC requires the use of a
> deprecated option.
This pull request has now been integrated.
Changeset: f5ab7dff
On Mon, 20 May 2024 06:42:19 GMT, Axel Boldt-Christmas
wrote:
> Improve ` java/util/logging/LoggingDeadlock2.java` stderr parsing by ignoring
> deprecated warnings. Testing non-generational ZGC requires the use of a
> deprecated option.
This pull request has now been integrated.
Changeset: 9
On Mon, 20 May 2024 07:25:12 GMT, Axel Boldt-Christmas
wrote:
>> Improve ` java/util/logging/LoggingDeadlock2.java` stderr parsing by
>> ignoring deprecated warnings. Testing non-generational ZGC requires the use
>> of a deprecated option.
>
> Axel Boldt-Christmas has updated the pull request
On Mon, 20 May 2024 22:42:20 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 11 commits:
>
> - Fix-up test.
> - Merge branch 'master' into JDK-8330188
> - Adjust test f
On Fri, 17 May 2024 08:28:15 GMT, Raffaello Giulietti
wrote:
>> All random number generator algorithms are implemented in module
>> `java.base`. The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory`
>> is no longer needed.
>
> Raffaello Giulietti has updated the pull request increment
On Mon, 20 May 2024 11:41:48 GMT, Axel Boldt-Christmas
wrote:
>> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691:
>>
>>> 689: * @throws RuntimeException If the pattern was not found
>>> 690: */
>>> 691: public OutputAnalyzer
>>> stderrShouldMatchIgnoreDeprecatedWarning
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas
wrote:
>> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
>> deprecated warnings. Testing non-generational ZGC requires the use of a
>> deprecated option.
>
> Axel Boldt-Christmas has updated the pull request incremen
On Mon, 20 May 2024 21:29:20 GMT, Vladimir Ivanov wrote:
> JVM routinely installs loader constraints for unloaded signature classes when
> method resolution takes place. MethodHandle resolution took a different route
> and eagerly resolves signature classes instead (see
> `java.lang.invoke.Mem
On Mon, 20 May 2024 10:52:27 GMT, Claes Redestad wrote:
> We can fold the call to `Objects.checkIndex` into the code generated in
> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
> This loads 9 less classes (of which 8 generated LFs and Species classes) on a
> min
> Get JDK 24 underway.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 11 commits:
- Fix-up test.
- Merge branch 'master' into JDK-8330188
- Adjust test for deprecated options.
- Merge branch 'master' into JDK-8330188
-
JVM routinely installs loader constraints for unloaded signature classes when
method resolution takes place. MethodHandle resolution took a different route
and eagerly resolves signature classes instead (see
`java.lang.invoke.MemberName$Factory::resolve` and
`sun.invoke.util.VerifyAccess::isTyp
On Mon, 20 May 2024 18:06:32 GMT, Chen Liang wrote:
>> We can fold the call to `Objects.checkIndex` into the code generated in
>> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
>> This loads 9 less classes (of which 8 generated LFs and Species classes) on
>> a min
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> It currently uses ad-hoc code to process class files and intends to migrate
> to ASM; but since we ha
On Mon, 20 May 2024 10:52:27 GMT, Claes Redestad wrote:
> We can fold the call to `Objects.checkIndex` into the code generated in
> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
> This loads 9 less classes (of which 8 generated LFs and Species classes) on a
> min
On Mon, 20 May 2024 10:52:27 GMT, Claes Redestad wrote:
> We can fold the call to `Objects.checkIndex` into the code generated in
> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
> This loads 9 less classes (of which 8 generated LFs and Species classes) on a
> min
We can fold the call to `Objects.checkIndex` into the code generated in
generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
This loads 9 less classes (of which 8 generated LFs and Species classes) on a
minimal test, while being neutral on a throughput sanity test:
Name
On Fri, 26 Apr 2024 14:06:02 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this simple patch?
> Some index check in Byte/ShortVector.fromArray/fromArray0Template seems not
> necessary, could be removed.
> Thanks
That does not look correct and will only check a prefix indexes. A `ByteVect
On Mon, 20 May 2024 08:37:49 GMT, Adam Sotona wrote:
> Parsing of a specifically corrupted class file cause unexpected
> `ArrayIndexOutOfBoundsException` during label inflation.
> This patch checks the valid range and throws expected
> `IllegalArgumentException` instead.
> Relevant test is adde
On Mon, 20 May 2024 18:39:31 GMT, Phil Race wrote:
>> make/conf/module-loader-map.conf line 105:
>>
>>> 103: java.smartcardio \
>>> 104: jdk.accessibility \
>>> 105: jdk.attach \
>>
>> The list of allowed modules has been rewritten from scratch, by looking at
>> the set of modules
On Thu, 16 May 2024 14:54:52 GMT, Viktor Klang wrote:
> Local testing seems to indicate that this fix (which mirrors what's done in
> the FIFO mode) addresses the problem. Regression test added for JDK20+
This pull request has now been integrated.
Changeset: b78613b6
Author:Viktor Klang
U
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Mon, 13 May 2024 10:49:30 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> make/conf/module-loader-map.conf line 105:
>
>> 103: java.smartcardio \
On Mon, 20 May 2024 16:42:19 GMT, Paul Sandoz wrote:
> some additional overhead e.g.,
>
> ```
> if (derefAdapters.length == 0) {
> // insert align check for the root layout on the initial MS +
> offset
> List> coordinateTypes = handle.coordinateTypes();
>
This test intends to verify the behavior of JdkConsole for the java.base
module, wrt restoring the echo. The test assumes the internal methods that
sets/gets the echo status of the platform.
-
Depends on: https://git.openjdk.org/jdk/pull/19184
Commit messages:
- initial commit
Ch
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes th
On Fri, 17 May 2024 19:45:00 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> (1) comments from @liach; (2) added javadoc; (3) Use
>> createTestJavaProcessBuilder() instead of
>> createLimitedTestJav
> JavacBench is a test program that compiles 90 Java source files. It uses a
> fair amount of invokedynamic callsites, so it's good for testing CDS support
> for indy and lambda expressions.
>
> This test was first integrated into the
> [leyden](https://github.com/openjdk/leyden/tree/premain) r
On Mon, 20 May 2024 16:31:18 GMT, Maurizio Cimadamore
wrote:
>
> Ah, got it. You mean more support in VarHandleGuards. Yes, I have a separate
> patch for that (actually had that for quite a while), but we're not super
> sure how to evaluate what impact it has :-)
Ah, i did not realize that.
On Mon, 20 May 2024 09:45:31 GMT, Maurizio Cimadamore
wrote:
> > Separately, we might be missing a few long argument accepting guard methods
> > for simpler cases as I suspect they are still focused more on int index
> > types.
>
> Not sure I understand what guard methods you are referring to
On Mon, 20 May 2024 13:03:36 GMT, Sean Mullan wrote:
>> In XML parlance, a "processor" is an aggregation of parsers, serializers,
>> and other things that contribute to the processing. So I think it could be
>> either here, but you have a point and if it stays as "processor" then it
>> should
> Add two sample configuration files:
>
> jaxp-strict.properties: used to set strict configuration, stricter than
> jaxp.properties in previous versions such as JDK 22
>
>> jaxp-compat.properties: used to regain compatibility from any more
>> restricted configuration than previous versions
On Mon, 20 May 2024 07:13:02 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> withdraw changes to jaxp.properties. The configuration process has not
>> changed, changing the default configuration woul
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> It currently uses ad-hoc code to process class files and intends to migrate
> to ASM; but since we ha
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> It currently uses ad-hoc code to process class files and intends to migrate
> to ASM; but since we ha
On Wed, 10 Jan 2024 20:54:20 GMT, Peter Levart wrote:
> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It
> returns `-1` (meaning that regions are equal) when passing the same instance
> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless
> of
On Mon, 20 May 2024 15:34:28 GMT, Oussama Louati wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> It currently uses ad-hoc code to process
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> It currently uses ad-hoc code to process class files and intends to migrate
> to ASM; but since we ha
On Mon, 20 May 2024 15:34:28 GMT, Oussama Louati wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> It currently uses ad-hoc code to process
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> It currently uses ad-hoc code to process class files and intends to migrate
> to ASM; but since we ha
On Mon, 20 May 2024 13:20:17 GMT, Oussama Louati wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> It currently uses ad-hoc code to process
On Mon, 20 May 2024 15:23:36 GMT, Viktor Klang wrote:
>> Local testing seems to indicate that this fix (which mirrors what's done in
>> the FIFO mode) addresses the problem. Regression test added for JDK20+
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit
> Local testing seems to indicate that this fix (which mirrors what's done in
> the FIFO mode) addresses the problem. Regression test added for JDK20+
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Turn the Runnables into callables
On Mon, 20 May 2024 14:49:13 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moving the memory leak test for SynchronousQueue into its own test and
>> runs only for JDK20+, using VirtualThreads
>
> Local testing seems to indicate that this fix (which mirrors what's done in
> the FIFO mode) addresses the problem. Regression test added for JDK20+
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Addressing review feedback
--
On Fri, 17 May 2024 13:19:19 GMT, Viktor Klang wrote:
>> Local testing seems to indicate that this fix (which mirrors what's done in
>> the FIFO mode) addresses the problem. Regression test added for JDK20+
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> It currently uses ad-hoc code to process class files and intends to migrate
> to ASM; but since we ha
On Mon, 20 May 2024 12:55:24 GMT, Alan Bateman wrote:
>> src/java.xml/share/classes/module-info.java line 444:
>>
>>> 442: *
>>> 443: * Deploying with this configuration prevents processors from
>>> unknowingly making
>>> 444: * outbound network connections to fetch DTDs, or process XML that
On Mon, 20 May 2024 12:48:01 GMT, Sean Mullan wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> withdraw changes to jaxp.properties. The configuration process has not
>> changed, changing the default configuration would
Hi David,
> I would not expect any class load
events.
I understand. I also haven't tried to intercept them but I see only one
approach right now to include them in an allowlist - 1) statically look for
invocations of "Lookup::defineHiddenClass". 2) Instrument them so that its
first argument
On Sun, 19 May 2024 05:01:32 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from any
On 20/05/2024 10:12 pm, Aman Sharma wrote:
Hi David,
> How did you try to intercept them? Hidden classes are not "loaded" in
the normal sense so won't trigger class load events.
I could not intercept them. I only see them when I pass `-verbose:class`
in the Java CLI.
Yes that is why I ask
On Mon, 20 May 2024 09:50:17 GMT, Jens Lidestrom wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add benchmarks for memoized IntFunction and Function
>> - Add benchmark for memoized supplier
>
> src/java.base/sha
Hi David,
> How did you try to intercept them? Hidden classes are not "loaded" in
the normal sense so won't trigger class load events.
I could not intercept them. I only see them when I pass `-verbose:class` in the
Java CLI.
I also couldn't intercept them using JVMTI Class File Load
Hook
On Mon, 20 May 2024 10:11:26 GMT, David Holmes wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691:
>
>> 689: * @throws
On Wed, 17 Apr 2024 12:37:01 GMT, Yudi Zheng wrote:
>> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
>> aarch64 and riscv but `zlen` is still passed in a register.
>>
>> https://github.com/openjdk/jdk/blob/870a6127cf54264c691f7322d775b202705c3bfa/src/hotspot/cpu/aarch
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas
wrote:
>> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
>> deprecated warnings. Testing non-generational ZGC requires the use of a
>> deprecated option.
>
> Axel Boldt-Christmas has updated the pull request incremen
On Fri, 17 May 2024 09:31:33 GMT, Per Minborg wrote:
>> # Stable Values & Collections (Internal)
>>
>> > src="https://github.com/openjdk/jdk/assets/7457876/db4b22a1-af87-4914-adac-b05a87e7cb42";
>> width=20% height=20%>
>>
>> ## Summary
>> This PR proposes to introduce an internal _Stable Valu
On Fri, 17 May 2024 23:42:17 GMT, Paul Sandoz wrote:
> Separately, we might be missing a few long argument accepting guard methods
> for simpler cases as I suspect they are still focused more on int index types.
Not sure I understand what guard methods you are referring to here?
-
On Wed, 15 May 2024 09:39:16 GMT, serhiysachkov wrote:
> Add specific regression tests for Calendar.roll() method to explicitly
> various leap year test scenarios. This is inspired by the ambiguity which
> occurred in leap year unaware test creation as in case with Calendar.add() in
> swing co
Parsing of a specifically corrupted class file cause unexpected
`ArrayIndexOutOfBoundsException` during label inflation.
This patch checks the valid range and throws expected
`IllegalArgumentException` instead.
Relevant test is added.
Please review.
Thanks,
Adam
-
Commit messages:
On Fri, 26 Apr 2024 14:06:02 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this simple patch?
> Some index check in Byte/ShortVector.fromArray/fromArray0Template seems not
> necessary, could be removed.
> Thanks
@PaulSandoz who would be a good person to give a review on this one? It's no
Class-File API `ClassRemapper` component suppose to remap all classes
referenced in a class file.
Actual implementation missed remapping of bootstrap methods referenced from
`invokedynamic` instructions.
This patch fixes the remapping and adds relevant test.
Please review.
Thanks,
Adam
---
On Mon, 20 May 2024 07:25:12 GMT, Axel Boldt-Christmas
wrote:
>> Improve ` java/util/logging/LoggingDeadlock2.java` stderr parsing by
>> ignoring deprecated warnings. Testing non-generational ZGC requires the use
>> of a deprecated option.
>
> Axel Boldt-Christmas has updated the pull request
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas
wrote:
>> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
>> deprecated warnings. Testing non-generational ZGC requires the use of a
>> deprecated option.
>
> Axel Boldt-Christmas has updated the pull request incremen
> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
> deprecated warnings. Testing non-generational ZGC requires the use of a
> deprecated option.
Axel Boldt-Christmas has updated the pull request incrementally with one
additional commit since the last revision:
Update co
On Mon, 20 May 2024 07:24:16 GMT, Axel Boldt-Christmas
wrote:
>> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
>> deprecated warnings. Testing non-generational ZGC requires the use of a
>> deprecated option.
>
> Axel Boldt-Christmas has updated the pull request incremen
> Improve ` java/util/logging/LoggingDeadlock2.java` stderr parsing by ignoring
> deprecated warnings. Testing non-generational ZGC requires the use of a
> deprecated option.
Axel Boldt-Christmas has updated the pull request incrementally with one
additional commit since the last revision:
U
On Mon, 20 May 2024 07:22:49 GMT, Axel Boldt-Christmas
wrote:
>> Improve ` java/util/logging/LoggingDeadlock2.java` stderr parsing by
>> ignoring deprecated warnings. Testing non-generational ZGC requires the use
>> of a deprecated option.
>
> Axel Boldt-Christmas has updated the pull request
On Mon, 20 May 2024 06:41:45 GMT, Axel Boldt-Christmas
wrote:
> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
> deprecated warnings. Testing non-generational ZGC requires the use of a
> deprecated option.
Hello Axel, the change looks OK to me. I was going to suggest
`
On Sun, 19 May 2024 05:01:32 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from any
On Mon, 20 May 2024 06:42:19 GMT, Axel Boldt-Christmas
wrote:
> Improve ` java/util/logging/LoggingDeadlock2.java` stderr parsing by ignoring
> deprecated warnings. Testing non-generational ZGC requires the use of a
> deprecated option.
The change looks OK to me. The copyright year on the fil
72 matches
Mail list logo