On Fri, 3 Nov 2023 14:03:02 GMT, Chen Liang wrote:
> Please review a patch that migrates `Class::getEnclosingMethod` and
> `Class::getEnclosingConstructor`'s descriptor parsing from old generic
> utilities to more simple utilities from java.lang.invoke implementation. This
> will help migrate
On Wed, 15 May 2024 19:18:02 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> test/jdk/java/lang/StringBuffer/IndexOf.java line 40:
>
>> 38: privat
On Tue, 14 May 2024 00:38:30 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1178:
>
>> 11
On Tue, 14 May 2024 18:38:38 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1784:
>
>> 17
On Fri, 17 May 2024 22:40:50 GMT, Sandhya Viswanathan
wrote:
>> The entry code switches Windows calling convention into Linux calling
>> convention by moving/saving registers, which are properly restored on
>> function exit. This makes register tracking easier.
>
> I don't see the place where
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Thu, 16 May 2024 14:37:15 GMT, Maurizio Cimadamore
wrote:
>> When creating a nested memory access var handle, we ensure that the segment
>> is accessed at the correct alignment for the root layout being accessed. But
>> we do not ensure that the segment has at least the size of the accessed
On Fri, 17 May 2024 21:57:00 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from any
On Thu, 16 May 2024 17:08:21 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 238:
>>
>>> 236: const Register needle = rdx;
>>> 237: const Register needle_len = rcx;
>>> 238:
>>
>> This is the calling convention on Linux. How is windows plat
On Thu, 16 May 2024 20:22:40 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1510:
>>
>>> 1508: compare_big_haystack_to_needle(sizeKnown, size,
>>> NUMBER_OF_NEEDLE_BYTES_TO_COMPARE, loop_top, hsPtrRet, hsLength,
>>> 1509:
On Fri, 17 May 2024 21:16:47 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> Please review this PR which corrects an edge case bug for
> java.text.DecimalFormat that causes incorrect parsing results for strings
> with very large exponent values.
>
> When parsing values with large exponents, if the value of the exponent
> exceeds `Integer.MAX_VALUE`, the parsed value
On Fri, 17 May 2024 21:16:47 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> Add two sample configuration files:
>
> jaxp-strict.properties: used to set strict configuration, stricter than
> jaxp.properties in previous versions such as JDK 22
>
>> jaxp-compat.properties: used to regain compatibility from any more
>> restricted configuration than previous versions
On Thu, 16 May 2024 22:20:39 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from any
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> thrpt3 6443.934 ± 6.491 ops/s
> SignatureBench.ECDSA.
On Fri, 17 May 2024 18:04:02 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-05-16. Locale tests pass as expected after update.
>
> Associated announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/20
On Tue, 7 May 2024 22:23:48 GMT, Jonathan Gibbons wrote:
> With the advent of JEP 467, `///` comments may be treated as documentation
> comments, and may be subject to the recently new `javac` warning about
> "dangling doc comments" in unexpected places.
>
> In keeping with the policy to keep
On Wed, 15 May 2024 09:39:16 GMT, serhiysachkov wrote:
> Add specific regression tests for Calendar.roll() method to explicitly
> various leap year test scenarios. This is inspired by the ambiguity which
> occurred in leap year unaware test creation as in case with Calendar.add() in
> swing co
On Tue, 7 May 2024 22:23:48 GMT, Jonathan Gibbons wrote:
> With the advent of JEP 467, `///` comments may be treated as documentation
> comments, and may be subject to the recently new `javac` warning about
> "dangling doc comments" in unexpected places.
>
> In keeping with the policy to keep
With the advent of JEP 467, `///` comments may be treated as documentation
comments, and may be subject to the recently new `javac` warning about
"dangling doc comments" in unexpected places.
In keeping with the policy to keep the `java.base` module free of all `javac`
warnings, this patch prop
On Thu, 16 May 2024 17:44:22 GMT, Ioi Lam wrote:
>> JavacBench is a test program that compiles 90 Java source files. It uses a
>> fair amount of invokedynamic callsites, so it's good for testing CDS support
>> for indy and lambda expressions.
>>
>> This test was first integrated into the
>> [
On Fri, 17 May 2024 18:04:02 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-05-16. Locale tests pass as expected after update.
>
> Associated announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/20
> The issue reported a ClassCastException "cannot assign instance of
> java.util.CollSer to field of type java.util.Map"
> while deserializing an object referring to an immutable Map that contained a
> reference to a class that was not available.
> Immutable Collections such as Map utilize a seri
Please review this PR which is a trivial update to the IANA sub tag registry to
version 2024-05-16. Locale tests pass as expected after update.
Associated announcement ->
https://mm.icann.org/pipermail/ietf-languages-announcements/2024-May/91.html
-
Commit messages:
- init
Ch
On Wed, 1 May 2024 18:43:21 GMT, Roger Riggs wrote:
> The issue reported a ClassCastException "cannot assign instance of
> java.util.CollSer to field of type java.util.Map"
> while deserializing an object referring to an immutable Map that contained a
> reference to a class that was not availab
On Thu, 16 May 2024 21:18:04 GMT, Stuart Marks wrote:
>> The issue reported a ClassCastException "cannot assign instance of
>> java.util.CollSer to field of type java.util.Map"
>> while deserializing an object referring to an immutable Map that contained a
>> reference to a class that was not a
On Fri, 17 May 2024 13:49:44 GMT, Doug Lea wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moving the memory leak test for SynchronousQueue into its own test and
>> runs only for JDK20+, using VirtualThreads
>
> S
On Thu, 16 May 2024 23:21:36 GMT, Sandhya Viswanathan
wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> whitespace
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_poly_mont.cpp line 168:
>
>> 166: XMMRegister
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> thrpt3 6443.934 ± 6.491 ops/s
> SignatureBench.ECDSA.
On Fri, 17 May 2024 15:54:04 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyrights
>
> src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 630:
>
>> 628: *
On Thu, 16 May 2024 14:37:15 GMT, Maurizio Cimadamore
wrote:
>> When creating a nested memory access var handle, we ensure that the segment
>> is accessed at the correct alignment for the root layout being accessed. But
>> we do not ensure that the segment has at least the size of the accessed
On Sun, 5 May 2024 15:22:15 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest releas
On Fri, 17 May 2024 08:28:15 GMT, Raffaello Giulietti
wrote:
>> All random number generator algorithms are implemented in module
>> `java.base`. The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory`
>> is no longer needed.
>
> Raffaello Giulietti has updated the pull request increment
On Thu, 16 May 2024 13:23:14 GMT, Raffaello Giulietti
wrote:
>> Yes, I thought about this the other day but decided for a bit more
>> conservative approach, relying on the annotation.
>>
>> But I agree that, since the meta-information now resides in
>> `RandomGeneratorProperties`, we might "m
On Fri, 17 May 2024 13:19:19 GMT, Viktor Klang wrote:
>> Local testing seems to indicate that this fix (which mirrors what's done in
>> the FIFO mode) addresses the problem.
>>
>> But with that said, I haven't come up with a decent way of adding some form
>> of regression test. Suggestions are
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
> the use of JNI in the following ways:
>
> * `System::load` and `System::loadLibrary` are now restricted methods
> * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods
> * binding a JNI `native` metho
On Thu, 16 May 2024 18:39:57 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add note on --illegal-native-access default value in the launcher help
>
> src/java.base/share/classes/java/lang
> Local testing seems to indicate that this fix (which mirrors what's done in
> the FIFO mode) addresses the problem.
>
> But with that said, I haven't come up with a decent way of adding some form
> of regression test. Suggestions are most welcome. /cc @DougLea
Viktor Klang has updated the pul
On Fri, 17 May 2024 11:52:12 GMT, Doug Lea wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding a leak detection test for SynchronousQueue
>
> Looks good; thanks. I don't know why I left out this check in a case
On Fri, 17 May 2024 05:51:31 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove jaxp-compat.properties from the list
>
> make/modules/java.xml/Copy.gmk line 37:
>
>> 35: JAXPPROPFILE_TARGET_FILES
On Thu, 16 May 2024 22:20:39 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from any
On Fri, 17 May 2024 08:28:51 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java
>> line 308:
>>
>>> 306: 0;
>>> 307: default ->
>>> 308: -1;
>>
>> I recommend we explicitly return -1 to ski
> ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only
> bytecode-level class verification.
> This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with
> additional class checks inspired by
> `hotspot/share/classfile/classFileParser.cpp`.
>
> Also new `Verifie
On Sat, 11 May 2024 19:35:33 GMT, Chen Liang wrote:
> Summary of the changes:
> - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps;
> they are exclusively used by jdeps in sources, and they are not used in any
> tests too. This will ease the removal of `com.sun.tools.clas
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced by CF API-based ne
On Fri, 17 May 2024 11:39:32 GMT, Viktor Klang wrote:
>> Local testing seems to indicate that this fix (which mirrors what's done in
>> the FIFO mode) addresses the problem.
>>
>> But with that said, I haven't come up with a decent way of adding some form
>> of regression test. Suggestions are
Hi Chen,
> java.lang.invoke.LambdaForm$MH/0x0200cc000400
I do see this as output when I pass -verbose:class. However, based on my
experiments, I have seen that neither an agent passed via 'javaagent' nor an
agent passed via 'agentpath' is able to intercept this hidden class.
Also, I was a
On Fri, 17 May 2024 11:35:55 GMT, Viktor Klang wrote:
>> Local testing seems to indicate that this fix (which mirrors what's done in
>> the FIFO mode) addresses the problem.
>>
>> But with that said, I haven't come up with a decent way of adding some form
>> of regression test. Suggestions are
> Local testing seems to indicate that this fix (which mirrors what's done in
> the FIFO mode) addresses the problem.
>
> But with that said, I haven't come up with a decent way of adding some form
> of regression test. Suggestions are most welcome. /cc @DougLea
Viktor Klang has updated the pul
On Sun, 12 May 2024 02:42:32 GMT, Chen Liang wrote:
>> Summary of the changes:
>> - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps;
>> they are exclusively used by jdeps in sources, and they are not used in any
>> tests too. This will ease the removal of `com.sun.tools.
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced by CF API-based ne
Hi Aman,
For `-verbose:class`, it's a JVM argument instead of a program argument; so
when you run a java program like `java Main`, you should call it as `java
-verbose:class Main`.
When done correctly, you should see hidden class outputs like:
[0.032s][info][class,load]
java.lang.invoke.LambdaForm$
On Mon, 6 May 2024 14:39:08 GMT, Claes Redestad wrote:
> This PR suggests refactoring the implementation classes of java.lang.constant
> into a new package jdk.internal.constant to enable sharing some trusted
> static factory methods with users elsewhere in java.base, such as
> java.lang.invok
On Wed, 15 May 2024 11:17:42 GMT, Claes Redestad wrote:
>> This PR suggests refactoring the implementation classes of
>> java.lang.constant into a new package jdk.internal.constant to enable
>> sharing some trusted static factory methods with users elsewhere in
>> java.base, such as java.lang.
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
Hi Roger,
Do you have ideas on how to intercept them? My javaagent is not able to nor a
JVMTI agent passed using `agentpath` option. It also does not seem to show up
in logs when I pass `-verbose:class`.
Also, what do you think of renaming the proxy classes as suggested below?
Regards,
Aman
On Fri, 17 May 2024 09:31:33 GMT, Per Minborg wrote:
>> # Stable Values & Collections (Internal)
>>
>> ## Summary
>> This PR proposes to introduce an internal _Stable Values & Collections_ API,
>> which provides immutable value holders where elements are initialized _at
>> most once_. Stable V
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
> # Stable Values & Collections (Internal)
>
> ## Summary
> This PR proposes to introduce an internal _Stable Values & Collections_ API,
> which provides immutable value holders where elements are initialized _at
> most once_. Stable Values & Collections offer the performance and safety
> benef
On Mon, 13 May 2024 21:00:10 GMT, Stuart Marks wrote:
>>> If an event class is loaded before JFR is started, the event class needs to
>>> be retransformed, but if it is loaded later, we can add instrumentation on
>>> class load and avoid the retransformation. More happens when an event class
>
On Thu, 16 May 2024 12:10:46 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of a change that moves the jdk.FileRead and
>> jdk.FileWrite events to java.base to remove the use of the ASM
>> instrumentation.
>>
>> Testing: jdk/jdk/jfr
>>
>> Thanks
>> Erik
>
> Erik Gahlin has update
On Sun, 12 May 2024 13:35:42 GMT, Erik Gahlin wrote:
> I guess it's not 100% safe if the JIT decides to store the read value
> elsewhere over several event checks, but it seems unlikely. Event settings
> checks (i.e., Event::isEnabled()) have always used plain reads, so it is not
> more unreli
On Thu, 16 May 2024 15:06:45 GMT, Viktor Klang wrote:
>> Local testing seems to indicate that this fix (which mirrors what's done in
>> the FIFO mode) addresses the problem.
>>
>> But with that said, I haven't come up with a decent way of adding some form
>> of regression test. Suggestions are
On Mon, 29 Apr 2024 14:45:07 GMT, Joachim Kern wrote:
> Since ~ end of March, after
> [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131),
> tools/launcher/JliLaunchTest.java fails on AIX. Failure is :
>
> stdout: [];
> stderr: [Error: could not find libjava.so
> Error: Could not find
On Wed, 15 May 2024 11:34:37 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied the suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java
>
> All random number generator algorithms are implemented in module `java.base`.
> The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory` is no longer
> needed.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
SecureRan
> # Stable Values & Collections (Internal)
>
> ## Summary
> This PR proposes to introduce an internal _Stable Values & Collections_ API,
> which provides immutable value holders where elements are initialized _at
> most once_. Stable Values & Collections offer the performance and safety
> benef
On Wed, 15 May 2024 11:17:42 GMT, Claes Redestad wrote:
>> This PR suggests refactoring the implementation classes of
>> java.lang.constant into a new package jdk.internal.constant to enable
>> sharing some trusted static factory methods with users elsewhere in
>> java.base, such as java.lang.
> # Stable Values & Collections (Internal)
>
> ## Summary
> This PR proposes to introduce an internal _Stable Values & Collections_ API,
> which provides immutable value holders where elements are initialized _at
> most once_. Stable Values & Collections offer the performance and safety
> benef
On Sun, 12 May 2024 02:42:32 GMT, Chen Liang wrote:
>> Summary of the changes:
>> - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps;
>> they are exclusively used by jdeps in sources, and they are not used in any
>> tests too. This will ease the removal of `com.sun.tools.
73 matches
Mail list logo
