Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v3]

2024-01-07 Thread Jatin Bhateja
On Fri, 5 Jan 2024 10:02:28 GMT, Emanuel Peter wrote: > Thanks for the updates! > > One more idea: Your AVX2 solution has a lot of cost for converting the mask > to a permutation. Might it make sense to split this off into a separate > vector-node, so that it can float out of a loop if the mas

Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v4]

2024-01-07 Thread Jatin Bhateja
> Hi, > > Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only > targets. > Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2 > instruction set. > These are very frequently used APIs in columnar database filter operation. > > Implementation uses a

Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v2]

2024-01-07 Thread Jatin Bhateja
On Fri, 5 Jan 2024 09:45:11 GMT, Emanuel Peter wrote: > You are using `VectorMask pred = VectorMask.fromLong(ispecies, > maskctr++);`. That basically systematically iterates over all masks, which is > nice for a correctness test. But that would use different density inside one > test run, righ

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2024-01-07 Thread Chen Liang
On Wed, 3 Jan 2024 12:25:29 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 737: >> >>> 735: private void generateMethod(ClassBuilder clb, ClassEntry >>> className) { >>> 736: var cp = clb.constantPool(); >>> 737:

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v7]

2024-01-07 Thread Chen Liang
On Wed, 3 Jan 2024 12:36:26 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions