> The testcase requires root permissions.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Fix gtest testcases compilation errors
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17198/files
- new: https://git.ope
On Sat, 23 Dec 2023 13:01:09 GMT, Markus KARG wrote:
>Typically it was sufficient to document the JMH results before and after a PR
>just once (not dynamically in the form of a test).
The problem with "results before and after a PR just once" is those benchmarks
will not automatically fail the
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
On Sat, 23 Dec 2023 19:11:35 GMT, Sergey Tsypanov wrote:
>> test/jdk/java/io/BufferedInputStream/TransferToTrusted.java line 83:
>>
>>> 81: var internalBuffer =
>>> bis.getClass().getDeclaredField("buf");
>>> 82: internalBuffer.setAccessible(true);
>>> 83:
On Sat, 23 Dec 2023 15:02:28 GMT, Vladimir Sitnikov
wrote:
>> Why do you want to put *that* in a test case at all? So far I did not come
>> across performance-based *tests* (only *benchmarks*), i. e. nobody ever
>> requested that from me in any of my NIO optimizations. Typically it was
>> suf
On Fri, 22 Dec 2023 15:08:33 GMT, Markus KARG wrote:
> IMHO the trigger for this PR was sparing time
That is fair. Do you know how one could create a reliable test for performance
that would fail without the fix and succeed with the fix?
I think the allocation is a reasonable proxy for the dur
On Sat, 23 Dec 2023 23:18:40 GMT, Markus KARG wrote:
>> Yeah, but how could I intercept the argument of OutputStream.write() and
>> check it's identity?
>
> As I wrote earlier today to Vladimir (see above) I actually do not see a
> solution for this, frankly spoken, as the interceptor would not
On Sat, 23 Dec 2023 13:08:06 GMT, Markus KARG wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8320971: Fix test
>
> test/jdk/java/io/BufferedInputStream/TransferToTrusted.java line 83:
>
>> 81:
On Fri, 22 Dec 2023 16:25:29 GMT, Vladimir Sitnikov
wrote:
>> IMHO the trigger for this PR was sparing *time*, not necessarily sparing
>> *bytes* (the default buffer size is just 8K); the latter certainly is a nice
>> and beneficial side effect. But I may be wrong here, then the original
>> c
On Thu, 28 Dec 2023 15:06:47 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1b
The testcase requires root permissions.
-
Commit messages:
- 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not
detected
- 4c556a78:
Changes: https://git.openjdk.org/jdk/pull/17198/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17198&range=00
Is
11 matches
Mail list logo
