Re: RFR: 8320348: java.io.File.getAbsolutePath fails if working directory is not on drive C

2023-11-19 Thread Matthias Baesken
On Sat, 18 Nov 2023 12:30:18 GMT, Matthias Baesken wrote: > > @MBaesken I would appreciate it if you would try out this proposed change > > to see whether it fixes the problem that you reported. Thanks! > > Hi Brian, I added your patch to our tests. After adding the patch, the errors seen befor

Re: RFR: 8320348: java.io.File.getAbsolutePath fails if working directory is not on drive C

2023-11-19 Thread Matthias Baesken
On Fri, 17 Nov 2023 21:51:06 GMT, Brian Burkhalter wrote: > The method `windowsDriveRelative` of the test `java/io/File/GetAbsolutePath` > was incorrectly translated from its previous version to the current JUnit 5 > version. Marked as reviewed by mbaesken (Reviewer). - PR Review

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy [v4]

2023-11-19 Thread Tobias Hartmann
On Thu, 16 Nov 2023 21:26:47 GMT, Steve Dohrmann wrote: >> Below is baseline data collected using a modified version of the >> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug >> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake >> i7-1185G7, whic

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy [v4]

2023-11-19 Thread Tobias Hartmann
On Thu, 16 Nov 2023 21:26:47 GMT, Steve Dohrmann wrote: >> Below is baseline data collected using a modified version of the >> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug >> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake >> i7-1185G7, whic

Re: RFR: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout [v4]

2023-11-19 Thread Prasanta Sadhukhan
On Wed, 25 Oct 2023 23:42:08 GMT, Phil Race wrote: >> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > indentation src/java.desktop/share/classes/sun/font/HB

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v7]

2023-11-19 Thread Jatin Bhateja
On Mon, 20 Nov 2023 01:34:57 GMT, Xiaohong Gong wrote: > > > BTW, I have two questions: > > > > > > 1. An intrinsic which should accept the vector as index like non-subword > > > gather is more benefical in real applications. See: [8287289: > > > Gather/Scatter with Index Vector  > > > panama-

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v8]

2023-11-19 Thread Roger Riggs
On Sun, 19 Nov 2023 02:19:52 GMT, Shaojin Wen wrote: >> `JapaneseChronology` is not extending `IsoChronology`, and that is the gist >> of the change I suggested. > > I added the testcase of IsoChronology and it also passed. The distinction is pretty subtle, I was referring to the `Chronology.i

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-19 Thread Xiaohong Gong
On Thu, 16 Nov 2023 13:00:03 GMT, Magnus Ihse Bursie wrote: >> Xiaohong Gong has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v7]

2023-11-19 Thread Xiaohong Gong
On Fri, 17 Nov 2023 06:06:16 GMT, Jatin Bhateja wrote: > > BTW, I have two questions: > > > > 1. An intrinsic which should accept the vector as index like non-subword > > gather is more benefical in real applications. See: [8287289: > > Gather/Scatter with Index Vector  > > panama-vector#201](

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > remove J2SE directory; add note explaining how DTDs are resolved Tests: Tier 1-3 and JCK pass

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
On Sun, 19 Nov 2023 08:46:30 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove J2SE directory; add note explaining how DTDs are resolved > > src/java.xml/share/classes/module-info.java line 910:

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
On Sun, 19 Nov 2023 08:45:29 GMT, Alan Bateman wrote: >> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line >> 34: >> >>> 32: >>> 33: http://java.sun.com/dtd/preferences.dtd"; >>> uri="J2SE/preferences.dtd"/> >>> 34: http://java.sun.com/dtd/properti

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]

2023-11-19 Thread Joe Wang
> Implement the built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: remove J2SE directory; add note explaining how DTDs are resolved - Changes: - all: https://git.openjdk.org/jdk/pull/16719/files - new: htt

Withdrawn: 8315999: Improve Date toString performance

2023-11-19 Thread duke
On Mon, 11 Sep 2023 12:12:17 GMT, Shaojin Wen wrote: > improve date toString performance, includes: > > java.util.Date.toString > java.util.Date.toGMTString > java.time.Instant.toString > java.time.LocalDate.toString > java.time.LocalDateTime.toString > java.time.LocalTime.toString This pull re

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v26]

2023-11-19 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull re

irk character set (Birke Heeren)

2023-11-19 Thread Birke Heeren
/* * when the character irk is detected, the language irk is present * */ public enum Irk { IRK, END_IRK, HASH, END_HASH, COLON, ARRAY, END_ARRAY, QUOTE, END_QUOTE, COMMA; public static String is_irk = " i**irk0"; public static String is_end_irk = " i**irk1"; public static String is

RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly

2023-11-19 Thread Doug Lea
This update cascades timeouts to trim subsequent workers after the first keepAlive inactive period. - Commit messages: - Support cascading idle timeouts Changes: https://git.openjdk.org/jdk/pull/16725/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16725&range=00 Issue:

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v25]

2023-11-19 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull re

Re: RFE: support safely wrapping restricted FFM calls

2023-11-19 Thread Kasper Nielsen
Hi Rob, In that case maybe just have an interface users of your library must implement with all the relevant caller sensitive methods? And then require the user to specify an instance whenever they call into your library? If you need to set up some static data structures this would probably not be

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module

2023-11-19 Thread Alan Bateman
On Sun, 19 Nov 2023 08:44:01 GMT, Alan Bateman wrote: >> Implement the built-in Catalog. > > src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 34: > >> 32: >> 33: http://java.sun.com/dtd/preferences.dtd"; >> uri="J2SE/preferences.dtd"/> >> 34: http:

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module

2023-11-19 Thread Alan Bateman
On Fri, 17 Nov 2023 20:22:40 GMT, Joe Wang wrote: > Implement the built-in Catalog. src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 34: > 32: > 33: http://java.sun.com/dtd/preferences.dtd"; > uri="J2SE/preferences.dtd"/> > 34: http://java.sun.com