RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts

2023-11-14 Thread Eric Liu
Vector API defines zero-extend operations [1], which are going to be intrinsified and generated to `VectorUCastNode` by C2. This patch adds backend implementation for `VectorUCastNode` on AArch64. The micro benchmark shows significant performance improvement. In my test machine (SVE, 256-bit),

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v7]

2023-11-14 Thread Viktor Klang
On Tue, 14 Nov 2023 09:48:13 GMT, Rémi Forax wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing last review feedback > > Hello, > the relation between a stateless gatherer (default initializer) and the > d

Re: RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v10]

2023-11-14 Thread Jaikiran Pai
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote: >> Please review this PR which speeds up TestTooManyEntries and clarifies its >> purpose: >> >> - The name 'TestTooManyEntries' does not clearly convey the purpose of the >> test. What is tested is the validation that the total CEN size f

Re: RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v10]

2023-11-14 Thread Jaikiran Pai
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote: >> Please review this PR which speeds up TestTooManyEntries and clarifies its >> purpose: >> >> - The name 'TestTooManyEntries' does not clearly convey the purpose of the >> test. What is tested is the validation that the total CEN size f

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags [v2]

2023-11-14 Thread Mandy Chung
> This PR includes test fixes for the following issues: > > 8319567: Update java/lang/invoke tests to support vm flags > 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > to accept vm flags > 8319672: Several classloader tests ignore VM flags > 8319676: A couple of jdk

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags [v2]

2023-11-14 Thread Mandy Chung
On Wed, 15 Nov 2023 00:17:56 GMT, Jorn Vernee wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review feedback > > test/jdk/java/lang/ClassLoader/getResource/GetResource.java line 166: > >> 164: Map env = pb

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags

2023-11-14 Thread Mandy Chung
On Wed, 15 Nov 2023 00:31:24 GMT, Jorn Vernee wrote: >> This PR includes test fixes for the following issues: >> >> 8319567: Update java/lang/invoke tests to support vm flags >> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> to accept vm flags >> 8319672: Several

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v7]

2023-11-14 Thread Jatin Bhateja
> Hi All, > > This patch optimizes sub-word gather operation for x86 targets with AVX2 and > AVX512 features. > > Following is the summary of changes:- > > 1) Intrinsify sub-word gather with high performance backend implementation > based on hybrid algorithm which initially partially unrolls s

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags

2023-11-14 Thread Mandy Chung
On Wed, 15 Nov 2023 00:45:45 GMT, Jorn Vernee wrote: >> This PR includes test fixes for the following issues: >> >> 8319567: Update java/lang/invoke tests to support vm flags >> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> to accept vm flags >> 8319672: Several

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-14 Thread Jatin Bhateja
On Wed, 15 Nov 2023 01:17:05 GMT, Steve Dohrmann wrote: >> @jatin-bhateja There is a sfence at line 781. > > Thanks, there is an store fence upon completion of the main loop for the > large size code: > > ![image](https://github.com/openjdk/jdk/assets/3858882/3bcea3c6-3bda-458c-aa7c-29ed6010cde

Integrated: 8319572: Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags

2023-11-14 Thread Sandhya Viswanathan
On Thu, 9 Nov 2023 22:08:06 GMT, Sandhya Viswanathan wrote: > Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags and thus marked > as flagless through @requires vm.flagless per > [JDK-8319566](https://bugs.openjdk.org/browse/JDK-8319566). This pull request has now been integrated.

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-14 Thread Steve Dohrmann
On Wed, 15 Nov 2023 00:39:29 GMT, Sandhya Viswanathan wrote: >> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 1186: >> >>> 1184: __ evmovntdquq(Address(dst, index, scale, offset + 0x40), xmm2, >>> Assembler::AVX_512bit); >>> 1185: __ evmovntdquq(Address(dst, index, scale,

Re: RFR: 8319572: Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags

2023-11-14 Thread Leonid Mesnik
On Thu, 9 Nov 2023 22:08:06 GMT, Sandhya Viswanathan wrote: > Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags and thus marked > as flagless through @requires vm.flagless per > [JDK-8319566](https://bugs.openjdk.org/browse/JDK-8319566). Marked as reviewed by lmesnik (Reviewer).

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-14 Thread Steve Dohrmann
On Tue, 14 Nov 2023 08:00:13 GMT, Jatin Bhateja wrote: >> Below is baseline data collected using a modified version of the >> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug >> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake >> i7-1185G7, which

Re: RFR: 8319572: Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags

2023-11-14 Thread Sandhya Viswanathan
On Wed, 15 Nov 2023 01:07:23 GMT, Leonid Mesnik wrote: >> Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags and thus >> marked as flagless through @requires vm.flagless per >> [JDK-8319566](https://bugs.openjdk.org/browse/JDK-8319566). > > Marked as reviewed by lmesnik (Reviewer).

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags

2023-11-14 Thread Jorn Vernee
On Tue, 14 Nov 2023 22:45:56 GMT, Mandy Chung wrote: > This PR includes test fixes for the following issues: > > 8319567: Update java/lang/invoke tests to support vm flags > 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > to accept vm flags > 8319672: Several class

Re: RFR: 8319572: Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags

2023-11-14 Thread Sandhya Viswanathan
On Thu, 9 Nov 2023 22:08:06 GMT, Sandhya Viswanathan wrote: > Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags and thus marked > as flagless through @requires vm.flagless per > [JDK-8319566](https://bugs.openjdk.org/browse/JDK-8319566). @lmesnik Could you please review this small

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags

2023-11-14 Thread Jorn Vernee
On Tue, 14 Nov 2023 22:45:56 GMT, Mandy Chung wrote: > This PR includes test fixes for the following issues: > > 8319567: Update java/lang/invoke tests to support vm flags > 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > to accept vm flags > 8319672: Several class

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-14 Thread Sandhya Viswanathan
On Tue, 14 Nov 2023 08:09:28 GMT, Jatin Bhateja wrote: >> Below is baseline data collected using a modified version of the >> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug >> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake >> i7-1185G7, which

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v14]

2023-11-14 Thread Jorn Vernee
On Mon, 13 Nov 2023 12:51:36 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and the

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v14]

2023-11-14 Thread Sergey Bylokhov
On Mon, 13 Nov 2023 12:51:36 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and the

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v14]

2023-11-14 Thread Jorn Vernee
On Tue, 14 Nov 2023 23:04:16 GMT, Sergey Bylokhov wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - Merge branch 'master' into AllowHeapNoLock >> - fix type and reformat doc in Linker >>

Integrated: JDK-8319628: DateFormat does not mention IllegalArgumentException for invalid style args

2023-11-14 Thread Justin Lu
On Sun, 12 Nov 2023 21:39:29 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868) > which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_ > static factory methods that have the _style_ parameter. This pull request has now bee

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v14]

2023-11-14 Thread Sergey Bylokhov
On Mon, 13 Nov 2023 12:51:36 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and the

RFR: 8319567: Update java/lang/invoke tests to support vm flags

2023-11-14 Thread Mandy Chung
This PR includes test fixes for the following issues: 8319567: Update java/lang/invoke tests to support vm flags 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags 8319672: Several classloader tests ignore VM flags 8319676: A couple of jdk/modules/incub

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Lance Andersen
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by lance

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Iris Clark
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by iris

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Justin Lu
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by jlu (

Re: RFR: 8303866: Allow ZipInputStream.readEnd to parse small Zip64 ZIP files [v6]

2023-11-14 Thread Lance Andersen
On Wed, 8 Nov 2023 13:45:14 GMT, Eirik Bjorsnos wrote: >> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the >> number of compressed or uncompressed bytes read from the inflater is larger >> than the Zip64 magic value. >> >> While the ZIP format mandates that the data des

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Roger Riggs
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by rrigg

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Joe Wang
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by joehw

RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, long, float and double arrays)

2023-11-14 Thread Srinivas Vamsi Parasa
The goal is to develop faster sort routines for x86_64 CPUs by taking advantage of AVX2 instructions. This enhancement provides an order of magnitude speedup for Arrays.sort() using int, long, float and double arrays. For serial sort on random data, this PR shows upto ~7.5x improvement for 32-bi

Re: [External] : Re: Provide thread-safe and concurrent sequenced collections with insertion order?

2023-11-14 Thread Stuart Marks
Ah, so you want a concurrent cache! This is why it's important to talk about use cases. Turns out there are a lot of subtle issues here, and there has been a lot of work in this area outside the JDK. For example, a bit of searching turned up this Stack Overflow question [1]. The answers aren't p

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Naoto Sato
> Correcting the explanation of the `DateFormat.SHORT` constant. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: abbreviated/full clarification - Changes: - all: https://git.openjdk.org/jdk/pull/16645/files - new: http

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Naoto Sato
On Tue, 14 Nov 2023 18:14:45 GMT, Roger Riggs wrote: >> Thanks for the feedback, Joe. I think I would rather keep the description >> somewhat abstract, simply mentioning the formatted output is `SHORT` <= >> `MEDIUM` <= `LONG` <= `FULL` in length-wise. As it is noted in the previous >> sentenc

Re: instead of JSON => data language: irk

2023-11-14 Thread Daniel Jeliński
Hi Birke, You can find the unsubscribe button on the subscription management page here: https://mail.openjdk.org/mailman/listinfo/core-libs-dev Cheers, Daniel wt., 14 lis 2023 o 17:26 Birke Heeren napisał(a): > > please post the message: > > development of irk is my new goal > > watch at: https:/

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v3]

2023-11-14 Thread Roger Riggs
On Tue, 14 Nov 2023 17:14:06 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/DateFormat.java line 120: >> >>> 118: * result; from {@link #SHORT} to {@link #MEDIUM} to {@link #LONG} to >>> {@link #FULL}. The exact result depends >>> 119: * on the locale, but generally: >>> 120:

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v8]

2023-11-14 Thread Andrey Turbanov
On Tue, 14 Nov 2023 16:35:53 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Unpacking the rethrown exceptions from Gatherers.

Integrated: 8287843: File::getCanonicalFile doesn't work for \\?\C:\ style paths DOS device paths

2023-11-14 Thread Brian Burkhalter
On Wed, 6 Sep 2023 21:38:39 GMT, Brian Burkhalter wrote: > In the Windows implementation of java.io.File.getCanonicalPath, strip any > long path or UNC prefix before canonicalizing the remainder of the pathname. This pull request has now been integrated. Changeset: 12fce4b7 Author:Brian Bu

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v7]

2023-11-14 Thread Mandy Chung
On Tue, 14 Nov 2023 15:58:57 GMT, Severin Gehwolf wrote: > > The current implementation `--system-modules` re-applies for every jlink > > invocation since the transformation depends on the set of modules to be > > linked in the resulting image. > > Yes. The same is true for a run-time image ba

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Naoto Sato
On Tue, 14 Nov 2023 17:43:54 GMT, Justin Lu wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/text/DateFormat.java line 122: > >> 120: * {@link #SHORT} is

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v3]

2023-11-14 Thread Naoto Sato
> Correcting the explanation of the `DateFormat.SHORT` constant. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Further clarification - Changes: - all: https://git.openjdk.org/jdk/pull/16645/files - new: https://git.o

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Justin Lu
On Tue, 14 Nov 2023 17:16:59 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments src/java.base/share/classes/java/

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin >> >> This fix

Re: RFR: 8317834: java/lang/Thread/IsAlive.java timed out [v2]

2023-11-14 Thread Alan Bateman
On Tue, 14 Nov 2023 17:25:42 GMT, Darragh Clarke wrote: >> Currently the `IsAlive` test occasionally times out. >> >> This PR changes the timeout from `10` to `25` which I think is an adequate >> increase based on the failures I've seen. Though I'd be happy to change it >> to another value if

Re: RFR: 8317834: java/lang/Thread/IsAlive.java timed out [v2]

2023-11-14 Thread Darragh Clarke
> Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to > another value if someone thinks `25` isn't ideal. Darragh Clarke has updated th

Re: RFR: 8317834: java/lang/Thread/IsAlive.java timed out

2023-11-14 Thread Daniel Fuchs
On Tue, 14 Nov 2023 16:41:31 GMT, Darragh Clarke wrote: > Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to > another value if someo

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Naoto Sato
On Tue, 14 Nov 2023 01:41:15 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/text/DateFormat.java line 120: > >> 118: * result; from {@lin

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Naoto Sato
> Correcting the explanation of the `DateFormat.SHORT` constant. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflects review comments - Changes: - all: https://git.openjdk.org/jdk/pull/16645/files - new: https://gi

Integrated: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 12:02:11 GMT, Stewart X Addison wrote: > ~~I will force push to change ONLY the commit message once I get a bug > created - I am not currently an author. In draft until I do that.~~ Done > > FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin > > This fixes a b

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin >> >> This fix

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Aleksey Shipilev
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin >> >> This fix

Re: RFR: 8317834: java/lang/Thread/IsAlive.java timed out

2023-11-14 Thread Alan Bateman
On Tue, 14 Nov 2023 16:41:31 GMT, Darragh Clarke wrote: > Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to > another value if someo

RFR: 8317834: java/lang/Thread/IsAlive.java timed out

2023-11-14 Thread Darragh Clarke
Currently the `IsAlive` test occasionally times out. This PR changes the timeout from `10` to `25` which I think is an adequate increase based on the failures I've seen. Though I'd be happy to change it to another value if someone thinks `25` isn't ideal. - Commit messages: - bump

Re: RFR: 8319123: Implementation of JEP-461: Stream Gatherers (Preview) [v8]

2023-11-14 Thread Viktor Klang
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Unpacking the rethrown exceptions from Gatherers.mapConcurrent() - Changes: - all: https://git.open

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v8]

2023-11-14 Thread Viktor Klang
On Tue, 14 Nov 2023 16:35:53 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Unpacking the rethrown exceptions from Gatherers.

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v6]

2023-11-14 Thread Severin Gehwolf
On Mon, 13 Nov 2023 15:37:29 GMT, Severin Gehwolf wrote: > > A few very minor things that I jotted down while looking at the current > > proposal: > > ``` > > * Adding a resource to serve as a marker that indicates it was created > > without the packaged modules is fine. I think the name should

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v4]

2023-11-14 Thread Roger Riggs
> Strings, after construction, are immutable but may be constructed from > mutable arrays of bytes, characters, or integers. > The string constructors should guard against the effects of mutating the > arrays during construction that might invalidate internal invariants for the > correct behavio

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v4]

2023-11-14 Thread Roger Riggs
On Tue, 14 Nov 2023 16:05:51 GMT, Roger Riggs wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction that migh

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v7]

2023-11-14 Thread Severin Gehwolf
On Tue, 14 Nov 2023 02:44:39 GMT, Mandy Chung wrote: > I did one pass through the changes. Thanks for the review! > Looks like the plugin author has to consider how it should work to support > linking without packaged modules. Yes, to some extent. > The current implementation `--system-modul

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v6]

2023-11-14 Thread Severin Gehwolf
On Tue, 14 Nov 2023 07:18:13 GMT, Alan Bateman wrote: > > It's not clear what you mean by that. Dropped from what? The CSR? Something > > else? The run-image based link needs the `--add-run-image-resources` plugin > > for it to work. > > I mean the list of plugins that are listed by --list-plu

RFR: JDK-8318175 : AIX PPC64: Handle alignment of double in structs

2023-11-14 Thread suchismith1993
1. use pragma directive to handle alignment. JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175) - Commit messages: - Remove trailing whitespaces - Handling alignment for double in AIX. Changes: https://git.openjdk.org/jdk/pull/16579/files Webrev: https://webrev

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v8]

2023-11-14 Thread Severin Gehwolf
> Please review this patch which adds a "jmodless" jlink mode to the JDK. > Fundamentally this patch adds an option to use `jlink` even though your JDK > install might not come with the packaged modules (directory `jmods`). This is > particularly useful to further reduce the size of a jlinked ru

Re: RFR: 8319123: Implementation of JEP-461: Stream Gatherers (Preview) [v7]

2023-11-14 Thread Remi Forax
- Original Message - > From: "Viktor Klang" > To: "core-libs-dev" > Sent: Tuesday, November 14, 2023 11:32:48 AM > Subject: Re: RFR: 8319123: Implementation of JEP-461: Stream Gatherers > (Preview) [v7] > On Tue, 14 Nov 2023 09:48:13 GMT, Rémi Forax wrote: > >> Hello, the relation

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-14 Thread Alan Bateman
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote: > Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin >> >> This fix

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Aleksey Shipilev
On Tue, 14 Nov 2023 13:10:50 GMT, Aleksey Shipilev wrote: >> Stewart X Addison has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Tue, 14 Nov 2023 13:10:50 GMT, Aleksey Shipilev wrote: >> Stewart X Addison has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-14 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull re

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Tue, 14 Nov 2023 13:10:50 GMT, Aleksey Shipilev wrote: > As a matter of course, please enable the GH testing and make sure the testing > passes. Go to https://github.com/sxa/jdk/actions, enable the workflows, then > trigger the workflow against your branch. Thanks - I had it on some of my o

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Aleksey Shipilev
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin >> >> This fix

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-14 Thread Alan Bateman
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote: >> The various Zip/Jar-file related Java APIs have some long-standing >> differences or peculiarities with respect to the ZIP-file specification or >> compared to other implementations which should be documented in the API-doc. >> Thi

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v6]

2023-11-14 Thread Jatin Bhateja
> Hi All, > > This patch optimizes sub-word gather operation for x86 targets with AVX2 and > AVX512 features. > > Following is the summary of changes:- > > 1) Intrinsify sub-word gather with high performance backend implementation > based on hybrid algorithm which initially partially unrolls s

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v14]

2023-11-14 Thread Martin Doerr
On Mon, 13 Nov 2023 12:51:36 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and the

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-14 Thread Magnus Ihse Bursie
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) It does beg the question though: Why is AIX not using dynamic loading of the standard library?

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-14 Thread Magnus Ihse Bursie
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) Okay, I checked the spec for `nativeLinker()`. * @implNote The libraries exposed by the {@

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-14 Thread Magnus Ihse Bursie
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) I've done another pass of reading through all comments and background. I think we're not even ne

Integrated: 8254693: Add Panama feature to pass heap segments to native code

2023-11-14 Thread Jorn Vernee
On Mon, 16 Oct 2023 10:19:17 GMT, Jorn Vernee wrote: > Add the ability to pass heap segments to native code. This requires using > `Linker.Option.critical(true)` as a linker option. It has the same > limitations as normal critical calls, namely: upcalls into Java are not > allowed, and the nat

Re: RFR: 8319123: Implementation of JEP-461: Stream Gatherers (Preview) [v7]

2023-11-14 Thread Viktor Klang
On Tue, 14 Nov 2023 09:48:13 GMT, Rémi Forax wrote: > Hello, the relation between a stateless gatherer (default initializer) and > the default combiner are not obvious to me. > > A default initializer means stateless and a default combiner means > sequential, so if i want the integrator of my

Re: RFR: 8319123: Implementation of JEP-461: Stream Gatherers (Preview) [v7]

2023-11-14 Thread Rémi Forax
On Tue, 14 Nov 2023 07:51:42 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing last review feedback Hello, the relat

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v3]

2023-11-14 Thread Martin Doerr
On Mon, 13 Nov 2023 20:42:00 GMT, Roger Riggs wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction that migh

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 21:18:59 GMT, Brian Burkhalter wrote: > Looks good. I verified that the test still builds and succeeds on Win64. I've also verified that it's ok on all three Windows platforms (x86, x64, aarch64) for JDK17 so should be good to go in here and be backported without problems.

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-14 Thread Jatin Bhateja
On Wed, 8 Nov 2023 23:23:48 GMT, Steve Dohrmann wrote: > Below is baseline data collected using a modified version of the > java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug > report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake > i7-1185G7, which doe

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-14 Thread Jatin Bhateja
On Wed, 8 Nov 2023 23:23:48 GMT, Steve Dohrmann wrote: > Below is baseline data collected using a modified version of the > java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug > report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake > i7-1185G7, which doe