On Thu, 19 Oct 2023 20:49:13 GMT, Maurizio Cimadamore
wrote:
>> The 21 iteration of the FFM API used to contain a method, namely
>> `ValueLayout::arrayElementVarHandle`. This var handle factory was useful
>> when accessing elements in a flat array of variable size.
>>
>> In 22, this method ha
On Thu, 19 Oct 2023 15:59:54 GMT, Claes Redestad wrote:
>> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
>> One idea to reduce this is to generate expression trees with fewer branches
>> by looking up and using the prefix-less `prepend` methods directly for cases
On Wed, 18 Oct 2023 18:13:38 GMT, Glavo wrote:
>> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>>
>> Reasons:
>>
>> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
>> creating a new shortcut can make writing shorter;
>> * Since all possible values
On Fri, 20 Oct 2023 04:23:22 GMT, Alexander Matveev
wrote:
>> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
>> CLI options to jpackage to provide signing identity directly to `codesign`
>> and `productbuild` tools as per CSR
>> [JDK-8316631](https://bugs.openjdk.
> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
> CLI options to jpackage to provide signing identity directly to `codesign`
> and `productbuild` tools as per CSR
> [JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631).
> - If `codesign` or `productbuild` fails
On Fri, 20 Oct 2023 02:29:15 GMT, Chen Liang wrote:
>> Please review a patch that renames `JavaLangAccess::xxNoRepl` to
>> `xxReportError` to explicitly indicate these APIs report encoding errors.
>>
>> The old "NoRepl" suffix presumably means "No Replacement", but it has been
>> misunderstood
> Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and
> `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to
> accurately describe these APIs. This also renames other associated methods.
>
> NoRepl means "no replication", which is not what these
On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Sat, 24 Jun 2023 06:42:18 GMT, Glavo wrote:
> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that can
> be used in many places to performance tuning.
>
> Currently they are implemented by `VarHandle`, so using them may have some
> impact on startup time.
>
> This PR r
> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
> tools/jpackage/linux/LinuxResourceTest.java.
> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
> But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still
> reappears. tools/jpackage/l
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't hesitate
On Thu, 19 Oct 2023 21:31:13 GMT, Justin Lu wrote:
> Please review this PR which adjusts the specification of
> `DateFormat.Field::getCalendarField` to conform to the implementation.
>
> `getCalendarField()` claims that it will return -1 if there is no
> corresponding `Calendar` constant.
>
>
On Fri, 29 Sep 2023 20:46:44 GMT, Justin Lu wrote:
> Please review this PR and which adjusts the pattern section of
> java.text.ChoiceFormat to specify the single quote behavior within a String
> pattern.
>
> The other Format classes that take a String pattern such as DecimalFormat,
> Compact
On Thu, 19 Oct 2023 15:28:54 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
> The 21 iteration of the FFM API used to contain a method, namely
> `ValueLayout::arrayElementVarHandle`. This var handle factory was useful when
> accessing elements in a flat array of variable size.
>
> In 22, this method has been removed because:
> * It was not general enough (it only worked
On Thu, 19 Oct 2023 12:58:39 GMT, Martin Doerr wrote:
>>> I wonder if the native_invoker_size_per_arg thing still works good enough.
>>> We may exceed the computed size, now, right?
>>
>> Good point. I'll have a look at enhancing the test we have for this.
>>
>> Intuitively, I think it will b
Please review this PR which adjusts the specification of
`DateFormat.Field::getCalendarField` to conform to the implementation.
`getCalendarField()` claims that it will return -1 if there is no corresponding
`Calendar` constant.
Although the built-in DateFormat.Fields with no associated `Calend
Hi Ramdas,
On a side note, please do not forward or copy e-mails from the
conformance-octla-private mailing list to other OpenJDK mailing lists,
since they may contain confidential information.
Instead, please start a fresh thread in the future describing the
specific concerns with specific
On Thu, 19 Oct 2023 16:52:53 GMT, Maurizio Cimadamore
wrote:
> The 21 iteration of the FFM API used to contain a method, namely
> `ValueLayout::arrayElementVarHandle`. This var handle factory was useful when
> accessing elements in a flat array of variable size.
>
> In 22, this method has bee
The 21 iteration of the FFM API used to contain a method, namely
`ValueLayout::arrayElementVarHandle`. This var handle factory was useful when
accessing elements in a flat array of variable size.
In 22, this method has been removed because:
* It was not general enough (it only worked with value
On Thu, 5 Oct 2023 16:23:03 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simplify some code in modules.cpp
>
> src/hotspot/share/classfile/modules.cpp line 597:
>
>> 595: MetaspaceShared::
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
This pull request has now been integrated.
Chan
On Thu, 19 Oct 2023 15:21:02 GMT, Jorn Vernee wrote:
>> Here is the patch for risc-v:
>> [riscv_panama_heap_segments.patch](https://github.com/openjdk/jdk/files/13043332/riscv_panama_heap_segments.patch)
>>
>> All `jdk_foreign` tests passed on linux-riscv with `-XX+VerifyOops
>> -XX:+VerifySta
On Thu, 19 Oct 2023 13:37:09 GMT, Lutz Schmidt wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add s390 support
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 100:
>
>> 98: Address offset_addr(callerSP
On Thu, 19 Oct 2023 15:21:02 GMT, Jorn Vernee wrote:
>> Here is the patch for risc-v:
>> [riscv_panama_heap_segments.patch](https://github.com/openjdk/jdk/files/13043332/riscv_panama_heap_segments.patch)
>>
>> All `jdk_foreign` tests passed on linux-riscv with `-XX+VerifyOops
>> -XX:+VerifySta
On Wed, 18 Oct 2023 23:56:17 GMT, Maurizio Cimadamore
wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 110:
>
>> 108:
>> 109: private static VarHandle getVarHandle(StructLayout struct, String
>> n
On Wed, 18 Oct 2023 17:35:58 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
On Thu, 19 Oct 2023 15:59:54 GMT, Claes Redestad wrote:
>> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
>> One idea to reduce this is to generate expression trees with fewer branches
>> by looking up and using the prefix-less `prepend` methods directly for cases
> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
> One idea to reduce this is to generate expression trees with fewer branches
> by looking up and using the prefix-less `prepend` methods directly for cases
> where constant is null/empty so that the prefixed prepender
> Add the ability to pass heap segments to native code. This requires using
> `Linker.Option.critical(true)` as a linker option. It has the same
> limitations as normal critical calls, namely: upcalls into Java are not
> allowed, and the native function should return relatively quickly. Heap
>
On Thu, 19 Oct 2023 13:40:55 GMT, Feilong Jiang wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add s390 support
>
> Here is the patch for risc-v:
> [riscv_panama_heap_segments.patch](https://github.com/openjdk/jdk
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
> the main module is specified. The module name will be stored in t
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
>
> Then I have manually modifi
On Tue, 17 Oct 2023 12:29:46 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>> "s/createJavaProcessBuilder(/createJavaProcessBu
On Thu, 2023-10-19 at 14:27 +0100, Alan Bateman wrote:
> > Could I please get some reviews on the CSR for a feature that would
> > allow runtime image-based jlinks (no need for the packaged modules -
> > jmods folder - being present)?
> >
> > https://bugs.openjdk.org/browse/JDK-8317420
> >
> > It
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because t
On Wed, 18 Oct 2023 17:04:52 GMT, Sidraya Jayagond
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add PPC impl
>> - add missing file
>
> Add s390x port from here
> [S390x_Panama_heap_segments.txt](https://githu
On Wed, 18 Oct 2023 17:38:24 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
On Wed, 18 Oct 2023 17:38:24 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>> 2.
On 19/10/2023 14:12, Severin Gehwolf wrote:
Hi,
Could I please get some reviews on the CSR for a feature that would
allow runtime image-based jlinks (no need for the packaged modules -
jmods folder - being present)?
https://bugs.openjdk.org/browse/JDK-8317420
It would be particularly helpful t
On Wed, 18 Oct 2023 17:37:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
Hi,
Could I please get some reviews on the CSR for a feature that would
allow runtime image-based jlinks (no need for the packaged modules -
jmods folder - being present)?
https://bugs.openjdk.org/browse/JDK-8317420
It would be particularly helpful to get consensus on the naming (it's
hard!) and
> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
> tools/jpackage/linux/LinuxResourceTest.java.
> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
> But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still
> reappears. tools/jpackage/l
On Wed, 18 Oct 2023 14:47:58 GMT, Jorn Vernee wrote:
> > I wonder if the native_invoker_size_per_arg thing still works good enough.
> > We may exceed the computed size, now, right?
>
> Good point. I'll have a look at enhancing the test we have for this.
>
> Intuitively, I think it will be okay
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Thu, 19 Oct 2023 12:22:29 GMT, Fei Yang wrote:
> Still good. You might want to correct the remaining typo.
Thanks for review!
-
PR Comment: https://git.openjdk.org/jdk/pull/16186#issuecomment-1770876188
On Thu, 19 Oct 2023 12:14:52 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
On Thu, 19 Oct 2023 12:14:52 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
On Thu, 19 Oct 2023 12:14:52 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Thu, 19 Oct 2023 11:38:57 GMT, Shaojin Wen wrote:
> In addition to #16244, will you submit a PR for this?
Once both #16244 and this has been integrated I want to revisit this. The
effect of changing `getBytes(byte[], int, byte)` might have disappeared with
#16244 since it better guarantees
On Wed, 18 Oct 2023 14:55:13 GMT, Roger Riggs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Corrected use of whitespace in text block.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil
On Thu, 19 Oct 2023 02:16:03 GMT, Chen Liang wrote:
>> Claes Redestad has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - dropLookupMode PRIVATE to ensure we don't accidentally use private methods
>> - Make all prepend methods package-pri
On Thu, 19 Oct 2023 11:39:24 GMT, Claes Redestad wrote:
>> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
>> One idea to reduce this is to generate expression trees with fewer branches
>> by looking up and using the prefix-less `prepend` methods directly for cases
> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
> One idea to reduce this is to generate expression trees with fewer branches
> by looking up and using the prefix-less `prepend` methods directly for cases
> where constant is null/empty so that the prefixed prepender
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Added indentation to generate the properly indented code.
Revert back to Formatter class from HexFormat class, so
On Wed, 18 Oct 2023 15:59:31 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use StringConcatFactory.makeConcatWithConstants
>
> I've opened up #16244 for review - thanks for helping with analysi
On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> als
On Fri, 6 Oct 2023 01:39:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634?
>
> The change in this commit introduces a new `exclude-modules` argument to the
> `dedup-
On Fri, 6 Oct 2023 02:22:52 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to implement the
>> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634?
>>
>> The change in this commit introduces a new `exclude-modules` argument to the
>> `d
On Thu, 19 Oct 2023 06:18:18 GMT, Per Minborg wrote:
> This PR suggests a fix for a failing test on platforms with big endian.
>
> The PR also contains a drive-by removal of an unused import.
This pull request has now been integrated.
Changeset: defc7e0f
Author:Per Minborg
URL:
htt
On Wed, 18 Oct 2023 15:59:31 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use StringConcatFactory.makeConcatWithConstants
>
> I've opened up #16244 for review - thanks for helping with analysi
On Fri, 6 Oct 2023 02:22:52 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to implement the
>> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634?
>>
>> The change in this commit introduces a new `exclude-modules` argument to the
>> `d
On Wed, 18 Oct 2023 09:45:53 GMT, Viktor Klang wrote:
> This PR corrects so that `opIsStateful()` is not invoked as a part of the
> java.util.stream.AbstractPipeline constructor—as `opIsStateful()` is intended
> to be overridden by subclasses, and as their own constructors have not run
> when
On Thu, 19 Oct 2023 06:18:18 GMT, Per Minborg wrote:
> This PR suggests a fix for a failing test on platforms with big endian.
>
> The PR also contains a drive-by removal of an unused import.
Test has passed. Thanks for fixing this so quickly!
-
Marked as reviewed by mdoerr (Revie
On Tue, 17 Oct 2023 17:31:30 GMT, Maurizio Cimadamore
wrote:
> This PR moves turns default methods in `MemorySegment` and `MemoryLayout`
> into ordinary abstract methods.
> These interfaces cannot be subclasses by developers (they are sealed), so
> there is no reson for having default methods
On Thu, 19 Oct 2023 06:18:18 GMT, Per Minborg wrote:
> This PR suggests a fix for a failing test on platforms with big endian.
>
> The PR also contains a drive-by removal of an unused import.
Marked as reviewed by mcimadamore (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pu
On Thu, 19 Oct 2023 06:18:18 GMT, Per Minborg wrote:
> This PR suggests a fix for a failing test on platforms with big endian.
>
> The PR also contains a drive-by removal of an unused import.
@TheRealMDoerr can you please check this?
-
PR Comment: https://git.openjdk.org/jdk/pull/
Removes a few unnecessary dereferences of `sourceStage`.
-
Commit messages:
- Avoiding unnecessary pointer-chasing in sourceStageSpliterator() and
avoiding a check-then-act in close()
Changes: https://git.openjdk.org/jdk/pull/16241/files
Webrev: https://webrevs.openjdk.org/?repo=j
On Wed, 18 Oct 2023 10:14:08 GMT, Viktor Klang wrote:
> Removes a few unnecessary dereferences of `sourceStage`.
Marked as reviewed by psandoz (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16241#pullrequestreview-1685995672
This PR corrects so that `opIsStateful()` is not invoked as a part of the
java.util.stream.AbstractPipeline constructor—as `opIsStateful()` is intended
to be overridden by subclasses, and as their own constructors have not run when
their superclass constructor runs, this means that `opIsStateful
On Wed, 18 Oct 2023 09:45:53 GMT, Viktor Klang wrote:
> This PR corrects so that `opIsStateful()` is not invoked as a part of the
> java.util.stream.AbstractPipeline constructor—as `opIsStateful()` is intended
> to be overridden by subclasses, and as their own constructors have not run
> when
On Wed, 18 Oct 2023 09:45:53 GMT, Viktor Klang wrote:
> This PR corrects so that `opIsStateful()` is not invoked as a part of the
> java.util.stream.AbstractPipeline constructor—as `opIsStateful()` is intended
> to be overridden by subclasses, and as their own constructors have not run
> when
On Wed, 18 Oct 2023 10:14:08 GMT, Viktor Klang wrote:
> Removes a few unnecessary dereferences of `sourceStage`.
@PaulSandoz Care to review this one? :)
-
PR Comment: https://git.openjdk.org/jdk/pull/16241#issuecomment-1768129782
On Tue, 17 Oct 2023 07:03:50 GMT, yaqsun wrote:
>> `%define _build_id_links none` must be added to a spec file in
>> LinuxResourceTest.java file. not on `rpmbuild` command line
>
>> `%define _build_id_links none` must be added to a spec file in
>> LinuxResourceTest.java file. not on `rpmbuild`
On Thu, 19 Oct 2023 07:25:38 GMT, Alan Bateman wrote:
> I assume it's "no replace", meaning it reports the error rather than use the
> coder's replacement value.
This revelation is too important; I might have to reevaluate my choices, for
many contributors have assumed that `NoRepl` was intend
> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
> tools/jpackage/linux/LinuxResourceTest.java.
> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
> But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still
> reappears. tools/jpackage/l
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because t
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because t
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because t
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote:
> NoRepl means "no replication", which is not what these APIs are for.
I assume it's "no replace", meaning it reports the error rather than use the
coder's replacement value.
I agree it could be renamed but I think look at CodingErrorAction
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote:
> Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and
> `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to
> accurately describe these APIs. This also renames other associated methods.
>
> N
On Wed, 18 Oct 2023 08:18:47 GMT, Matthias Baesken wrote:
> 8315026 adjusted and improved the describings comments already for AIX/Linux.
> But macOS was not adjusted.
This pull request has now been integrated.
Changeset: 47bb1a1c
Author:Matthias Baesken
URL:
https://git.openjdk.or
On Wed, 18 Oct 2023 08:18:47 GMT, Matthias Baesken wrote:
> 8315026 adjusted and improved the describings comments already for AIX/Linux.
> But macOS was not adjusted.
Hi Roger, thanks for the review !
-
PR Comment: https://git.openjdk.org/jdk/pull/16236#issuecomment-1770209550
On Tue, 17 Oct 2023 07:03:50 GMT, yaqsun wrote:
>> `%define _build_id_links none` must be added to a spec file in
>> LinuxResourceTest.java file. not on `rpmbuild` command line
>
>> `%define _build_id_links none` must be added to a spec file in
>> LinuxResourceTest.java file. not on `rpmbuild`
Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and
`getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to
accurately describe these APIs. This also renames other associated methods.
NoRepl means "no replication", which is not what these APIs are f
87 matches
Mail list logo
