On Mon, 18 Sep 2023 17:30:25 GMT, Daniel Jeliński wrote:
> WinHTTP functions are only used when an application:
> - uses DefaultProxySelector to resolve proxies, and
> - is run with -Djava.net.useSystemProxies=true
>
> In all other cases, loading winhttp.dll is a waste of resources.
>
> Verifie
On Mon, 18 Sep 2023 17:18:29 GMT, Roger Riggs wrote:
> > HexDecimal#DIGITS is a table with a size of 512 bytes. I think that in such
> > a table, when it needs to be used continuously, it is worthwhile to perform
> > table lookup operations.
>
> HexFormat was designed for presenting bytes to h
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Mon, 18 Sep 2023 20:08:31 GMT, iaroslavski wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove the unnecessary exception in single pivot partitioning fallback
>> method
>
> ... more suggestions to h
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
On Mon, 18 Sep 2023 19:08:14 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 422:
>>
>>> 420: toHexDigits(out, bytes[fromIndex + i]);
>>> 421: }
>>> 422: out.append(suffix);
>>
>> Maybe change t
Fixed the failing (well, false-positive) test case. Made the following changes
to the test:
- Corrected the path to the mapping files directory
- Made sure to fail if the directory path is incorrect
- Took care of `GB18030` alias, which is dynamically derived at runtime
- Provided `MS950_HKSCS.ma
`JVM_MoreStackWalk` has a bug that always assumes that the Java frame
stream is currently at the frame decoded in the last patch and so always
advances to the next frame before filling in the new batch of stack frame.
However `JVM_MoreStackWalk` may return 0. The library will set
the continuation
Please review this PR which restricts sub-classing of the internal calendar
system in sun.util.calendar to only the existing implementations.
As the implementation is long-standing and complete with no intent for future
sub-classing, the CalendarSystem should be made sealed. Modifiers adjusted
On Wed, 13 Sep 2023 17:52:13 GMT, Justin Lu wrote:
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` i
Wording changes to make clear that the scenarios described are merely examples
and are not normative requirements.
-
Commit messages:
- Update wording for {Deque,List,SortedMap,SortedSet}.reversed implSpecs.
Changes: https://git.openjdk.org/jdk/pull/15799/files
Webrev: https://web
On Fri, 15 Sep 2023 13:32:39 GMT, Alexey Semenyuk wrote:
>> On Windows, restart app launcher in a way that when the parent app launcher
>> process terminates, the child app launcher process is automatically
>> terminated.
>
> Alexey Semenyuk has updated the pull request incrementally with two
On Tue, 12 Sep 2023 19:47:19 GMT, Alexey Semenyuk wrote:
> On Windows, restart app launcher in a way that when the parent app launcher
> process terminates, the child app launcher process is automatically
> terminated.
This pull request has now been integrated.
Changeset: dcea9bf0
Author:
On Fri, 15 Sep 2023 15:40:25 GMT, Alexey Semenyuk wrote:
> Run jpackage jtreg tests on Windows sequentially. Asynch execution of
> `msiexec.exe` that unpacks msi files doesn't work well.
This pull request has now been integrated.
Changeset: 1b104b63
Author:Alexey Semenyuk
URL:
http
On Mon, 18 Sep 2023 18:54:07 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 18 Sep 2023 18:54:07 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Fri, 15 Sep 2023 18:04:29 GMT, 温绍锦 wrote:
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]
On Mon, 18 Sep 2023 13:40:48 GMT, Chen Liang wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#for
WinHTTP functions are only used when an application:
- uses DefaultProxySelector to resolve proxies, and
- is run with -Djava.net.useSystemProxies=true
In all other cases, loading winhttp.dll is a waste of resources.
Verified that:
- existing tier1 and tier2 tests still pass
- the same system pro
On Mon, 18 Sep 2023 18:54:07 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Fri, 15 Sep 2023 22:17:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Sat, 16 Sep 2023 22:49:14 GMT, iaroslavski wrote:
>> Hello Paul,
>>
>> As suggested, the functional interfaces were moved next to the associated
>> methods and also added a `@ForceInline` for `arraySort` in the latest commit.
>>
>>> I recommend embedding the functional interfaces next to th
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
On Mon, 18 Sep 2023 18:04:22 GMT, Erik Joelsson wrote:
>> Naoto Sato has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update
>> make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>>
>>Co-autho
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Conjunct Break specified in
> the latest [Unicode Annex #29 ("Unicode Text
> Segmentation")](https://unico
On Mon, 18 Sep 2023 18:05:19 GMT, Daniel Jeliński wrote:
> Hmm, indeed `VER_PLATFORM_WIN32_WINDOWS` was not used... Removed now. Was
> that the `define` you were referring to?
Err, sorry, I was talking about the `_WIN32_NT` define, but that was actually
already removed in
https://github.com/o
On Fri, 15 Sep 2023 16:56:48 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the delayload clause, the patch also cleans up the
> `getHomeF
On Mon, 18 Sep 2023 14:44:13 GMT, Daniel Jeliński wrote:
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the
On Fri, 15 Sep 2023 22:19:53 GMT, 温绍锦 wrote:
> HexDecimal#DIGITS is a table with a size of 512 bytes. I think that in such a
> table, when it needs to be used continuously, it is worthwhile to perform
> table lookup operations.
HexFormat was designed for presenting bytes to humans, typical lin
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote:
> enumeration(list) will create an enumeration, a list and an iterator whereas
> the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps
> the enumeration to an iterator for the o
On Mon, 3 Jul 2023 04:02:44 GMT, 温绍锦 wrote:
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.StringUpperLower.*"
>
>
>
> ## 1.
> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.htm
On Mon, 18 Sep 2023 16:05:37 GMT, Daniel Jeliński wrote:
> based on the above, I believe we can ignore WinXP compatibility here.
I tend to agree.
> During compilation we enable APIs from Win8:
This is interesting. I think that means the `define` at the start of
src/java.base/windows/native/li
On Sun, 17 Sep 2023 07:42:43 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/StackFrameInfo.java line 93:
>>
>>> 91: synchronized (this) {
>>> 92: if (type instanceof String sig) {
>>> 93: type = JLIA.getMethodType(sig,
>>> declaringClass().ge
On Mon, 18 Sep 2023 14:44:13 GMT, Daniel Jeliński wrote:
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the
On Mon, 18 Sep 2023 13:51:06 GMT, Chen Liang wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#for
On Fri, 15 Sep 2023 19:11:48 GMT, 温绍锦 wrote:
> The byte[] length used by HexFormatBench is 512. In this scenario, the
> performance improvement of using table lookup is significant.
Is this a common use-case? I could see an argument that formatting small chunks
is much more common, where users
On Mon, 18 Sep 2023 14:44:13 GMT, Daniel Jeliński wrote:
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the
On Fri, 15 Sep 2023 18:04:29 GMT, 温绍锦 wrote:
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]
In the improvement of @cl4es PR #15591, the advantages of non-lookup-table were
discussed.
But if the input is byte[], using lookup table can improve performance.
For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]), If
the length of byte[] is larger, the performance of t
On Fri, 15 Sep 2023 18:20:32 GMT, Claes Redestad wrote:
> What numbers do you get with this?
>
> In my experiments the improvement was either negligible or small enough to
> hardly matter. I also tried flipping bits similar to what you're doing for
> uppercasing but saw a net regression from t
On Fri, 15 Sep 2023 18:04:29 GMT, 温绍锦 wrote:
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]
On Fri, 15 Sep 2023 18:04:29 GMT, 温绍锦 wrote:
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.StringUpperLower.*"
>
>
>
> ## 1.
> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
> * cpu : intel xeon sapphire rapids (x
Please review this patch that makes java.dll load shell32.dll earlier.
Delay-loading requires some additional code (delayimp.lib), and offers no
benefits since we always load shell32 during JVM startup.
Other than removing the delayload clause, the patch also cleans up the
`getHomeFromShell32`
On Mon, 18 Sep 2023 15:00:20 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.StringUpperLower.*"
>
>
>
> ## 1.
> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
> * cpu : intel xeon sapphire rapids (x
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Wed, 13 Sep 2023 19:43:53 GMT, ExE Boss wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add missing space + reflow lines
>> - Fix typo
>>
>>Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.gith
On Mon, 4 Sep 2023 06:50:18 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai
Thanks for the clarification Alan.
To ensure the reproducibility of the whole JDK image regardless of the
specific bootjdk used, would it make sense once the "Build JDK" has been
built, we re-build jrt-fs.jar again using the "Build JDK" ? Thus jrt-fs.jar
will be consistent with the rest of the ima
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We have a valid size for the Zip64 extra header but we are
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We have a valid size for the Zip64 extra header but we are
On Mon, 18 Sep 2023 04:11:25 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta
On Mon, 18 Sep 2023 03:00:25 GMT, Chen Liang wrote:
>> 温绍锦 has updated the pull request with a new target base due to a merge or a
>> rebase. The incremental webrev excludes the unrelated changes brought in by
>> the merge/rebase. The pull request contains ten additional commits since the
>> l
On Mon, 18 Sep 2023 04:11:25 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta
On Thu, 14 Sep 2023 13:30:28 GMT, Alan Bateman wrote:
>> Thread::getState is an API for monitoring and management purposes to report
>> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
>> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
>> Ge
On Mon, 14 Aug 2023 12:56:46 GMT, Nikita Sakharin wrote:
> `Collections.rotate` method contains a bug. This method throws
> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
> reproduce:
>
> final int size = (1 << 30) + 1;
> final List list = new ArrayList<>(size);
On Tue, 29 Nov 2022 10:26:31 GMT, Adam Sotona wrote:
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 1203e11a
Author:
63 matches
Mail list logo
