Re: RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v5]

2023-09-16 Thread Naoto Sato
On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu wrote: >> Please review this PR which is a continuation of >> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused >> code from the _sun.util.Calendar_ classes. >> >> `forceStandardTime` is always false. >> >> In addition, `lo

Re: RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v5]

2023-09-16 Thread Naoto Sato
On Sat, 16 Sep 2023 07:37:37 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java >> line 160: >> >>> 158: unsupported(); >>> 159: } >>> 160: >> >> This removal does not look right. The class claims `immutable`, and yet it >> is

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v36]

2023-09-16 Thread iaroslavski
On Fri, 15 Sep 2023 22:11:44 GMT, Srinivas Vamsi Parasa wrote: >> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor the sort and partition intrinsics to accept method references for >> fallback functions >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-16 Thread iaroslavski
On Fri, 15 Sep 2023 20:17:17 GMT, Paul Sandoz wrote: > > > Alan, you mentioned that DualPivotQuicksort will need detailed review. > > > Can we go ahead and start reviewing? Laurent checked performance, JMH > > > results look fine. > > > > As before, I think the main question with this change i

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v35]

2023-09-16 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v34]

2023-09-16 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Integrated: 8316187: Modernize examples in StringTokenizer and {Date,Number}Format

2023-09-16 Thread Pavel Rappo
On Wed, 13 Sep 2023 12:39:00 GMT, Pavel Rappo wrote: > This modernizes an example to use the extended for-statement introduced in > JDK 1.5. > > I understand that StringTokenizer is a legacy class. But legacy or not, a > class shouldn't promote older constructs when newer fit better. Especiall

Re: RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v5]

2023-09-16 Thread Andrey Turbanov
On Fri, 15 Sep 2023 23:31:16 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cleanup existing typos > > src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java > line 160: > >> 158: