Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-10 Thread Alan Bateman
On Mon, 11 Sep 2023 06:31:33 GMT, Per Minborg wrote: > Currently, all deprecated methods of `Unsafe` are at the end of the file. Are you looking at the internal Unsafe, rather than sun.misc.Unsafe? This PR is sun.misc.Unsafe only. Previous deprecation didn't re-order the methods. With VarHandl

Re: RFR: 8315973: Remove unused fields from ThreadLocalRandom

2023-09-10 Thread Jaikiran Pai
On Mon, 21 Aug 2023 15:07:45 GMT, Andrey Turbanov wrote: > These messages were used before > [JDK-8248862](https://bugs.openjdk.org/browse/JDK-8248862) Looks OK to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15363#pullrequestreview-161

Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-10 Thread Per Minborg
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote: > There are several methods defined by sun.misc.Unsafe that have standard API > equivalents for many years and releases. The change proposed here is to > deprecate, for removal, the park, unpark, getLoadAverage, loadFence, > storeFence, and

RFR: 8315973: Remove unused fields from ThreadLocalRandom

2023-09-10 Thread Andrey Turbanov
These messages were used before [JDK-8248862](https://bugs.openjdk.org/browse/JDK-8248862) - Commit messages: - [PATCH] Remove unused fields from ThreadLocalRandom Changes: https://git.openjdk.org/jdk/pull/15363/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15363&range=00

Re: Java 21 clinit deadlock

2023-09-10 Thread David Holmes
On 8/09/2023 12:38 am, Simone Bordet wrote: Hello, We switched the Jetty builds to Java 21 a while ago, and they randomly fail with a hard deadlock during class initialization. We tried to understand if we were doing something wrong, but the code compiles fine, and at first glance there seems t

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v6]

2023-09-10 Thread 温绍锦
> Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is also needed in > other places, such as: > http

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v5]

2023-09-10 Thread Yi Yang
On Mon, 11 Sep 2023 01:12:25 GMT, 温绍锦 wrote: >> Some codes in core libs are duplicated, including: >> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS >> java.util.DecimalDigits::size -> java.lang.Long.stringSize >> >> We can reduce duplication through JavaLangAccess, whic

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v5]

2023-09-10 Thread 温绍锦
> Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is also needed in > other places, such as: > http

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v4]

2023-09-10 Thread 温绍锦
> Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is also needed in > other places, such as: > http

Re: RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 22:27:48 GMT, Claes Redestad wrote: >> https://bugs.openjdk.org/browse/JDK-8310929 >> >> @TheRealMDoerr Feedback: >> >> >> We're getting test failures on AIX: >> compiler/intrinsics/Test8215792.java >> compiler/intrinsics/string/TestStringIntrinsics.java >> runtime/CompactS

Re: RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 16:39:30 GMT, 温绍锦 wrote: > https://bugs.openjdk.org/browse/JDK-8310929 > > @TheRealMDoerr Feedback: > > > We're getting test failures on AIX: > compiler/intrinsics/Test8215792.java > compiler/intrinsics/string/TestStringIntrinsics.java > runtime/CompactStrings/TestMethodNam

Integrated: 8314491: Linux: jexec launched via PATH fails to find java

2023-09-10 Thread Vladimir Petko
On Fri, 18 Aug 2023 10:06:19 GMT, Vladimir Petko wrote: > 8314491: Linux: jexec launched via PATH fails to find java This pull request has now been integrated. Changeset: dab1c213 Author:Vladimir Petko Committer: David Holmes URL: https://git.openjdk.org/jdk/commit/dab1c213fd276068

Re: RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread Claes Redestad
On Sun, 10 Sep 2023 16:39:30 GMT, 温绍锦 wrote: > https://bugs.openjdk.org/browse/JDK-8310929 > > @TheRealMDoerr Feedback: > > > We're getting test failures on AIX: > compiler/intrinsics/Test8215792.java > compiler/intrinsics/string/TestStringIntrinsics.java > runtime/CompactStrings/TestMethodNam

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v2]

2023-09-10 Thread Claes Redestad
On Sun, 10 Sep 2023 18:08:44 GMT, Roger Riggs wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> move java.util.DecimalDigits to jdk.internal.util.DecimalDigits > > src/java.base/share/classes/java/util/Digits.java line 36: >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v19]

2023-09-10 Thread iaroslavski
On Sun, 12 Mar 2023 21:28:59 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javad

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-10 Thread Roger Riggs
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v2]

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 18:08:44 GMT, Roger Riggs wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> move java.util.DecimalDigits to jdk.internal.util.DecimalDigits > > src/java.base/share/classes/java/util/Digits.java line 36: >

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v2]

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 18:37:20 GMT, 温绍锦 wrote: >> src/java.base/share/classes/java/util/Digits.java line 36: >> >>> 34: * @since 21 >>> 35: */ >>> 36: sealed interface Digits permits HexDigits, OctalDigits { >> >> Don't break up the trio, move all three classes and the interface to >> jdk.inte

Re: RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 16:39:30 GMT, 温绍锦 wrote: > https://bugs.openjdk.org/browse/JDK-8310929 > > @TheRealMDoerr Feedback: > > > We're getting test failures on AIX: > compiler/intrinsics/Test8215792.java > compiler/intrinsics/string/TestStringIntrinsics.java > runtime/CompactStrings/TestMethodNam

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v3]

2023-09-10 Thread 温绍锦
> Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is also needed in > other places, such as: > http

Re: RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread Roger Riggs
On Sun, 10 Sep 2023 16:39:30 GMT, 温绍锦 wrote: > https://bugs.openjdk.org/browse/JDK-8310929 > > @TheRealMDoerr Feedback: > > > We're getting test failures on AIX: > compiler/intrinsics/Test8215792.java > compiler/intrinsics/string/TestStringIntrinsics.java > runtime/CompactStrings/TestMethodNam

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v2]

2023-09-10 Thread Roger Riggs
On Sun, 10 Sep 2023 17:59:10 GMT, 温绍锦 wrote: >> Some codes in core libs are duplicated, including: >> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS >> java.util.DecimalDigits::size -> java.lang.Long.stringSize >> >> We can reduce duplication through JavaLangAccess, whic

Re: RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread Claes Redestad
On Sun, 10 Sep 2023 16:39:30 GMT, 温绍锦 wrote: > https://bugs.openjdk.org/browse/JDK-8310929 > > @TheRealMDoerr Feedback: > > > We're getting test failures on AIX: > compiler/intrinsics/Test8215792.java > compiler/intrinsics/string/TestStringIntrinsics.java > runtime/CompactStrings/TestMethodNam

RFR: 8315970: Big-endian issues after JDK-8310929

2023-09-10 Thread 温绍锦
https://bugs.openjdk.org/browse/JDK-8310929 @TheRealMDoerr Feedback: We're getting test failures on AIX: compiler/intrinsics/Test8215792.java compiler/intrinsics/string/TestStringIntrinsics.java runtime/CompactStrings/TestMethodNames.java runtime/StringIntrinsic/StringIndexOfChar.java Is there a

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v2]

2023-09-10 Thread 温绍锦
> Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is also needed in > other places, such as: > http

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS

2023-09-10 Thread Claes Redestad
On Sun, 10 Sep 2023 16:15:01 GMT, 温绍锦 wrote: > Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 15:59:05 GMT, 温绍锦 wrote: >> Filed https://bugs.openjdk.org/browse/JDK-8315968 - we should also get >> @JimLaskey to weigh in here (who's recently authored the `java.util.Digits` >> code). Tl;dr: I think it'd be good to consolidate and share the code to >> produce these pack

Re: RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS

2023-09-10 Thread Roger Riggs
On Sun, 10 Sep 2023 16:15:01 GMT, 温绍锦 wrote: > Some codes in core libs are duplicated, including: > java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS > java.util.DecimalDigits::size -> java.lang.Long.stringSize > > We can reduce duplication through JavaLangAccess, which is

RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS

2023-09-10 Thread 温绍锦
Some codes in core libs are duplicated, including: java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS java.util.DecimalDigits::size -> java.lang.Long.stringSize We can reduce duplication through JavaLangAccess, which is also needed in other places, such as: https://github.com

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-10 Thread 温绍锦
On Sun, 10 Sep 2023 15:19:51 GMT, Claes Redestad wrote: >> Please help me create an issue, and I will submit a new PR to modify it. > > Filed https://bugs.openjdk.org/browse/JDK-8315968 - we should also get > @JimLaskey to weigh in here (who's recently authored the `java.util.Digits` > code). T

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-10 Thread Claes Redestad
On Sat, 9 Sep 2023 07:59:30 GMT, 温绍锦 wrote: >> Perhaps you could extract the `digitPair` method you're adding in #1 to >> a separate PR and use that to remove `HexDigits::DIGITS`? > > Please help me create an issue, and I will submit a new PR to modify it. Filed https://bugs.openjdk.org/bro

Integrated: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-09-10 Thread Alan Bateman
On Wed, 30 Aug 2023 13:56:42 GMT, Alan Bateman wrote: > In the virtual thread implementation, thread identity switches to the carrier > before freezing and switches back to the virtual thread after thawing. This > was a forced move due to issues getting JVMTI to work with virtual threads. > JV

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v28]

2023-09-10 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ