On Tue, 18 Jul 2023 01:49:17 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.Integers.toStri
On Fri, 30 Jun 2023 14:43:36 GMT, Chen Liang wrote:
> As discussed on the mailing list
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html,
> BufWriter::asByteBuffer has a behavior not suitable for API and is only used
> by internal StackMapGenerator/StackCounter, so i
On Fri, 25 Aug 2023 18:46:53 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary import in Arrays.java
>
> After I fixed it Tier1 passed and I submitted other tiers.
@v
> 8268829: Provide an optimized way to walk the stack with Class object only
>
> `StackWalker::walk` creates one `StackFrame` per frame and the current
> implementation
> allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some
> frameworks
> like logging may only interest in
On Fri, 25 Aug 2023 01:57:41 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Fri, 18 Aug 2023 14:22:49 GMT, Erik Joelsson wrote:
> In the JDK build we have various build tools that generate source code from
> data files. For most of these tools, the source files are based on template
> files, which already have copyright headers, but for some, the complete
> source
On Thu, 24 Aug 2023 06:23:29 GMT, Srinivas Vamsi Parasa
wrote:
>>> Improvements are nice but it would not pay off if you have big regressions.
>>> I can accept 0.9x but 0.4x - 0.8x regressions should be investigated and
>>> implementation adjusted to avoid them.
>>
>> Hi Vladimir,
>>
>> Than
On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote:
> This PR adds an internal method to calculate hash code from the provided
> integer array, offset and length into that array, and the initial hash code
> value.
>
> Current options for calculating a hash code for int[] are inflexible. It's
On Fri, 25 Aug 2023 01:57:41 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Thu, 24 Aug 2023 06:23:29 GMT, Srinivas Vamsi Parasa
wrote:
>>> Improvements are nice but it would not pay off if you have big regressions.
>>> I can accept 0.9x but 0.4x - 0.8x regressions should be investigated and
>>> implementation adjusted to avoid them.
>>
>> Hi Vladimir,
>>
>> Than
On Fri, 25 Aug 2023 13:35:04 GMT, Dan Heidinga wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback and javadoc clean up
>
> src/hotspot/share/classfile/javaClasses.cpp line 2990:
>
>> 2988: // direc
Vote: Yes
On 8/25/23 11:23 AM, Roger Riggs wrote:
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 11:23 AM, Roger Riggs wrote:
I hereby nominate Lance Andersen to Membership in the Core Libraries
Group
Vote: Yes
On 8/25/23 11:24 AM, Roger Riggs wrote:
I hereby nominate Michael McMahon to Membership in the Core Libraries
Group
Vote: yes
Mandy
Vote: Yes
Mandy
Vote: yes
Mandy
Hi there!
I’ve e nominate my self to be a change provoker of this community!
I’ve propose to stop kissing everyones butts only because of the history,
go this evening to your favorite bar get drunk, talk to people about your
beliefs and in the morning or next day assemble all your craziest hidden
On Fri, 25 Aug 2023 10:33:49 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/logger/LazyLoggers.java line 425:
>>
>>> 423: */
>>> 424: public static final Logger getLogger(String name, Module module) {
>>> 425: BootstrapLogger.detectBackend();
>>
>> Suggest
On Fri, 25 Aug 2023 10:24:23 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Improve test coverage
>> - Incorporate review comments from Daniel
>
> src/java.base/share/classes/jdk/internal/logge
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case developed to simulate loading
> of an external LoggerFinder service while als
On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simul
Vote: yes
-Joe
On 8/25/23 8:24 AM, Roger Riggs wrote:
I hereby nominate Michael McMahon to Membership in the Core Libraries
Group
Vote: yes
-Joe
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Lance Andersen to Membership in the Core Libraries
Group
Vote: yes
-Joe
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
Vote: yes
Vote: yes
Vote: yes
I hereby nominate Michael McMahon to Membership in the Core Libraries Group
Michael has been contributing to the OpenJDK Core Libraries since 2008,
originally at Sun Microsystems, now Oracle. He has deep networking
experience and has made more than 260 contributions to OpenJDK.
Votes are due
I hereby nominate Lance Andersen to Membership in the Core Libraries Group
Lance has been contributing to the OpenJDK at Oracle since 2007. He has
been the JDBC spec lead since 2005 and an OpenJDK committer since day 1.
He has extensive experience with Java EE, Databases and SQL and is
improvi
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
Daniel has been contributing to the OpenJDK Core Libraries at Oracle
since 2012. He is leading the networking team and has made nearly 400
contributions to OpenJDK since JDK 6.
Votes are due by September 8th, 2023.
Only
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Thu, 24 Aug 2023 02:36:52 GMT, Stuart Marks wrote:
>> Nikita Sakharin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8314236: rewrite test
>
> @nikita-sakharin
>
> Thanks for the updates. With the "Mock List" implementation we can r
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
> In this case, it seems a bit fragile to do it in CgroupUtil as it should be
> allowed to use any of the file system APIs to access cgroups or proc files.
In theory, yes. It should be able to use any file system APIs. Practically, it
doesn
On Fri, 25 Aug 2023 01:57:41 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
> `Collections.rotate` method contains a bug. This method throws
> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
> reproduce:
>
> final int size = (1 << 30) + 1;
> final List list = new ArrayList<>(size);
> for (int i = 0; i < size; ++i)
> list.add((byte) 0);
On Fri, 25 Aug 2023 06:45:25 GMT, Andrey Turbanov wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Suggestion from dholmes
>
> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 236:
>
>> 234:
> In the JDK build we have various build tools that generate source code from
> data files. For most of these tools, the source files are based on template
> files, which already have copyright headers, but for some, the complete
> source file is generated by the tool, which is providing the cop
On Thu, 4 May 2023 23:29:17 GMT, Chen Liang wrote:
> This patch migrates `MethodHandles::arrayConstructor`, added in Java 9 as a
> hotfix to the incorrect constructor found on arrays via Lookup, to share the
> array access caching features. The result is that calling
> `MethodHandles.arrayCons
On Tue, 15 Aug 2023 17:30:54 GMT, Weibing Xiao wrote:
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It r
On Thu, 29 Jun 2023 09:59:30 GMT, Chen Liang wrote:
> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry,
> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a
> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or
> MethodTypeDesc
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simul
On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simul
On Wed, 23 Aug 2023 17:16:15 GMT, Daniel Fuchs wrote:
> We could create a singleton instance of TemporaryLoggerFinder in the
> TemporaryLoggerFinder class and return that.
I think the disadvantage is that this singleton instance will never be GCed
(till `LoggerFinderLoader` class itself is unl
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This PR adds the required functionality to the Java code.
>
>
> `Collections.rotate` method contains a bug. This method throws
> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
> reproduce:
>
> final int size = (1 << 30) + 1;
> final List list = new ArrayList<>(size);
> for (int i = 0; i < size; ++i)
> list.add((byte) 0);
On Fri, 25 Aug 2023 09:01:43 GMT, Maurizio Cimadamore
wrote:
>> I had something like that, but another reviewer didn't like it, either.
>> Originally, I had thought that the v1 and v2 CallArrangers would get more
>> content, but they're still empty. Would it be better to remove these special
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This PR adds the required functionality to the Java code.
>
>
On Wed, 23 Aug 2023 17:10:42 GMT, Daniel Fuchs wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Improve test coverage
>> - Incorporate review comments from Daniel
>
> src/java.base/share/classes/jdk/internal/logge
On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simul
On Thu, 24 Aug 2023 14:39:18 GMT, Severin Gehwolf wrote:
> I've now realized that the bug had an incorrect statement in the description.
> The cycle happens due to the `Runtime.getRuntime().maxMemory()`
> implementation in GraalVM to use JDK `Metrics`, since the `ByteBuffer` [code
> relies on
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote:
> I want to add a log output similar to JDK-8301627 to Runtime.halt().
> To avoid double logging of Runtime.exit(), add a flag to indicate whether
> logging was done, and fix it so that logging is done only once.
> Could someone please revie
I want to add a log output similar to JDK-8301627 to Runtime.halt().
To avoid double logging of Runtime.exit(), add a flag to indicate whether
logging was done, and fix it so that logging is done only once.
Could someone please review this fix?
-
Commit messages:
- Merge branch 'ope
On Fri, 25 Aug 2023 07:54:51 GMT, Martin Doerr wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 717:
>>
>>> 715: public void interpret(Deque stack, StoreFunc storeFunc,
>>> 716: LoadFunc loadFunc, SegmentAllocator
>>> allocat
On Thu, 24 Aug 2023 23:08:43 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs protocol.
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai
On Fri, 25 Aug 2023 07:48:19 GMT, Martin Doerr wrote:
>> If my assumption above is correct, then maybe another way to solve the
>> problem, would be to, instead of adding a new shift binding, to generalize
>> the VM store binding we have to allow writing a smaller value into a bigger
>> storag
On Fri, 25 Aug 2023 07:36:47 GMT, Martin Doerr wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/ABIv1CallArranger.java
>> line 33:
>>
>>> 31: * PPC64 CallArranger specialized for ABI v1.
>>> 32: */
>>> 33: public class ABIv1CallArranger extends CallArranger {
>>
>> Wouldn
On Fri, 25 Aug 2023 06:30:13 GMT, Alexey Semenyuk wrote:
> The intention was to make jpackage native code work with compilers without
> native std::unique_ptr.
I understand, however it appears MSVC does not use the code inside that file
-
PR Comment: https://git.openjdk.org/jdk/pu
On Thu, 24 Aug 2023 23:38:42 GMT, Maurizio Cimadamore
wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
On Fri, 25 Aug 2023 00:10:11 GMT, Maurizio Cimadamore
wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
On Thu, 24 Aug 2023 23:58:35 GMT, Maurizio Cimadamore
wrote:
>> Maybe I'm starting to see it - it's not a special rule, as much as it is a
>> consequence of the endianness. E.g. if you have a struct that is 64 + 32
>> bytes, you can store the first 64 bytes as a long. Then, there's an issue as
On Wed, 16 Aug 2023 18:33:01 GMT, Roger Riggs wrote:
>> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
>> as user that is member of the Administrators group. In that case new files
>> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
>>
On Thu, 24 Aug 2023 23:33:23 GMT, Maurizio Cimadamore
wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains eight additional
commits si
68 matches
Mail list logo
