Re: RFR: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-08-03 Thread Koichi Sakata
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote: > Modified 3 of 3 test/jdk/tools/jlink test classes to replace > com.sun.tools.classfile library. Marked as reviewed by ksakata (Committer). I'll sponsor you. I've checked those tests passed. - PR Review: https://git.openjdk.org/

Integrated: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-08-03 Thread Qing Xiao
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote: > Modified 3 of 3 test/jdk/tools/jlink test classes to replace > com.sun.tools.classfile library. This pull request has now been integrated. Changeset: 10a26058 Author:Qing Xiao Committer: Koichi Sakata URL: https://git.openjdk.or

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-03 Thread Stuart Marks
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator ope

Re: RFR: 8159527: Collections mutator methods should all be marked as optional operations

2023-08-03 Thread Brian Burkhalter
On Wed, 2 Aug 2023 20:11:35 GMT, Stuart Marks wrote: > Adjust the leading javadoc sentence of several collections mutator methods to > include "(optional operation)" as appropriate. Also adjust doc for > UnsupportedOperationException on those methods as necessary. Looks fine. - M

Re: RFR: 8159527: Collections mutator methods should all be marked as optional operations

2023-08-03 Thread Naoto Sato
On Wed, 2 Aug 2023 20:11:35 GMT, Stuart Marks wrote: > Adjust the leading javadoc sentence of several collections mutator methods to > include "(optional operation)" as appropriate. Also adjust doc for > UnsupportedOperationException on those methods as necessary. Marked as reviewed by naoto (

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v5]

2023-08-03 Thread Cristian Vat
On Thu, 3 Aug 2023 14:42:45 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are al

Integrated: 8311006: missing @since info in jdk.xml.dom

2023-08-03 Thread Joe Wang
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. This pull request has now been integrated. Changeset: d60352e2 Author:Joe Wang URL: https://git.openjdk.

Re: RFR: 8311006: missing @since info in jdk.xml.dom

2023-08-03 Thread Joe Wang
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. Thanks all! - PR Comment: https://git.openjdk.org/jdk/pull/15129#issuecomment-1664686325

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match [v4]

2023-08-03 Thread Raffaello Giulietti
On Mon, 31 Jul 2023 18:38:30 GMT, Raffaello Giulietti wrote: >> Fixes a bug showing up after >> [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are >> capturing groups outside the match. > > Raffaello Giulietti has updated the pull request with a new target base due > to

Re: RFR: 8041488: Locale-Dependent List Patterns [v3]

2023-08-03 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

[jdk21] Integrated: 8312572: JDK 21 RDP2 L10n resource files update

2023-08-03 Thread Justin Lu
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote: > Please review this PR (L10N translation update), which is a backport of > commit > [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >

Re: RFR: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

2023-08-03 Thread Iris Clark
On Thu, 3 Aug 2023 16:31:01 GMT, Justin Lu wrote: > Please review this PR which updates the IANA data from version 05-11-2023 to > version > [08-02-2023](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-August/88.html). > > The contents of the update added variant subtag “b

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match [v4]

2023-08-03 Thread Stuart Marks
On Mon, 31 Jul 2023 18:38:30 GMT, Raffaello Giulietti wrote: >> Fixes a bug showing up after >> [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are >> capturing groups outside the match. > > Raffaello Giulietti has updated the pull request with a new target base due > to

Re: RFR: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

2023-08-03 Thread Naoto Sato
On Thu, 3 Aug 2023 16:31:01 GMT, Justin Lu wrote: > Please review this PR which updates the IANA data from version 05-11-2023 to > version > [08-02-2023](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-August/88.html). > > The contents of the update added variant subtag “b

Re: RFR: 8311006: missing @since info in jdk.xml.dom

2023-08-03 Thread Naoto Sato
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15129#pullrequest

RFR: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

2023-08-03 Thread Justin Lu
Please review this PR which updates the IANA data from version 05-11-2023 to version [08-02-2023](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-August/88.html). The contents of the update added variant subtag “blasl” to the language subtag registry. - Commit

Re: RFR: 8311006: missing @since info in jdk.xml.dom

2023-08-03 Thread Lance Andersen
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15129#pullreques

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v5]

2023-08-03 Thread Cristian Vat
> Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this class, \1 through \9 are always interpreted as back references, " > > Only with Matche

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-08-03 Thread Raffaello Giulietti
On Fri, 28 Jul 2023 12:15:21 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

[jdk21] Integrated: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-08-03 Thread Christoph Langer
On Tue, 1 Aug 2023 21:57:17 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of > [JDK-8311822](https://bugs.openjdk.org/browse/JDK-8311822), commit > [d1cc2782](https://github.com/openjdk/jdk/commit/d1cc2782606e8a3cfead9055aa845e48e851edd4) > from the [openjdk