Integrated: 8313312: Add missing classpath exception copyright header

2023-08-02 Thread Amit Kumar
On Fri, 28 Jul 2023 13:02:20 GMT, Amit Kumar wrote: > Adds `classpath exception` in multiple files, affects copyright header only. This pull request has now been integrated. Changeset: 53ca75b1 Author:Amit Kumar URL: https://git.openjdk.org/jdk/commit/53ca75b18ea419d469758475fac8352

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

2023-08-02 Thread Amit Kumar
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote: >> Adds `classpath exception` in multiple files, affects copyright header only. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > revert java.lang.foreign changes Thanks for

Re: RFR: 8313406: nep_invoker_blob can be simplified more

2023-08-02 Thread Jorn Vernee
On Thu, 3 Aug 2023 04:07:27 GMT, Yasumasa Suenaga wrote: > then shuffling would remain somewhare even if we could eliminate them from > NEP stub. Since things on the Java side are visible to the JIT, it should be able to avoid the extra data motion. > Thus this topic would be lower priority i

Re: RFR: 8313406: nep_invoker_blob can be simplified more

2023-08-02 Thread Yasumasa Suenaga
On Mon, 31 Jul 2023 12:22:00 GMT, Yasumasa Suenaga wrote: > In FFM, native function would be called via `nep_invoker_blob`. If the > function has two arguments, it would be following: > > > Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10 > ---

Re: RFR: 8311006: missing @since info in jdk.xml.dom

2023-08-02 Thread Iris Clark
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15129#pullrequestr

Re: RFR: 8041488: Locale-Dependent List Patterns [v2]

2023-08-02 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8174722: Wrong behavior of DecimalFormat with RoundingMode.UP in special case [v3]

2023-08-02 Thread Justin Lu
> Please review this PR, which addresses a case where Decimal Format would > violate certain RoundingMode contracts given the right pattern and input > decimal String. > > For example, > > > DecimalFormat df = new DecimalFormat(); > df.setRoundingMode(RoundingMode.UP); > double small = 0.0001;

RFR: 8041488: Locale-Dependent List Patterns

2023-08-02 Thread Naoto Sato
Introducing a new formatting class for locale-dependent list patterns. The class is to provide the functionality from the Unicode Consortium's LDML specification for [list patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). For example, given a list of String as "Mon

RFR: 8159527: Collections mutator methods should all be marked as optional operations

2023-08-02 Thread Stuart Marks
Adjust the leading javadoc sentence of several collections mutator methods to include "(optional operation)" as appropriate. Also adjust doc for UnsupportedOperationException on those methods as necessary. - Commit messages: - Adjust wording of various UnsupportedOperationException

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v3]

2023-08-02 Thread Brian Burkhalter
On Sun, 30 Jul 2023 13:06:36 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 6478546: Move buffer clamping up to Java layer; correct read behavior to >> match legacy > > src/java.base/share/c

RFR: 8311006: missing @since info in jdk.xml.dom

2023-08-02 Thread Joe Wang
Please review a patch that add `@since` tags following existing convention for XML APIs in java.xml and jdk.xml.dom modules. - Commit messages: - 8311006: missing @since info in jdk.xml.dom Changes: https://git.openjdk.org/jdk/pull/15129/files Webrev: https://webrevs.openjdk.org/?

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-08-02 Thread Erik Gahlin
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match [v4]

2023-08-02 Thread Alan Bateman
On Mon, 31 Jul 2023 18:38:30 GMT, Raffaello Giulietti wrote: >> Fixes a bug showing up after >> [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are >> capturing groups outside the match. > > Raffaello Giulietti has updated the pull request with a new target base due > to

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-08-02 Thread Alan Bateman
On Wed, 2 Aug 2023 18:19:27 GMT, Tim Prinzing wrote: > I believe this has all requested changes or has separate bug reports to > address changes yet needing to be made. > https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling > https://bugs.openjdk.org/browse/JDK-8310978 - mis

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-08-02 Thread Tim Prinzing
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

Re: [jdk21] RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-08-02 Thread Iris Clark
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote: > Please review this PR (L10N translation update), which is a backport of > commit > [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >

Re: [jdk21] RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-08-02 Thread Naoto Sato
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote: > Please review this PR (L10N translation update), which is a backport of > commit > [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >

Integrated: 8306582: Remove MetaspaceShared::exit_after_static_dump()

2023-08-02 Thread Matias Saavedra Silva
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva wrote: > Currently we exit the VM after static dumping with > `MetaspaceShared::exit_after_static_dump()`. > > > // We have finished dumping the static archive. At this point, there may be > pending VM > // operations. We have change

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v3]

2023-08-02 Thread Matias Saavedra Silva
On Thu, 27 Jul 2023 18:07:12 GMT, Ioi Lam wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactored KlassToOopHandleTable, Ioi and Alan comments > > Looks good. Just a couple of nits. Thank you for the r

[jdk21] RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-08-02 Thread Justin Lu
Please review this PR (L10N translation update), which is a backport of commit [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This change is required to keep the localized translations up

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v4]

2023-08-02 Thread Ioi Lam
On Wed, 2 Aug 2023 04:01:46 GMT, David Holmes wrote: >> Yes it should! Thank you for catching this. > > This suggests we don't have test coverage for this case. If we want to add a test case, I would suggest adding a WhiteBox method like: public native Object[] getResolvedReferences(Class c);

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

2023-08-02 Thread Roger Riggs
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote: >> Adds `classpath exception` in multiple files, affects copyright header only. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > revert java.lang.foreign changes Marked as r

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

2023-08-02 Thread Adam Sotona
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote: >> Adds `classpath exception` in multiple files, affects copyright header only. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > revert java.lang.foreign changes Marked as r

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

2023-08-02 Thread Roger Riggs
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote: >> Adds `classpath exception` in multiple files, affects copyright header only. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > revert java.lang.foreign changes /Reviewers

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

2023-08-02 Thread Roger Riggs
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote: >> Adds `classpath exception` in multiple files, affects copyright header only. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > revert java.lang.foreign changes The changes

Re: RFR: 8313406: nep_invoker_blob can be simplified more

2023-08-02 Thread Jorn Vernee
On Wed, 2 Aug 2023 12:35:50 GMT, Yasumasa Suenaga wrote: > I guess you suggested that ArgumentShuffle in HotSpot moves into > DowncallLinker, right? No, ArgumentShuffle should stay inside HotSpot. We can not do all the shuffling on the Java side. We can only eliminate some of the register move

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2023-08-02 Thread Yudi Zheng
On Wed, 2 Aug 2023 12:33:43 GMT, Ferenc Rakoczi wrote: >> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 3473: >> >>> 3471: __ bcax(v24, __ T16B, v24, v8, v31); >>> 3472: >>> 3473: __ ld1r(v31, __ T2D, __ post(rscratch1, 8)); >> >> is it intentional to load 16 bytes and post-i

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2023-08-02 Thread Ferenc Rakoczi
On Wed, 2 Aug 2023 11:02:07 GMT, Yudi Zheng wrote: >> Fei Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add if (isJDK16OrHigher()) check for SHA3 in CheckGraalIntrinsics.java > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp l

Re: RFR: 8313406: nep_invoker_blob can be simplified more

2023-08-02 Thread Yasumasa Suenaga
On Wed, 2 Aug 2023 02:12:43 GMT, Jorn Vernee wrote: >> In FFM, native function would be called via `nep_invoker_blob`. If the >> function has two arguments, it would be following: >> >> >> Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10 >> ---

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2023-08-02 Thread Yudi Zheng
On Wed, 21 Oct 2020 23:42:33 GMT, Fei Yang wrote: >> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com >> >> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. >> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto >> Extensions: >> https:

[jdk21] Integrated: 8313023: Return value corrupted when using CCS + isTrivial (mainline)

2023-08-02 Thread Jorn Vernee
On Mon, 31 Jul 2023 08:13:55 GMT, Jorn Vernee wrote: > Hi all, > > This pull request contains a backport of commit > [6fca2898](https://github.com/openjdk/jdk/commit/6fca28988794b52a6aa974bed1ed6f4f07e0994b) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bein

Integrated: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out

2023-08-02 Thread Alan Bateman
On Fri, 28 Jul 2023 15:44:54 GMT, Alan Bateman wrote: > This is a test only change to a test that exercises core reflection from > virtual threads. One of the tests (testNewInstance6) uses a custom scheduler > in setup to check that calling a constructor reflectively, where the > constructor p

Re: [jdk21] RFR: 8313023: Return value corrupted when using CCS + isTrivial (mainline)

2023-08-02 Thread Maurizio Cimadamore
On Mon, 31 Jul 2023 08:13:55 GMT, Jorn Vernee wrote: > Hi all, > > This pull request contains a backport of commit > [6fca2898](https://github.com/openjdk/jdk/commit/6fca28988794b52a6aa974bed1ed6f4f07e0994b) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bein

Re: RFR: 8311517: Add performance information to ArrayList javadoc

2023-08-02 Thread dan1st
On Wed, 26 Jul 2023 23:01:26 GMT, Stuart Marks wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterat

Re: [jdk21] RFR: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-08-02 Thread Matthias Baesken
On Tue, 1 Aug 2023 21:57:17 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of > [JDK-8311822](https://bugs.openjdk.org/browse/JDK-8311822), commit > [d1cc2782](https://github.com/openjdk/jdk/commit/d1cc2782606e8a3cfead9055aa845e48e851edd4) > from the [openjdk