Re: [jdk21] RFR: 8309032: jpackage does not work for module projects unless --module-path is specified

2023-07-22 Thread Alan Bateman
On Thu, 20 Jul 2023 02:34:05 GMT, airsquared wrote: > 8309032: jpackage does not work for module projects unless --module-path is > specified JDK 21 is in rampdown phase two so only P1/P2 bugs (with approval) at this time, maybe this is one for JDK 21u instead. - PR Comment: http

Re: RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ [v2]

2023-07-22 Thread Vladimir Petko
On Fri, 21 Jul 2023 20:52:32 GMT, Alexander Matveev wrote: >> Vladimir Petko has updated the pull request incrementally with one >> additional commit since the last revision: >> >> copyright typo > > src/jdk.jpackage/share/native/common/app.cpp line 2: > >> 1: /* >> 2: * Copyright (c) 2020

Re: RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ [v2]

2023-07-22 Thread Vladimir Petko
> Use the same approach as Logger::defaultLogger() to ensure that the appender > is not destroyed before shared object destructor function is executed. > > The alternative is to delete dcon() function, but we might run into a > similiar tear-down issue later (e.g. logging from some object's des

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-22 Thread Cristian Vat
On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-22 Thread Cristian Vat
> Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this class, \1 through \9 are always interpreted as back references, " > > Only with Matche

Integrated: 8301341: LinkedTransferQueue does not respect timeout for poll()

2023-07-22 Thread Doug Lea
On Mon, 5 Jun 2023 18:52:00 GMT, Doug Lea wrote: > This update addresses performance issues across both LinkedTransferQueue and > SynchronousQueue by creating a common basis for implementation across them > (mainly in LinkedTransferQueue). Pasting from internal doc summary of > changes: >

Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v4]

2023-07-22 Thread yaqsun
> The prerequisite is to install the rpmbuild command, when multiple users > switch to write /var/tmp/*.files will have the permission forbidden. yaqsun has updated the pull request incrementally with one additional commit since the last revision: 8311631: restore to final patch and trigger a

Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v3]

2023-07-22 Thread yaqsun
> The prerequisite is to install the rpmbuild command, when multiple users > switch to write /var/tmp/*.files will have the permission forbidden. yaqsun has updated the pull request incrementally with one additional commit since the last revision: 8311631: When multiple users run tools/jpacka

Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v2]

2023-07-22 Thread Ao Qi
On Mon, 17 Jul 2023 01:08:15 GMT, yaqsun wrote: >> The fix with `%{_builddir}` looks better. Did it resolve the issue? > >> The fix with `%{_builddir}` looks better. Did it resolve the issue? > > Yes, it solved. The root of intermediate files changed to > /tmp/jdk.jpackage16701381473798822/BUIL

Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v2]

2023-07-22 Thread Ao Qi
On Fri, 14 Jul 2023 21:58:33 GMT, Alexey Semenyuk wrote: >> yaqsun has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, >> Permission denied for writing /var/tmp/*.files