On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
I have narrowed d
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 and
> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8311905
Hi, thanks for the background and the discussion of the alternatives. I'm not
sure that drafting the CSR is th
On Fri, 21 Jul 2023 22:40:00 GMT, Brian Burkhalter wrote:
> Limit native memory allocation and move write loop from the native layer into
> Java. This change should make the OOME reported in the issue much less likely.
The cost of native memory allocation appears to degrade the throughput of re
Limit native memory allocation and move write loop from the native layer into
Java. This change should make the OOME reported in the issue much less likely.
-
Commit messages:
- 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty
available
Changes: https:/
On Wed, 21 Jun 2023 15:03:12 GMT, Sergey Tsypanov wrote:
>> Just a tiny clean-up to remove racy read within synchronized method
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.base/share/classes/java/io/P
On Fri, 21 Jul 2023 10:55:13 GMT, Vladimir Petko wrote:
> Use the same approach as Logger::defaultLogger() to ensure that the appender
> is not destroyed before shared object destructor function is executed.
>
> The alternative is to delete dcon() function, but we might run into a
> similiar
On Fri, 21 Jul 2023 16:29:24 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
>> line 896:
>>
>>> 894: for (DualNode p = (pred == null) ? head : pred.next, c = p;
>>> 895: p != null; ) {
>>> 896: boole
On Fri, 21 Jul 2023 15:14:23 GMT, Maurizio Cimadamore
wrote:
>> So have you thought of making this low-level classes public so we outside
>> users no longer need to deal with VarHandles?
> I believe this is beyond the scope of this PR.
Sure, I brought this up here but yes, it is not really th
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
FWIW, I found a b
On Fri, 21 Jul 2023 15:59:42 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and po
On Fri, 21 Jul 2023 16:48:12 GMT, Stuart Marks wrote:
> ListIterator fuses three different concepts: the ability to traverse forwards
> and
> backwards, the ability to mutate the underlying List at the current location
> (add/remove/set), and the index of the current location. Which of these is
On Fri, 21 Jul 2023 15:59:42 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and po
On Mon, 24 Apr 2023 21:39:43 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 96 commits:
>
> - Merge branch 'master' into JDK-8266571-Sequen
On Tue, 18 Jul 2023 20:06:56 GMT, Andrey Turbanov wrote:
> Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`.
This pull request has now been integrated.
Changeset: f4ba7b21
Author:Andrey Turbanov
URL:
https://git.openjdk.org/jdk/commit/f4ba7b219851217c48e462
On Fri, 21 Jul 2023 16:19:35 GMT, Hollis Waite wrote:
> a SequencedCollection is backed by a doubly linked list. It's up to the user
> to understand performance implications.
Beware of this kind of thinking, implementations of collections in the JDK
change.
Many hashtable implementations in o
On Fri, 21 Jul 2023 16:19:35 GMT, Hollis Waite wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 96 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedCollections
>> - Optimizations for Reverse
On Mon, 24 Apr 2023 21:39:43 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 96 commits:
>
> - Merge branch 'master' into JDK-8266571-Sequen
> This update addresses performance issues across both LinkedTransferQueue and
> SynchronousQueue by creating a common basis for implementation across them
> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
> changes:
> * * Class DualNode replaces Qnode, with fields an
On Fri, 21 Jul 2023 14:00:06 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
> line 896:
>
>> 89
On Mon, 24 Apr 2023 21:39:43 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 96 commits:
>
> - Merge branch 'master' into JDK-8266571-Sequen
On Fri, 21 Jul 2023 13:53:57 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
> line 639:
>
>> 63
On Fri, 21 Jul 2023 15:59:42 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and po
On Fri, 21 Jul 2023 15:59:42 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and po
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater
> than zero" in j
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater
> than zero" in j
On Thu, 20 Jul 2023 19:29:33 GMT, Stephen Colebourne
wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> com
On Fri, 21 Jul 2023 09:43:43 GMT, Uwe Schindler wrote:
>
> So have you thought of making this low-level classes public so we outside
> users no longer need to deal with VarHandles?
>
I believe this is beyond the scope of this PR.
As for what do we do in the JDK, I can see few options:
1. We
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
StdLibTest tests
On Fri, 21 Jul 2023 10:55:13 GMT, Vladimir Petko wrote:
> Use the same approach as Logger::defaultLogger() to ensure that the appender
> is not destroyed before shared object destructor function is executed.
>
> The alternative is to delete dcon() function, but we might run into a
> similiar
On Fri, 21 Jul 2023 11:16:11 GMT, Hollis Waite wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 96 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedCollections
>> - Optimizations for Reverse
On Fri, 21 Jul 2023 12:31:07 GMT, Doug Lea wrote:
>> This update addresses performance issues across both LinkedTransferQueue and
>> SynchronousQueue by creating a common basis for implementation across them
>> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
>> changes:
On Fri, 21 Jul 2023 11:16:55 GMT, Doug Lea wrote:
>> It's a good point, but we don't normally do this. Added (L336):
>> * returns just barely too soon. As is the case in most j.u.c
>> * blocking support, untimed waits use ManagedBlockers when
>> * callers are ForkJoin threads, but
On Fri, 21 Jul 2023 11:16:11 GMT, Hollis Waite wrote:
> It'd be convenient if SequencedCollection overrode Iterable.iterator() to
> return a ListIterator. That would make it simpler to derive a List from
> LinkedHashMap.values().
What stops you from deriving a list from LinkedHashMap.values()
On Fri, 21 Jul 2023 11:16:11 GMT, Hollis Waite wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 96 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedCollections
>> - Optimizations for Reverse
On Fri, 21 Jul 2023 12:31:07 GMT, Doug Lea wrote:
>> This update addresses performance issues across both LinkedTransferQueue and
>> SynchronousQueue by creating a common basis for implementation across them
>> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
>> changes:
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
I am using below
On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option and `-debug` option of the `java` command? This
> addresses https://bugs.openjdk.org/browse/JDK-8227229.
>
> As noted in the JBS issu
> This update addresses performance issues across both LinkedTransferQueue and
> SynchronousQueue by creating a common basis for implementation across them
> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
> changes:
> * * Class DualNode replaces Qnode, with fields an
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
I can see it fail
On Fri, 21 Jul 2023 10:46:14 GMT, Martin Doerr wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> I've seen
>
> java/foreign/StdLibTest.java
> Total tests run: 41388, Passes: 39378
On Mon, 24 Apr 2023 21:39:43 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 96 commits:
>
> - Merge branch 'master' into JDK-8266571-Sequen
On Fri, 21 Jul 2023 10:55:19 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
>> line 446:
>>
>>> 444: Thread.onSpinWait();
>>> 445: else
>>> 446: LockSupport.parkNanos(ns);
>>
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
Removing
Use the same approach as Logger::defaultLogger() to ensure that the appender
is not destroyed before shared object destructor function is executed.
The alternative is to delete dcon() function, but we might run into a similiar
tear-down issue later (e.g. logging from some object's destructor).
On Fri, 21 Jul 2023 09:30:53 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> nitpicks
>
> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
> line 397:
>
>> 395: * T
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
I've seen
java/f
On Thu, 20 Jul 2023 21:43:49 GMT, Maurizio Cimadamore
wrote:
>>> By the way, I ran `LoopOverNonConstantHeap` on the 3700x platform, and the
>>> performance of ByteBuffer was also poor:
>>
>> I finally see it.
>>
>>
>> Benchmark (polluteProfile) Mode Cnt Score
On Thu, 20 Jul 2023 10:26:03 GMT, Doug Lea wrote:
>> This update addresses performance issues across both LinkedTransferQueue and
>> SynchronousQueue by creating a common basis for implementation across them
>> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
>> changes:
On Thu, 20 Jul 2023 10:26:03 GMT, Doug Lea wrote:
>> This update addresses performance issues across both LinkedTransferQueue and
>> SynchronousQueue by creating a common basis for implementation across them
>> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
>> changes:
On Thu, 20 Jul 2023 10:26:03 GMT, Doug Lea wrote:
>> This update addresses performance issues across both LinkedTransferQueue and
>> SynchronousQueue by creating a common basis for implementation across them
>> (mainly in LinkedTransferQueue). Pasting from internal doc summary of
>> changes:
50 matches
Mail list logo
