Ok, ty for the heads up.
On Tue, Jul 18, 2023 at 1:18 AM - wrote:
> Hi David,
> Please do not ask for technical support in the development mailing list.
> There's no proof that this issue is with the core libraries instead of the
> Java compiler or another component.
> I have already downloaded
Hi David,
Please do not ask for technical support in the development mailing list.
There's no proof that this issue is with the core libraries instead of the
Java compiler or another component.
I have already downloaded your zip, compiled the 4 files with JDK 22 (my
local dev build for another unre
On Sat, 15 Jul 2023 13:54:46 GMT, Alan Bateman wrote:
> If FileDescriptor::sync is invoked by a virtual thread then it doesn't
> release its carrier to do other work while modifications are written to the
> file system. For cases like this, parallelism should be temporarily increased
> for the
On Tue, 18 Jul 2023 04:42:31 GMT, Joe Darcy wrote:
> Change one overload of java.lang.reflect.Array.newInstance to have an
> `@implSpec` of calling the other method.
>
> I choose not to use a snippet tag here is this code is semantically only one
> line and doesn't need to be cut-and-pasted.
>
Change one overload of java.lang.reflect.Array.newInstance to have an
`@implSpec` of calling the other method.
I choose not to use a snippet tag here is this code is semantically only one
line and doesn't need to be cut-and-pasted.
As adding an `@implSpec` is technically a (small) specification
On Tue, 18 Jul 2023 01:57:56 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
Wait, nevermind. Don't ignore. I was able to recreate this issue on the
command line using the abovementioned JDK. Could someone come back and take
a look at this please?
Sorry for jerking everyone around here. I have multiple JDK's and got mixed
up on which one I was using.
On Sun, Jul 16, 2023
On Tue, 18 Jul 2023 01:57:56 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
> Then I wonder if we should consider the size of a function with
> assertions removed when making JIT inline decisions? Since
> at JIT time I presume whether assertions are turned on or off
> is known – or is it too inefficient to calculate this metric?
Hi Andrew,
This is also a good suggestion
Thanks, I see. Then I wonder if we should consider the size of a function with
assertions removed when making JIT inline decisions? Since at JIT time I
presume whether assertions are turned on or off is known – or is it too
inefficient to calculate this metric?
Thanks,
-Andrew
From: Daohan Q
On Wed, 31 May 2023 11:57:19 GMT, Raffaello Giulietti
wrote:
>> The `default` method `nextDouble(double origin, double bound)` in
>> `java.util.random.RandomGenerator` aims at generating a uniformly and
>> spatially equidistributed random `double` in the left-closed and right-open
>> range [`
> This makes me wonder if it is worth introducing a compiler flag
> that would omit assert statements from the compiled bytecode
> for this scenario.
Hi Andrew,
Maybe the first one of this FAQ could answer your question:
https://docs.oracle.com/javase/8/docs/technotes/guides/language/assert.html
This makes me wonder if it is worth introducing a compiler flag that would omit
assert statements from the compiled bytecode for this scenario. Forgive me if
this has been discussed and decided before though…
Thanks,
-Andrew
From: core-libs-dev On Behalf Of Alan Bateman
Sent: Monday, July 17
On Tue, 18 Jul 2023 01:52:35 GMT, 温绍锦 wrote:
>> I think he means to check the `charPos` to ensure it is not out of bounds.
>
> Oh, I see, charPos needs to do bound checks, I added assert with reference
> to the implementation of StringUTF16#putChar, is this safe enough?
I think we might need t
On Mon, 17 Jul 2023 17:29:09 GMT, Mandy Chung wrote:
>> test/jdk/java/lang/invoke/MethodHandleProxies/WrapperHiddenClassTest.java
>> line 165:
>>
>>> 163: () -> "incorrect dynamic module name: " +
>>> implModule.getName());
>>> 164:
>>> 165: assertSame(implClass.getCla
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1] abstrac
On Tue, 18 Jul 2023 01:38:47 GMT, Chen Liang wrote:
>> The value range of the r variable is 0-99, and the length of PACKED_DIGITS
>> is 100, There is no need to check the array boundary here.
>
> I think he means to check the `charPos` to ensure it is not out of bounds.
Oh, I see, charPos needs
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
On Tue, 18 Jul 2023 01:26:55 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/lang/Integer.java line 528:
>>
>>> 526: i = q;
>>> 527: charPos -= 2;
>>> 528: UNSAFE.putShortUnaligned(buf,
>>> Unsafe.ARRAY_BYTE_BASE_OFFSET + charPos, PACKED_DIGITS[r], false)
On Mon, 17 Jul 2023 20:53:23 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Integer/Long toString test against compact strings
>>
>> Co-authored-by: liach
>
> src/java.base/share/classes/java/lang/In
On Mon, 3 Apr 2023 08:08:45 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that `Map`
> doesn't contain `null` values.
> Instead of pair containsKey+put we can use putIfAbsent and compare result
> with null.
> Result code is shorter and a bit fast
On Fri, 5 May 2023 04:48:09 GMT, Chen Liang wrote:
> This patch implements lazy initialization for VarHandle working on static
> fields. It has a good initial call performance.
>
> We introduce a new internal API, `target()` to unpack a lazy VarHandle in VH
> implementation methods. If called
On Wed, 12 Jul 2023 22:26:14 GMT, John R Rose wrote:
> Yes, it would be, because `rp` has a statically observable type,
> `BigInteger`. And that observation will flow across the call to the helper
> method.
After all, my mental model is incorrect; sigh.
I read your write-up as though once we
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in the java.text area.
>
> * Some changes to `equals` and `hashCode` are refactoring rather than
> modernization. Such changes can be as trivial as rearranging, adding, or
> commenting checks.
On 17 Jul 2023, at 2:08, Alan Bateman wrote:
On 15/07/2023 17:53, Daohan Qu wrote:
You will find places in the JDK code, esp. in performance critical
code, where assertions are commented out. The reason is that asserts,
even if disabled, increase the method size and can impact inlining by
th
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Fri, 14 Jul 2023 12:06:29 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for in java.nio and implementation code.
>
> Please note, test results are pending.
>
> Additional notes:
>
> * This PR saves a v
On Mon, 26 Jun 2023 23:13:19 GMT, Mandy Chung wrote:
>> This PR updates the spec of `Lookup::findClass` to reflect the current
>> behavior that requires a binary name or a string representing an array class
>> in the form as returned by `Class::getName`.
>>
>> `test/jdk/java/lang/invoke/ac
On Mon, 26 Jun 2023 23:13:19 GMT, Mandy Chung wrote:
>> This PR updates the spec of `Lookup::findClass` to reflect the current
>> behavior that requires a binary name or a string representing an array class
>> in the form as returned by `Class::getName`.
>>
>> `test/jdk/java/lang/invoke/ac
On Mon, 26 Jun 2023 23:13:19 GMT, Mandy Chung wrote:
>> This PR updates the spec of `Lookup::findClass` to reflect the current
>> behavior that requires a binary name or a string representing an array class
>> in the form as returned by `Class::getName`.
>>
>> `test/jdk/java/lang/invoke/ac
On Mon, 17 Jul 2023 21:04:48 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
> which updates the javadoc for the constructor of MessageFormat regarding a
> `null` locale,
>
> `MessageFormat` when created with a `null` locale may throw a
> `
On Mon, 17 Jul 2023 17:14:01 GMT, Ioi Lam wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have changed some g
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva
wrote:
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have change
On Mon, 17 Jul 2023 21:31:33 GMT, Justin Lu wrote:
>> Please review this PR which refactors more java.util.Locale tests to JUnit
>> with some minor cleanup as well.
>>
>> Although some of the files could benefit from being renamed bugNNN to
>> something more descriptive, this makes reviewi
On Mon, 17 Jul 2023 10:58:12 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Review: Explicitly run via othervm and pass locale args in cmdline
>> - Review: ws removal in Bug8179071.java
>> -
On Fri, 14 Jul 2023 21:59:40 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Review: Explicitly run via othervm and pass locale args in cmdline
>> - Review: ws removal in Bug8179071.java
>> - Revie
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing harder, and will be handled
> separately.
Justin Lu h
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
which updates the javadoc for the constructor of MessageFormat regarding a
`null` locale,
`MessageFormat` when created with a `null` locale may throw a
`NullPointerException` either during the object creation, or later
On Mon, 3 Jul 2023 03:49:01 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.Integers.toStrin
On Thu, 13 Jul 2023 06:34:09 GMT, Justin Lu wrote:
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
> of deprecated three-letter IDs in java.util.TimeZone
>
> Although it is made apparent in TimeZone that certain 3-letter IDs
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
co
[JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
[JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
-
Commit messages:
- Minor code cleanup in LauncherData.java
- Fix ClassCastException in getPathListParameter: ImmutableCollections$List12
cannot be cast to class
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
co
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
co
On Mon, 17 Jul 2023 19:40:42 GMT, Joe Darcy wrote:
> Update to conform to accepted syntax.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14908#pullrequestreview-1533548769
On Mon, 17 Jul 2023 19:40:42 GMT, Joe Darcy wrote:
> Update to conform to accepted syntax.
This pull request has now been integrated.
Changeset: 295ae119
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/295ae1190dfb6ac3d00d3cf2d8c8c131f5c319b5
Stats: 2 lines in 2 files c
Update to conform to accepted syntax.
-
Commit messages:
- JDK-8312195: Changes in JDK-8284493 use wrong copyright synta
Changes: https://git.openjdk.org/jdk/pull/14908/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14908&range=00
Issue: https://bugs.openjdk.org/browse/JD
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote:
> This PR improves both the worst-case performance of `nextExponential` and
> `nextGaussian` and the distribution of output at the tails. It fixes the
> following imperfections:
>
> * Repeatedly adding DoubleZigguratTables.exponentialX0 to
On Tue, 31 Jan 2023 15:57:43 GMT, Per Minborg wrote:
> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for values
> in the range [-18h, 18h] for each second that is on an even quarter of an
> hour (i.e. at most 2*18*4+1 = 145 values).
>
> Instead of using a `ConcurrentHashM
> This PR improves both the worst-case performance of `nextExponential` and
> `nextGaussian` and the distribution of output at the tails. It fixes the
> following imperfections:
>
> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a
> rounding error to accumulate at the ta
On Fri, 14 Jul 2023 20:42:03 GMT, Joe Darcy wrote:
>> @JimLaskey @jddarcy @turbanoff @rgiulietti Could this please be merged?
>
> @Pr0methean , please update your branch with the current contents of the
> master before issuing the integrate command. Assuming that succeeds as
> expected, myself
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because of
On Mon, 17 Jul 2023 17:21:50 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review changees
>
> test/jdk/java/lang/invoke/MethodHandleProxies/WrapperHiddenClassTest.java
> line 165:
>
>> 163:
On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato wrote:
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
Thanks, Alan.
> This lo
On Tue, 11 Jul 2023 19:22:58 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva
wrote:
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have change
On Tue, 11 Jul 2023 19:22:58 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Sat, 15 Jul 2023 13:54:46 GMT, Alan Bateman wrote:
> If FileDescriptor::sync is invoked by a virtual thread then it doesn't
> release its carrier to do other work while modifications are written to the
> file system. For cases like this, parallelism should be temporarily increased
> for the
On Sat, 15 Jul 2023 13:54:46 GMT, Alan Bateman wrote:
> If FileDescriptor::sync is invoked by a virtual thread then it doesn't
> release its carrier to do other work while modifications are written to the
> file system. For cases like this, parallelism should be temporarily increased
> for the
If FileDescriptor::sync is invoked by a virtual thread then it doesn't release
its carrier to do other work while modifications are written to the file
system. For cases like this, parallelism should be temporarily increased for
the duration of the operation. This one is somewhat legacy as it's
On Mon, 17 Jul 2023 09:36:35 GMT, Pavel Rappo wrote:
> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
> Object[]. I've been told elsewhere that it shouldn't have significant
> performance implications.
Looks OK to me.
-
Marked as reviewed by vtewari
On Thu, 15 Jun 2023 15:44:04 GMT, Jorn Vernee wrote:
> This patch changes the implementation of `MethodHandles::collectCoordinates`
> to allow using filters that return `void`. This brings the behavior in line
> with the previously existing `MethodHandles::collectArgument` which operates
> on
On Thu, 13 Jul 2023 19:21:01 GMT, Doug Lea wrote:
>> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
>> enabling re-introduction of spin control from the previous version, removing
>> anomalies like this one.
>
> Doug Lea has updated the pull request with a new targ
On Mon, 17 Jul 2023 09:36:35 GMT, Pavel Rappo wrote:
> Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
> Object[]. I've been told elsewhere that it shouldn't have significant
> performance implications.
Marked as reviewed by rriggs (Reviewer).
-
PR Re
On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato wrote:
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
This looks quite good. I
Hi Pavel,
> There have been studies looking into correlation between assertion density
> and fault/defect density. Here's one such study: "Assessing the Relationship
> between Software Assertions and Code Quality: An Empirical Investigation".
Thanks and yes! And there are also some more recent st
Hi John,
> I believe this can be partially alleviated by extracting the asserts to a
> method (partially as the call also increases method size). The optimizer
> seems to be smart enough to not call the method if it does nothing
> (when ea is disabled).
Thanks a lot! Good to know that. I'm not su
Hi Alan,
> You will find places in the JDK code, esp. in performance critical code,
> where assertions are commented out. The reason is that asserts, even if
> disabled, increase the method size and can impact inlining by the
> compiler at run-time. So while useful when debugging some issue in suc
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 226
Hi Liang,
Thank you for your response! The provided guidelines are quite helpful. I have
noticed that different packages in JDK use the assert keyword to varying
degrees.
I wonder if this is more a matter of developer preference (if it is not the
performance
reason mentioned by Alan). :P
Regar
On Fri, 30 Jun 2023 13:10:55 GMT, Chen Liang wrote:
> `Classfile.PREVIEW_MINOR_VERSION`, currently -1, is correct when passed to
> `ClassBuilder::withVersion`, but is incorrect when compared to
> `ClassModel::minorVersion`, which only sets the bits of 2 lowest bytes to 1
> (65536). Discovered
In this thread, Alan has already pointed out possible runtime cost of Java
assertions. But as far as the general idea goes, I find assertions to be very
helpful.
There have been studies looking into correlation between assertion density and
fault/defect density. Here's one such study: "Assessin
On Tue, 11 Jul 2023 15:47:35 GMT, Volker Simonis wrote:
>> As the included jtreg test demonstrates, `StackWalker.getCallerClass()` can
>> throw an `UnsupportedOperationException` if called reflectively. Currently
>> this only happens if we invoke `StackWalker.getCallerClass()` recursively
>> r
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote:
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing ha
On 17/07/2023 11:08, Alan Bateman wrote:
On 15/07/2023 17:53, Daohan Qu wrote:
:
Although the |assert| keyword has been around for a long time and
is handy for invariant checks, it does not seem to be widely used.
For example, in the famous |j.u.c| packages, nearly all |assert|
statements ar
Please review this PR to refactor Arrays.hashCode for long[], boolean[], and
Object[]. I've been told elsewhere that it shouldn't have significant
performance implications.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/14900/files
Webrev: https://w
On 15/07/2023 17:53, Daohan Qu wrote:
:
Although the |assert| keyword has been around for a long time and
is handy for invariant checks, it does not seem to be widely used.
For example, in the famous |j.u.c| packages, nearly all |assert|
statements are commented out [1].
My questions are, sh
On Fri, 14 Jul 2023 10:01:16 GMT, Sean Coffey wrote:
> Simple tweak to remove the "available locales" section from default
> `-XshowSettings` output.
>
> Instead, it remains available with the `-XshowSettings:locale` option
This pull request has now been integrated.
Changeset: f6e23ae4
Author
On Fri, 30 Jun 2023 13:10:55 GMT, Chen Liang wrote:
> `Classfile.PREVIEW_MINOR_VERSION`, currently -1, is correct when passed to
> `ClassBuilder::withVersion`, but is incorrect when compared to
> `ClassModel::minorVersion`, which only sets the bits of 2 lowest bytes to 1
> (65536). Discovered
81 matches
Mail list logo
