On Sat, 15 Jul 2023 00:47:35 GMT, Jaikiran Pai wrote:
>> Hello Alan,
>>
>>> Files.isSameFile checks the file contents, this doesn't look right here.
>>
>> I was always under the impression that `Files.isSameFile()` only checks file
>> paths and attributes for testing whether they are same. The
On Sat, 15 Jul 2023 00:41:12 GMT, Jaikiran Pai wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 666:
>>
>>> 664: return false;
>>> 665: }
>>> 666: return Files.isSameFile(javaBasePath, javaBaseInDefaultPath);
>>
>> Files.isSameFile c
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Fri, 14 Jul 2023 16:09:15 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor - remove duplicated code comment
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 666
On Thu, 13 Jul 2023 11:46:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote:
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing ha
On Thu, 6 Jul 2023 20:07:56 GMT, Brian Burkhalter wrote:
> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
> to `Closeable::close` except that it instead throws
> `java.io.UncheckedIOException`.
This pull request has been closed without being integrated.
-
On Fri, 7 Jul 2023 15:56:13 GMT, Brian Burkhalter wrote:
>> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
>> to `Closeable::close` except that it instead throws
>> `java.io.UncheckedIOException`.
>
> Brian Burkhalter has updated the pull request incrementally with
On Thu, 13 Jul 2023 07:27:22 GMT, yaqsun wrote:
>> The prerequisite is to install the rpmbuild command, when multiple users
>> switch to write /var/tmp/*.files will have the permission forbidden.
>
> yaqsun has updated the pull request incrementally with one additional commit
> since the last r
On Fri, 16 Jun 2023 15:15:07 GMT, Jorn Vernee wrote:
>> This patch changes the implementation of `MethodHandles::collectCoordinates`
>> to allow using filters that return `void`. This brings the behavior in line
>> with the previously existing `MethodHandles::collectArgument` which operates
>>
On Fri, 14 Jul 2023 03:27:07 GMT, Chris Hennick wrote:
>> Chris Hennick has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 20 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into patch-1
>> - Merge remote-tracking b
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponential
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote:
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
This pull request has now been integrated.
Changeset: 19691fab
Author:Joe Darcy
URL:
https://git.o
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Expand test as recommended in code review comments.
--
On Fri, 14 Jul 2023 18:25:45 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 14 Jul 2023 16:42:02 GMT, Alan Bateman wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address another case from feedback
>> - Address feedback
>
> src/java.base/share/classes/java/nio/charset/Charset.jav
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for in java.nio and implementation code.
>
> Please note, test results are pending.
>
> Additional notes:
>
> * This PR saves a volatile read in java.nio.file.attribute.AclEntry.hashCo
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Clarify docs based on review feedback.
-
On Fri, 14 Jul 2023 16:55:44 GMT, Mandy Chung wrote:
> The example above of a primitive type is `I` (the descriptor string) versus
> `forPrimitiveType` takes the primitive type name. It may need some
> clarification.
Add some clarification that argument like "int" and "long" are expected for
Currently we exit the VM after static dumping with
`MetaspaceShared::exit_after_static_dump()`.
// We have finished dumping the static archive. At this point, there may be
pending VM
// operations. We have changed some global states (such as
vmClasses::_klasses) that
// may cause these VM
On Fri, 14 Jul 2023 02:54:59 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The increment
On Fri, 14 Jul 2023 13:16:27 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for in java.nio and implementation code.
>>
>> Please note, test results are pending.
>>
>> Additional notes:
>>
>> * This PR s
On Mon, 10 Jul 2023 20:36:31 GMT, Joe Darcy wrote:
> For discussion purposes, pushed an update where the new method returns null
> on a non-primitive name.
I also think returning null is saner than throwing a checked exception which
avoids forcing the caller to catch and also the cost of const
On Fri, 14 Jul 2023 02:54:59 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The increment
On Thu, 13 Jul 2023 22:43:27 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
>> of deprecated three-letter IDs in java.util.TimeZone
>>
>> Although it is made apparent in TimeZone that certain 3-lette
This is to bring the JLine-based Console implementation as the default, which
was the initial intention in
[JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR
has also been drafted.
-
Commit messages:
- javadoc cleanup
- Merge branch 'master' into JDK-
On Thu, 13 Jul 2023 22:43:27 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list
>> of deprecated three-letter IDs in java.util.TimeZone
>>
>> Although it is made apparent in TimeZone that certain 3-lette
On Tue, 11 Jul 2023 15:47:35 GMT, Volker Simonis wrote:
>> As the included jtreg test demonstrates, `StackWalker.getCallerClass()` can
>> throw an `UnsupportedOperationException` if called reflectively. Currently
>> this only happens if we invoke `StackWalker.getCallerClass()` recursively
>> r
On Thu, 13 Jul 2023 11:46:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Wed, 5 Jul 2023 23:30:03 GMT, Oliver Kopp wrote:
>> It's looking pretty good.
>>
>> About the test, I don't see `ArrayList::add` in the generated bytecode of
>> `sub2-13`. The dedup string set is used for the targets of qualified
>> exports and opens and uses. The modifiers set of `req
On Fri, 14 Jul 2023 09:42:05 GMT, Alan Bateman wrote:
> This is a test only update to a test for the JFR event
> jdk.VirtualThreadPinned event. The test we added in JDK 19 does 3 sleeps, one
> with a small duration, twice with a long duration. The test enables the
> event with a threshold of
On Fri, 14 Jul 2023 11:21:02 GMT, Sean Coffey wrote:
>> Simple tweak to remove the "available locales" section from default
>> `-XshowSettings` output.
>>
>> Instead, it remains available with the `-XshowSettings:locale` option
>
> Sean Coffey has updated the pull request incrementally with one
On Fri, 14 Jul 2023 14:42:47 GMT, Pavel Rappo wrote:
> > * java.nio.charset.Charset#compareTo seems **inconsistent** with equals. If
> > so, I cannot see where that inconsistency is specified.
>
> @AlanBateman, what do you think of that? For convenience, let me paste here
> relevant source par
On Thu, 13 Jul 2023 19:27:01 GMT, Mandy Chung wrote:
> I wonder if we should move the check to throw UOE if called by
> caller-sensitive method in Java as a general guidance to implement the
> runtime in Java if desirable. That means it requires the VM to fill not only
> the class in the buffe
On Fri, 14 Jul 2023 11:21:02 GMT, Sean Coffey wrote:
>> Simple tweak to remove the "available locales" section from default
>> `-XshowSettings` output.
>>
>> Instead, it remains available with the `-XshowSettings:locale` option
>
> Sean Coffey has updated the pull request incrementally with one
On Thu, 13 Jul 2023 15:07:35 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts o
On Fri, 14 Jul 2023 13:16:27 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for in java.nio and implementation code.
>>
>> Please note, test results are pending.
>>
>> Additional notes:
>>
>> * This PR s
On Fri, 14 Jul 2023 02:54:59 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The increment
- Original Message -
> From: "Uwe Schindler"
> To: "core-libs-dev" , net-...@openjdk.org,
> nio-...@openjdk.org, security-...@openjdk.org
> Sent: Wednesday, July 12, 2023 6:08:17 PM
> Subject: Re: RFR: 8311943: Cleanup usages of toLowerCase() and toUpperCase()
> in java.base [v2]
> On W
On Fri, 14 Jul 2023 13:01:46 GMT, Glavo wrote:
>>> However, while I think this corrects the behavior, this caused a change in
>>> the behavior of the API, so a CSR may be required. I don't want to debate
>>> this in this PR, so I'll revert this change and open a new PR in the future.
>>
>> Str
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for in java.nio and implementation code.
>
> Please note, test results are pending.
>
> Additional notes:
>
> * This PR saves a volatile read in java.nio.file.attribute.AclEntry.hashCo
On Fri, 14 Jul 2023 10:24:47 GMT, Alan Bateman wrote:
> It might be that the conclusion is that it's just too risky to change, in
> which case Uwe's suggestion is good and would avoid it showing up on
> someone's else radar in the future.
Until we're sure we want to normalize a usage of `toLow
On Fri, 14 Jul 2023 12:06:29 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for in java.nio and implementation code.
>
> Please note, test results are pending.
>
> Additional notes:
>
> * This PR saves a v
Please review this PR to use modern APIs and language features to simplify
equals, hashCode, and compareTo for in java.nio and implementation code.
Please note, test results are pending.
Additional notes:
* This PR saves a volatile read in java.nio.file.attribute.AclEntry.hashCode.
Not that it
On Fri, 14 Jul 2023 12:06:29 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for in java.nio and implementation code.
>
> Please note, test results are pending.
>
> Additional notes:
>
> * This PR saves a v
On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote:
> This PR adds an internal method to calculate hash code from the provided
> integer array, offset and length into that array, and the initial hash code
> value.
>
> Current options for calculating a hash code for int[] are inflexible. It's
On Fri, 14 Jul 2023 11:21:02 GMT, Sean Coffey wrote:
>> Simple tweak to remove the "available locales" section from default
>> `-XshowSettings` output.
>>
>> Instead, it remains available with the `-XshowSettings:locale` option
>
> Sean Coffey has updated the pull request incrementally with one
On Fri, 14 Jul 2023 11:02:33 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback and bug id added to test
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 289:
>
>
> Simple tweak to remove the "available locales" section from default
> `-XshowSettings` output.
>
> Instead, it remains available with the `-XshowSettings:locale` option
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
review feedbac
On Fri, 23 Jun 2023 07:44:31 GMT, Daohan Qu wrote:
> Similar to #11745 , this patch adds more information for
> `NoSuchFieldException` thrown by `getField()` or `getDeclaredField()` of
> `java.lang.Class`. The error message changes like the example below:
> 1. For `getField()`
>
> Before this
On Fri, 14 Jul 2023 10:01:16 GMT, Sean Coffey wrote:
> Simple tweak to remove the "available locales" section from default
> `-XshowSettings` output.
>
> Instead, it remains available with the `-XshowSettings:locale` option
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 289:
On Fri, 14 Jul 2023 09:42:05 GMT, Alan Bateman wrote:
> This is a test only update to a test for the JFR event
> jdk.VirtualThreadPinned event. The test we added in JDK 19 does 3 sleeps, one
> with a small duration, twice with a long duration. The test enables the
> event with a threshold of
On Wed, 12 Jul 2023 16:17:49 GMT, Glavo wrote:
>> Maybe a small suggestion to make it clear whats wanted here. In other
>> projects I am involved in (Apache Lucene/Solr, Apache TIKA, PostgresSQL
>> JDBC, Checkstyle itsself, Elasticserach/Opensearch), which use the
>> [forbiddenapis Maven/Gradl
Simple tweak to remove the "available locales" section from default
`-XshowSettings` output.
Instead, it remains available with the `-XshowSettings:locale` option
-
Commit messages:
- 8310201
Changes: https://git.openjdk.org/jdk/pull/14885/files
Webrev: https://webrevs.openjdk.or
This is a test only update to a test for the JFR event jdk.VirtualThreadPinned
event. The test we added in JDK 19 does 3 sleeps, one with a small duration,
twice with a long duration. The test enables the event with a threshold of
500ms and expects there will be two events recorded; no event fo
On Fri, 14 Jul 2023 08:39:44 GMT, ExE Boss wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed case when calling getCallerClass() from a @CallerSensitive method
>> reflectively
>
> src/hotspot/share/prims/stac
On Tue, 11 Jul 2023 15:47:35 GMT, Volker Simonis wrote:
>> As the included jtreg test demonstrates, `StackWalker.getCallerClass()` can
>> throw an `UnsupportedOperationException` if called reflectively. Currently
>> this only happens if we invoke `StackWalker.getCallerClass()` recursively
>> r
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
This pull request has now been integrated.
Changeset: 2e12a123
Author:Sean Coffey
URL:
https://git.openjdk.org/jdk/c
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
59 matches
Mail list logo
