Please review this PR and associated
[CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list of
deprecated three-letter IDs in java.util.TimeZone
Although it is made apparent in TimeZone that certain 3-letter IDs are
deprecated, it does not actually list them in the specifi
Hi all,
This pull request contains a backport of commit
[743e8b8e](https://github.com/openjdk/jdk/commit/743e8b8e0a9fe032a0dd652a4fef1f761af66595)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Stuart Marks on 12 Jul 2023 and was
rev
On Wed, 12 Jul 2023 17:25:03 GMT, Stuart Marks wrote:
> Change some reverse-ordered spliterators to use
> `Spliterators.spliterator(Collection, ORDERED)` instead of
> `Spliterators.spliteratorUnknownSize()`. This gives SIZED and ORDERED
> spliterators. More optimizations will be done later. I'
On Wed, 12 Jul 2023 17:25:03 GMT, Stuart Marks wrote:
> Change some reverse-ordered spliterators to use
> `Spliterators.spliterator(Collection, ORDERED)` instead of
> `Spliterators.spliteratorUnknownSize()`. This gives SIZED and ORDERED
> spliterators. More optimizations will be done later. I'
On Wed, 12 Jul 2023 17:25:03 GMT, Stuart Marks wrote:
> Change some reverse-ordered spliterators to use
> `Spliterators.spliterator(Collection, ORDERED)` instead of
> `Spliterators.spliteratorUnknownSize()`. This gives SIZED and ORDERED
> spliterators. More optimizations will be done later. I'
Change some reverse-ordered spliterators to use
`Spliterators.spliterator(Collection, ORDERED)` instead of
`Spliterators.spliteratorUnknownSize()`. This gives SIZED and ORDERED
spliterators. More optimizations will be done later. I'm intending to backport
this to JDK 21 so I want this to be min
On Wed, 12 Jul 2023 18:21:29 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [f82c8184](https://github.com/openjdk/jdk/commit/f82c8184b26142da4018ae096cfa39d87a4c6540)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Thu, 9 Feb 2023 16:20:31 GMT, Tingjun Yuan wrote:
> Currently, the two subclasses of `java.util.EnumSet` optimize bulk operations
> when the argument is also a `EnumSet`, but there is no such optimization for
> wrapper sets (returned by `Collections.unmodifiableSet`,
> `Collections.synchron
On Fri, 7 Jul 2023 00:39:20 GMT, Pavel Rappo wrote:
>> Thanks @rose00 for the writeup and @pavelrappo for asking pertinent followup
>> questions.
>>
>> For me the issue here is that there is a bunch of lore about avoiding
>> `Objects::equals` and it's embodied in comments like this:
>>
>>> NB
On Wed, 12 Jul 2023 18:21:29 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [f82c8184](https://github.com/openjdk/jdk/commit/f82c8184b26142da4018ae096cfa39d87a4c6540)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Wed, 12 Jul 2023 18:21:29 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [f82c8184](https://github.com/openjdk/jdk/commit/f82c8184b26142da4018ae096cfa39d87a4c6540)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Wed, 12 Jul 2023 10:58:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
Hi all,
This pull request contains a backport of commit
[f82c8184](https://github.com/openjdk/jdk/commit/f82c8184b26142da4018ae096cfa39d87a4c6540)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Stuart Marks on 12 Jul 2023 and was
rev
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote:
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
> guarantee as to how the underlying output stream actually writes the bytes
> provided to it.
This pull request has now been integrated.
Changeset: ed9337e
On Sun, 12 Mar 2023 21:28:59 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javad
On Fri, 9 Jun 2023 15:49:03 GMT, Brian Burkhalter wrote:
> Please see [I have a patch, what do I
> do?](https://openjdk.org/guide/#i-have-a-patch-what-do-i-do) and in
> particular [Socialize your
> change](https://openjdk.org/guide/#socialize-your-change).
Thanks, will put it on the mailing l
On Wed, 12 Jul 2023 16:05:03 GMT, Uwe Schindler wrote:
> Maybe a small suggestion to make it clear whats wanted here. In other
> projects I am involved in (Apache Lucene/Solr, Apache TIKA, PostgresSQL JDBC,
> Checkstyle itsself, Elasticserach/Opensearch), which use the [forbiddenapis
> Maven/G
On Thu, 15 Jun 2023 22:38:43 GMT, Stuart Marks wrote:
> Can I get a preliminary review of the wording for Deque.reversed()? If the
> text is good, I'll make corresponding changes to the implSpecs of the other
> reversed() default methods, namely those in List, SortedMap, and SortedSet
> and th
On Wed, 12 Jul 2023 14:31:53 GMT, Glavo wrote:
>> src/java.base/share/classes/java/io/StreamTokenizer.java line 632:
>>
>>> 630: sval = String.copyValueOf(buf, 0, i);
>>> 631: if (forceLower)
>>> 632: sval = sval.toLowerCase(Locale.ROOT);
>>
>> I suspect
On Wed, 12 Jul 2023 09:00:33 GMT, Alan Bateman wrote:
> The test runs 3 times, each run is for 3 minutes so 9 mins in total and too
> long for tier1. Here's the times for test/jdk:tier1_part1 that I see locally:
>
>
> ==
> Test summary
>
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
Glavo has updated the pull request incrementally with one additional commit
since the last revision:
Revert StreamTokenizer.java
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14763/files
- new: https://g
On Wed, 12 Jul 2023 10:58:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Wed, 12 Jul 2023 13:26:03 GMT, Alan Bateman wrote:
> I suspect this change to StreamTokenizer needs eyes. I think long standing
> behavior of the lowerCaseMode(true) has been to use the rules for the default
> locale so we need to be careful.
I investigated some usage of this method on GitH
On Mon, 3 Jul 2023 20:53:34 GMT, Glavo wrote:
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
src/java.base/share/classes/java/io/StreamTokenizer.java line 632:
> 630: sval = String.copyValueOf(buf, 0, i);
> 631: if (forceLower)
> 632:
Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
-
Commit messages:
- Update DateTimeFormatterBuilder
- Avoid locale-sensitive case conversions in java.base
Changes: https://git.openjdk.org/jdk/pull/14763/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1476
On Mon, 3 Jul 2023 20:53:34 GMT, Glavo wrote:
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
Hello Glavo, I've created https://bugs.openjdk.org/browse/JDK-8311943 to track
this change. Please update the title to this PR to `8311943: Cleanup usages of
toLowerCase() and toUp
On Wed, 12 Jul 2023 11:47:45 GMT, Jaikiran Pai wrote:
> As for the 15 "afterShutdown" forks() that follow, they would already notice
> that the scope is shutdown and won't start the new threads.
> Did I misunderstand this test?
The test arranges for a subtask to do shutdown, it's not done by th
On Wed, 12 Jul 2023 11:56:18 GMT, Alan Bateman wrote:
>> test/jdk/java/util/concurrent/StructuredTaskScope/StressShutdown.java line
>> 83:
>>
>>> 81: // fork subtask to shutdown
>>> 82: scope.fork(() -> {
>>> 83: scope.shutdown();
>>
>> Hello Alan, the p
On Tue, 11 Jul 2023 17:03:26 GMT, Alan Bateman wrote:
> StructuredTaskScope.shutdown can sometimes not interrupt the thread for a
> newly forked subtask, leading to join blocking until subtask completes. The
> "hang" can be duplicated with a stress test that shuts down the scope while a
> long
On Tue, 11 Jul 2023 17:03:26 GMT, Alan Bateman wrote:
> StructuredTaskScope.shutdown can sometimes not interrupt the thread for a
> newly forked subtask, leading to join blocking until subtask completes. The
> "hang" can be duplicated with a stress test that shuts down the scope while a
> long
On Wed, 12 Jul 2023 09:00:33 GMT, Alan Bateman wrote:
> The test runs 3 times, each run is for 3 minutes so 9 mins in total and too
> long for tier1. Here's the times for test/jdk:tier1_part1 that I see locally:
>
>
> ==
> Test summary
>
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Mon, 26 Jun 2023 10:51:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 and
> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8311905
Fyi you can keep the pull request title to that of one issue, like
`8305734: BitSet.get(int, int) always return
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 and
> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8311905
Hi everyone,
Apologies for not being very active recently.
I have been looking at the BitSet class for my bac
The test runs 3 times, each run is for 3 minutes so 9 mins in total and too
long for tier1. Here's the times for test/jdk:tier1_part1 that I see locally:
==
Test summary
==
TEST TOTAL PASS F
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 and
> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8311905
I posted a second bug report & edited this PR to also include this second bug.
https://bugs.openjdk.org/browse
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
@TheRealMDoerr ,
StructuredTaskScope.shutdown can sometimes not interrupt the thread for a newly
forked subtask, leading to join blocking until subtask completes. The "hang"
can be duplicated with a stress test that shuts down the scope while a long
running subtask is being forked. The bug is in the underlying t
39 matches
Mail list logo
