Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-09 Thread Jaikiran Pai
On Mon, 10 Jul 2023 06:13:02 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/lang/ScopedValue.java line 405: >> >>> 403: * as a structure violation when the operation >>> completes (normally or with an >>> 404: * exception). In that case, the underlying construct

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-09 Thread Jaikiran Pai
On Mon, 10 Jul 2023 05:05:13 GMT, Alan Bateman wrote: >> Docs only update to add a missing `@throws StructureViolationException` and >> make it clearer when the exception is thrown. In the future we might >> re-visit this so that the description is in one place rather than in each >> method. >

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-09 Thread Alan Bateman
On Mon, 10 Jul 2023 06:04:57 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-09 Thread Jaikiran Pai
On Mon, 10 Jul 2023 05:05:13 GMT, Alan Bateman wrote: >> Docs only update to add a missing `@throws StructureViolationException` and >> make it clearer when the exception is thrown. In the future we might >> re-visit this so that the description is in one place rather than in each >> method. >

Re: RFR: JDK-8310550: Adjust references to rt.jar [v5]

2023-07-09 Thread Alan Bateman
On Fri, 30 Jun 2023 09:57:04 GMT, Matthias Baesken wrote: > Hi Alan, I adjusted the comment in DriverManager.java . Thanks, the update looks okay. - PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1257728322

Re: RFR: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader [v3]

2023-07-09 Thread Alan Bateman
On Fri, 30 Jun 2023 18:12:18 GMT, Mandy Chung wrote: >> The spec of `ClassLoader::getClassLoadingLock` is unclear that this method >> is intended for parallel-capable class loader implementations to provide an >> alternate implementation. For non-parallel-capable class loaders, this >> metho

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-09 Thread Alan Bateman
> Docs only update to add a missing `@throws StructureViolationException` and > make it clearer when the exception is thrown. In the future we might re-visit > this so that the description is in one place rather than in each method. Alan Bateman has updated the pull request with a new target bas

Re: RFR: 8180892: Correct handling of annotations on parameters [v2]

2023-07-09 Thread Chen Liang
On Wed, 26 Apr 2023 14:46:53 GMT, Chen Liang wrote: >> This patch aims to correct handling of annotations on parameters with the >> help of `MethodParameters` attribute, which will be always available once >> #9862 is integrated. >> >> It utilizes and expands upon the existing parameter matchi

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v6]

2023-07-09 Thread ExE Boss
On Fri, 7 Jul 2023 23:42:51 GMT, 温绍锦 wrote: >> src/java.base/share/classes/java/util/UUID.java line 475: >> >>> 473: long msb = mostSigBits; >>> 474: byte[] buf = new byte[36]; >>> 475: UNSAFE.putLongUnaligned( >> >> I understood that since UUID was not used during start

Re: RFR: 8066869: Add Closeable::closeUnchecked that is the equivalent of close but throws UncheckedIOException [v2]

2023-07-09 Thread Kasper Nielsen
What would an alternative method signature look like for a method called closeUnchecked? On Sat, 8 Jul 2023 at 15.49, Glavo wrote: > > Can it be a static method instead of a default method? `Closeable` is a > widely used class, so adding new default methods risks conflicting with > existing meth