On Thu, 6 Jul 2023 16:12:15 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1] abstrac
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote:
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
> guarantee as to how the underlying output stream actually writes the bytes
> provided to it.
This issue is reported against JDK 8 and 9. It was fixed in 16
On Thu, 6 Jul 2023 16:12:15 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Thu, 6 Jul 2023 16:12:15 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Tue, 27 Jun 2023 19:04:35 GMT, Justin Lu wrote:
> Please review this PR which refactors Currency tests to use JUnit.
>
> The most significant change occurs in `ValidateISO4217.java`. Other changes
> to this file excluding the JUnit refactoring include
>
> - Tests are no longer dependent on
On Sat, 1 Jul 2023 23:32:57 GMT, Chen Liang wrote:
> /integrate
A "reviewer" means a role in the jdk project in the OpenJDK organization:
https://openjdk.org/census#jdk
-
PR Comment: https://git.openjdk.org/jdk/pull/14745#issuecomment-1624502704
On Thu, 6 Jul 2023 20:07:56 GMT, Brian Burkhalter wrote:
> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
> to `Closeable::close` except that it instead throws
> `java.io.UncheckedIOException`.
src/java.base/share/classes/java/io/Closeable.java line 72:
> 70:
On Thu, 6 Jul 2023 23:50:04 GMT, Stuart Marks wrote:
> and then when I look around for example use sites, I can't find any ... and
> maybe this is telling me the API idea isn't as great as I thought it was.
I hear you.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14789#di
On Thu, 6 Jul 2023 23:38:01 GMT, Stuart Marks wrote:
> For me the issue here is that there is a bunch of lore about avoiding
> `Objects::equals` and it's embodied in comments like this:
>
> > NB: Do not replace with Object.equals until JDK-8015417 is resolved.
>
> These comments are almost exa
On Thu, 6 Jul 2023 22:48:12 GMT, Brian Burkhalter wrote:
> Unless it's a matter of further background investigation, I think actually
> making any such changes would be better handled as a separate issue.
OK. It doesn't have to be part of this change, but it would good if some
example use case
On Tue, 4 Jul 2023 22:03:58 GMT, John R Rose wrote:
>>> Hmm, I think that issue refers to code that have explicit non-Object
>>> parameter types (like `X::equals(Object)boolean` in the issue's sample).
>>> This method already have both arguments as `Object`, so I don't think
>>> there's any ty
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Sun, 18 Jun 2023 20:26:04 GMT, Stephen Colebourne
wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Tue, 20 Jun 2023 18:23:09 GMT, Roger Riggs wrote:
> > Where did you get this idea? A "positive" means a number that is _greater_
> > than zero.
>
> One of my colleagues with a strong math background has corrected many of my
> API javadoc comments seeking to avoid any ambiguity. See referenc
On Thu, 6 Jul 2023 22:42:35 GMT, Stuart Marks wrote:
> This is probably reasonable for test code, where it's often acceptable to let
> exceptions propagate instead of handling them.
Understood.
> Are there other places in the JDK (in library code or in the tests) where
> `closeUnchecked` can
On Thu, 6 Jul 2023 20:55:15 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Closeable.java line 60:
>>
>>> 58: * with it. If the stream is already closed then invoking this
>>> 59: * method has no effect.
>>> 60: *
>>
>> Can you add an example showing the reco
On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by jlu (Committer).
-
PR Review: http
On Sun, 18 Jun 2023 20:26:04 GMT, Stephen Colebourne
wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote:
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
> guarantee as to how the underlying output stream actually writes the bytes
> provided to it.
It might be equally reasonable simply to resolve the issue as
Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no
guarantee as to how the underlying output stream actually writes the bytes
provided to it.
-
Commit messages:
- 8155902: DataOutputStream writeInt creates 2 packets instead of 1
Changes: https://git.open
I'm not a big fan of hiding exceptions, why not wrapping the IOException in an
UncheckedIOException ?
So closeUnchecked() means close and throw an unchecked exception if an
exception occurs.
regards,
Rémi
- Original Message -
> From: "Brian Burkhalter"
> To: "core-libs-dev"
> Sent: T
On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https
On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by lancea (Reviewer).
-
PR Review: ht
On Thu, 6 Jul 2023 19:32:09 GMT, Justin Lu wrote:
>> Please review this PR which refactors additional tests in Locale to use
>> JUnit.
>>
>> If a test was named bugNNN.java, it was renamed to something more
>> descriptive.
>>
>> Below is a list of all the changes
>>
>> - Refactor and Ren
Removing the IDE specific `@SuppressWarnings` attached to
`java.util.Calendar#equals()`. `equals()` implementation now checks the type of
the other instance for this.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/14790/files
Webrev: https://webrevs
On Thu, 6 Jul 2023 20:42:34 GMT, Roger Riggs wrote:
> Can you add an example showing the recommended pattern of use?
One pattern is for example when reading from a stream and closing it is highly
unlikely to generate an exception, then instead of the try block in
InputStream in = ...;
while(so
On Thu, 6 Jul 2023 20:07:56 GMT, Brian Burkhalter wrote:
> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
> to `Closeable::close` except that it instead throws
> `java.io.UncheckedIOException`.
src/java.base/share/classes/java/io/Closeable.java line 60:
> 58:
Add a default method `java.io.Closeable::closeUnchecked` which is equivalent to
`Closeable::close` except that it instead throws `java.io.UncheckedIOException`.
-
Commit messages:
- 8066869: Add Closeable::closeUnchecked that is the equivalent of close but
throws UncheckedIOExcepti
On Thu, 6 Jul 2023 20:07:56 GMT, Brian Burkhalter wrote:
> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
> to `Closeable::close` except that it instead throws
> `java.io.UncheckedIOException`.
A CSR will follow if there is agreement on the concept.
-
On Thu, 6 Jul 2023 19:59:11 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts of
On Thu, 6 Jul 2023 19:32:09 GMT, Justin Lu wrote:
>> Please review this PR which refactors additional tests in Locale to use
>> JUnit.
>>
>> If a test was named bugNNN.java, it was renamed to something more
>> descriptive.
>>
>> Below is a list of all the changes
>>
>> - Refactor and Ren
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Mon, 3 Jul 2023 17:55:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: Remove Bug8025703.java and add to LSRT.java
>> - Review: Clarify comments in ISO639.java
>
> test/jdk/java/util/Lo
> Please review this PR which refactors additional tests in Locale to use JUnit.
>
> If a test was named bugNNN.java, it was renamed to something more
> descriptive.
>
> Below is a list of all the changes
>
> - Refactor and Rename Bug4175998Test.java as ISO639.java
> - Refactor and Rename B
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Thu, 6 Jul 2023 12:20:15 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts of
On Thu, 6 Jul 2023 13:27:15 GMT, Roger Riggs wrote:
>> `WeakReferenceKey::equals` and `SoftReferenceKey::equals`:
>>
>> Instead of `return Objects.equals(get(), obj);`, suggest to do:
>>
>>
>> return refersTo(obj);
>
>> @mlchung Not sure I catch the nuance. `refersTo` doesn't work if the s
On Thu, 29 Jun 2023 08:27:43 GMT, Alan Bateman wrote:
> The changes make me wonder if `-XshowSetting:aardvark` should be an error
> rather than default to print all settings. Something we should look at again.
> Same thing for `-XshowSettings:system` on non-Linux, probably should have
> been a
On Thu, 6 Jul 2023 16:12:15 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Thu, 6 Jul 2023 12:20:15 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts of
On Thu, 6 Jul 2023 14:46:59 GMT, Pavel Rappo wrote:
>> I'd suggest replacing the calls to `valuesMatch` with `Objects.equals` and
>> remove the `valuesMatch` method as unnecessary.
>
>> I'd suggest replacing the calls to `valuesMatch` with `Objects.equals` and
>> remove the `valuesMatch` method
On Thu, 6 Jul 2023 13:27:15 GMT, Roger Riggs wrote:
>> `WeakReferenceKey::equals` and `SoftReferenceKey::equals`:
>>
>> Instead of `return Objects.equals(get(), obj);`, suggest to do:
>>
>>
>> return refersTo(obj);
>
>> @mlchung Not sure I catch the nuance. `refersTo` doesn't work if the s
On Thu, 6 Jul 2023 16:12:15 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1] abstrac
On Thu, 6 Jul 2023 00:13:05 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split u
On Wed, 5 Jul 2023 15:33:13 GMT, Roger Riggs wrote:
> I'd suggest replacing the calls to `valuesMatch` with `Objects.equals` and
> remove the `valuesMatch` method as unnecessary.
I'll do something about them soon, Roger. But first I need to understand
JDK-8015417 better, as it also affects oth
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Wed, 5 Jul 2023 19:33:28 GMT, Mandy Chung wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to use VirtualThread friendly stale queue.
>
> `WeakReferenceKey::equals` and `SoftReferenceKey::equals`:
>
> Inste
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Wed, 5 Jul 2023 19:33:28 GMT, Mandy Chung wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to use VirtualThread friendly stale queue.
>
> `WeakReferenceKey::equals` and `SoftReferenceKey::equals`:
>
> Inste
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in the java.text area.
>
> * Some changes to `equals` and `hashCode` are refactoring rather than
> modernization. Such changes can be as trivial as rearranging, adding, or
> commenting checks.
On Wed, 5 Jul 2023 17:44:52 GMT, Roger Riggs wrote:
>> You are right, I have no stats. Performance-wise, it's already better than
>> what was there before. Before, there was no short-circuit check. But I can
>> go either way; I don't have a strong opinion.
>>
>> Reusing superclass' equals is n
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 5 Jul 2023 10:21:51 GMT, Daniel Jeliński wrote:
> The methods declared in dirent_md are not used in libjava and not exported.
> They should be removed.
This pull request has now been integrated.
Changeset: 356067d0
Author:Daniel Jeliński
URL:
https://git.openjdk.org/jdk/com
On Wed, 5 Jul 2023 19:14:07 GMT, Mandy Chung wrote:
> Thanks for catching this issue. I agree that `Method::invoke` should be
> skipped the caller-sensitive test in this case but the fix isn't quite right.
> The caller-sensitive test should apply in any batch. For example, `CSM` calls
> `getCa
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust comment
-
Changes:
- all: https://
On Thu, 22 Jun 2023 09:23:05 GMT, Matthias Baesken wrote:
>> test/langtools/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java
>> line 1:
>>
>>> 1: /*
>>
>> The name of this test includes RTJar. It needs to be changed too I think.
>> Does this test actually still test something?
>
>
On Wed, 5 Jul 2023 15:07:15 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revi
On Wed, 5 Jul 2023 17:25:24 GMT, Volker Simonis wrote:
>> As the included jtreg test demonstrates, `StackWalker.getCallerClass()` can
>> throw an `UnsupportedOperationException` if called reflectively. Currently
>> this only happens if we invoke `StackWalker.getCallerClass()` recursively
>> re
61 matches
Mail list logo
