On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Tue, 4 Jul 2023 01:01:22 GMT, Pavel Rappo wrote:
>> Hmm, I think that issue refers to code that have explicit non-Object
>> parameter types (like `X::equals(Object)boolean` in the issue's sample).
>> This method already have both arguments as `Object`, so I don't think
>> there's any type-s
On Tue, 4 Jul 2023 21:00:30 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line
>> 324:
>>
>>> 322: r = PROXY_LOOKUPS.get(intfc);
>>> 323: }
>>> 324: return r.get();
>>
>> This doesn't look right to me. AFAICT the Lo
On Tue, 4 Jul 2023 14:14:03 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 44 commits:
>>
>> - Merge branch 'master' into explore/mhp-iface
>> - stage
>>
>>Signed-off-by: liach
>>
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
Hi all,
This pull request contains a backport of commit
[7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Pavel Rappo on 4 Jul 2023 and was
revie
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Alright, I think all the areas that this PR touches have been reviewed by area
experts.
-
PR Comment: https://git.openjdk.org/jdk/pull/14718#issueco
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
This pull request has now been integrated.
Changeset: 7b3c2dc5
Author:Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6e
On Sun, 2 Jul 2023 02:05:23 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Tue, 4 Jul 2023 13:37:45 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 44 commits:
>>
>> - Merge branch 'master' into explore/mhp-iface
>> - stage
>>
>>Signed-off-by: liach
>>
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
> caching scheme for Carrier objects. The technique used is generally useful
> for a variety of caching schemes and is being moved to be shared in other
> parts of the jdk. The MethodType interning case is one example.
On Fri, 30 Jun 2023 17:29:20 GMT, Mandy Chung wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to use VirtualThread friendly stale queue.
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line 89
1. Missing leading asterisk interferes with example indentation; nothing in
https://bugs.openjdk.org/browse/JDK-8276700 (or review thereof), which
introduced that line, suggests that the asterisk was omitted on purpose.
2. link and linkplain tags are used suboptimally.
-
Commit mes
On Fri, 30 Jun 2023 17:48:35 GMT, Mandy Chung wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove warning tied to String Templates
>
> MethodType's `ConcurrentWeakInternSet` uses `NativeReferenceQueue` which uses
On Mon, 3 Jul 2023 20:22:30 GMT, Mandy Chung wrote:
> Thanks for the update. Some comments below.
Thank you for the feedback! I didn't see the "proper" usage of effectively
final variables.
> The test you add does not cause new locals be defined in the helper methods.
> Do you think you can
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
19 matches
Mail list logo
