Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-18 Thread Axel Boldt-Christmas
> The current implementation for testing generational ZGC with jtreg is > implemented with a filter on the mode flag `ZGenerational`. Because of this > only environments which set this flag explicitly will run most of the tests. > So they get missed in Github Actions and for developers running j

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-18 Thread Alan Bateman
On Mon, 19 Jun 2023 05:46:34 GMT, Anthony Scarpino wrote: > From what I was told, the native library was one of the reasons it was not in > the base pkg before modularization and just remained so afterwards. Maybe you are thinking about the size of libsunec or non-technical issues that meant

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-18 Thread Thomas Stuefe
> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] > > jspawnhelper uses argv[0] to receive the fd string from the parent. That > breaks with conventions and trips over certain tools like binfmt_misc. > > For details, see linked ML discussion. > > [1] https://mail.openjdk.or

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-18 Thread Thomas Stüfe
Thank you Daniel. Comment's fixed. Cheers, Thomas On Sun, Jun 18, 2023 at 2:25 AM Daniel Jarabek wrote: > Hi Thomas, > > Thank you for this quick fix! > > I have tested (after much difficultly getting cross compilation to work - > a good learning experience) and this fix works for me. Using QEM

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-18 Thread Anthony Scarpino
On Sat, 17 Jun 2023 13:10:35 GMT, Alan Bateman wrote: > > This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has > > always been separate from the base module/pkg because of its dependence on > > a native library. That library was removed in JDK 16. > > The proposed changes

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread David Holmes
On Sun, 18 Jun 2023 18:54:22 GMT, Jens Lidestrom wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> missing 'L' for the array class name > > src/java.base/share/classes/java/lang/Class.java line 395: > >> 393: *

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread Chen Liang
On Sun, 18 Jun 2023 18:36:28 GMT, Jens Lidestrom wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> missing 'L' for the array class name > > src/java.base/share/classes/java/lang/Class.java line 395: > >> 393: *

Re: RFR: 8310019: MIPS builds are broken after JDK-8304913 [v3]

2023-06-18 Thread Vladimir Petko
On Thu, 15 Jun 2023 17:44:01 GMT, Roger Riggs wrote: >> Add mipsel and mips64el to the Architecture enum. >> (Later to be backported to JDK 21) > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct mps64el test case [mips

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread ExE Boss
On Sun, 18 Jun 2023 18:56:39 GMT, Jens Lidestrom wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> missing 'L' for the array class name > > src/java.base/share/classes/java/lang/Class.java line 427: > >> 425: *

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-18 Thread Anthony Scarpino
On Sat, 17 Jun 2023 12:53:17 GMT, Alan Bateman wrote: >> src/jdk.crypto.ec/share/classes/module-info.java line 36: >> >>> 34: @Deprecated(since="22", forRemoval = true) >>> 35: module jdk.crypto.ec { >>> 36: //provides java.security.Provider with sun.security.ec.SunEC; >> >> Just remove it.

Re: RFR: 8310033: Clarify return value of Java Time compareTo methods [v2]

2023-06-18 Thread Stephen Colebourne
On Fri, 16 Jun 2023 22:12:43 GMT, Roger Riggs wrote: >> In java.time packages, clarify timeline order javadoc to mention "before" >> and "after" in the value of the `compareTo` method return values. >> Add javadoc @see tags to isBefore and isAfter methods >> >> Replace use of "negative" and po

Re: RFR: 8310033: Clarify return value of Java Time compareTo methods [v2]

2023-06-18 Thread Jens Lidestrom
On Fri, 16 Jun 2023 22:54:59 GMT, Pavel Rappo wrote: > While the new wording is clearly an improvement, this reads weird: > > > @return the comparator value is less... > I suggest you use the safe form as the old text, which used a comma: > ``` > @return the comparator value, that is negative

Re: RFR: 8310033: Clarify return value of Java Time compareTo methods [v2]

2023-06-18 Thread Jens Lidestrom
On Fri, 16 Jun 2023 22:12:43 GMT, Roger Riggs wrote: >> In java.time packages, clarify timeline order javadoc to mention "before" >> and "after" in the value of the `compareTo` method return values. >> Add javadoc @see tags to isBefore and isAfter methods >> >> Replace use of "negative" and po

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread Jens Lidestrom
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull request

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread Jens Lidestrom
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull request