On Thu, 11 May 2023 13:08:55 GMT, Alan Bateman wrote:
> This is the implementation of:
>
> - JEP 453: Structured Concurrency (Preview)
> - JEP 446: Scoped Values (Preview)
>
> For the most part, this is just moving code and tests. StructuredTaskScope
> moves to j.u.concurrent as a preview API
On Wed, 31 May 2023 19:46:57 GMT, Glavo wrote:
> > Hello @Glavo, I see you reopened this PR, so I'm guessing you are still
> > interested in pursuing this further. Are you considering updating this PR
> > to implement Alan's suggestion to do similar changes in `JImageTask.java`
> > and `JlinkT
On Tue, 6 Jun 2023 18:45:50 GMT, Erik Österlund wrote:
>> For hotspot, when GC occurs, it causes all threads to run to the nearest
>> safepoint and then freeze. Generally, safepoints are generated at branch
>> jumps, method ends(ret instructions), loops instructions, and so on.
>> Therefore, t
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
> TEST=gc/TestAllocHumongousFragment.java
> error info:
>
> Caused by: java.lang.NullPointerException: Cannot invoke
> "sun.util.locale.BaseLocale.getVariant()" because "base" is null
> at java.base/java.util.Locale.forLanguageTag(Lo
Add some basic core reflections tests for unnamed classes.
-
Commit messages:
- JDK-8309574: Improve core reflection tests for JEP 445
Changes: https://git.openjdk.org/jdk/pull/14345/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14345&range=00
Issue: https://bugs.openjdk
On Wed, 7 Jun 2023 00:10:59 GMT, Paul Sandoz wrote:
>>> I believe instead of changing the guards we can change the implementation
>>> of the static methods on the concrete static VHs to call `asDirect()` (lets
>>> also add `@ForceInline` on `asDirect`), since `linkToStatic` will pass the
>>> a
> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`.
>
> A few implementation-detail methods in VarHandle are now documented with the
> implied constraints to avoid subtle problems in the future. Changed
> `IndirectVarHandle` to call `asDirect` lazily to accomodate the la
On Tue, 6 Jun 2023 18:48:35 GMT, John R Rose wrote:
>> This reasoning seems invalid. There are method calls in there, and you rely
>> on inlining heuristics for this not to break. Please use reachabilityFence
>> instead.
>
> It appears you are assuming that some combination of bytecodes constit
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
> TEST=gc/TestAllocHumongousFragment.java
> error info:
>
> Caused by: java.lang.NullPointerException: Cannot invoke
> "sun.util.locale.BaseLocale.getVariant()" because "base" is null
> at java.base/java.util.Locale.forLanguageTag(Lo
On Fri, 2 Jun 2023 20:32:14 GMT, Doug Simon wrote:
> This PR improves the startup time for libgraal by speeding up how
> `VM.savedProps` is copied into libgraal. This data structure is now
> serialized to a native buffer directly from C++ and the native buffer is then
> directly decoded by lib
On Tue, 6 Jun 2023 22:34:57 GMT, Chen Liang wrote:
> Is this aimed at decreasing long-term invocation cost or the initial
> invocation cost? FYI long-term invocation is already efficient enough; if
> this is for initial invocation, which can potentially bypass costly MH
> construction, I recom
On Mon, 5 Jun 2023 18:58:36 GMT, Tom Rodriguez wrote:
> I don't really love the hard code parsing of the HashMap. What properties are
> actually required for JVMCI? It seems to me that the contents of
> Arguments::system_properties() should contain all the properties we want to
> advertise to
On Tue, 6 Jun 2023 21:29:49 GMT, Paul Sandoz wrote:
> I believe instead of changing the guards we can change the implementation of
> the static methods on the concrete static VHs to call `asDirect()` (lets also
> add `@ForceInline` on `asDirect`), since `linkToStatic` will pass the args to
> t
On Fri, 2 Jun 2023 19:09:49 GMT, Mandy Chung wrote:
> > I wonder if it is possible to transition from an lazy (indirect) VH to a
> > direct VH once initialized i.e., `checkAccessModeThenIsDirect` returns the
> > value of `initialized`.
>
> Sounds a good idea. Once the class is initialized, the
On Tue, 6 Jun 2023 02:31:19 GMT, SUN Guoyun wrote:
>> I still don't see a clear explanation of how the proposed patch fixes the
>> problem. Also, I would appreciate the reasoning in the comments.
>
> For hotspot, when GC occurs, it causes all threads to run to the nearest
> safepoint and then f
On Tue, 6 Jun 2023 18:45:50 GMT, Erik Österlund wrote:
>> For hotspot, when GC occurs, it causes all threads to run to the nearest
>> safepoint and then freeze. Generally, safepoints are generated at branch
>> jumps, method ends(ret instructions), loops instructions, and so on.
>> Therefore, t
On Mon, 5 Jun 2023 01:11:54 GMT, Joe Darcy wrote:
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
This pull request has now been integrated.
Changeset: d82436e4
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/d82436e
On Tue, 6 Jun 2023 17:15:32 GMT, Joe Darcy wrote:
>> Document existing behavior.
>>
>> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrel
On Tue, 6 Jun 2023 17:15:32 GMT, Joe Darcy wrote:
>> Document existing behavior.
>>
>> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrel
On Tue, 6 Jun 2023 17:32:35 GMT, Artem Semenov wrote:
>> I didn't ask to revert the change. It's
>> `s/TARGET_OS_MAC/defined(__APPLE__)/`.
>
> This is rarely used in the code and is not the essence of the current changes.
> If you introduce such changes, then throughout the code.
> Moreover, thi
On Thu, 1 Jun 2023 15:04:09 GMT, Weijun Wang wrote:
>> done
>
> I didn't ask to revert the change. It's `s/TARGET_OS_MAC/defined(__APPLE__)/`.
This is rarely used in the code and is not the essence of the current changes.
If you introduce such changes, then throughout the code.
Moreover, this ca
> Fix the bug mentioned in the JBS issue.
>
> The implementation is updated to slice the capture state segment using the
> capture state layout. This checks both that the segment is big enough, and
> that it is properly aligned.
>
> Additionally, I added a check for `MS::NULL` since this is als
On Tue, 6 Jun 2023 17:13:23 GMT, Maurizio Cimadamore
wrote:
>> Fix the bug mentioned in the JBS issue.
>>
>> The implementation is updated to slice the capture state segment using the
>> capture state layout. This checks both that the segment is big enough, and
>> that it is properly aligned.
On Tue, 6 Jun 2023 16:22:41 GMT, Jorn Vernee wrote:
> Fix the bug mentioned in the JBS issue.
>
> The implementation is updated to slice the capture state segment using the
> capture state layout. This checks both that the segment is big enough, and
> that it is properly aligned.
>
> Addition
On Tue, 6 Jun 2023 07:13:15 GMT, Alan Bateman wrote:
>> This is the implementation of:
>>
>> - JEP 453: Structured Concurrency (Preview)
>> - JEP 446: Scoped Values (Preview)
>>
>> For the most part, this is just moving code and tests. StructuredTaskScope
>> moves to j.u.concurrent as a previ
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull reque
On Tue, 6 Jun 2023 08:41:28 GMT, Alan Bateman wrote:
> > "Latest Java class file format version recognized by the Java runtime as
> > "MAJOR.MINOR" where MAJOR and MINOR are both formatted as decimal integers"
>
> Okay, and linking to ClassFileFormatVersion.latest() is good.
>
> Again, just to
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and
> adjust implementations to match.
This pull request has now been integrated.
Changeset: 95261908
Author:Stuart Marks
URL:
https://git.openjdk.org/jdk/c
On Tue, 6 Jun 2023 04:55:10 GMT, Jaikiran Pai wrote:
>> Adjust the specification of the `SequencedMap` sequenced-view methods, and
>> adjust implementations to match.
>
> src/java.base/share/classes/java/util/SequencedMap.java line 268:
>
>> 266: * Its {@link SequencedSet#reversed reversed
Fix the bug mentioned in the JBS issue.
The implementation is updated to slice the capture state segment using the
capture state layout. This checks both that the segment is big enough, and that
it is properly aligned.
Additionally, I added a check for `MS::NULL` since this is also an illegal
On Tue, 6 Jun 2023 04:58:46 GMT, Jaikiran Pai wrote:
>> Adjust the specification of the `SequencedMap` sequenced-view methods, and
>> adjust implementations to match.
>
> src/java.base/share/classes/java/util/AbstractMap.java line 908:
>
>> 906: public boolean add(E t) { throw uoe(); }
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote:
> This PR improves both the worst-case performance of `nextExponential` and
> `nextGaussian` and the distribution of output at the tails. It fixes the
> following imperfections:
>
> * Repeatedly adding DoubleZigguratTables.exponentialX0 to
On Sun, 26 Mar 2023 20:45:19 GMT, Chen Liang wrote:
>> This patch aims to improve the performance of MethodTypeDesc in general, as
>> it is currently a performance bottleneck in the Classfile API. A previous
>> revision changed the parameter storage from an array to a list; this is
>> dropped
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote:
> This PR improves both the worst-case performance of `nextExponential` and
> `nextGaussian` and the distribution of output at the tails. It fixes the
> following imperfections:
>
> * Repeatedly adding DoubleZigguratTables.exponentialX0 to
On Thu, 6 Apr 2023 03:44:07 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/common/NativeCompilation.gmk
>>
>> Thanks you!
>>
>> Co-authored-by: Erik Joelsson <37597443+eri
On Tue, 6 Jun 2023 15:17:26 GMT, Jorn Vernee wrote:
>> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and
>> `float` is promoted to `double`, when being passed as variadic argument (see
>> e.g.
>> https://en.cppreference.com/w/c/language/conversion#Default_argument_prom
On Mon, 5 Jun 2023 19:33:48 GMT, Mandy Chung wrote:
> Lookup.findSpecial fails on Object method call from an interface because of a
> bug in the implementation calling `Class::getSuperclass` on an interface
> which has no superclass. The implementation should only search the method
> from it
On Sun, 26 Mar 2023 05:23:54 GMT, Chen Liang wrote:
> This patch aims to improve the performance of MethodTypeDesc in general, as
> it is currently a performance bottleneck in the Classfile API. A previous
> revision changed the parameter storage from an array to a list; this is
> dropped now.
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote:
> This allows bin/idea.sh to properly see the JVMCI files again.
This pull request has now been integrated.
Changeset: 7edd0540
Author:Tom Rodriguez
URL:
https://git.openjdk.org/jdk/commit/7edd0540e06444313647acd133c230785ddaf8ee
On Mon, 5 Jun 2023 18:52:00 GMT, Doug Lea wrote:
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
> enabling re-introduction of spin control from the previous version, removing
> anomalies like this one.
src/java.base/share/classes/java/util/concurrent/LinkedTrans
On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with four additional
> commits since th
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Fri, 7 Apr 2023 08:27:18 GMT, Tingjun Yuan wrote:
> In the current implementation of `String.join(CharSequence, Iterable)`, the
> temp array `elems` is always initialized with a length of 8. It will cause
> many array recreations when the `Iterable` contains more than 8 elements.
> Furtherm
On Fri, 2 Jun 2023 00:00:07 GMT, Brian Burkhalter wrote:
> For Unix, copy the `jchar`s into an allocated `char` array.
This pull request has now been integrated.
Changeset: 91881426
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/9188142698d8fdcee43c0b0519fde5c63b001
> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and
> `float` is promoted to `double`, when being passed as variadic argument (see
> e.g.
> https://en.cppreference.com/w/c/language/conversion#Default_argument_promotions).
> This patch adds the automatic argument promoti
On Fri, 2 Jun 2023 16:22:43 GMT, Jorn Vernee wrote:
>> In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and
>> `float` is promoted to `double`, when being passed as variadic argument (see
>> e.g.
>> https://en.cppreference.com/w/c/language/conversion#Default_argument_prom
On Mon, 5 Jun 2023 19:33:48 GMT, Mandy Chung wrote:
> Lookup.findSpecial fails on Object method call from an interface because of a
> bug in the implementation calling `Class::getSuperclass` on an interface
> which has no superclass. The implementation should only search the method
> from it
On Tue, 6 Jun 2023 12:39:58 GMT, Jim Laskey wrote:
> Status was incorrectly specified as
>
> @JEP(number=430, title="String Templates", status="First Preview")
>
> Should be
>
> @JEP(number=430, title="String Templates)
This pull request has now been integrated.
Changeset: ca6f07f9
Author
On Wed, 24 May 2023 09:24:46 GMT, Rudi Horn wrote:
> This change prevents the contents of the internal string array from being
> copied back when releasing it.
This pull request has now been integrated.
Changeset: 8f0839bc
Author:Rudi Horn
Committer: Alan Bateman
URL:
https://git.
On Tue, 6 Jun 2023 12:39:58 GMT, Jim Laskey wrote:
> Status was incorrectly specified as
>
> @JEP(number=430, title="String Templates", status="First Preview")
>
> Should be
>
> @JEP(number=430, title="String Templates)
Marked as reviewed by alanb (Reviewer).
-
PR Review: htt
Status was incorrectly specified as
@JEP(number=430, title="String Templates", status="First Preview")
Should be
@JEP(number=430, title="String Templates)
-
Commit messages:
- Status incorrectly specified
Changes: https://git.openjdk.org/jdk/pull/14332/files
Webrev: https://w
On Tue, 6 Jun 2023 10:10:38 GMT, Aleksandar Pejovic
wrote:
>> I'm not convinced this is a good change. Going by that mailing list thread,
>> it suggests that people considered changing it. If one of those attempts
>> were successful, it would have broken this code. It makes it rather fragile.
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 218
On Mon, 5 Jun 2023 18:52:00 GMT, Doug Lea wrote:
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
> enabling re-introduction of spin control from the previous version, removing
> anomalies like this one.
This looks okay to me, it was a bit easier than I expected.
On Tue, 9 May 2023 04:17:28 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>> 2.
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and
> adjust implementations to match.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14267#pullrequestreview-146486
> As the FFM API evolved over time, some parts of the javadoc went out of sync.
> Now that most of the API is stable, it is a good time to look again at the
> javadoc as a whole, and bring some more consistency.
>
> While most of the changes in this PR are stylistic, I'd like to call out few
>
On Mon, 5 Jun 2023 09:44:31 GMT, Severin Gehwolf wrote:
>> As far as I can tell, the delimiter hasn't changed since the file was
>> introduced, and judging by the kernel mailing list (e.g., see [the
>> following](https://lore.kernel.org/all/yr5jvhhsucrbt...@mtj.duckdns.org/)),
>> I don't think
On Mon, 5 Jun 2023 20:05:24 GMT, Chris Plummer wrote:
> The following commit in loom heavily modified this file with a lot of added
> expected methods. There are other related tests with similar changes. I'm not
> so sure I understand the need for so many additions, and also why
> expectedLeng
On Tue, 6 Jun 2023 01:34:03 GMT, Joe Darcy wrote:
> "Latest Java class file format version recognized by the Java runtime as
> "MAJOR.MINOR" where MAJOR and MINOR are both formatted as decimal integers"
Okay, and linking to ClassFileFormatVersion.latest() is good.
Again, just to lobby for putt
On Fri, 2 Jun 2023 10:08:09 GMT, JoKern65 wrote:
> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared
> code https://github.com/openjdk/jdk/pull/14146
> It handles the part in java.base.
>
> Compiling on AIX with xlc17 which contains the new clang 15 frontend
> shows th
> This is the implementation of:
>
> - JEP 453: Structured Concurrency (Preview)
> - JEP 446: Scoped Values (Preview)
>
> For the most part, this is just moving code and tests. StructuredTaskScope
> moves to j.u.concurrent as a preview API, ScopedValue moves to j.lang as a
> preview API, and m
63 matches
Mail list logo
