Re: RFR: 8307483: New micros for j.u.c.LockSupport

2023-05-07 Thread David Holmes
On Fri, 5 May 2023 14:31:29 GMT, Alan Bateman wrote: >> These micros were developed while investigating JDK-8305670 by myself and >> Sergey Kuksenko. The order of thread creation was important in that bug, so >> there are 2 JMH for creating sleepers before and after the worker threads. > > test

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

2023-05-07 Thread Roger Riggs
> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases > did not correctly borrow or carry from the nanos to the seconds when > computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. > The errant computation was introduced by > [JDK-8273369](https://bugs.openjdk.org/brows

Re: RFR: 8307575: Migrate the serialization constructor accessors to Method Handles [v2]

2023-05-07 Thread Chen Liang
> Apparently method handle linking doesn't impose extra checks on constructor > invocation, so the special logic for the serialization constructor to call > superclass constructor in MagicAccessorImpl can be removed altogether with > old core reflection implementation. > > Serialization and sun

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v16]

2023-05-07 Thread Chen Liang
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based > implementation of MethodHandleProxies.asInterface has a few issues: > 1. Exposes too much information via Proxy supertype (and WrapperInstance > interface) > 2. Does not allow future expansion to support SAM[^1] abstrac

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v15]

2023-05-07 Thread Chen Liang
On Sun, 7 May 2023 04:26:34 GMT, Chen Liang wrote: >> As John Rose has pointed out in this issue, the current j.l.r.Proxy based >> implementation of MethodHandleProxies.asInterface has a few issues: >> 1. Exposes too much information via Proxy supertype (and WrapperInstance >> interface) >> 2.

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-07 Thread Mandy Chung
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-07 Thread Mandy Chung
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to report